From eb648db47678337f925a98ea946268e100695c79 Mon Sep 17 00:00:00 2001 From: Alexei Sorokin Date: Sun, 13 Sep 2020 18:47:26 +0300 Subject: [PATCH] Fix XMLObj::sub argument order XMLStream::endXML assumes $ns to be second. --- XMPPHP/XMLObj.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/XMPPHP/XMLObj.php b/XMPPHP/XMLObj.php index 33b53e8..bfa6665 100644 --- a/XMPPHP/XMLObj.php +++ b/XMPPHP/XMLObj.php @@ -158,15 +158,15 @@ class XMLObj * Return a sub * * @param string $name - * @param array|null $attrs (optional) * @param string|null $ns (optional) + * @param array|null $attrs (optional) * @return mixed */ - public function sub(string $name, ?array $attrs = null, ?string $ns = null) + public function sub(string $name, ?string $ns = null, ?array $attrs = null) { - #TODO attrs is ignored + // @todo attrs is ignored foreach ($this->subs as $sub) { - if ($sub->name == $name and ($ns == null or $sub->ns == $ns)) { + if ($sub->name === $name && (is_null($ns) || $sub->ns === $ns)) { return $sub; } }