add_factor should succeed if Constraints are satisfied

2012-11-15 17:28:57 +00:00 · 2012-11-15 17:28:57 +00:00 · 114a6732f0
commit 114a6732f0
parent 740dd0ce99
1 changed files with 8 additions and 2 deletions
--- a/packages/CLPBN/clpbn/ground_factors.yap
+++ b/packages/CLPBN/clpbn/ground_factors.yap
@ -142,6 +142,7 @@ add_factor(factor(Type, Id, Ks, _, _Phi, Constraints), NKs) :-
    %writeln(+Ks),
 	( Ks = [K,Els], var(Els)
 	 ->
+	% aggregate factor
 	  once(run(Constraints)),
 	  avg_factors(K, Els, 0.0, NewKeys, NewId),
 	  NKs = [K|NewKeys]
@ -150,8 +151,13 @@ add_factor(factor(Type, Id, Ks, _, _Phi, Constraints), NKs) :-
 	  NKs = Ks,
 	  Id = NewId
 	),
-	\+ f(Type, NewId, NKs),
-	assert(f(Type, NewId, NKs)).
+	(
+          f(Type, NewId, NKs)
+        ->
+	  true
+        ;
+	  assert(f(Type, NewId, NKs))
+         ).

 run([Goal|Goals]) :-
 	call(user:Goal),