From 2bc123d72c97f75d7baae687e0356327f803e697 Mon Sep 17 00:00:00 2001 From: Tiago Gomes Date: Wed, 13 Feb 2013 14:26:47 +0000 Subject: [PATCH] Update class, struct and enum bracket style --- packages/CLPBN/horus/BayesBall.h | 6 ++--- packages/CLPBN/horus/BayesBallGraph.h | 6 ++--- packages/CLPBN/horus/BeliefProp.h | 13 ++++----- packages/CLPBN/horus/ConstraintTree.h | 9 +++---- packages/CLPBN/horus/CountingBp.h | 9 +++---- packages/CLPBN/horus/ElimGraph.h | 9 +++---- packages/CLPBN/horus/Factor.h | 6 ++--- packages/CLPBN/horus/FactorGraph.h | 9 +++---- packages/CLPBN/horus/GroundSolver.h | 3 +-- packages/CLPBN/horus/Histogram.h | 3 +-- packages/CLPBN/horus/Horus.h | 6 ++--- packages/CLPBN/horus/Indexer.h | 6 ++--- packages/CLPBN/horus/LiftedBp.h | 11 ++++---- packages/CLPBN/horus/LiftedKc.h | 36 +++++++++---------------- packages/CLPBN/horus/LiftedOperations.h | 3 +-- packages/CLPBN/horus/LiftedSolver.h | 3 +-- packages/CLPBN/horus/LiftedUtils.h | 12 +++------ packages/CLPBN/horus/LiftedVe.h | 18 +++++-------- packages/CLPBN/horus/LiftedWCNF.h | 18 ++++++------- packages/CLPBN/horus/Parfactor.h | 3 +-- packages/CLPBN/horus/ParfactorList.h | 6 ++--- packages/CLPBN/horus/ProbFormula.h | 6 ++--- packages/CLPBN/horus/TinySet.h | 3 +-- packages/CLPBN/horus/Var.h | 6 ++--- packages/CLPBN/horus/VarElim.h | 3 +-- packages/CLPBN/horus/WeightedBp.h | 6 ++--- 26 files changed, 80 insertions(+), 139 deletions(-) diff --git a/packages/CLPBN/horus/BayesBall.h b/packages/CLPBN/horus/BayesBall.h index f5c49a12a..06573b3c2 100644 --- a/packages/CLPBN/horus/BayesBall.h +++ b/packages/CLPBN/horus/BayesBall.h @@ -11,8 +11,7 @@ namespace Horus { -struct ScheduleInfo -{ +struct ScheduleInfo { ScheduleInfo (BBNode* n, bool vfp, bool vfc) : node(n), visitedFromParent(vfp), visitedFromChild(vfc) { } @@ -25,8 +24,7 @@ struct ScheduleInfo typedef std::queue> Scheduling; -class BayesBall -{ +class BayesBall { public: BayesBall (FactorGraph& fg); diff --git a/packages/CLPBN/horus/BayesBallGraph.h b/packages/CLPBN/horus/BayesBallGraph.h index 35173b983..2c3fa26f8 100644 --- a/packages/CLPBN/horus/BayesBallGraph.h +++ b/packages/CLPBN/horus/BayesBallGraph.h @@ -9,8 +9,7 @@ namespace Horus { -class BBNode : public Var -{ +class BBNode : public Var { public: BBNode (Var* v) : Var (v), visited_(false), markedOnTop_(false), markedOnBottom_(false) { } @@ -51,8 +50,7 @@ class BBNode : public Var }; -class BayesBallGraph -{ +class BayesBallGraph { public: BayesBallGraph (void) { } diff --git a/packages/CLPBN/horus/BeliefProp.h b/packages/CLPBN/horus/BeliefProp.h index 80c216988..dbec49860 100644 --- a/packages/CLPBN/horus/BeliefProp.h +++ b/packages/CLPBN/horus/BeliefProp.h @@ -19,8 +19,7 @@ enum MsgSchedule { }; -class BpLink -{ +class BpLink { public: BpLink (FacNode* fn, VarNode* vn); @@ -60,20 +59,22 @@ class BpLink typedef std::vector BpLinks; -class SPNodeInfo -{ +class SPNodeInfo { public: SPNodeInfo (void) { } + void addBpLink (BpLink* link) { links_.push_back (link); } + const BpLinks& getLinks (void) { return links_; } + private: BpLinks links_; + DISALLOW_COPY_AND_ASSIGN (SPNodeInfo); }; -class BeliefProp : public GroundSolver -{ +class BeliefProp : public GroundSolver { public: BeliefProp (const FactorGraph&); diff --git a/packages/CLPBN/horus/ConstraintTree.h b/packages/CLPBN/horus/ConstraintTree.h index fc9b005a3..cc9125224 100644 --- a/packages/CLPBN/horus/ConstraintTree.h +++ b/packages/CLPBN/horus/ConstraintTree.h @@ -22,8 +22,7 @@ typedef std::vector CTNodes; typedef std::vector ConstraintTrees; -class CTNode -{ +class CTNode { private: struct CmpSymbol { bool operator() (const CTNode* n1, const CTNode* n2) const { @@ -100,8 +99,7 @@ CTNode::findSymbol (Symbol symb) std::ostream& operator<< (std::ostream&, const CTNode&); -class ConstraintTree -{ +class ConstraintTree { public: ConstraintTree (unsigned); @@ -209,8 +207,7 @@ class ConstraintTree std::vector> countNormalize ( const CTNode*, unsigned); - static void split ( - CTNode*, CTNode*, CTChilds&, CTChilds&, unsigned); + static void split (CTNode*, CTNode*, CTChilds&, CTChilds&, unsigned); CTNode* root_; LogVars logVars_; diff --git a/packages/CLPBN/horus/CountingBp.h b/packages/CLPBN/horus/CountingBp.h index 2bec69b41..ad3e9d0dc 100644 --- a/packages/CLPBN/horus/CountingBp.h +++ b/packages/CLPBN/horus/CountingBp.h @@ -67,8 +67,7 @@ template struct hash> namespace Horus { -class VarCluster -{ +class VarCluster { public: VarCluster (const VarNodes& vs) : members_(vs) { } @@ -88,8 +87,7 @@ class VarCluster }; -class FacCluster -{ +class FacCluster { public: FacCluster (const FacNodes& fcs, const VarClusters& vcs) : members_(fcs), varClusters_(vcs) { } @@ -113,8 +111,7 @@ class FacCluster }; -class CountingBp : public GroundSolver -{ +class CountingBp : public GroundSolver { public: CountingBp (const FactorGraph& fg); diff --git a/packages/CLPBN/horus/ElimGraph.h b/packages/CLPBN/horus/ElimGraph.h index 8e9da22b4..c5d6bf823 100644 --- a/packages/CLPBN/horus/ElimGraph.h +++ b/packages/CLPBN/horus/ElimGraph.h @@ -18,8 +18,7 @@ class EgNode; typedef TinySet EGNeighs; -enum ElimHeuristic -{ +enum ElimHeuristic { SEQUENTIAL, MIN_NEIGHBORS, MIN_WEIGHT, @@ -28,8 +27,7 @@ enum ElimHeuristic }; -class EgNode : public Var -{ +class EgNode : public Var { public: EgNode (VarId vid, unsigned range) : Var (vid, range) { } @@ -46,8 +44,7 @@ class EgNode : public Var }; -class ElimGraph -{ +class ElimGraph { public: ElimGraph (const Factors&); diff --git a/packages/CLPBN/horus/Factor.h b/packages/CLPBN/horus/Factor.h index 925901cc3..5213c59d6 100644 --- a/packages/CLPBN/horus/Factor.h +++ b/packages/CLPBN/horus/Factor.h @@ -13,8 +13,7 @@ namespace Horus { template -class TFactor -{ +class TFactor { public: const std::vector& arguments (void) const { return args_; } @@ -327,8 +326,7 @@ TFactor::cartesianProduct ( -class Factor : public TFactor -{ +class Factor : public TFactor { public: Factor (void) { } diff --git a/packages/CLPBN/horus/FactorGraph.h b/packages/CLPBN/horus/FactorGraph.h index 40039b575..272a09834 100644 --- a/packages/CLPBN/horus/FactorGraph.h +++ b/packages/CLPBN/horus/FactorGraph.h @@ -16,8 +16,7 @@ namespace Horus { class FacNode; -class VarNode : public Var -{ +class VarNode : public Var { public: VarNode (VarId varId, unsigned nrStates, int evidence = Constants::NO_EVIDENCE) @@ -37,8 +36,7 @@ class VarNode : public Var -class FacNode -{ +class FacNode { public: FacNode (const Factor& f) : factor_(f), index_(-1) { } @@ -66,8 +64,7 @@ class FacNode -class FactorGraph -{ +class FactorGraph { public: FactorGraph (void) : bayesFactors_(false) { } diff --git a/packages/CLPBN/horus/GroundSolver.h b/packages/CLPBN/horus/GroundSolver.h index 3877fd280..ec31b365e 100644 --- a/packages/CLPBN/horus/GroundSolver.h +++ b/packages/CLPBN/horus/GroundSolver.h @@ -7,8 +7,7 @@ namespace Horus { -class GroundSolver -{ +class GroundSolver { public: GroundSolver (const FactorGraph& factorGraph) : fg(factorGraph) { } diff --git a/packages/CLPBN/horus/Histogram.h b/packages/CLPBN/horus/Histogram.h index 876c42e0e..41e16c8ef 100644 --- a/packages/CLPBN/horus/Histogram.h +++ b/packages/CLPBN/horus/Histogram.h @@ -11,8 +11,7 @@ typedef std::vector Histogram; namespace Horus { -class HistogramSet -{ +class HistogramSet { public: HistogramSet (unsigned, unsigned); diff --git a/packages/CLPBN/horus/Horus.h b/packages/CLPBN/horus/Horus.h index 0e81a5af2..a889b8487 100644 --- a/packages/CLPBN/horus/Horus.h +++ b/packages/CLPBN/horus/Horus.h @@ -34,16 +34,14 @@ typedef std::vector Ranges; typedef unsigned long long ullong; -enum LiftedSolverType -{ +enum LiftedSolverType { LVE, // generalized counting first-order variable elimination (GC-FOVE) LBP, // lifted first-order belief propagation LKC // lifted first-order knowledge compilation }; -enum GroundSolverType -{ +enum GroundSolverType { VE, // variable elimination BP, // belief propagation CBP // counting belief propagation diff --git a/packages/CLPBN/horus/Indexer.h b/packages/CLPBN/horus/Indexer.h index 94ce6e8d1..9ff78191b 100644 --- a/packages/CLPBN/horus/Indexer.h +++ b/packages/CLPBN/horus/Indexer.h @@ -12,8 +12,7 @@ namespace Horus { -class Indexer -{ +class Indexer { public: Indexer (const Ranges& ranges, bool calcOffsets = true); @@ -200,8 +199,7 @@ operator<< (std::ostream& os, const Indexer& indexer) -class MapIndexer -{ +class MapIndexer { public: MapIndexer (const Ranges& ranges, const std::vector& mask); diff --git a/packages/CLPBN/horus/LiftedBp.h b/packages/CLPBN/horus/LiftedBp.h index 622fb3f80..03cfcfc7b 100644 --- a/packages/CLPBN/horus/LiftedBp.h +++ b/packages/CLPBN/horus/LiftedBp.h @@ -12,16 +12,15 @@ namespace Horus { class FactorGraph; class WeightedBp; -class LiftedBp : public LiftedSolver -{ +class LiftedBp : public LiftedSolver{ public: - LiftedBp (const ParfactorList& pfList); + LiftedBp (const ParfactorList& pfList); - ~LiftedBp (void); + ~LiftedBp (void); - Params solveQuery (const Grounds&); + Params solveQuery (const Grounds&); - void printSolverFlags (void) const; + void printSolverFlags (void) const; private: void refineParfactors (void); diff --git a/packages/CLPBN/horus/LiftedKc.h b/packages/CLPBN/horus/LiftedKc.h index e7ff1ee04..33c392d00 100644 --- a/packages/CLPBN/horus/LiftedKc.h +++ b/packages/CLPBN/horus/LiftedKc.h @@ -27,8 +27,7 @@ enum CircuitNodeType { -class CircuitNode -{ +class CircuitNode { public: CircuitNode (void) { } @@ -39,8 +38,7 @@ class CircuitNode -class OrNode : public CircuitNode -{ +class OrNode : public CircuitNode { public: OrNode (void) : CircuitNode(), leftBranch_(0), rightBranch_(0) { } @@ -58,8 +56,7 @@ class OrNode : public CircuitNode -class AndNode : public CircuitNode -{ +class AndNode : public CircuitNode { public: AndNode (void) : CircuitNode(), leftBranch_(0), rightBranch_(0) { } @@ -80,8 +77,7 @@ class AndNode : public CircuitNode -class SetOrNode : public CircuitNode -{ +class SetOrNode : public CircuitNode { public: SetOrNode (unsigned nrGroundings) : CircuitNode(), follow_(0), nrGroundings_(nrGroundings) { } @@ -107,8 +103,7 @@ class SetOrNode : public CircuitNode -class SetAndNode : public CircuitNode -{ +class SetAndNode : public CircuitNode { public: SetAndNode (unsigned nrGroundings) : CircuitNode(), follow_(0), nrGroundings_(nrGroundings) { } @@ -126,8 +121,7 @@ class SetAndNode : public CircuitNode -class IncExcNode : public CircuitNode -{ +class IncExcNode : public CircuitNode { public: IncExcNode (void) : CircuitNode(), plus1Branch_(0), plus2Branch_(0), minusBranch_(0) { } @@ -148,8 +142,7 @@ class IncExcNode : public CircuitNode -class LeafNode : public CircuitNode -{ +class LeafNode : public CircuitNode { public: LeafNode (Clause* clause, const LiftedWCNF& lwcnf) : CircuitNode(), clause_(clause), lwcnf_(lwcnf) { } @@ -169,8 +162,7 @@ class LeafNode : public CircuitNode -class SmoothNode : public CircuitNode -{ +class SmoothNode : public CircuitNode { public: SmoothNode (const Clauses& clauses, const LiftedWCNF& lwcnf) : CircuitNode(), clauses_(clauses), lwcnf_(lwcnf) { } @@ -190,8 +182,7 @@ class SmoothNode : public CircuitNode -class TrueNode : public CircuitNode -{ +class TrueNode : public CircuitNode { public: TrueNode (void) : CircuitNode() { } @@ -200,8 +191,7 @@ class TrueNode : public CircuitNode -class CompilationFailedNode : public CircuitNode -{ +class CompilationFailedNode : public CircuitNode { public: CompilationFailedNode (void) : CircuitNode() { } @@ -210,8 +200,7 @@ class CompilationFailedNode : public CircuitNode -class LiftedCircuit -{ +class LiftedCircuit { public: LiftedCircuit (const LiftedWCNF* lwcnf); @@ -285,8 +274,7 @@ class LiftedCircuit -class LiftedKc : public LiftedSolver -{ +class LiftedKc : public LiftedSolver { public: LiftedKc (const ParfactorList& pfList) : LiftedSolver(pfList) { } diff --git a/packages/CLPBN/horus/LiftedOperations.h b/packages/CLPBN/horus/LiftedOperations.h index c1030a169..8b15014d3 100644 --- a/packages/CLPBN/horus/LiftedOperations.h +++ b/packages/CLPBN/horus/LiftedOperations.h @@ -6,8 +6,7 @@ namespace Horus { -class LiftedOperations -{ +class LiftedOperations { public: static void shatterAgainstQuery ( ParfactorList& pfList, const Grounds& query); diff --git a/packages/CLPBN/horus/LiftedSolver.h b/packages/CLPBN/horus/LiftedSolver.h index 5f7535704..5143ce494 100644 --- a/packages/CLPBN/horus/LiftedSolver.h +++ b/packages/CLPBN/horus/LiftedSolver.h @@ -6,8 +6,7 @@ namespace Horus { -class LiftedSolver -{ +class LiftedSolver { public: LiftedSolver (const ParfactorList& pfList) : parfactorList(pfList) { } diff --git a/packages/CLPBN/horus/LiftedUtils.h b/packages/CLPBN/horus/LiftedUtils.h index 501be0cb0..cae3727c9 100644 --- a/packages/CLPBN/horus/LiftedUtils.h +++ b/packages/CLPBN/horus/LiftedUtils.h @@ -12,8 +12,7 @@ namespace Horus { -class Symbol -{ +class Symbol { public: Symbol (void) : id_(Util::maxUnsigned()) { } @@ -32,8 +31,7 @@ class Symbol }; -class LogVar -{ +class LogVar { public: LogVar (void) : id_(Util::maxUnsigned()) { } @@ -111,8 +109,7 @@ void printSymbolDictionary (void); -class Ground -{ +class Ground { public: Ground (Symbol f) : functor_(f) { } @@ -138,8 +135,7 @@ typedef std::vector Grounds; -class Substitution -{ +class Substitution { public: void add (LogVar X_old, LogVar X_new); diff --git a/packages/CLPBN/horus/LiftedVe.h b/packages/CLPBN/horus/LiftedVe.h index 285a70a3c..bc3c801ff 100644 --- a/packages/CLPBN/horus/LiftedVe.h +++ b/packages/CLPBN/horus/LiftedVe.h @@ -10,8 +10,7 @@ namespace Horus { -class LiftedOperator -{ +class LiftedOperator { public: virtual ~LiftedOperator (void) { } @@ -35,8 +34,7 @@ class LiftedOperator -class ProductOperator : public LiftedOperator -{ +class ProductOperator : public LiftedOperator { public: ProductOperator ( ParfactorList::iterator g1, ParfactorList::iterator g2, @@ -62,8 +60,7 @@ class ProductOperator : public LiftedOperator -class SumOutOperator : public LiftedOperator -{ +class SumOutOperator : public LiftedOperator { public: SumOutOperator (PrvGroup group, ParfactorList& pfList) : group_(group), pfList_(pfList) { } @@ -90,8 +87,7 @@ class SumOutOperator : public LiftedOperator -class CountingOperator : public LiftedOperator -{ +class CountingOperator : public LiftedOperator { public: CountingOperator ( ParfactorList::iterator pfIter, @@ -119,8 +115,7 @@ class CountingOperator : public LiftedOperator -class GroundOperator : public LiftedOperator -{ +class GroundOperator : public LiftedOperator { public: GroundOperator ( PrvGroup group, @@ -148,8 +143,7 @@ class GroundOperator : public LiftedOperator -class LiftedVe : public LiftedSolver -{ +class LiftedVe : public LiftedSolver { public: LiftedVe (const ParfactorList& pfList) : LiftedSolver(pfList) { } diff --git a/packages/CLPBN/horus/LiftedWCNF.h b/packages/CLPBN/horus/LiftedWCNF.h index 632b6cb16..4e246ea9a 100644 --- a/packages/CLPBN/horus/LiftedWCNF.h +++ b/packages/CLPBN/horus/LiftedWCNF.h @@ -15,14 +15,17 @@ namespace Horus { class ParfactorList; -enum LogVarType { FULL_LV, POS_LV, NEG_LV }; +enum LogVarType { + FULL_LV, + POS_LV, + NEG_LV +}; typedef long LiteralId; typedef std::vector LogVarTypes; -class Literal -{ +class Literal { public: Literal (LiteralId lid, const LogVars& lvs) : lid_(lid), logVars_(lvs), negated_(false) { } @@ -65,8 +68,7 @@ typedef std::vector Literals; -class Clause -{ +class Clause { public: Clause (const ConstraintTree& ct = ConstraintTree({})) : constr_(ct) { } @@ -160,8 +162,7 @@ typedef std::vector Clauses; -class LitLvTypes -{ +class LitLvTypes { public: LitLvTypes (LiteralId lid, const LogVarTypes& lvTypes) : lid_(lid), lvTypes_(lvTypes) { } @@ -201,8 +202,7 @@ typedef TinySet LitLvTypesSet; -class LiftedWCNF -{ +class LiftedWCNF { public: LiftedWCNF (const ParfactorList& pfList); diff --git a/packages/CLPBN/horus/Parfactor.h b/packages/CLPBN/horus/Parfactor.h index db87a4e66..545b9d845 100644 --- a/packages/CLPBN/horus/Parfactor.h +++ b/packages/CLPBN/horus/Parfactor.h @@ -13,8 +13,7 @@ namespace Horus { -class Parfactor : public TFactor -{ +class Parfactor : public TFactor { public: Parfactor ( const ProbFormulas&, diff --git a/packages/CLPBN/horus/ParfactorList.h b/packages/CLPBN/horus/ParfactorList.h index 22d9dfd2e..d205688ee 100644 --- a/packages/CLPBN/horus/ParfactorList.h +++ b/packages/CLPBN/horus/ParfactorList.h @@ -12,8 +12,7 @@ namespace Horus { class Parfactor; -class ParfactorList -{ +class ParfactorList { public: ParfactorList (void) { } @@ -103,8 +102,7 @@ class ParfactorList const ProbFormula&, ConstraintTree, const ProbFormula&, ConstraintTree) const; - struct sortByParams - { + struct sortByParams { bool operator() (const Parfactor* pf1, const Parfactor* pf2) { if (pf1->params().size() < pf2->params().size()) { diff --git a/packages/CLPBN/horus/ProbFormula.h b/packages/CLPBN/horus/ProbFormula.h index 2cc499448..fe4ffd70e 100644 --- a/packages/CLPBN/horus/ProbFormula.h +++ b/packages/CLPBN/horus/ProbFormula.h @@ -14,8 +14,7 @@ namespace Horus { typedef unsigned long PrvGroup; -class ProbFormula -{ +class ProbFormula { public: ProbFormula (Symbol f, const LogVars& lvs, unsigned range) : functor_(f), logVars_(lvs), range_(range), @@ -81,8 +80,7 @@ class ProbFormula typedef std::vector ProbFormulas; -class ObservedFormula -{ +class ObservedFormula { public: ObservedFormula (Symbol f, unsigned a, unsigned ev); diff --git a/packages/CLPBN/horus/TinySet.h b/packages/CLPBN/horus/TinySet.h index 65df98e33..7b8748c7b 100644 --- a/packages/CLPBN/horus/TinySet.h +++ b/packages/CLPBN/horus/TinySet.h @@ -9,8 +9,7 @@ namespace Horus { template > -class TinySet -{ +class TinySet { public: typedef typename std::vector::iterator iterator; typedef typename std::vector::const_iterator const_iterator; diff --git a/packages/CLPBN/horus/Var.h b/packages/CLPBN/horus/Var.h index 5a56572b2..787118000 100644 --- a/packages/CLPBN/horus/Var.h +++ b/packages/CLPBN/horus/Var.h @@ -12,8 +12,7 @@ namespace Horus { -struct VarInfo -{ +struct VarInfo { VarInfo (std::string l, const States& sts) : label(l), states(sts) { } std::string label; @@ -21,8 +20,7 @@ struct VarInfo }; -class Var -{ +class Var { public: Var (const Var*); diff --git a/packages/CLPBN/horus/VarElim.h b/packages/CLPBN/horus/VarElim.h index 8a17ec418..d20c7ef5d 100644 --- a/packages/CLPBN/horus/VarElim.h +++ b/packages/CLPBN/horus/VarElim.h @@ -11,8 +11,7 @@ namespace Horus { -class VarElim : public GroundSolver -{ +class VarElim : public GroundSolver { public: VarElim (const FactorGraph& fg) : GroundSolver (fg) { } diff --git a/packages/CLPBN/horus/WeightedBp.h b/packages/CLPBN/horus/WeightedBp.h index 67d18cc6c..49c740fec 100644 --- a/packages/CLPBN/horus/WeightedBp.h +++ b/packages/CLPBN/horus/WeightedBp.h @@ -8,8 +8,7 @@ namespace Horus { -class WeightedLink : public BpLink -{ +class WeightedLink : public BpLink { public: WeightedLink (FacNode* fn, VarNode* vn, size_t idx, unsigned weight) : BpLink (fn, vn), index_(idx), weight_(weight), @@ -43,8 +42,7 @@ WeightedLink::updateMessage (void) -class WeightedBp : public BeliefProp -{ +class WeightedBp : public BeliefProp { public: WeightedBp (const FactorGraph& fg, const std::vector>& weights)