EM was not checking for convergence properly.

2008-11-02 15:58:29 +00:00 · 2008-11-02 15:58:29 +00:00 · 941d3c3f13
commit 941d3c3f13
parent ac34be01b0
1 changed files with 1 additions and 1 deletions
--- a/CLPBN/learning/em.yap
+++ b/CLPBN/learning/em.yap
@ -81,7 +81,7 @@ em_loop(Its, Likelihood0, State, MaxError, MaxIts, LikelihoodF, FTables) :-
 	writeln(Likelihood:Likelihood0:Tables),
 	(
 	    (
-	     (Likelihood - Likelihood0)/Likelihood < MaxError
+	     abs((Likelihood - Likelihood0)/Likelihood) < MaxError
 	    ;
 	     Its == MaxIts
 	    )