From 01689edc66ea61b5d6023d06f231f689313f20ac Mon Sep 17 00:00:00 2001 From: Diogo Peralta Cordeiro Date: Fri, 10 Dec 2021 02:42:36 +0000 Subject: [PATCH] [PLUGIN][Favourite] Report already favoured or unfavoured --- plugins/Favourite/Controller/Favourite.php | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/plugins/Favourite/Controller/Favourite.php b/plugins/Favourite/Controller/Favourite.php index 303921d027..625aec1d4d 100644 --- a/plugins/Favourite/Controller/Favourite.php +++ b/plugins/Favourite/Controller/Favourite.php @@ -73,8 +73,11 @@ class Favourite extends FeedController $form_add_to_favourite->handleRequest($request); if ($form_add_to_favourite->isSubmitted()) { - \Plugin\Favourite\Favourite::favourNote(note_id: $id, actor_id: $actor_id); - DB::flush(); + if (!is_null(\Plugin\Favourite\Favourite::favourNote(note_id: $id, actor_id: $actor_id))) { + DB::flush(); + } else { + throw new ClientException(_m('Note already favoured!')); + } // Redirect user to where they came from // Prevent open redirect @@ -129,8 +132,11 @@ class Favourite extends FeedController $form_remove_favourite->handleRequest($request); if ($form_remove_favourite->isSubmitted()) { - \Plugin\Favourite\Favourite::unfavourNote(note_id: $id, actor_id: $actor_id); - DB::flush(); + if (!is_null(\Plugin\Favourite\Favourite::unfavourNote(note_id: $id, actor_id: $actor_id))) { + DB::flush(); + } else { + throw new ClientException(_m('Note already unfavoured!')); + } // Redirect user to where they came from // Prevent open redirect