From 06b25f384af869358b4f0b4a721d6fdf9971d234 Mon Sep 17 00:00:00 2001 From: Mikael Nordfeldth Date: Tue, 2 May 2017 09:07:00 +0200 Subject: [PATCH] File_redirection->getFile could never get the file anyway if $redir->file_id was empty... --- plugins/Oembed/classes/File_oembed.php | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/plugins/Oembed/classes/File_oembed.php b/plugins/Oembed/classes/File_oembed.php index 38a1754ae2..e47fee6abe 100644 --- a/plugins/Oembed/classes/File_oembed.php +++ b/plugins/Oembed/classes/File_oembed.php @@ -126,10 +126,7 @@ class File_oembed extends Managed_DataObject } catch (NoResultException $e) { // File_redirection::where argument 'discover' is false to avoid loops $redir = File_redirection::where($given_url, false); - if (empty($redir->file_id)) { - $f = $redir->getFile(); - $file_oembed->mimetype = $f->mimetype; - } else { + if (!empty($redir->file_id)) { $file_id = $redir->file_id; } }