From 1457aa82207768f4855998f80add0fb6cedc96ce Mon Sep 17 00:00:00 2001
From: Hugo Sales <hugo@hsal.es>
Date: Sat, 4 Dec 2021 11:59:45 +0000
Subject: [PATCH] [UI][PLUGIN][DeleteNote][EVENT] Add 'AddExtraNoteActions'
 event, which can be leveraged to add extra actions on each note, but which
 are normally collapsed

---
 plugins/DeleteNote/Controller/DeleteNote.php | 36 ++++++++++++++++++++
 plugins/DeleteNote/DeleteNote.php            | 21 ++++++++++--
 src/Twig/Extension.php                       |  1 +
 src/Twig/Runtime.php                         |  7 ++++
 templates/cards/note/view.html.twig          | 12 +++++++
 5 files changed, 75 insertions(+), 2 deletions(-)
 create mode 100644 plugins/DeleteNote/Controller/DeleteNote.php

diff --git a/plugins/DeleteNote/Controller/DeleteNote.php b/plugins/DeleteNote/Controller/DeleteNote.php
new file mode 100644
index 0000000000..390392c5b6
--- /dev/null
+++ b/plugins/DeleteNote/Controller/DeleteNote.php
@@ -0,0 +1,36 @@
+<?php
+
+declare(strict_types = 1);
+
+// {{{ License
+
+// This file is part of GNU social - https://www.gnu.org/software/social
+//
+// GNU social is free software: you can redistribute it and/or modify
+// it under the terms of the GNU Affero General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// GNU social is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU Affero General Public License for more details.
+//
+// You should have received a copy of the GNU Affero General Public License
+// along with GNU social.  If not, see <http://www.gnu.org/licenses/>.
+
+// }}}
+
+namespace Plugin\DeleteNote\Controller;
+
+use App\Core\Controller;
+use App\Util\Exception\NotImplementedException;
+use Symfony\Component\HttpFoundation\Request;
+
+class DeleteNote extends Controller
+{
+    public function __invoke(Request $request)
+    {
+        throw new NotImplementedException;
+    }
+}
diff --git a/plugins/DeleteNote/DeleteNote.php b/plugins/DeleteNote/DeleteNote.php
index c2b94d7887..b62cf2f110 100644
--- a/plugins/DeleteNote/DeleteNote.php
+++ b/plugins/DeleteNote/DeleteNote.php
@@ -26,6 +26,8 @@ use App\Core\Event;
 use App\Core\Form;
 use function App\Core\I18n\_m;
 use App\Core\Modules\NoteHandlerPlugin;
+use App\Core\Router\RouteLoader;
+use App\Core\Router\Router;
 use App\Entity\Note;
 use App\Util\Common;
 use App\Util\Exception\RedirectException;
@@ -46,14 +48,29 @@ use Symfony\Component\HttpFoundation\Request;
  */
 class DeleteNote extends NoteHandlerPlugin
 {
-    // TODO: Refactoring to link instead of a form
+    public function onAddRoute(RouteLoader $r)
+    {
+        $r->connect(id: 'delete_note', uri_path: '/object/note/{id<\d+>}/delete', target: Controller\DeleteNote::class);
+        return Event::next;
+    }
+
+    public function onAddExtraNoteActions(Request $request, Note $note, array &$actions)
+    {
+        $actions[] = [
+            'title'   => _m('Delete note'),
+            'classes' => '',
+            'url'     => Router::url('delete_note', ['id' => $note->getId()]),
+        ];
+    }
+
     /**
      * HTML rendering event that adds the repeat form as a note
      * action, if a user is logged in
      *
      * @throws RedirectException
      */
-/*    public function onAddNoteActions(Request $request, Note $note, array &$actions)
+    // TODO: Refactoring to link instead of a form
+    /*    public function onAddNoteActions(Request $request, Note $note, array &$actions)
     {
         if (($user = Common::user()) === null) {
             return Event::next;
diff --git a/src/Twig/Extension.php b/src/Twig/Extension.php
index e3b44ecd89..5aaff61bcd 100644
--- a/src/Twig/Extension.php
+++ b/src/Twig/Extension.php
@@ -64,6 +64,7 @@ class Extension extends AbstractExtension
             new TwigFunction('active', [Runtime::class, 'isCurrentRouteActive']),
             new TwigFunction('is_route', [Runtime::class, 'isCurrentRoute']),
             new TwigFunction('get_note_actions', [Runtime::class, 'getNoteActions']),
+            new TwigFunction('get_extra_note_actions', [Runtime::class, 'getExtraNoteActions']),
             new TwigFunction('show_stylesheets', [Runtime::class, 'getShowStylesheets']),
             new TwigFunction('handle_event', [Runtime::class, 'handleEvent']),
             new TwigFunction('config', [Runtime::class, 'getConfig']),
diff --git a/src/Twig/Runtime.php b/src/Twig/Runtime.php
index 9040e40c6e..176a5addc9 100644
--- a/src/Twig/Runtime.php
+++ b/src/Twig/Runtime.php
@@ -72,6 +72,13 @@ class Runtime implements RuntimeExtensionInterface, EventSubscriberInterface
         return $actions;
     }
 
+    public function getExtraNoteActions(Note $note)
+    {
+        $extra_actions = [];
+        Event::handle('AddExtraNoteActions', [$this->request, $note, &$extra_actions]);
+        return $extra_actions;
+    }
+
     /**
      * @codeCoverageIgnore
      */
diff --git a/templates/cards/note/view.html.twig b/templates/cards/note/view.html.twig
index d2f7fa2378..a33519abf5 100644
--- a/templates/cards/note/view.html.twig
+++ b/templates/cards/note/view.html.twig
@@ -4,6 +4,18 @@
             {% for current_action in get_note_actions(note) %}
                 <a title="{{ current_action["title"] | trans }}" class="{{ current_action["classes"] }}" href="{{ current_action["url"] }}"></a>
             {% endfor %}
+            <details>
+                <summary>
+                    {{ icon('kebab', 'icon icon-extra-note-actions') | raw }} {# button-container #}
+                </summary>
+                <ul>
+                    {% for current_action in get_extra_note_actions(note) %}
+                        <li>
+                            <a class="{{ current_action["classes"] }}" href="{{ current_action["url"] }}">{{ current_action['title'] }}</a>
+                        </li>
+                    {% endfor %}
+                </ul>
+            </details>
         </div>
     {% endif %}
 {% endblock note_actions %}