better layout for single-bookmark page

This commit is contained in:
Evan Prodromou 2010-12-27 12:08:55 -08:00
parent 29103f5d0e
commit 45b2059cd8
2 changed files with 30 additions and 6 deletions

View File

@ -224,11 +224,16 @@ class BookmarkPlugin extends Plugin
$att = $atts[0]; $att = $atts[0];
$out->elementStart('h3'); // XXX: only show the bookmark URL for non-single-page stuff
$out->element('a',
array('href' => $att->url), if ($out instanceof ShowbookmarkAction) {
$nb->title); } else {
$out->elementEnd('h3'); $out->elementStart('h3');
$out->element('a',
array('href' => $att->url),
$nb->title);
$out->elementEnd('h3');
}
$out->elementStart('ul', array('class' => 'bookmark_tags')); $out->elementStart('ul', array('class' => 'bookmark_tags'));
@ -267,7 +272,10 @@ class BookmarkPlugin extends Plugin
array('class' => 'bookmark_description'), array('class' => 'bookmark_description'),
$nb->description); $nb->description);
$nli->showNoticeAttachments(); if (common_config('attachments', 'show_thumbs')) {
$al = new InlineAttachmentList($notice, $out);
$al->show();
}
$out->elementStart('p', array('style' => 'float: left')); $out->elementStart('p', array('style' => 'float: left'));

View File

@ -113,4 +113,20 @@ class ShowbookmarkAction extends ShownoticeAction
return true; return true;
} }
function title()
{
return sprintf(_('%s\'s bookmark for "%s"'),
$this->user->nickname,
$this->bookmark->title);
}
function showPageTitle()
{
$this->elementStart('h1');
$this->element('a',
array('href' => $this->bookmark->url),
$this->bookmark->title);
$this->elementEnd('h1');
}
} }