eliseuamaro/gnu-social
1
0
Fork 0
forked from GNUsocial/gnu-social
Code Issues Pull Requests Releases Wiki Activity

Clear out potential duplicates when semi-joining a union

Browse Source 
Using a left outer join as a semi-join is not a valid approach.
Can still be used for an anti-semi-join.
This commit is contained in:
Alexei Sorokin
2020-09-21 22:25:33 +03:00
parent aed2344bd4
commit 4d8b04cda9
3 changed files with 9 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
classes/Memcached_DataObject.php
View File

@@ -128,7 +128,7 @@ class Memcached_DataObject extends Safe_DataObject
$join_tablename = common_database_tablename(
$obj->tableName() . '_vals'
);
$join_keyword = ($preserve ? 'RIGHT' : 'LEFT') . ' JOIN';
$join_keyword = ($preserve ? 'RIGHT' : 'INNER') . ' JOIN';
$vals_cast_type = ($col_type === 'int') ? 'INTEGER' : 'TEXT';
// A lot of magic to ensure we get an ordered reply with the same exact
@@ -179,10 +179,6 @@ class Memcached_DataObject extends Safe_DataObject
);
}
if (!$preserve) {
// Implements a left semi-join
$obj->whereAdd("{$join_tablename}.{$keyCol}_pos IS NOT NULL");
}
// Filters both NULLs requested and non-matching NULLs
if ($skipNulls) {
$obj->whereAdd("{$obj->escapedTableName()}.{$keyCol} IS NOT NULL");