From 650074c648d98f81674c6e2b0ebf052c473ada6e Mon Sep 17 00:00:00 2001
From: Evan Prodromou <evan@status.net>
Date: Wed, 31 Mar 2010 15:54:35 -0400
Subject: [PATCH] don't insert the same notice twice into an inbox

---
 classes/Inbox.php | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/classes/Inbox.php b/classes/Inbox.php
index 014ba3d829..0d807946d5 100644
--- a/classes/Inbox.php
+++ b/classes/Inbox.php
@@ -114,6 +114,16 @@ class Inbox extends Memcached_DataObject
             return false;
         }
 
+        $ids = unpack('N*', $inbox->notice_ids);
+
+        // bulk inserts sometimes fail and get restarted.
+        // Skip if this one has been inserted before.
+
+        if (in_array($notice_id, $ids)) {
+            // effectively successful
+            return true;
+        }
+
         $result = $inbox->query(sprintf('UPDATE inbox '.
                                         'set notice_ids = concat(cast(0x%08x as binary(4)), '.
                                         'substr(notice_ids, 1, %d)) '.