Ticket #3022: fix formatting output for ApiAction::clientError and ApiAction::serverError when caller doesn't explicitly pass the format.

Format's already available as a member variable, so use it!

Fixes some error reponses in api/statusnet/groups/leave.json which were coming through as XML.
May fix some others as well.
This commit is contained in:
Brion Vibber 2011-02-01 14:35:42 -08:00
parent b46ce3b67d
commit 7977454456

View File

@ -1236,9 +1236,12 @@ class ApiAction extends Action
return; return;
} }
function clientError($msg, $code = 400, $format = 'xml') function clientError($msg, $code = 400, $format = null)
{ {
$action = $this->trimmed('action'); $action = $this->trimmed('action');
if ($format === null) {
$format = $this->format;
}
common_debug("User error '$code' on '$action': $msg", __FILE__); common_debug("User error '$code' on '$action': $msg", __FILE__);
@ -1278,9 +1281,12 @@ class ApiAction extends Action
} }
} }
function serverError($msg, $code = 500, $content_type = 'xml') function serverError($msg, $code = 500, $content_type = null)
{ {
$action = $this->trimmed('action'); $action = $this->trimmed('action');
if ($content_type === null) {
$content_type = $this->format;
}
common_debug("Server error '$code' on '$action': $msg", __FILE__); common_debug("Server error '$code' on '$action': $msg", __FILE__);