From 7c31462f86518ffd53e2659b4ee70ed9bef52054 Mon Sep 17 00:00:00 2001 From: Evan Prodromou Date: Tue, 19 Apr 2011 16:00:31 -0400 Subject: [PATCH] Let showNotice() go unimplemented Default implementation of showNotice(). --- lib/microappplugin.php | 35 ++++------------------------------- 1 file changed, 4 insertions(+), 31 deletions(-) diff --git a/lib/microappplugin.php b/lib/microappplugin.php index 5df76a074f..0fd6868f8c 100644 --- a/lib/microappplugin.php +++ b/lib/microappplugin.php @@ -137,21 +137,6 @@ abstract class MicroAppPlugin extends Plugin */ abstract function activityObjectFromNotice($notice); - /** - * Custom HTML output for your special notice; called when a - * matching notice turns up in a NoticeListItem. - * - * All micro-app classes must override this method. - * - * @param Notice $notice - * @param HTMLOutputter $out - * - * @fixme WARNING WARNING WARNING base plugin stuff below tries to close - * a div that this function opens in the BookmarkPlugin child class. - * This is probably wrong. - */ - abstract function showNotice($notice, $out); - /** * When building the primary notice form, we'll fetch also some * alternate forms for specialized types -- that's you! @@ -560,20 +545,8 @@ abstract class MicroAppPlugin extends Plugin return true; } - /** - * Custom HTML output for your special notice; called when a - * matching notice turns up in a NoticeListItem. - * - * All micro-app classes must override this method. - * - * @param Notice $notice - * @param HTMLOutputter $out - * - * @fixme WARNING WARNING WARNING base plugin stuff below tries to close - * a div that this function opens in the BookmarkPlugin child class. - * This is probably wrong. - */ - abstract function showNotice($notice, $out); - - + function showNotice($notice, $out) + { + throw new ServerException("You must implement either adaptNoticeListItem() or showNotice()"); + } }