eliseuamaro/gnu-social
1
0
Fork 0
forked from GNUsocial/gnu-social
Code Issues Pull Requests Releases Wiki Activity

Ticket #1611 and a bunch of code cleanup

Browse Source
This commit is contained in:
Zach Copley 2009-06-12 01:31:22 -07:00
parent eddc2af158
commit 8064397588
9 changed files with 361 additions and 373 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
actions/twitapiaccount.php
View File

@ -17,7 +17,9 @@
* along with this program. If not, see <http://www.gnu.org/licenses/>. * along with this program. If not, see <http://www.gnu.org/licenses/>.
*/ */
if (!defined('LACONICA')) { exit(1); } if (!defined('LACONICA')) {
exit(1);
}
require_once(INSTALLDIR.'/lib/twitterapi.php'); require_once(INSTALLDIR.'/lib/twitterapi.php');
@ -51,7 +53,8 @@ class TwitapiaccountAction extends TwitterapiAction
parent::handle($args); parent::handle($args);
if ($_SERVER['REQUEST_METHOD'] != 'POST') { if ($_SERVER['REQUEST_METHOD'] != 'POST') {
$this->clientError(_('This method requires a POST.'), 400, $apidata['content-type']); $this->clientError(_('This method requires a POST.'),
400, $apidata['content-type']);
return; return;
} }
@ -60,24 +63,20 @@ class TwitapiaccountAction extends TwitterapiAction
if (!is_null($location) && mb_strlen($location) > 255) { if (!is_null($location) && mb_strlen($location) > 255) {
// XXX: But Twitter just truncates and runs with it. -- Zach // XXX: But Twitter just truncates and runs with it. -- Zach
$this->clientError(_('That\'s too long. Max notice size is 255 chars.'), 406, $apidate['content-type']); $this->clientError(_('That\'s too long. Max notice size is 255 chars.'),
406, $apidate['content-type']);
return; return;
} }
$user = $apidata['user']; $user = $apidata['user']; // Always the auth user
$profile = $user->getProfile(); $profile = $user->getProfile();
if (!$profile) {
$this->serverError(_('User has no profile.'));
return;
}
$orig_profile = clone($profile); $orig_profile = clone($profile);
$profile->location = $location; $profile->location = $location;
$result = $profile->update($orig_profile); $result = $profile->update($orig_profile);
if (!$result) { if (empty($result)) {
common_log_db_error($profile, 'UPDATE', __FILE__); common_log_db_error($profile, 'UPDATE', __FILE__);
$this->serverError(_('Couldn\'t save profile.')); $this->serverError(_('Couldn\'t save profile.'));
return; return;

10
actions/twitapiblocks.php
View File

@ -17,7 +17,9 @@
* along with this program. If not, see <http://www.gnu.org/licenses/>. * along with this program. If not, see <http://www.gnu.org/licenses/>.
*/ */
if (!defined('LACONICA')) { exit(1); } if (!defined('LACONICA')) {
exit(1);
}
require_once(INSTALLDIR.'/lib/twitterapi.php'); require_once(INSTALLDIR.'/lib/twitterapi.php');
@ -31,12 +33,12 @@ class TwitapiblocksAction extends TwitterapiAction
$blockee = $this->get_user($apidata['api_arg'], $apidata); $blockee = $this->get_user($apidata['api_arg'], $apidata);
if (!$blockee) { if (empty($blockee)) {
$this->clientError('Not Found', 404, $apidata['content-type']); $this->clientError('Not Found', 404, $apidata['content-type']);
return; return;
} }
$user = $apidata['user']; $user = $apidata['user']; // Always the auth user
if ($user->hasBlocked($blockee) || $user->block($blockee)) { if ($user->hasBlocked($blockee) || $user->block($blockee)) {
$type = $apidata['content-type']; $type = $apidata['content-type'];
@ -53,7 +55,7 @@ class TwitapiblocksAction extends TwitterapiAction
parent::handle($args); parent::handle($args);
$blockee = $this->get_user($apidata['api_arg'], $apidata); $blockee = $this->get_user($apidata['api_arg'], $apidata);
if (!$blockee) { if (empty($blockee)) {
$this->clientError('Not Found', 404, $apidata['content-type']); $this->clientError('Not Found', 404, $apidata['content-type']);
return; return;
} }

76
actions/twitapidirect_messages.php
View File

@ -17,7 +17,9 @@
* along with this program. If not, see <http://www.gnu.org/licenses/>. * along with this program. If not, see <http://www.gnu.org/licenses/>.
*/ */
if (!defined('LACONICA')) { exit(1); } if (!defined('LACONICA')) {
exit(1);
}
require_once(INSTALLDIR.'/lib/twitterapi.php'); require_once(INSTALLDIR.'/lib/twitterapi.php');
@ -38,42 +40,34 @@ class Twitapidirect_messagesAction extends TwitterapiAction
function show_messages($args, $apidata, $type) function show_messages($args, $apidata, $type)
{ {
$user = $apidata['user']; $user = $apidata['user']; // Always the auth user
$count = $this->arg('count'); $message = new Message();
$since = $this->arg('since'); $title = null;
$since_id = $this->arg('since_id');
$max_id = $this->arg('max_id');
$page = $this->arg('page');
if (!$page) {
$page = 1;
}
if (!$count) {
$count = 20;
}
$message = new Message();
$title = null;
$subtitle = null; $subtitle = null;
$link = null; $link = null;
$server = common_root_url(); $server = common_root_url();
if ($type == 'received') { if ($type == 'received') {
$message->to_profile = $user->id; $message->to_profile = $user->id;
$title = sprintf(_("Direct messages to %s"), $user->nickname); $title = sprintf(_("Direct messages to %s"), $user->nickname);
$subtitle = sprintf(_("All the direct messages sent to %s"), $user->nickname); $subtitle = sprintf(_("All the direct messages sent to %s"),
$user->nickname);
$link = $server . $user->nickname . '/inbox'; $link = $server . $user->nickname . '/inbox';
} else { } else {
$message->from_profile = $user->id; $message->from_profile = $user->id;
$title = _('Direct Messages You\'ve Sent'); $title = _('Direct Messages You\'ve Sent');
$subtitle = sprintf(_("All the direct messages sent from %s"), $user->nickname); $subtitle = sprintf(_("All the direct messages sent from %s"),
$user->nickname);
$link = $server . $user->nickname . '/outbox'; $link = $server . $user->nickname . '/outbox';
} }
$page = (int)$this->arg('page', 1);
$count = (int)$this->arg('count', 20);
$max_id = (int)$this->arg('max_id', 0);
$since_id = (int)$this->arg('since_id', 0);
$since = $this->arg('since');
if ($max_id) { if ($max_id) {
$message->whereAdd("id <= $max_id"); $message->whereAdd("id <= $max_id");
} }
@ -82,25 +76,23 @@ class Twitapidirect_messagesAction extends TwitterapiAction
$message->whereAdd("id > $since_id"); $message->whereAdd("id > $since_id");
} }
$since = strtotime($this->arg('since'));
if ($since) { if ($since) {
$d = date('Y-m-d H:i:s', $since); $d = date('Y-m-d H:i:s', $since);
$message->whereAdd("created > '$d'"); $message->whereAdd("created > '$d'");
} }
$message->orderBy('created DESC, id DESC'); $message->orderBy('created DESC, id DESC');
$message->limit((($page-1)*20), $count); $message->limit((($page-1)*$count), $count);
$message->find(); $message->find();
switch($apidata['content-type']) { switch($apidata['content-type']) {
case 'xml': case 'xml':
$this->show_xml_dmsgs($message); $this->show_xml_dmsgs($message);
break; break;
case 'rss': case 'rss':
$this->show_rss_dmsgs($message, $title, $link, $subtitle); $this->show_rss_dmsgs($message, $title, $link, $subtitle);
break; break;
case 'atom': case 'atom':
$selfuri = common_root_url() . 'api/direct_messages'; $selfuri = common_root_url() . 'api/direct_messages';
$selfuri .= ($type == 'received') ? '.atom' : '/sent.atom'; $selfuri .= ($type == 'received') ? '.atom' : '/sent.atom';
$taguribase = common_config('integration', 'taguri'); $taguribase = common_config('integration', 'taguri');
@ -111,12 +103,13 @@ class Twitapidirect_messagesAction extends TwitterapiAction
$id = "tag:$taguribase:DirectMessages:" . $user->id; $id = "tag:$taguribase:DirectMessages:" . $user->id;
} }
$this->show_atom_dmsgs($message, $title, $link, $subtitle, $selfuri, $id); $this->show_atom_dmsgs($message, $title, $link, $subtitle,
$selfuri, $id);
break; break;
case 'json': case 'json':
$this->show_json_dmsgs($message); $this->show_json_dmsgs($message);
break; break;
default: default:
$this->clientError(_('API method not found!'), $code = 404); $this->clientError(_('API method not found!'), $code = 404);
} }
@ -128,22 +121,24 @@ class Twitapidirect_messagesAction extends TwitterapiAction
parent::handle($args); parent::handle($args);
if ($_SERVER['REQUEST_METHOD'] != 'POST') { if ($_SERVER['REQUEST_METHOD'] != 'POST') {
$this->clientError(_('This method requires a POST.'), 400, $apidata['content-type']); $this->clientError(_('This method requires a POST.'),
400, $apidata['content-type']);
return; return;
} }
$user = $apidata['user']; $user = $apidata['user'];
$source = $this->trimmed('source'); // Not supported by Twitter. $source = $this->trimmed('source'); // Not supported by Twitter.
$reserved_sources = array('web', 'omb', 'mail', 'xmpp', 'api'); $reserved_sources = array('web', 'omb', 'mail', 'xmpp', 'api');
if (!$source || in_array($source, $reserved_sources)) { if (empty($source) || in_array($source, $reserved_sources)) {
$source = 'api'; $source = 'api';
} }
$content = $this->trimmed('text'); $content = $this->trimmed('text');
if (!$content) { if (empty($content)) {
$this->clientError(_('No message text!'), $code = 406, $apidata['content-type']); $this->clientError(_('No message text!'),
$code = 406, $apidata['content-type']);
} else { } else {
$content_shortened = common_shorten_links($content); $content_shortened = common_shorten_links($content);
if (mb_strlen($content_shortened) > 140) { if (mb_strlen($content_shortened) > 140) {
@ -155,8 +150,9 @@ class Twitapidirect_messagesAction extends TwitterapiAction
$other = $this->get_user($this->trimmed('user')); $other = $this->get_user($this->trimmed('user'));
if (!$other) { if (empty($other)) {
$this->clientError(_('Recipient user not found.'), $code = 403, $apidata['content-type']); $this->clientError(_('Recipient user not found.'),
$code = 403, $apidata['content-type']);
return; return;
} else if (!$user->mutuallySubscribed($other)) { } else if (!$user->mutuallySubscribed($other)) {
$this->clientError(_('Can\'t send direct messages to users who aren\'t your friend.'), $this->clientError(_('Can\'t send direct messages to users who aren\'t your friend.'),

82
actions/twitapifavorites.php
View File

@ -17,7 +17,9 @@
* along with this program. If not, see <http://www.gnu.org/licenses/>. * along with this program. If not, see <http://www.gnu.org/licenses/>.
*/ */
if (!defined('LACONICA')) { exit(1); } if (!defined('LACONICA')) {
exit(1);
}
require_once(INSTALLDIR.'/lib/twitterapi.php'); require_once(INSTALLDIR.'/lib/twitterapi.php');
@ -31,50 +33,39 @@ class TwitapifavoritesAction extends TwitterapiAction
$this->auth_user = $apidata['user']; $this->auth_user = $apidata['user'];
$user = $this->get_user($apidata['api_arg'], $apidata); $user = $this->get_user($apidata['api_arg'], $apidata);
if (!$user) { if (empty($user)) {
$this->clientError('Not Found', 404, $apidata['content-type']); $this->clientError('Not Found', 404, $apidata['content-type']);
return; return;
} }
$profile = $user->getProfile(); $profile = $user->getProfile();
if (!$profile) { $sitename = common_config('site', 'name');
$this->serverError(_('User has no profile.')); $title = sprintf(_('%s / Favorites from %s'), $sitename,
return; $user->nickname);
}
$page = $this->arg('page');
if (!$page) {
$page = 1;
}
if (!$count) {
$count = 20;
}
$notice = $user->favoriteNotices((($page-1)*20), $count);
if (!$notice) {
$this->serverError(_('Could not retrieve favorite notices.'));
return;
}
$sitename = common_config('site', 'name');
$title = sprintf(_('%s / Favorites from %s'), $sitename, $user->nickname);
$taguribase = common_config('integration', 'taguri'); $taguribase = common_config('integration', 'taguri');
$id = "tag:$taguribase:Favorites:".$user->id; $id = "tag:$taguribase:Favorites:".$user->id;
$link = common_local_url('favorites', array('nickname' => $user->nickname)); $link = common_local_url('favorites',
$subtitle = sprintf(_('%s updates favorited by %s / %s.'), $sitename, $profile->getBestName(), $user->nickname); array('nickname' => $user->nickname));
$subtitle = sprintf(_('%s updates favorited by %s / %s.'), $sitename,
$profile->getBestName(), $user->nickname);
$page = (int)$this->arg('page', 1);
$count = (int)$this->arg('count', 20);
$max_id = (int)$this->arg('max_id', 0);
$since_id = (int)$this->arg('since_id', 0);
$since = $this->arg('since');
$notice = $user->favoriteNotices(($page-1)*$count, $count);
switch($apidata['content-type']) { switch($apidata['content-type']) {
case 'xml': case 'xml':
$this->show_xml_timeline($notice); $this->show_xml_timeline($notice);
break; break;
case 'rss': case 'rss':
$this->show_rss_timeline($notice, $title, $link, $subtitle); $this->show_rss_timeline($notice, $title, $link, $subtitle);
break; break;
case 'atom': case 'atom':
if (isset($apidata['api_arg'])) { if (isset($apidata['api_arg'])) {
$selfuri = $selfuri = common_root_url() . $selfuri = $selfuri = common_root_url() .
'api/favorites/' . $apidata['api_arg'] . '.atom'; 'api/favorites/' . $apidata['api_arg'] . '.atom';
@ -82,12 +73,13 @@ class TwitapifavoritesAction extends TwitterapiAction
$selfuri = $selfuri = common_root_url() . $selfuri = $selfuri = common_root_url() .
'api/favorites.atom'; 'api/favorites.atom';
} }
$this->show_atom_timeline($notice, $title, $id, $link, $subtitle, null, $selfuri); $this->show_atom_timeline($notice, $title, $id, $link,
$subtitle, null, $selfuri);
break; break;
case 'json': case 'json':
$this->show_json_timeline($notice); $this->show_json_timeline($notice);
break; break;
default: default:
$this->clientError(_('API method not found!'), $code = 404); $this->clientError(_('API method not found!'), $code = 404);
} }
@ -100,7 +92,8 @@ class TwitapifavoritesAction extends TwitterapiAction
// Check for RESTfulness // Check for RESTfulness
if (!in_array($_SERVER['REQUEST_METHOD'], array('POST', 'DELETE'))) { if (!in_array($_SERVER['REQUEST_METHOD'], array('POST', 'DELETE'))) {
// XXX: Twitter just prints the err msg, no XML / JSON. // XXX: Twitter just prints the err msg, no XML / JSON.
$this->clientError(_('This method requires a POST or DELETE.'), 400, $apidata['content-type']); $this->clientError(_('This method requires a POST or DELETE.'),
400, $apidata['content-type']);
return; return;
} }
@ -109,25 +102,27 @@ class TwitapifavoritesAction extends TwitterapiAction
return; return;
} }
$this->auth_user = $apidata['user']; $user = $apidata['user']; // Always the auth user
$user = $this->auth_user;
$notice_id = $apidata['api_arg']; $notice_id = $apidata['api_arg'];
$notice = Notice::staticGet($notice_id); $notice = Notice::staticGet($notice_id);
if (!$notice) { if (empty($notice)) {
$this->clientError(_('No status found with that ID.'), 404, $apidata['content-type']); $this->clientError(_('No status found with that ID.'),
404, $apidata['content-type']);
return; return;
} }
// XXX: Twitter lets you fave things repeatedly via api. // XXX: Twitter lets you fave things repeatedly via api.
if ($user->hasFave($notice)) { if ($user->hasFave($notice)) {
$this->clientError(_('This notice is already a favorite!'), 403, $apidata['content-type']); $this->clientError(_('This notice is already a favorite!'),
403, $apidata['content-type']);
return; return;
} }
$fave = Fave::addNew($user, $notice); $fave = Fave::addNew($user, $notice);
if (!$fave) { if (empty($fave)) {
$this->serverError(_('Could not create favorite.')); $this->serverError(_('Could not create favorite.'));
return; return;
} }
@ -149,7 +144,8 @@ class TwitapifavoritesAction extends TwitterapiAction
$this->serverError(_('API method under construction.'), $code=501); $this->serverError(_('API method under construction.'), $code=501);
} }
// XXX: these two funcs swiped from faves. Maybe put in util.php, or some common base class? // XXX: these two funcs swiped from faves.
// Maybe put in util.php, or some common base class?
function notify($fave, $notice, $user) function notify($fave, $notice, $user)
{ {

36
actions/twitapifriendships.php
View File

@ -17,7 +17,9 @@
* along with this program. If not, see <http://www.gnu.org/licenses/>. * along with this program. If not, see <http://www.gnu.org/licenses/>.
*/ */
if (!defined('LACONICA')) { exit(1); } if (!defined('LACONICA')) {
exit(1);
}
require_once(INSTALLDIR.'/lib/twitterapi.php'); require_once(INSTALLDIR.'/lib/twitterapi.php');
@ -29,23 +31,25 @@ class TwitapifriendshipsAction extends TwitterapiAction
parent::handle($args); parent::handle($args);
if ($_SERVER['REQUEST_METHOD'] != 'POST') { if ($_SERVER['REQUEST_METHOD'] != 'POST') {
$this->clientError(_('This method requires a POST.'), 400, $apidata['content-type']); $this->clientError(_('This method requires a POST.'),
400, $apidata['content-type']);
return; return;
} }
$id = $apidata['api_arg']; $id = $apidata['api_arg'];
$other = $this->get_user($id); $other = $this->get_user($id);
if (!$other) { if (empty($other)) {
$this->clientError(_('Could not follow user: User not found.'), 403, $apidata['content-type']); $this->clientError(_('Could not follow user: User not found.'),
403, $apidata['content-type']);
return; return;
} }
$user = $apidata['user']; $user = $apidata['user'];
if ($user->isSubscribed($other)) { if ($user->isSubscribed($other)) {
$errmsg = sprintf(_('Could not follow user: %s is already on your list.'), $other->nickname); $errmsg = sprintf(_('Could not follow user: %s is already on your list.'),
$other->nickname);
$this->clientError($errmsg, 403, $apidata['content-type']); $this->clientError($errmsg, 403, $apidata['content-type']);
return; return;
} }
@ -60,8 +64,9 @@ class TwitapifriendshipsAction extends TwitterapiAction
$result = $sub->insert(); $result = $sub->insert();
if (!$result) { if (empty($result)) {
$errmsg = sprintf(_('Could not follow user: %s is already on your list.'), $other->nickname); $errmsg = sprintf(_('Could not follow user: %s is already on your list.'),
$other->nickname);
$this->clientError($errmsg, 400, $apidata['content-type']); $this->clientError($errmsg, 400, $apidata['content-type']);
return; return;
} }
@ -82,7 +87,8 @@ class TwitapifriendshipsAction extends TwitterapiAction
parent::handle($args); parent::handle($args);
if (!in_array($_SERVER['REQUEST_METHOD'], array('POST', 'DELETE'))) { if (!in_array($_SERVER['REQUEST_METHOD'], array('POST', 'DELETE'))) {
$this->clientError(_('This method requires a POST or DELETE.'), 400, $apidata['content-type']); $this->clientError(_('This method requires a POST or DELETE.'),
400, $apidata['content-type']);
return; return;
} }
@ -91,7 +97,7 @@ class TwitapifriendshipsAction extends TwitterapiAction
# We can't subscribe to a remote person, but we can unsub # We can't subscribe to a remote person, but we can unsub
$other = $this->get_profile($id); $other = $this->get_profile($id);
$user = $apidata['user']; $user = $apidata['user']; // Alwyas the auth user
$sub = new Subscription(); $sub = new Subscription();
$sub->subscriber = $user->id; $sub->subscriber = $user->id;
@ -102,7 +108,8 @@ class TwitapifriendshipsAction extends TwitterapiAction
$sub->delete(); $sub->delete();
$sub->query('COMMIT'); $sub->query('COMMIT');
} else { } else {
$this->clientError(_('You are not friends with the specified user.'), 403, $apidata['content-type']); $this->clientError(_('You are not friends with the specified user.'),
403, $apidata['content-type']);
return; return;
} }
@ -128,8 +135,9 @@ class TwitapifriendshipsAction extends TwitterapiAction
$user_a = $this->get_user($user_a_id); $user_a = $this->get_user($user_a_id);
$user_b = $this->get_user($user_b_id); $user_b = $this->get_user($user_b_id);
if (!$user_a || !$user_b) { if (empty($user_a) || empty($user_b)) {
$this->clientError(_('Two user ids or screen_names must be supplied.'), 400, $apidata['content-type']); $this->clientError(_('Two user ids or screen_names must be supplied.'),
400, $apidata['content-type']);
return; return;
} }

4
actions/twitapihelp.php
View File

@ -17,7 +17,9 @@
* along with this program. If not, see <http://www.gnu.org/licenses/>. * along with this program. If not, see <http://www.gnu.org/licenses/>.
*/ */
if (!defined('LACONICA')) { exit(1); } if (!defined('LACONICA')) {
exit(1);
}
require_once(INSTALLDIR.'/lib/twitterapi.php'); require_once(INSTALLDIR.'/lib/twitterapi.php');

399
actions/twitapistatuses.php
View File

@ -17,7 +17,9 @@
* along with this program. If not, see <http://www.gnu.org/licenses/>. * along with this program. If not, see <http://www.gnu.org/licenses/>.
*/ */
if (!defined('LACONICA')) { exit(1); } if (!defined('LACONICA')) {
exit(1);
}
require_once(INSTALLDIR.'/lib/twitterapi.php'); require_once(INSTALLDIR.'/lib/twitterapi.php');
@ -26,64 +28,45 @@ class TwitapistatusesAction extends TwitterapiAction
function public_timeline($args, $apidata) function public_timeline($args, $apidata)
{ {
parent::handle($args); // XXX: To really live up to the spec we need to build a list
$sitename = common_config('site', 'name');
$title = sprintf(_("%s public timeline"), $sitename);
$taguribase = common_config('integration', 'taguri');
$id = "tag:$taguribase:PublicTimeline";
$link = common_root_url();
$subtitle = sprintf(_("%s updates from everyone!"), $sitename);
// Number of public statuses to return by default -- Twitter sends 20
$MAX_PUBSTATUSES = 20;
// FIXME: To really live up to the spec we need to build a list
// of notices by users who have custom avatars, so fix this SQL -- Zach // of notices by users who have custom avatars, so fix this SQL -- Zach
$page = $this->arg('page'); parent::handle($args);
$since_id = $this->arg('since_id');
$max_id = $this->arg('max_id');
if (!$page) { $sitename = common_config('site', 'name');
$page = 1; $title = sprintf(_("%s public timeline"), $sitename);
} $taguribase = common_config('integration', 'taguri');
if (!$since_id) { $id = "tag:$taguribase:PublicTimeline";
$since_id = 0; $link = common_root_url();
} $subtitle = sprintf(_("%s updates from everyone!"), $sitename);
if (!$max_id) {
$max_id = 0;
}
$since = strtotime($this->arg('since')); $page = (int)$this->arg('page', 1);
$count = (int)$this->arg('count', 20);
$max_id = (int)$this->arg('max_id', 0);
$since_id = (int)$this->arg('since_id', 0);
$since = $this->arg('since');
$notice = Notice::publicStream((($page-1)*$MAX_PUBSTATUSES), $MAX_PUBSTATUSES, $since_id, $max_id, $since); $notice = Notice::publicStream(($page-1)*$count, $count, $since_id,
$max_id, $since);
if ($notice) { switch($apidata['content-type']) {
case 'xml':
switch($apidata['content-type']) { $this->show_xml_timeline($notice);
case 'xml': break;
$this->show_xml_timeline($notice); case 'rss':
break; $this->show_rss_timeline($notice, $title, $link, $subtitle);
case 'rss': break;
$this->show_rss_timeline($notice, $title, $link, $subtitle); case 'atom':
break; $selfuri = common_root_url() . 'api/statuses/public_timeline.atom';
case 'atom': $this->show_atom_timeline($notice, $title, $id, $link,
$selfuri = common_root_url() . 'api/statuses/public_timeline.atom'; $subtitle, null, $selfuri);
$this->show_atom_timeline($notice, $title, $id, $link, $subtitle, null, $selfuri); break;
break; case 'json':
case 'json': $this->show_json_timeline($notice);
$this->show_json_timeline($notice); break;
break; default:
default: $this->clientError(_('API method not found!'), $code = 404);
$this->clientError(_('API method not found!'), $code = 404); break;
break;
}
} else {
$this->serverError(_('Couldn\'t find any statuses.'), $code = 503);
} }
} }
@ -92,68 +75,57 @@ class TwitapistatusesAction extends TwitterapiAction
{ {
parent::handle($args); parent::handle($args);
$since = $this->arg('since');
$since_id = $this->arg('since_id');
$count = $this->arg('count');
$page = $this->arg('page');
$max_id = $this->arg('max_id');
if (!$page) {
$page = 1;
}
if (!$count) {
$count = 20;
}
if (!$since_id) {
$since_id = 0;
}
if (!$max_id) {
$max_id = 0;
}
$since = strtotime($this->arg('since'));
$user = $this->get_user($apidata['api_arg'], $apidata); $user = $this->get_user($apidata['api_arg'], $apidata);
$this->auth_user = $user; $this->auth_user = $user;
if (empty($user)) { if (empty($user)) {
$this->clientError(_('No such user!'), 404, $apidata['content-type']); $this->clientError(_('No such user!'), 404,
$apidata['content-type']);
return; return;
} }
$profile = $user->getProfile(); $profile = $user->getProfile();
$sitename = common_config('site', 'name'); $sitename = common_config('site', 'name');
$title = sprintf(_("%s and friends"), $user->nickname); $title = sprintf(_("%s and friends"), $user->nickname);
$taguribase = common_config('integration', 'taguri'); $taguribase = common_config('integration', 'taguri');
$id = "tag:$taguribase:FriendsTimeline:" . $user->id; $id = "tag:$taguribase:FriendsTimeline:" . $user->id;
$link = common_local_url('all', array('nickname' => $user->nickname)); $link = common_local_url('all',
$subtitle = sprintf(_('Updates from %1$s and friends on %2$s!'), $user->nickname, $sitename); array('nickname' => $user->nickname));
$subtitle = sprintf(_('Updates from %1$s and friends on %2$s!'),
$user->nickname, $sitename);
$notice = $user->noticesWithFriends(($page-1)*20, $count, $since_id, $max_id, $since); $page = (int)$this->arg('page', 1);
$count = (int)$this->arg('count', 20);
$max_id = (int)$this->arg('max_id', 0);
$since_id = (int)$this->arg('since_id', 0);
$since = $this->arg('since');
$notice = $user->noticesWithFriends(($page-1)*$count,
$count, $since_id, $max_id,$since);
switch($apidata['content-type']) { switch($apidata['content-type']) {
case 'xml': case 'xml':
$this->show_xml_timeline($notice); $this->show_xml_timeline($notice);
break; break;
case 'rss': case 'rss':
$this->show_rss_timeline($notice, $title, $link, $subtitle); $this->show_rss_timeline($notice, $title, $link, $subtitle);
break; break;
case 'atom': case 'atom':
if (isset($apidata['api_arg'])) { if (isset($apidata['api_arg'])) {
$selfuri = common_root_url() . $selfuri = common_root_url() .
'api/statuses/friends_timeline/' . $apidata['api_arg'] . '.atom'; 'api/statuses/friends_timeline/' .
$apidata['api_arg'] . '.atom';
} else { } else {
$selfuri = common_root_url() . $selfuri = common_root_url() .
'api/statuses/friends_timeline.atom'; 'api/statuses/friends_timeline.atom';
} }
$this->show_atom_timeline($notice, $title, $id, $link, $subtitle, null, $selfuri); $this->show_atom_timeline($notice, $title, $id, $link,
$subtitle, null, $selfuri);
break; break;
case 'json': case 'json':
$this->show_json_timeline($notice); $this->show_json_timeline($notice);
break; break;
default: default:
$this->clientError(_('API method not found!'), $code = 404); $this->clientError(_('API method not found!'), $code = 404);
} }
@ -166,48 +138,21 @@ class TwitapistatusesAction extends TwitterapiAction
$this->auth_user = $apidata['user']; $this->auth_user = $apidata['user'];
$user = $this->get_user($apidata['api_arg'], $apidata); $user = $this->get_user($apidata['api_arg'], $apidata);
if (!$user) { if (empty($user)) {
$this->clientError('Not Found', 404, $apidata['content-type']); $this->clientError('Not Found', 404, $apidata['content-type']);
return; return;
} }
$profile = $user->getProfile(); $profile = $user->getProfile();
if (!$profile) { $sitename = common_config('site', 'name');
$this->serverError(_('User has no profile.')); $title = sprintf(_("%s timeline"), $user->nickname);
return;
}
$count = $this->arg('count');
$since = $this->arg('since');
$since_id = $this->arg('since_id');
$page = $this->arg('page');
$max_id = $this->arg('max_id');
if (!$page) {
$page = 1;
}
if (!$count) {
$count = 20;
}
if (!$since_id) {
$since_id = 0;
}
if (!$max_id) {
$max_id = 0;
}
$since = strtotime($this->arg('since'));
$sitename = common_config('site', 'name');
$title = sprintf(_("%s timeline"), $user->nickname);
$taguribase = common_config('integration', 'taguri'); $taguribase = common_config('integration', 'taguri');
$id = "tag:$taguribase:UserTimeline:".$user->id; $id = "tag:$taguribase:UserTimeline:".$user->id;
$link = common_local_url('showstream', array('nickname' => $user->nickname)); $link = common_local_url('showstream',
$subtitle = sprintf(_('Updates from %1$s on %2$s!'), $user->nickname, $sitename); array('nickname' => $user->nickname));
$subtitle = sprintf(_('Updates from %1$s on %2$s!'),
$user->nickname, $sitename);
# FriendFeed's SUP protocol # FriendFeed's SUP protocol
# Also added RSS and Atom feeds # Also added RSS and Atom feeds
@ -215,26 +160,34 @@ class TwitapistatusesAction extends TwitterapiAction
$suplink = common_local_url('sup', null, null, $user->id); $suplink = common_local_url('sup', null, null, $user->id);
header('X-SUP-ID: '.$suplink); header('X-SUP-ID: '.$suplink);
# XXX: since $page = (int)$this->arg('page', 1);
$count = (int)$this->arg('count', 20);
$max_id = (int)$this->arg('max_id', 0);
$since_id = (int)$this->arg('since_id', 0);
$since = $this->arg('since');
$notice = $user->getNotices((($page-1)*20), $count, $since_id, $max_id, $since); $notice = $user->getNotices(($page-1)*$count,
$count, $since_id, $max_id, $since);
switch($apidata['content-type']) { switch($apidata['content-type']) {
case 'xml': case 'xml':
$this->show_xml_timeline($notice); $this->show_xml_timeline($notice);
break; break;
case 'rss': case 'rss':
$this->show_rss_timeline($notice, $title, $link, $subtitle, $suplink); $this->show_rss_timeline($notice, $title, $link,
$subtitle, $suplink);
break; break;
case 'atom': case 'atom':
if (isset($apidata['api_arg'])) { if (isset($apidata['api_arg'])) {
$selfuri = common_root_url() . $selfuri = common_root_url() .
'api/statuses/user_timeline/' . $apidata['api_arg'] . '.atom'; 'api/statuses/user_timeline/' .
$apidata['api_arg'] . '.atom';
} else { } else {
$selfuri = common_root_url() . $selfuri = common_root_url() .
'api/statuses/user_timeline.atom'; 'api/statuses/user_timeline.atom';
} }
$this->show_atom_timeline($notice, $title, $id, $link, $subtitle, $suplink, $selfuri); $this->show_atom_timeline($notice, $title, $id, $link,
$subtitle, $suplink, $selfuri);
break; break;
case 'json': case 'json':
$this->show_json_timeline($notice); $this->show_json_timeline($notice);
@ -247,7 +200,6 @@ class TwitapistatusesAction extends TwitterapiAction
function update($args, $apidata) function update($args, $apidata)
{ {
parent::handle($args); parent::handle($args);
if (!in_array($apidata['content-type'], array('xml', 'json'))) { if (!in_array($apidata['content-type'], array('xml', 'json'))) {
@ -256,21 +208,24 @@ class TwitapistatusesAction extends TwitterapiAction
} }
if ($_SERVER['REQUEST_METHOD'] != 'POST') { if ($_SERVER['REQUEST_METHOD'] != 'POST') {
$this->clientError(_('This method requires a POST.'), 400, $apidata['content-type']); $this->clientError(_('This method requires a POST.'),
400, $apidata['content-type']);
return; return;
} }
$this->auth_user = $apidata['user']; $user = $apidata['user']; // Always the auth user
$user = $this->auth_user;
$status = $this->trimmed('status'); $status = $this->trimmed('status');
$source = $this->trimmed('source'); $source = $this->trimmed('source');
$in_reply_to_status_id = intval($this->trimmed('in_reply_to_status_id')); $in_reply_to_status_id =
intval($this->trimmed('in_reply_to_status_id'));
$reserved_sources = array('web', 'omb', 'mail', 'xmpp', 'api'); $reserved_sources = array('web', 'omb', 'mail', 'xmpp', 'api');
if (!$source || in_array($source, $reserved_sources)) {
if (empty($source) || in_array($source, $reserved_sources)) {
$source = 'api'; $source = 'api';
} }
if (!$status) { if (empty($status)) {
// XXX: Note: In this case, Twitter simply returns '200 OK' // XXX: Note: In this case, Twitter simply returns '200 OK'
// No error is given, but the status is not posted to the // No error is given, but the status is not posted to the
@ -288,9 +243,9 @@ class TwitapistatusesAction extends TwitterapiAction
// as "truncated." Sending this error may screw up some clients // as "truncated." Sending this error may screw up some clients
// that assume Twitter will truncate for them. Should we just // that assume Twitter will truncate for them. Should we just
// truncate too? -- Zach // truncate too? -- Zach
$this->clientError(_('That\'s too long. Max notice size is 140 chars.'), $code = 406, $apidata['content-type']); $this->clientError(_('That\'s too long. Max notice size is 140 chars.'),
$code = 406, $apidata['content-type']);
return; return;
} }
} }
@ -321,13 +276,15 @@ class TwitapistatusesAction extends TwitterapiAction
if ($reply) { if ($reply) {
$reply_to = $in_reply_to_status_id; $reply_to = $in_reply_to_status_id;
} else { } else {
$this->clientError(_('Not found'), $code = 404, $apidata['content-type']); $this->clientError(_('Not found'), $code = 404,
$apidata['content-type']);
return; return;
} }
} }
$notice = Notice::saveNew($user->id, html_entity_decode($status, ENT_NOQUOTES, 'UTF-8'), $notice = Notice::saveNew($user->id,
$source, 1, $reply_to); html_entity_decode($status, ENT_NOQUOTES, 'UTF-8'),
$source, 1, $reply_to);
if (is_string($notice)) { if (is_string($notice)) {
$this->serverError($notice); $this->serverError($notice);
@ -343,71 +300,55 @@ class TwitapistatusesAction extends TwitterapiAction
function mentions($args, $apidata) function mentions($args, $apidata)
{ {
parent::handle($args); parent::handle($args);
$since = $this->arg('since');
$count = $this->arg('count');
$page = $this->arg('page');
$since_id = $this->arg('since_id');
$max_id = $this->arg('max_id');
$user = $this->get_user($apidata['api_arg'], $apidata); $user = $this->get_user($apidata['api_arg'], $apidata);
$this->auth_user = $apidata['user']; $this->auth_user = $apidata['user'];
if (empty($user)) {
$this->clientError(_('No such user!'), 404,
$apidata['content-type']);
return;
}
$profile = $user->getProfile(); $profile = $user->getProfile();
$sitename = common_config('site', 'name'); $sitename = common_config('site', 'name');
$title = sprintf(_('%1$s / Updates mentioning %2$s'), $title = sprintf(_('%1$s / Updates mentioning %2$s'),
$sitename, $user->nickname); $sitename, $user->nickname);
$taguribase = common_config('integration', 'taguri'); $taguribase = common_config('integration', 'taguri');
$id = "tag:$taguribase:Mentions:".$user->id; $id = "tag:$taguribase:Mentions:".$user->id;
$link = common_local_url('replies', array('nickname' => $user->nickname)); $link = common_local_url('replies',
$subtitle = sprintf(_('%1$s updates that reply to updates from %2$s / %3$s.'), array('nickname' => $user->nickname));
$subtitle = sprintf(_('%1$s updates that reply to updates from %2$s / %3$s.'),
$sitename, $user->nickname, $profile->getBestName()); $sitename, $user->nickname, $profile->getBestName());
if (!$page) { $page = (int)$this->arg('page', 1);
$page = 1; $count = (int)$this->arg('count', 20);
} $max_id = (int)$this->arg('max_id', 0);
$since_id = (int)$this->arg('since_id', 0);
$since = $this->arg('since');
if (!$count) { $notice = $user->getReplies(($page-1)*$count,
$count = 20;
}
if (!$since_id) {
$since_id = 0;
}
if (!$max_id) {
$max_id = 0;
}
$since = strtotime($this->arg('since'));
$notice = $user->getReplies((($page-1)*20),
$count, $since_id, $max_id, $since); $count, $since_id, $max_id, $since);
$notices = array();
while ($notice->fetch()) {
$notices[] = clone($notice);
}
switch($apidata['content-type']) { switch($apidata['content-type']) {
case 'xml': case 'xml':
$this->show_xml_timeline($notices); $this->show_xml_timeline($notice);
break; break;
case 'rss': case 'rss':
$this->show_rss_timeline($notices, $title, $link, $subtitle); $this->show_rss_timeline($notice, $title, $link, $subtitle);
break; break;
case 'atom': case 'atom':
$selfuri = common_root_url() . $selfuri = common_root_url() .
ltrim($_SERVER['QUERY_STRING'], 'p='); ltrim($_SERVER['QUERY_STRING'], 'p=');
$this->show_atom_timeline($notices, $title, $id, $link, $subtitle, $this->show_atom_timeline($notice, $title, $id, $link, $subtitle,
null, $selfuri); null, $selfuri);
break; break;
case 'json': case 'json':
$this->show_json_timeline($notices); $this->show_json_timeline($notice);
break; break;
default: default:
$this->clientError(_('API method not found!'), $code = 404); $this->clientError(_('API method not found!'), $code = 404);
} }
@ -428,8 +369,8 @@ class TwitapistatusesAction extends TwitterapiAction
} }
$this->auth_user = $apidata['user']; $this->auth_user = $apidata['user'];
$notice_id = $apidata['api_arg']; $notice_id = $apidata['api_arg'];
$notice = Notice::staticGet($notice_id); $notice = Notice::staticGet($notice_id);
if ($notice) { if ($notice) {
if ($apidata['content-type'] == 'xml') { if ($apidata['content-type'] == 'xml') {
@ -438,15 +379,16 @@ class TwitapistatusesAction extends TwitterapiAction
$this->show_single_json_status($notice); $this->show_single_json_status($notice);
} }
} else { } else {
// XXX: Twitter just sets a 404 header and doens't bother to return an err msg // XXX: Twitter just sets a 404 header and doens't bother
$this->clientError(_('No status with that ID found.'), 404, $apidata['content-type']); // to return an err msg
$this->clientError(_('No status with that ID found.'),
404, $apidata['content-type']);
} }
} }
function destroy($args, $apidata) function destroy($args, $apidata)
{ {
parent::handle($args); parent::handle($args);
if (!in_array($apidata['content-type'], array('xml', 'json'))) { if (!in_array($apidata['content-type'], array('xml', 'json'))) {
@ -457,17 +399,18 @@ class TwitapistatusesAction extends TwitterapiAction
// Check for RESTfulness // Check for RESTfulness
if (!in_array($_SERVER['REQUEST_METHOD'], array('POST', 'DELETE'))) { if (!in_array($_SERVER['REQUEST_METHOD'], array('POST', 'DELETE'))) {
// XXX: Twitter just prints the err msg, no XML / JSON. // XXX: Twitter just prints the err msg, no XML / JSON.
$this->clientError(_('This method requires a POST or DELETE.'), 400, $apidata['content-type']); $this->clientError(_('This method requires a POST or DELETE.'),
400, $apidata['content-type']);
return; return;
} }
$this->auth_user = $apidata['user']; $user = $apidata['user']; // Always the auth user
$user = $this->auth_user;
$notice_id = $apidata['api_arg']; $notice_id = $apidata['api_arg'];
$notice = Notice::staticGet($notice_id); $notice = Notice::staticGet($notice_id);
if (!$notice) { if (empty($notice)) {
$this->clientError(_('No status found with that ID.'), 404, $apidata['content-type']); $this->clientError(_('No status found with that ID.'),
404, $apidata['content-type']);
return; return;
} }
@ -483,7 +426,8 @@ class TwitapistatusesAction extends TwitterapiAction
$this->show_single_json_status($notice); $this->show_single_json_status($notice);
} }
} else { } else {
$this->clientError(_('You may not delete another user\'s status.'), 403, $apidata['content-type']); $this->clientError(_('You may not delete another user\'s status.'),
403, $apidata['content-type']);
} }
} }
@ -514,42 +458,41 @@ class TwitapistatusesAction extends TwitterapiAction
function subscriptions($apidata, $other_attr, $user_attr, $onlyIDs=false) function subscriptions($apidata, $other_attr, $user_attr, $onlyIDs=false)
{ {
$this->auth_user = $apidata['user']; $this->auth_user = $apidata['user'];
$user = $this->get_user($apidata['api_arg'], $apidata); $user = $this->get_user($apidata['api_arg'], $apidata);
if (!$user) { if (empty($user)) {
$this->clientError('Not Found', 404, $apidata['content-type']); $this->clientError('Not Found', 404, $apidata['content-type']);
return; return;
} }
$page = $this->trimmed('page');
if (!$page || !is_numeric($page)) {
$page = 1;
}
$profile = $user->getProfile(); $profile = $user->getProfile();
if (!$profile) {
$this->serverError(_('User has no profile.'));
return;
}
$sub = new Subscription(); $sub = new Subscription();
$sub->$user_attr = $profile->id; $sub->$user_attr = $profile->id;
$since = strtotime($this->trimmed('since'));
if ($since) {
$d = date('Y-m-d H:i:s', $since);
$sub->whereAdd("created > '$d'");
}
$sub->orderBy('created DESC'); $sub->orderBy('created DESC');
// Normally, page 100 friends at a time
if (!$onlyIDs) { if (!$onlyIDs) {
$sub->limit(($page-1)*100, 100); $page = $this->arg('page', 1);
$count = $this->arg('count', 100);
$sub->limit(($page-1)*$count, $count);
} else {
// If we're just looking at IDs, return
// ALL of them, unless the user specifies a page,
// in which case, return 500 per page.
$page = $this->arg('page');
if (!empty($page)) {
if ($page < 1) {
$page = 1;
}
$count = 500;
$sub->limit(($page-1)*$count, $count);
}
} }
$others = array(); $others = array();
@ -578,21 +521,21 @@ class TwitapistatusesAction extends TwitterapiAction
function show_profiles($profiles, $type) function show_profiles($profiles, $type)
{ {
switch ($type) { switch ($type) {
case 'xml': case 'xml':
$this->elementStart('users', array('type' => 'array')); $this->elementStart('users', array('type' => 'array'));
foreach ($profiles as $profile) { foreach ($profiles as $profile) {
$this->show_profile($profile); $this->show_profile($profile);
} }
$this->elementEnd('users'); $this->elementEnd('users');
break; break;
case 'json': case 'json':
$arrays = array(); $arrays = array();
foreach ($profiles as $profile) { foreach ($profiles as $profile) {
$arrays[] = $this->twitter_user_array($profile, true); $arrays[] = $this->twitter_user_array($profile, true);
} }
print json_encode($arrays); print json_encode($arrays);
break; break;
default: default:
$this->clientError(_('unsupported file type')); $this->clientError(_('unsupported file type'));
} }
} }
@ -600,21 +543,21 @@ class TwitapistatusesAction extends TwitterapiAction
function showIDs($profiles, $type) function showIDs($profiles, $type)
{ {
switch ($type) { switch ($type) {
case 'xml': case 'xml':
$this->elementStart('ids'); $this->elementStart('ids');
foreach ($profiles as $profile) { foreach ($profiles as $profile) {
$this->element('id', null, $profile->id); $this->element('id', null, $profile->id);
} }
$this->elementEnd('ids'); $this->elementEnd('ids');
break; break;
case 'json': case 'json':
$ids = array(); $ids = array();
foreach ($profiles as $profile) { foreach ($profiles as $profile) {
$ids[] = (int)$profile->id; $ids[] = (int)$profile->id;
} }
print json_encode($ids); print json_encode($ids);
break; break;
default: default:
$this->clientError(_('unsupported file type')); $this->clientError(_('unsupported file type'));
} }
} }
@ -627,8 +570,8 @@ class TwitapistatusesAction extends TwitterapiAction
function supported($cmd) function supported($cmd)
{ {
$cmdlist = array('MessageCommand', 'SubCommand', 'UnsubCommand',
$cmdlist = array('MessageCommand', 'SubCommand', 'UnsubCommand', 'FavCommand', 'OnCommand', 'OffCommand'); 'FavCommand', 'OnCommand', 'OffCommand');
if (in_array(get_class($cmd), $cmdlist)) { if (in_array(get_class($cmd), $cmdlist)) {
return true; return true;

13
actions/twitapiusers.php
View File

@ -17,7 +17,9 @@
* along with this program. If not, see <http://www.gnu.org/licenses/>. * along with this program. If not, see <http://www.gnu.org/licenses/>.
*/ */
if (!defined('LACONICA')) { exit(1); } if (!defined('LACONICA')) {
exit(1);
}
require_once(INSTALLDIR.'/lib/twitterapi.php'); require_once(INSTALLDIR.'/lib/twitterapi.php');
@ -51,18 +53,11 @@ class TwitapiusersAction extends TwitterapiAction
$user = $apidata['user']; $user = $apidata['user'];
} }
if (!$user) { if (empty($user)) {
$this->client_error(_('Not found.'), 404, $apidata['content-type']); $this->client_error(_('Not found.'), 404, $apidata['content-type']);
return; return;
} }
$profile = $user->getProfile();
if (!$profile) {
common_server_error(_('User has no profile.'));
return;
}
$twitter_user = $this->twitter_user_array($profile, true); $twitter_user = $this->twitter_user_array($profile, true);
if ($apidata['content-type'] == 'xml') { if ($apidata['content-type'] == 'xml') {

95
lib/twitterapi.php
View File

@ -17,7 +17,9 @@
* along with this program. If not, see <http://www.gnu.org/licenses/>. * along with this program. If not, see <http://www.gnu.org/licenses/>.
*/ */
if (!defined('LACONICA')) { exit(1); } if (!defined('LACONICA')) {
exit(1);
}
class TwitterapiAction extends Action class TwitterapiAction extends Action
{ {
@ -521,11 +523,11 @@ class TwitterapiAction extends Action
function init_document($type='xml') function init_document($type='xml')
{ {
switch ($type) { switch ($type) {
case 'xml': case 'xml':
header('Content-Type: application/xml; charset=utf-8'); header('Content-Type: application/xml; charset=utf-8');
$this->startXML(); $this->startXML();
break; break;
case 'json': case 'json':
header('Content-Type: application/json; charset=utf-8'); header('Content-Type: application/json; charset=utf-8');
// Check for JSONP callback // Check for JSONP callback
@ -534,15 +536,15 @@ class TwitterapiAction extends Action
print $callback . '('; print $callback . '(';
} }
break; break;
case 'rss': case 'rss':
header("Content-Type: application/rss+xml; charset=utf-8"); header("Content-Type: application/rss+xml; charset=utf-8");
$this->init_twitter_rss(); $this->init_twitter_rss();
break; break;
case 'atom': case 'atom':
header('Content-Type: application/atom+xml; charset=utf-8'); header('Content-Type: application/atom+xml; charset=utf-8');
$this->init_twitter_atom(); $this->init_twitter_atom();
break; break;
default: default:
$this->client_error(_('Not a supported data format.')); $this->client_error(_('Not a supported data format.'));
break; break;
} }
@ -553,10 +555,10 @@ class TwitterapiAction extends Action
function end_document($type='xml') function end_document($type='xml')
{ {
switch ($type) { switch ($type) {
case 'xml': case 'xml':
$this->endXML(); $this->endXML();
break; break;
case 'json': case 'json':
// Check for JSONP callback // Check for JSONP callback
$callback = $this->arg('callback'); $callback = $this->arg('callback');
@ -564,13 +566,13 @@ class TwitterapiAction extends Action
print ')'; print ')';
} }
break; break;
case 'rss': case 'rss':
$this->end_twitter_rss(); $this->end_twitter_rss();
break; break;
case 'atom': case 'atom':
$this->end_twitter_rss(); $this->end_twitter_rss();
break; break;
default: default:
$this->client_error(_('Not a supported data format.')); $this->client_error(_('Not a supported data format.'));
break; break;
} }
@ -657,13 +659,13 @@ class TwitterapiAction extends Action
{ {
$profile_array = $this->twitter_user_array($profile, true); $profile_array = $this->twitter_user_array($profile, true);
switch ($content_type) { switch ($content_type) {
case 'xml': case 'xml':
$this->show_twitter_xml_user($profile_array); $this->show_twitter_xml_user($profile_array);
break; break;
case 'json': case 'json':
$this->show_json_objects($profile_array); $this->show_json_objects($profile_array);
break; break;
default: default:
$this->client_error(_('Not a supported data format.')); $this->client_error(_('Not a supported data format.'));
return; return;
} }
@ -672,8 +674,8 @@ class TwitterapiAction extends Action
function get_user($id, $apidata=null) function get_user($id, $apidata=null)
{ {
if (!$id) { if (empty($id)) {
// Twitter supports these other ways of passing the user ID // Twitter supports these other ways of passing the user ID
if (is_numeric($this->arg('id'))) { if (is_numeric($this->arg('id'))) {
return User::staticGet($this->arg('id')); return User::staticGet($this->arg('id'));
@ -681,7 +683,7 @@ class TwitterapiAction extends Action
$nickname = common_canonical_nickname($this->arg('id')); $nickname = common_canonical_nickname($this->arg('id'));
return User::staticGet('nickname', $nickname); return User::staticGet('nickname', $nickname);
} else if ($this->arg('user_id')) { } else if ($this->arg('user_id')) {
// This is to ensure that a non-numeric user_id still // This is to ensure that a non-numeric user_id still
// overrides screen_name even if it doesn't get used // overrides screen_name even if it doesn't get used
if (is_numeric($this->arg('user_id'))) { if (is_numeric($this->arg('user_id'))) {
return User::staticGet('id', $this->arg('user_id')); return User::staticGet('id', $this->arg('user_id'));
@ -693,7 +695,7 @@ class TwitterapiAction extends Action
// Fall back to trying the currently authenticated user // Fall back to trying the currently authenticated user
return $apidata['user']; return $apidata['user'];
} }
} else if (is_numeric($id)) { } else if (is_numeric($id)) {
return User::staticGet($id); return User::staticGet($id);
} else { } else {
@ -720,13 +722,13 @@ class TwitterapiAction extends Action
{ {
$source_name = _($source); $source_name = _($source);
switch ($source) { switch ($source) {
case 'web': case 'web':
case 'xmpp': case 'xmpp':
case 'mail': case 'mail':
case 'omb': case 'omb':
case 'api': case 'api':
break; break;
default: default:
$ns = Notice_source::staticGet($source); $ns = Notice_source::staticGet($source);
if ($ns) { if ($ns) {
$source_name = '<a href="' . $ns->url . '">' . $ns->name . '</a>'; $source_name = '<a href="' . $ns->url . '">' . $ns->name . '</a>';
@ -736,4 +738,49 @@ class TwitterapiAction extends Action
return $source_name; return $source_name;
} }
/**
* Returns query argument or default value if not found. Certain
* parameters used throughout the API are lightly scrubbed and
* bounds checked. This overrides Action::arg().
*
* @param string $key requested argument
* @param string $def default value to return if $key is not provided
*
* @return var $var
*/
function arg($key, $def=null)
{
// XXX: Do even more input validation/scrubbing?
if (array_key_exists($key, $this->args)) {
switch($key) {
case 'page':
$page = (int)$this->args['page'];
return ($page < 1) ? 1 : $page;
case 'count':
$count = (int)$this->args['count'];
if ($count < 1) {
return 20;
} elseif ($count > 200) {
return 200;
} else {
return $count;
}
case 'since_id':
$since_id = (int)$this->args['since_id'];
return ($since_id < 1) ? 0 : $since_id;
case 'max_id':
$max_id = (int)$this->args['max_id'];
return ($max_id < 1) ? 0 : $max_id;
case 'since':
return strtotime($this->args['since']);
default:
return parent::arg($key, $def);
}
} else {
return $def;
}
}
} }