Add some basic oEmbed lookup test cases; fixed a bug in discovery fallback.

This commit is contained in:
Brion Vibber 2010-11-15 11:55:28 -08:00
parent 57ec01d0b8
commit 87114a5c30
2 changed files with 67 additions and 1 deletions

View File

@ -164,7 +164,6 @@ class oEmbedHelper
} }
} }
return false;
throw new oEmbedHelper_DiscoveryException(); throw new oEmbedHelper_DiscoveryException();
} }

67
tests/oEmbedTest.php Normal file
View File

@ -0,0 +1,67 @@
<?php
if (isset($_SERVER) && array_key_exists('REQUEST_METHOD', $_SERVER)) {
print "This script must be run from the command line\n";
exit();
}
define('INSTALLDIR', realpath(dirname(__FILE__) . '/..'));
define('STATUSNET', true);
require_once INSTALLDIR . '/lib/common.php';
class oEmbedTest extends PHPUnit_Framework_TestCase
{
public function setup()
{
//$this->old_oohembed = common_config('oohembed', 'endpoint');
}
public function tearDown()
{
//$GLOBALS['config']['attachments']['supported'] = $this->old_attachments_supported;
}
/**
* @dataProvider fileTypeCases
*
*/
public function testoEmbed($url, $expectedType)
{
try {
$data = oEmbedHelper::getObject($url);
$this->assertEquals($expectedType, $data->type);
} catch (Exception $e) {
if ($expectedType == 'none') {
$this->assertEquals($expectedType, 'none', 'Should not have data for this URL.');
} else {
throw $e;
}
}
}
static public function fileTypeCases()
{
$files = array(
'http://www.flickr.com/photos/brionv/5172500179/' => 'photo',
'http://twitpic.com/36adw6' => 'photo',
'http://yfrog.com/fy42747177j' => 'photo',
'http://identi.ca/attachment/34437400' => 'photo',
'http://www.youtube.com/watch?v=eUgLR232Cnw' => 'video',
'http://vimeo.com/9283184' => 'video',
'http://en.wikipedia.org/wiki/File:Wiki.png' => 'link', // @fixme in future there may be a native provider -- will change to 'photo'
'http://leuksman.com/log/2010/10/29/statusnet-0-9-6-release/' => 'none',
);
$dataset = array();
foreach ($files as $url => $type) {
$dataset[] = array($url, $type);
}
return $dataset;
}
}