From f17df2e6be37f0d7a25e7e594fb0116785b46e6d Mon Sep 17 00:00:00 2001 From: sarven Date: Thu, 15 Jan 2009 23:59:43 +0000 Subject: [PATCH 1/5] notice_favorite class submit doesn't need a paragraph wrapper --- lib/favorform.php | 6 +++--- lib/htmloutputter.php | 2 -- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/lib/favorform.php b/lib/favorform.php index 4f4fd72a9d..8b01483b2e 100644 --- a/lib/favorform.php +++ b/lib/favorform.php @@ -125,7 +125,7 @@ class FavorForm extends Form function formActions() { $this->out->submit('favor-submit-' . $this->notice->id, - _('Make a favorite')); + _('Favorite')); } /** @@ -136,6 +136,6 @@ class FavorForm extends Form function formClass() { - return 'favor'; + return 'notice_favorite'; } -} \ No newline at end of file +} diff --git a/lib/htmloutputter.php b/lib/htmloutputter.php index 75a995bef1..eb8a612e4f 100644 --- a/lib/htmloutputter.php +++ b/lib/htmloutputter.php @@ -324,13 +324,11 @@ class HTMLOutputter extends XMLOutputter function submit($id, $label, $cls='submit', $name=null) { - $this->elementStart('p'); $this->element('input', array('type' => 'submit', 'id' => $id, 'name' => ($name) ? $name : $id, 'class' => $cls, 'value' => $label)); - $this->elementEnd('p'); } /** From ed8c3794df59cb03c366e0a16188cefbd6719c90 Mon Sep 17 00:00:00 2001 From: sarven Date: Fri, 16 Jan 2009 00:50:46 +0000 Subject: [PATCH 2/5] Created reply icon (vertical flip of undo) --- theme/identica/css/display.css | 2 +- .../identica/images/icons/twotone/green/reply.gif | Bin 0 -> 79 bytes 2 files changed, 1 insertion(+), 1 deletion(-) create mode 100644 theme/identica/images/icons/twotone/green/reply.gif diff --git a/theme/identica/css/display.css b/theme/identica/css/display.css index 4f2ba46526..7e0c6d7b4c 100644 --- a/theme/identica/css/display.css +++ b/theme/identica/css/display.css @@ -180,7 +180,7 @@ color:#333333; border-bottom-color:#ccc; } .notice-options .reply a { -background:transparent url(../images/icons/twotone/green/undo.gif) no-repeat 0 45%; +background:transparent url(../images/icons/twotone/green/reply.gif) no-repeat 0 45%; } .notice-options form.notice_favorite input.submit { background:transparent url(../images/icons/twotone/green/favourite.gif) no-repeat 0 45%; diff --git a/theme/identica/images/icons/twotone/green/reply.gif b/theme/identica/images/icons/twotone/green/reply.gif new file mode 100644 index 0000000000000000000000000000000000000000..6ff01bb355956903f06ddee4c88ec13185d7cf36 GIT binary patch literal 79 zcmZ?wbhEHb6krfwSjfQe|NsB^DFQ$e2o!&^FfuSOG3YP=0Z5*KNg Date: Fri, 16 Jan 2009 01:03:10 +0000 Subject: [PATCH 3/5] Added formLegend() --- lib/favorform.php | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/lib/favorform.php b/lib/favorform.php index 8b01483b2e..977f191838 100644 --- a/lib/favorform.php +++ b/lib/favorform.php @@ -103,6 +103,18 @@ class FavorForm extends Form common_session_token()); } + + /** + * Legend of the Form + * + * @return void + */ + function formLegend() + { + $this->out->element('legend', null, _('Delete this notice')); + } + + /** * Data elements * From 179ad6c13b06559959943ec6685b840f7ea3d18a Mon Sep 17 00:00:00 2001 From: sarven Date: Fri, 16 Jan 2009 01:33:42 +0000 Subject: [PATCH 4/5] showReplyLink --- lib/noticelist.php | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/lib/noticelist.php b/lib/noticelist.php index 6f4d1c04e0..fde93a3b66 100644 --- a/lib/noticelist.php +++ b/lib/noticelist.php @@ -438,16 +438,13 @@ class NoticeListItem extends Widget $reply_url = common_local_url('newnotice', array('replyto' => $this->profile->nickname)); - $reply_js = - 'return doreply("'.$this->profile->nickname.'",'.$this->notice->id.');'; - - $this->out->elementStart('a', - array('href' => $reply_url, - 'onclick' => $reply_js, - 'title' => _('reply'), - 'class' => 'replybutton')); - $this->out->raw(' →'); - $this->out->elementEnd('a'); + $this->out->elementStart('dl', 'reply'); + $this->out->element('dt', null, _('Reply to this notice')); + $this->out->elementStart('dd'); + $this->out->element('a', array('href' => $reply_url, + 'title' => _('reply')), _('Reply')); + $this->out->elementEnd('dd'); + $this->out->elementEnd('dl'); } /** From 5d5dcb6f51c0babc54f43f1baace4cc9830e4939 Mon Sep 17 00:00:00 2001 From: sarven Date: Fri, 16 Jan 2009 01:55:39 +0000 Subject: [PATCH 5/5] Markup update for common_tag_link(), common_at_link(), common_at_hash_link() --- lib/util.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/util.php b/lib/util.php index 8c6cddbd9e..9ca817eab3 100644 --- a/lib/util.php +++ b/lib/util.php @@ -571,7 +571,7 @@ function common_tag_link($tag) { $canonical = common_canonical_tag($tag); $url = common_local_url('tag', array('tag' => $canonical)); - return ''; + return ''; } function common_canonical_tag($tag) @@ -589,7 +589,7 @@ function common_at_link($sender_id, $nickname) $sender = Profile::staticGet($sender_id); $recipient = common_relative_profile($sender, common_canonical_nickname($nickname)); if ($recipient) { - return ''.$nickname.''; + return ''.$nickname.''; } else { return $nickname; } @@ -606,7 +606,7 @@ function common_at_hash_link($sender_id, $tag) $url = common_local_url('subscriptions', array('nickname' => $user->nickname, 'tag' => $tag)); - return ''.$tag.''; + return ''; } else { return $tag; }