Handle the case where confirmation is cancelled

This commit is contained in:
Luke Fitzgerald 2010-07-24 07:54:09 -07:00
parent be0fb03560
commit 9f0eea69ff
2 changed files with 41 additions and 30 deletions

View File

@ -95,11 +95,11 @@ class Phergie_Plugin_Statusnet extends Phergie_Plugin_Abstract {
if ($event->getNick() == 'NickServ') { if ($event->getNick() == 'NickServ') {
$message = $event->getArgument(1); $message = $event->getArgument(1);
if (preg_match($this->unregRegexp, $message, $groups)) { if (preg_match($this->unregRegexp, $message, $groups)) {
$nick = $groups[1]; $screenname = $groups[1];
call_user_func($this->regCallback, array('nick' => $nick, 'registered' => false)); call_user_func($this->regCallback, array('screenname' => $screenname, 'registered' => false));
} elseif (preg_match($this->regRegexp, $message, $groups)) { } elseif (preg_match($this->regRegexp, $message, $groups)) {
$nick = $groups[1]; $screenname = $groups[1];
call_user_func($this->regCallback, array('nick' => $nick, 'registered' => true)); call_user_func($this->regCallback, array('screenname' => $screenname, 'registered' => true));
} }
} }
} }

View File

@ -151,13 +151,16 @@ class IrcManager extends ImManager {
*/ */
public function handle_reg_response($data) { public function handle_reg_response($data) {
// Retrieve data // Retrieve data
$nickdata = $this->regchecks[$data['nick']]; $screenname = $data['screenname'];
$nickdata = $this->regchecks[$screenname];
$usernick = $nickdata['user']->nickname;
if (isset($this->regchecksLookup[$usernick])) {
if ($data['registered']) { if ($data['registered']) {
// Send message // Send message
$this->plugin->send_confirmation_code($nickdata['screenname'], $nickdata['code'], $nickdata['user'], true); $this->plugin->send_confirmation_code($screenname, $nickdata['code'], $nickdata['user'], true);
} else { } else {
$this->plugin->send_message($nickdata['screenname'], _m('Your nickname is not registered so IRC connectivity cannot be enabled')); $this->plugin->send_message($screenname, _m('Your nickname is not registered so IRC connectivity cannot be enabled'));
$confirm = new Confirm_address(); $confirm = new Confirm_address();
@ -177,10 +180,11 @@ class IrcManager extends ImManager {
} }
// Unset lookup value // Unset lookup value
unset($this->regchecksLookup[$nickdata['screenname']]); unset($this->regchecksLookup[$usernick]);
// Unset data // Unset data
unset($this->regchecks[$data['nick']]); unset($this->regchecks[$screename]);
}
} }
/** /**
@ -194,14 +198,20 @@ class IrcManager extends ImManager {
if (!$this->conn) { if (!$this->conn) {
return false; return false;
} }
if ($data['type'] != 'message') { if ($data['type'] != 'message') {
// Nick checking // Nick checking
$screenname = $data['nickdata']['screenname']; $nickdata = $data['nickdata'];
if (isset($this->regchecksLookup[$user->nickname])) { $usernick = $nickdata['user']->nickname;
$screenname = $nickdata['screenname'];
// Cancel any existing checks for this user
if (isset($this->regchecksLookup[$usernick])) {
unset($this->regchecks[$this->regchecksLookup[$usernick]]);
} }
$this->regchecks[$screenname] = $data['nickdata'];
$this->regchecksLookup[$user->nickname] = $screenname; $this->regchecks[$screenname] = $nickdata;
$this->regchecksLookup[$usernick] = $screenname;
} }
try { try {
@ -210,6 +220,7 @@ class IrcManager extends ImManager {
$this->conn->reconnect(); $this->conn->reconnect();
return false; return false;
} }
return true; return true;
} }
} }