XMPP cleanup: fix outgoing XMPP when queuing is disabled; fix notice for first access to undefined member variable

This commit is contained in:
Brion Vibber 2010-03-08 10:32:40 -08:00
parent 5adb494c26
commit a77efb2447
2 changed files with 22 additions and 13 deletions

View File

@ -88,22 +88,30 @@ class Sharing_XMPP extends XMPPHP_XMPP
/** /**
* Build an XMPP proxy connection that'll save outgoing messages * Build an XMPP proxy connection that'll save outgoing messages
* to the 'xmppout' queue to be picked up by xmppdaemon later. * to the 'xmppout' queue to be picked up by xmppdaemon later.
*
* If queueing is disabled, we'll grab a live connection.
*
* @return XMPPHP
*/ */
function jabber_proxy() function jabber_proxy()
{ {
$proxy = new Queued_XMPP(common_config('xmpp', 'host') ? if (common_config('queue', 'enabled')) {
common_config('xmpp', 'host') : $proxy = new Queued_XMPP(common_config('xmpp', 'host') ?
common_config('xmpp', 'server'), common_config('xmpp', 'host') :
common_config('xmpp', 'port'), common_config('xmpp', 'server'),
common_config('xmpp', 'user'), common_config('xmpp', 'port'),
common_config('xmpp', 'password'), common_config('xmpp', 'user'),
common_config('xmpp', 'resource') . 'daemon', common_config('xmpp', 'password'),
common_config('xmpp', 'server'), common_config('xmpp', 'resource') . 'daemon',
common_config('xmpp', 'debug') ? common_config('xmpp', 'server'),
true : false, common_config('xmpp', 'debug') ?
common_config('xmpp', 'debug') ? true : false,
XMPPHP_Log::LEVEL_VERBOSE : null); common_config('xmpp', 'debug') ?
return $proxy; XMPPHP_Log::LEVEL_VERBOSE : null);
return $proxy;
} else {
return jabber_connect();
}
} }
/** /**

View File

@ -36,6 +36,7 @@ class XmppManager extends IoManager
protected $site = null; protected $site = null;
protected $pingid = 0; protected $pingid = 0;
protected $lastping = null; protected $lastping = null;
protected $conn = null;
static protected $singletons = array(); static protected $singletons = array();