[MODULES] Introduce the concept of abstract modules to V3

Introduce placeholder for abstract upload and thumb modules
Temporarily supress some bugs

plugins/Cover/Cover.php

@@ -22,7 +22,7 @@ namespace Plugin\Cover;
 
 use App\Core\DB\DB;
 use App\Core\Event;
-use App\Core\Module;
+use App\Core\Modules\Module;
 use App\Core\Router\RouteLoader;
 use App\Util\Common;
 

plugins/Directory/Directory.php

@@ -22,7 +22,7 @@
 namespace Plugin\Directory;
 
 use App\Core\Event;
-use App\Core\Module;
+use App\Core\Modules\Module;
 use App\Core\Router\RouteLoader;
 
 class Directory extends Module

plugins/EmailNotifications/EmailNotifications.php

@@ -33,7 +33,7 @@
 namespace Plugin\EmailNotifications;
 
 use App\Core\Event;
-use App\Core\Module;
+use App\Core\Modules\Module;
 
 class EmailNotifications extends Module
 {

plugins/Embed/Embed.php

@@ -32,7 +32,7 @@
 
 namespace Plugin\Embed;
 
-use App\Core\Module;
+use App\Core\Modules\Module;
 
 /**
  * Base class for the Embed plugin that does most of the heavy lifting to get

plugins/Favourite/Favourite.php

@@ -22,10 +22,10 @@ namespace Plugin\Favourite;
 use App\Core\DB\DB;
 use App\Core\Event;
 use App\Core\Form;
-use App\Core\Module;
-use App\Entity\Favourite as Fave;
+use App\Core\Modules\Module;
 use App\Entity\Note;
 use App\Util\Common;
+use Plugin\Favourite\Entity\Favourite as Fave;
 use Symfony\Component\Form\Extension\Core\Type\HiddenType;
 use Symfony\Component\Form\Extension\Core\Type\SubmitType;
 use Symfony\Component\HttpFoundation\Request;

plugins/Media/Media.php

@@ -20,7 +20,7 @@
 namespace Plugin\Media;
 
 use App\Core\Event;
-use App\Core\Module;
+use App\Core\Modules\Module;
 use App\Core\Router\RouteLoader;
 
 class Media extends Module

plugins/Poll/Poll.php

@@ -24,7 +24,7 @@ use App\Core\DB\DB;
 use App\Core\Event;
 use App\Core\Form;
 use function App\Core\I18n\_m;
-use App\Core\Module;
+use App\Core\Modules\Module;
 use App\Core\Router\RouteLoader;
 use App\Entity\Note;
 use App\Entity\PollResponse;

plugins/ProfileColor/ProfileColor.php

@@ -22,7 +22,7 @@ namespace Plugin\ProfileColor;
 
 use App\Core\DB\DB;
 use App\Core\Event;
-use App\Core\Module;
+use App\Core\Modules\Module;
 use App\Core\Router\RouteLoader;
 use App\Util\Common;
 

plugins/Repeat/Repeat.php

@@ -22,7 +22,7 @@ namespace Plugin\Repeat;
 use App\Core\DB\DB;
 use App\Core\Event;
 use App\Core\Form;
-use App\Core\Module;
+use App\Core\Modules\Module;
 use App\Entity\Note;
 use App\Util\Common;
 use App\Util\Exception\NotFoundException;

plugins/Reply/Reply.php

@@ -25,7 +25,7 @@ use App\Core\DB\DB;
 use App\Core\Event;
 use App\Core\Form;
 use function App\Core\I18n\_m;
-use App\Core\Module;
+use App\Core\Modules\Module;
 use App\Entity\Note;
 use App\Util\Common;
 use App\Util\Exceptiion\InvalidFormException;

plugins/StoreRemoteMedia/StoreRemoteMedia.php

@@ -16,7 +16,7 @@
 
 namespace Plugin\StoreRemoteMedia;
 
-use App\Core\Module;
+use App\Core\Modules\Module;
 
 /**
  * The StoreRemoteMedia plugin downloads remotely attached files to local server.

plugins/TreeNotes/TreeNotes.php

@@ -19,10 +19,8 @@
 
 namespace Plugin\TreeNotes;
 
+use App\Core\Modules\Module;
 use App\Entity\Note;
-use App\Core\Event;
-use App\Core\Module;
-use Functional as F;
 
 class TreeNotes extends Module
 {
@@ -31,7 +29,7 @@ class TreeNotes extends Module
      */
     public function onFormatNoteList(array &$notes_in_trees_out)
     {
-        $roots = array_filter($notes_in_trees_out, function(Note $note) { return $note->getReplyTo() == null; }, ARRAY_FILTER_USE_BOTH);
+        $roots              = array_filter($notes_in_trees_out, function (Note $note) { return $note->getReplyTo() == null; }, ARRAY_FILTER_USE_BOTH);
         $notes_in_trees_out = $this->build_tree($roots, $notes_in_trees_out);
     }
 
@@ -46,7 +44,7 @@ class TreeNotes extends Module
 
     private function build_subtree(Note $parent, array $notes)
     {
-        $children = array_filter($notes, function(Note $n) use ($parent) { return $parent->getId() == $n->getReplyTo(); }, ARRAY_FILTER_USE_BOTH);
+        $children = array_filter($notes, function (Note $n) use ($parent) { return $parent->getId() == $n->getReplyTo(); }, ARRAY_FILTER_USE_BOTH);
         return ['note' => $parent, 'replies' => $this->build_tree($children, $notes)];
     }
 }

plugins/VideoThumbnail/FFmpeg.php

@@ -28,7 +28,7 @@
 
 namespace Plugin\FFmpeg;
 
-use App\Core\Module;
+use App\Core\Modules\Module;
 use Plugin\Media\Util\ImageFile;
 
 class FFmpeg extends Module

plugins/VideoThumbnail/locale/FFmpeg.pot

@@ -0,0 +1,23 @@
+# SOME DESCRIPTIVE TITLE.
+# Copyright (C) YEAR THE PACKAGE'S COPYRIGHT HOLDER
+# This file is distributed under the same license as the PACKAGE package.
+# FIRST AUTHOR <EMAIL@ADDRESS>, YEAR.
+#
+#, fuzzy
+msgid ""
+msgstr ""
+"Project-Id-Version: PACKAGE VERSION\n"
+"Report-Msgid-Bugs-To: \n"
+"POT-Creation-Date: 2020-08-13 03:09+0100\n"
+"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
+"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
+"Language-Team: LANGUAGE <LL@li.org>\n"
+"Language: \n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=CHARSET\n"
+"Content-Transfer-Encoding: 8bit\n"
+
+#. TRANS: Plugin description.
+#: FFmpegPlugin.php:104
+msgid "Use PHP-FFMpeg for resizing animated GIFs"
+msgstr ""

plugins/XMPPNotifications/XMPPNotifications.php

@@ -33,7 +33,7 @@
 namespace Plugin\XMPPNotifications;
 
 use App\Core\Event;
-use App\Core\Module;
+use App\Core\Modules\Module;
 
 class XMPPNotifications extends Module
 {