[AttachmentToNote][Attachment] Add title getter to Attachment

plugins/ImageEncoder/ImageEncoder.php

@@ -126,7 +126,11 @@ class ImageEncoder extends Plugin
      */
     public function onViewAttachmentImage(array $vars, array &$res): bool
     {
-        $res[] = Formatting::twigRenderFile('imageEncoder/imageEncoderView.html.twig', ['attachment' => $vars['attachment'], 'thumbnail_parameters' => $vars['thumbnail_parameters']]);
+        $res[] = Formatting::twigRenderFile('imageEncoder/imageEncoderView.html.twig',
+            ['attachment'              => $vars['attachment'],
+                'thumbnail_parameters' => $vars['thumbnail_parameters'],
+                'note'                 => $vars['note'],
+            ]);
         return Event::stop;
     }
 

plugins/ImageEncoder/templates/imageEncoder/imageEncoderView.html.twig

@@ -2,6 +2,6 @@
     <img class="u-photo" src="{{ path('attachment_thumbnail', thumbnail_parameters) }}"
          alt="{{ attachment.getFilename() }}">
     <figcaption><a
-                href="{{ path('attachment_show', {'id': attachment.getId()}) }}">{{ attachment.getFilename() }}</a>
+                href="{{ path('attachment_show', {'id': attachment.getId()}) }}">{{ attachment.getBestTitle(note) }}</a>
     </figcaption>
 </figure>