From 85d61475aab64a08ba67cdedfcb795af4ce4850d Mon Sep 17 00:00:00 2001
From: Meitar Moscovitz <meitarm@gmail.com>
Date: Mon, 16 Mar 2009 17:42:24 -0400
Subject: [PATCH 01/38] Output code to explicitly reference favicons.

This makes favicons work when Laconica is not installed at a web
server's DOCUMENT_ROOT. I've also added the capability to override the
Laconica default favicon.ico file with a theme-specific one simply by
dropping a themed favicon.ico in the appropriate theme directory.
---
 lib/action.php | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/lib/action.php b/lib/action.php
index 975c2bfcb8..285eae59ab 100644
--- a/lib/action.php
+++ b/lib/action.php
@@ -112,6 +112,7 @@ class Action extends HTMLOutputter // lawsuit
         // XXX: attributes (profile?)
         $this->elementStart('head');
         $this->showTitle();
+        $this->showShortcutIcon();
         $this->showStylesheets();
         $this->showScripts();
         $this->showOpenSearch();
@@ -147,6 +148,22 @@ class Action extends HTMLOutputter // lawsuit
         return _("Untitled page");
     }
 
+    /**
+     * Show themed shortcut icon
+     *
+     * @return nothing
+     */
+    function showShortcutIcon()
+    {
+        if (is_readable(INSTALLDIR . '/theme/' . common_config('site', 'theme') . '/favicon.ico')) {
+            $this->element('link', array('rel' => 'shortcut icon',
+                                         'href' => theme_path('favicon.ico')));
+        } else {
+            $this->element('link', array('rel' => 'shortcut icon',
+                                         'href' => common_path('favicon.ico')));
+        }
+    }
+
     /**
      * Show stylesheets
      *

From 91b0fb8028b30438401bebafd13119fe360337a3 Mon Sep 17 00:00:00 2001
From: Meitar Moscovitz <meitarm@gmail.com>
Date: Mon, 16 Mar 2009 18:03:58 -0400
Subject: [PATCH 02/38] Add `apple-touch-icon.png` support; favicons for the
 iPhone OS.

---
 apple-touch-icon.png | Bin 0 -> 6265 bytes
 lib/action.php       |  10 ++++++++++
 2 files changed, 10 insertions(+)
 create mode 100644 apple-touch-icon.png

diff --git a/apple-touch-icon.png b/apple-touch-icon.png
new file mode 100644
index 0000000000000000000000000000000000000000..d129298d4adb1dff16a6e37b1c2577f7f0a96316
GIT binary patch
literal 6265
zcmV-<7>4JGP)<h;3K|Lk000e1NJLTq002Ay002A)1^@s6I{evk00009a7bBm000XU
z000XU0RWnu7ytkYPiaF#P*7-ZbZ>KLZ*U+<Lqi~Na&Km7Y-Iodc-oy)XH-+^7Crag
z^g>IBfRsybQWXdwQbLP>6p<z>Aqfylh#{fb6;Z(vMMVS~$e@S=j*ftg6;Uh<iVD~V
z<RPMtgQJLw%KPDaqifc@_vX$1wbwr9tn;0-&j-K=43<bUQ8j=JsX`tR;Dg7+#^K~H
zK!FM*Z~zbpvt%K2{UZSY_<lS*D<Z%Lz5oGu(+dayz)hRLFdT>f59&ghTmgWD0l;*T
zI7<kC6aYYajzXpYKt=(8otP$50H6c_V9R4-;{Z@C0AMG7=F<Rxo%or10RUT+Ar%3j
zkpLhQWr#!oXgdI`&sK^>09Y^p6lP1rIRMx#05C~cW=H_Aw*bJ-5DT&Z2n+x)QHX^p
z00esgV8|mQcmRZ%02D^@S3L16t`O%c004NIvOKvYIYoh62rY33S640`D9%Y2D-<?i
z0%4j!F2Z@488U%158(66005wo6%pWr^Zj_v4zAA5HjcIqUoGmt2LB>rV&neh&#Q1i
z007~1e$oCcFS8neI|hJl{-P!B1ZZ9hpmq0)X0i`JwE&>$+E?>%_<lS*MWK+n+1cgf
z<k(8YLR(?VSAG6x!e78w{cQPuJpA|d;J)G{fihizM+Erb!p!tcr5w+a34~(Y=8s4G
zw+sLL9n&JjNn*KJDiq^U5^;`1nvC-@r6P$!k}1U{(*I=Q-z@tBKHoI}uxdU5dyy@u
zU1J0GOD7Ombim^G008p4Z^6_k2m^p<gW=D2|L;HjN1!DDfM!XOaR2~bL?kX$%CkSm
z2mk;?pn)o|K^yeJ7%adB9Ki+L!3+FgHiSYX#KJ-lLJDMn9CBbOtb#%)hRv`YDqt_v
zKpix|QD}yfa1JiQRk#j4a1Z)n2%f<xynzV>LC6RbVIkUx0b+_+BaR3cnT7Zv!AJxW
zizFb)h!jyGOOZ85F;a?DAXP{m@;!0_Ifq<Ex{*7`05XF7hP+2Hl!3BQJ=6@fL%FCo
z8iYoo3(#bAF`ADSpqtQgv>H8(HlgRxt7s3}k3K`kFu>>-2Q$QMFfPW!La{h336o>X
zu_CMttHv6zR;&ZNiS=X8v3CR#fknUxHUxJ<AYmRsNLWl*PS{AOARHt#5!wki2?K;t
z!Y3k=s7tgax)J%r7-BLphge7~Bi0g+6E6^Zh(p9TBoc{3GAFr^0!gu?RMHaCM$&Fl
zBk3%un>0uoBa_M6WNWeqIg~6QE69c9o#eyhGvpiOA@W-aonk<7r1(?fC{oI5N*U!4
z<uv66WtcKSRim0x-Ke2d5jBrmLam{;Qm;{ms1r1GnmNsb7D-E`t)i9F8fX`2_i3-_
zbh;7Ul^#x)&{xvS=|||7=mYe33=M`AgU5(xC>fg=2N-7=cNnjjOr{yriy6mMFgG#l
znCF=fnQv8CDz++o6_Lscl}eQ+l^ZHARH>?_s@|##Rr6KLRFA1%Q+=*RRWnoLsR`7U
zt5vF<Q0r40Q)j6=sE4X&sBct1q<&fbi3VB2Ov6t@q*0);U*o*SAPZv|vv@2aYYnT0
zb%8a+Cb7-ge0D0knEf5Qi#@8Tp*ce{N;6lpQuCB%KL_KOarm5cP6_8Ir<e17iry6O
zDdH&`rZh~sF=bq9s+O0QSgS~@QL9Jmy*94xr=6y~MY~!1fet~(N+(<=M`w@D1)b+p
z*;C!83a1uLJv#NSE~;y#8=<>IcfW3@?wFpwUVxrVZ>QdQz32KIeJ}k~{cZZE^+ya?
z2D1z#2HOnI7(B%_ac?{wFUQ;QQA1tBKtrWrm0_3Rgps+?Jfqb{jYbcQX~taRB;#$y
zZN{S}1|}gUOHJxc?wV3fxuz+mJ4`!F$IZ;mqRrNsHJd##*D~ju=bP7?-?v~|cv>vB
zsJ6IeNwVZxrdjT`yl#bBIa#GxRa#xMMy;K#CDyyGyQdMSxlWT#tDe?p!?5wT$+oGt
z8L;Kp2HUQ-ZMJ=3XJQv;x5ci*?vuTfeY$;({XGW_huIFR9a<fJbF^|4I#xQ~n$Dc=
zKYhjYmgz5NSkDm8*fZm{6U!;YX`NG>(?@3)XSs8O^N5RyOM=TTmp(3=8^+zpz2r)C
z^>JO{deZfso3oq3?Wo(Y?l$ge?uXo;%ru`Vo>?<<(8I_>;8Eq#KMS9gFl*neeosSB
zfoHYnBQIkwkyowPu(zdms`p{<7e4kra-ZWq<2*OsGTvEV%s0Td$hXT+!*8Bnh2KMe
zBmZRodjHV?r+_5^X9J0WL4jKW`}lf%A-|44I@@LTvf1rHjG(ze6+w@Jt%Bvjts!X0
z?2xS?_ve_-k<Mujg;0Lz*3buG=3$G&ehepthlN*$KaOySSQ^nWmo<0M+(UEUMEXRQ
zMBbZcF;6+KElM>iKB_KiJlZ$9G`c^=E@oNG)mWWaNo-3TIW8)$Hg0Ub-~8?KhvJ>$
z3*&nim@mj(aCxE5!t{lw7O5^0EIO7zOo&c6l<+|iDySBWCGrz@C5{St!X3hAA}`T4
z(TLbXTq+(;@<=L8dXnssyft|w#WSTW<++3>sgS%(4NTpeI-VAqb|7ssJvzNHgOZVu
zaYCvgO_R1~>SyL=cFU|~g|hy|Zi}}s9+d~lYqOB71z9Z$wnC=pR9Yz4DhIM>Wmjgu
z&56o6maCpC&F##y%G;1PobR9i?GnNg;gYtchD%p19a!eQtZF&3JaKv33gZ<8D~47E
ztUS1iwkmDaPpj=$m#%)jCVEY4fnLGNg2A-`YwHVD3gv};>)hAvT~AmqS>Lr``i7kw
zJ{5_It`yrBmlc25DBO7E8;5VoznR>Ww5hAaxn$2~(q`%A-YuS64wkBy=9dm`4cXeX
z4c}I@?e+FW+b@^RDBHV(wnMq2zdX3SWv9u`%{xC-q*U}&`cyXV(%rRT*Z6MH?i+i&
z_B8C(+grT%{XWUQ+f@NoP1R=AW&26{v-dx)iK^-Nmiuj8txj!m?Z*Ss1N{dh4z}01
z)YTo*JycSU)+_5r4#yw9{+;i4Ee$peRgIj+;v;ZGdF1K$3E%e~4LaI(jC-u%2h$&R
z9cLXcYC@Xwnns&bn)_Q~Te?roKGD|d-g^8;+aC{{G(1^(O7m37Y1-+6)01cN&y1aw
zoqc{T`P^XJqPBbIW6s}d4{z_f5Om?vMgNQEJG?v2T=KYd^0M3I6IZxbny)%vZR&LD
zJpPl@Psh8QyPB@KTx+@RdcC!KX7}kEo;S|j^u2lU7XQ}Oo;f|;z4Ll+_r>@1-xl3|
zawq-H%e&ckC+@AhPrP6BK<z=<L*0kfKU@CX*zeqbYQT4(^U>T#_XdT7&;F71j}Joy
zkC~6lh7E@6o;W@^IpRNZ{ptLtL(gQ-CY~4mqW;US7Zxvm_|@yz&e53Bp_lTPlfP|z
zrTyx_>lv@x#=^!PzR7qqF<$gm`|ZJZ+;<)Cqu&ot<a{81DF0~rvGr5Xr~8u`lav1h
z1DNytV>2z=0000WV@Og>004R=004l4008;_004mL004C`008P>0026e000+nl3&F}
z000f7Nkl<Zc-qvOX^dP|c7VTg-+NWnRc*KJc5hxWV6d?#W;0+I4IT%a83;l_OhyPz
zlpxIzDS~7I!dTJFpkbnjWddOaNQjUkV8SvYfiVU$4qE^(7%v!`rEP3?8|+@(?!CI|
zE%)R{Rky3VUVCZVJ?2VBwcU5${oXnE+;h$?QC0rqrEe40R3P#!qF_Z4HMl^ef+j+;
z9^AO_6V`rm7MWCj=HyK8+)X>@EJ-H93lz>0s0T8|;krRv5oyc^iI1*W*toW-wPE+}
z#@?@@z7DDvEMjV^orQCnS+(v0s;heW*4+KHx7Tptg_}89%{`%u-H6@$Ypx0+=i27h
zDc3YJ<(y<91VGBWPXL*La#7OtZ(6_OOk7t!O=g1Cku&9Wwe}6hp^Xh#6ba4ciJacC
ztz-If*NrM2#~$B}9Sh3*WaY&9R94*@=E7H{f`^UK^`{cpjNzILaGzRUCGXsj@WM(X
zI_3$ewWy6Ih}!SBcV}LEZ`<6TC%vHJbOAm$QhiC$yAZ14>~^e81VU>j_2*JQF~W-?
z_UwcgqJKc(D-?Z6g{zLLHMK<6Cya6g;Q&E6Kp5qStdHvGrZ0dIMO44*2k!57?4GgM
zGx`Tv!&ivP^T71cI#^qDR$@q}s;Q}(M^$D9o>z$xLq6!GH+z7C-8<>c?jHg-#wmAk
z0zu%-|7hQ&-!5I$coVR0Jb~u|PmBhuY6)$QOtO|4wTn4-#<kQ;nvd%wF~%!<D51^M
z*}Ip<eXD71TT5^D07hJlam%z_S=m2(>)!gucQn`hnHYBuCt(e_MW;L3KAcwN5#YQy
z1GLsh#4vZpcR2sdo0&Rk-jUajaY-1Ly2%Tuo4kPT{(XGB=LH(~t;P?sxK0X6R;>VG
z=qw7<c}R@+J%QjvE!+hNJUhyolG{Z1PMqh6qCBa@Brcx!Ll&HI!<cSfm6^#m7v912
zsTZ?u$G^~<J%D2pWzI~5>xJlc-|)*mPsX&h3<I_%7I>b)tc-{CsYq3`^!$HdR_&4#
zHnTbPS28g@oi{f9ltX=ca7REFtkA9qgjc!}=5t3+&`Yaz4~x2BU5uI)C{=N5HsNJh
zy6Enc0z25MC!Wo+3-6&aRYw^4aj{yBL4KTxl!_A&7r?V6gDY6WB82PWCKlO%#q(}u
zR^2yGdQdR6>Kv9VxQ(~A-ix&%Mx4VAPoN^y>(ddBf_!{J8ulVHB#F@ADmMbvBRdCS
zmYFq|@QpM7{FH@$a~hU%_Oz>sqWmxiR&=8Ek;pZX2xAok;5!k%6A?HO`9wG+bfTr@
zrX1n9Y0f+2hBC);QX?U8SUBf<WGd>gHY#7smTSc7M6t?P!~j&~>Zr=qF=?Qlv_I)A
z75hi!rtDKY`8;OSUV6$inyFRi&@lCUG(NDr%rP><HNsfL0A!OrWRpGgCws_y1M@{?
z;&APP5s!xI3-O!^#-q)hwtUzcE^*fhRlCTlWh~+X3?zC>_ul!&j`WZg&#h$o)QcFe
zRzGDCo?Af><&Y5`J3`L~o*nZ(>>LL4fH`IB7sYiFOsPC`+<+5an#q-C(Au>F5jQT}
z9X$!D^hS+B3!$Y*>E|lda%9&@l1fe*H(<e`GTlH+=k~J68<D!=4r34J)gT!MjF4Zw
zA7h7ysKbCuGByLG%bt#c=cXCYCSpjqnb>qvm5NdhaRf8P!~flW!i^ma{BJ8>39M75
z;o<voDn4@4aRpXYtVX5QH*zY9f@EBRFM8>|?Nd@sS!`gD5+;e&@Zo4Y1Uk#u1oA;2
zRxL)%I3Zi|eph@sQ0PS!nc!h}_tAgXR)Vg86h}`W3$e7yp!lkCAnp#4_36!iHEtTV
z8qwL;jKn-(g;pkbHrm_Iz{+jduHcw6C{u6(c2FXNHkacXf-p;4*N$-m?i*;OZ=j{H
z7Z++j;0U;a$vE4zsh@!rTd{4q<Bz2WB*TDY$Vw%7Nq!_FY+6JJ!Yp64ZyGn?=GL`X
z4Um)ro&i5Xy92btC)(N9p8ea+4ceBUDv&-N590!uq9;@YgYH6UL#Q2544~!EHoE$o
zn3S1)YR%aO?CyLA>nQqJ57G8+qU~MSJz2Cpuj)tt3j9i-4fxc+yDq!~tOxQ(1@`Pf
z>36%V$R>gB4p*}wvOa#$f6BGHr~7?cH*6$WwU21sA#8V0>Wl{8dRnNnO?Tib7p%f6
z;7JOvqnorvN+k>WTHI5gkZxe=#JQ&wwm)d&!w2rC_a|EjUT;N*!;Zd<6<DqZo^{~Y
zP+q(!aazL#<iCNvrNbHHQCl^?tP*)LTNL@c^W!^c`lr`$4n<?FQDy}G26!H5h~Jhl
z!^KFq3InA<faj)}Hud6D7ieI4`|iJI$D_}XI4R@tC%`knq;d^cWe>~bEXE7JC01sa
zPA26|q@nu!QwIG0LqB8FgOB2k4uA!sVssQ1-|LZ~mnl3_UbU<!sVo>peCIOJl9*bd
zcFH&K+>@UR57;i&zw%2q|NIxRrvihZiByXEOD<vNl~+<xSBKx%N86@N?0fS~`a3!b
zTXp>PKL}ur!qY>*ZcAlpp9)1U)RKy~)reU&N3L}AX7^*&Qk9u;%z?$19Ut(~p8urv
z-`+sF$|pPsJA2tOuDJJJ8kQ_66sk+_+tkFy`|ji8C!ZwreVlmczXM(ddR%~LSVkgq
zMOa*#3n#n`^-~s=4b<J&Ol#M6S`Te!f5#TA4VY1TDRq+<Qk9-gWx4^+NrMPslqH)#
zM0ejlI=UNaZd=E}+)mh?N7r`8C1_Y+!Ob_b?D5A*OqdY+;3mwT&9cWHqk7&v-dVYl
zFq<uVZ~}`ATxZ}n?oirs_{RkxHHSTC!1U^isZ7@wHF<#M*7x}8;AXn|_R`hYL=X)W
zk4c1WUp$NFRFF<pQ<0p4W0HszJa9hfr9anB-tWP6Q@E)V;inzgF24*o0%l!)`4M4D
z+oIcVr+e>SK6vP%vJ44u6t0fog<=7~J)B#kONY4vjhK+G=ktB5*uDR4I(l~E2Ym!#
z77+)>cqF~UB{0W$s9O4S2k9GVMT^x05kbUY#37lOSeQ{RBHS9UUC(v7?4Em$33jk8
zzWZ)=z5FtVcJD6p2MU*4s4djAOuDFDotU!y%ZKHUZUvw1dj)NZh7NlKIbuOT#Ndc2
zR*XjN1ir=Y>5Fw#Q_ek?Syx|uTn@0Jww75}T}9^;PsHSV%;|?}1CX@&qWJR!&M5CJ
z7*jaXG~&djY-8FhBa3a%#R4}h8QU?=v?WVMb6l<m)derD{^0l5svJGOk;D6+U-T_0
z5p%@T{ZVp!$j4t(QByM};B;LbA~Lj;hK&gs0}weLk>jBvSC3wD5rWV`L=Ogr4@Kk`
zei&Vn5A0d0_O2k8{Q!}+V-JLA#kHHnkua`<-`zbX;CyFiENn5#3Jd9B!B3wJoEtwo
z*`G`Vn`TY!+0fit{rk?eY@C|cp|u$Kxd%G;G(J$f@S+Pe3@-)dDb!0LfG?hMOJ1Q<
z&=%lRV_6@~40o#PXTa={7SytF<CuV3Hf+EWzo#dl-37?yg0$z#a@UbbB@gEyD!*6s
zO+~h3Qn@V`%x%(LU)Ca&o1qv3u%#e^Dqw8FC@G6kRPqYGh=PEm9sGyCa#22s18(2C
zm6i<~sK4~sk9Gz+I%rz6CKgzr#fMG<5Jt9MRj&Yg1fEkzZ$!8V_$w{smzz~Z{lG<z
zFNN`e9-z1QzCe>O^#7`n+;ay)tGpNIBm5v>{XO>_*UdhD>@nIu`z+RJ0UIM|F#wfG
zH*_86vB>kz25tgg1e%8?c@mqcN|1fKjn@DAk{%!nZ%E929N>%BU+2BM?n0yJsN*(1
z|2!KXd=OM)(@KH2^o%pJgPLy!-Ur%GX?AY}+nPh)Y9n3nnj~O5@M@fv4Y2Wn2Uv5<
zEgamoE#A=w0UzFfKWlEim0V9xtab&O>;;Qo%02RAV!VpXLnj2bWdL1!a0oaF{kHJ8
zsJ=L8fUQqG#Y@*+$Lbqzq;1piLgJTiy~VpLR*>uN9?g^ip7NJ{dyhY}M#dFbg9!g0
zKfx(#Z%|x#UErzF_WT6U)!fXs7hhz}kA6h|fdj)#IUI4EGUECVUAUio7RAqxD=-S$
z8S55QU?uRzk*bXq!2Zpfd2huE0J1GD99Vb6Kk2nt_~DTC=n4K`dQ8n3)y?++e*ydk
zSUOrK57_?n)68DJ95<8U;I3VxL3{z+0&Fd-c$`LUKX3!^a1nmg(DwiCypzndX+%K~
z2eAS8>yfYk<}?FFp)(18>A(*Zc1TRw$^d<>t+a00G7>fvxIYDdtTC{sC2&b3_>6^1
zBe>PV3&5_C6OW0e-WB+%f&RfFz~J^K6&2vRr!DXxK)(<F9>Dj3KLuVpl9}gWbuZ*Q
z3jq!N#n*1YfB9wP^UqIjU`n*4@VSLM6?Tu(wLOA&0w4zjC6WhhV<WV-p8mi?RnCH@
zJ_%r@6iQwr*TCi!Y^ee!jv{9A<gX8KiN;?L_~(%|KY{;|!YiXm^10`}e!#`{Gle%x
zK6fen_Gn%(xoXwv53GfFn_3DdV-pLX2U2jmLQApR`@omSGM4$8m@%dpFP9vt>`=H9
jh%7v7izTw7$^Q=kOJylMKqsXt00000NkvXXu0mjfFfZqQ

literal 0
HcmV?d00001

diff --git a/lib/action.php b/lib/action.php
index 285eae59ab..f0baa062c2 100644
--- a/lib/action.php
+++ b/lib/action.php
@@ -162,6 +162,16 @@ class Action extends HTMLOutputter // lawsuit
             $this->element('link', array('rel' => 'shortcut icon',
                                          'href' => common_path('favicon.ico')));
         }
+
+        if (common_config('site', 'mobile')) {
+            if (is_readable(INSTALLDIR . '/theme/' . common_config('site', 'theme') . '/apple-touch-icon.png')) {
+                $this->element('link', array('rel' => 'apple-touch-icon',
+                                             'href' => theme_path('apple-touch-icon.png')));
+            } else {
+                $this->element('link', array('rel' => 'apple-touch-icon',
+                                             'href' => common_path('apple-touch-icon.png')));
+            }
+        }
     }
 
     /**

From f1041a3b4e1f728ddffd8df80a5d5d6f5520fea6 Mon Sep 17 00:00:00 2001
From: Evan Prodromou <evan@controlyourself.ca>
Date: Wed, 18 Mar 2009 16:34:41 -0400
Subject: [PATCH 03/38] fix bug in profile list owner check

---
 lib/profilelist.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/profilelist.php b/lib/profilelist.php
index 766189ab4c..bd9b51958c 100644
--- a/lib/profilelist.php
+++ b/lib/profilelist.php
@@ -89,7 +89,7 @@ class ProfileList extends Widget
                                              'id' => 'profile-' . $this->profile->id));
 
         $user = common_current_user();
-        $is_own = !is_null($user) && isset($this->user) && ($user->id === $this->user->id);
+        $is_own = !is_null($user) && isset($this->owner) && ($user->id === $this->owner->id);
 
         $this->out->elementStart('div', 'entity_profile vcard');
 

From 0e93b638b5fe5a3f087c25a48dcb1bac032e400d Mon Sep 17 00:00:00 2001
From: Evan Prodromou <evan@controlyourself.ca>
Date: Wed, 18 Mar 2009 16:34:41 -0400
Subject: [PATCH 04/38] fix bug in profile list owner check

---
 lib/profilelist.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/profilelist.php b/lib/profilelist.php
index 766189ab4c..bd9b51958c 100644
--- a/lib/profilelist.php
+++ b/lib/profilelist.php
@@ -89,7 +89,7 @@ class ProfileList extends Widget
                                              'id' => 'profile-' . $this->profile->id));
 
         $user = common_current_user();
-        $is_own = !is_null($user) && isset($this->user) && ($user->id === $this->user->id);
+        $is_own = !is_null($user) && isset($this->owner) && ($user->id === $this->owner->id);
 
         $this->out->elementStart('div', 'entity_profile vcard');
 

From e7c57b43073888d18760e2411b207a4ee2cf508b Mon Sep 17 00:00:00 2001
From: Evan Prodromou <evan@controlyourself.ca>
Date: Thu, 19 Mar 2009 09:21:50 -0400
Subject: [PATCH 05/38] ping handler returns proper boolean response

The ping queue handler wasn't returning a true value -- filling up the
queue with ping requests. It now returns a true value.
---
 lib/ping.php                 | 77 ++++++++++++++++++++++++++----------
 scripts/pingqueuehandler.php |  4 +-
 2 files changed, 58 insertions(+), 23 deletions(-)

diff --git a/lib/ping.php b/lib/ping.php
index 32c0b9806a..2cbec2f212 100644
--- a/lib/ping.php
+++ b/lib/ping.php
@@ -1,7 +1,7 @@
 <?php
 /*
  * Laconica - a distributed open-source microblogging tool
- * Copyright (C) 2008, Controlez-Vous, Inc.
+ * Copyright (C) 2009, Control Yourself, Inc.
  *
  * This program is free software: you can redistribute it and/or modify
  * it under the terms of the GNU Affero General Public License as published by
@@ -20,49 +20,84 @@
 if (!defined('LACONICA')) { exit(1); }
 
 function ping_broadcast_notice($notice) {
+
 	if (!$notice->is_local) {
-		return;
+		return true;
 	}
-	
+
 	# Array of servers, URL => type
 	$notify = common_config('ping', 'notify');
 	$profile = $notice->getProfile();
 	$tags = ping_notice_tags($notice);
-	
+
 	foreach ($notify as $notify_url => $type) {
 		switch ($type) {
 		 case 'xmlrpc':
 		 case 'extended':
 			$req = xmlrpc_encode_request('weblogUpdates.ping',
 										 array($profile->nickname, # site name
-											   common_local_url('showstream', 
+											   common_local_url('showstream',
 																array('nickname' => $profile->nickname)),
 											   common_local_url('shownotice',
 																array('notice' => $notice->id)),
-											   common_local_url('userrss', 
+											   common_local_url('userrss',
 																array('nickname' => $profile->nickname)),
 											   $tags));
-			
-			# We re-use this tool's fetcher, since it's pretty good
-	
-			$fetcher = Auth_Yadis_Yadis::getHTTPFetcher();
 
-			if (!$fetcher) {
-				common_log(LOG_WARNING, 'Failed to initialize Yadis fetcher.', __FILE__);
-				return false;
-			}
-	
-			$result = $fetcher->post($notify_url,
-									 $req);
-											   
+            $context = stream_context_create(array('http' => array('method' => "POST",
+                                                                   'header' =>
+                                                                   "Content-Type: text/xml\r\n".
+                                                                   "User-Agent: Laconica/".LACONICA_VERSION."\r\n",
+                                                                   'content' => $request)));
+            $file = file_get_contents($notify_url, false, $context);
+            $response = xmlrpc_decode($file);
+            if (xmlrpc_is_fault($response)) {
+                common_log(LOG_WARNING,
+                           "XML-RPC error for ping ($notify_url, $notice->id) ".
+                           "$response[faultString] ($response[faultCode])");
+            } else {
+                common_log(LOG_INFO,
+                           "Ping success for $notify_url $notice->id");
+            }
+            break;
+
 		 case 'get':
-		 case 'post':			
+		 case 'post':
+            $args = array('name' => $profile->nickname,
+                          'url' => common_local_url('showstream',
+                                                    array('nickname' => $profile->nickname)),
+                          'changesURL' => common_local_url('userrss',
+                                                           array('nickname' => $profile->nickname)));
+
+            $fetcher = Auth_Yadis_Yadis::getHTTPFetcher();
+
+            if ($type === 'get') {
+                $result = $fetcher->get($notify_url . '?' . http_build_query($args),
+                                        array('User-Agent: Laconica/'.LACONICA_VERSION));
+            } else {
+                $result = $fetcher->post($notify_url,
+                                         http_build_query($args),
+                                         array('User-Agent: Laconica/'.LACONICA_VERSION));
+            }
+            if ($result->status != '200') {
+                common_log(LOG_WARNING,
+                           "Ping error for '$notify_url' ($notice->id): ".
+                           "$result->body");
+            } else {
+                common_log(LOG_INFO,
+                           "Ping success for '$notify_url' ($notice->id): ".
+                           "'$result->body'");
+            }
+            break;
+
 		 default:
 			common_log(LOG_WARNING, 'Unknown notify type for ' . $notify_url . ': ' . $type);
-										   }
+        }
 	}
+
+    return true;
 }
-		
+
 function ping_notice_tags($notice) {
 	$tag = new Notice_tag();
 	$tag->notice_id = $notice->id;
diff --git a/scripts/pingqueuehandler.php b/scripts/pingqueuehandler.php
index 55a266e4a4..ada6ecdba2 100644
--- a/scripts/pingqueuehandler.php
+++ b/scripts/pingqueuehandler.php
@@ -34,7 +34,7 @@ require_once(INSTALLDIR . '/lib/queuehandler.php');
 set_error_handler('common_error_handler');
 
 class PingQueueHandler extends QueueHandler {
-	
+
 	function transport() {
 		return 'ping';
 	}
@@ -47,7 +47,7 @@ class PingQueueHandler extends QueueHandler {
 	function handle_notice($notice) {
 		return ping_broadcast_notice($notice);
 	}
-	
+
 	function finish() {
 	}
 }

From 5dc913f58951815fcaa246e675ff7d30ad93f633 Mon Sep 17 00:00:00 2001
From: Evan Prodromou <evan@controlyourself.ca>
Date: Thu, 19 Mar 2009 09:21:50 -0400
Subject: [PATCH 06/38] ping handler returns proper boolean response

The ping queue handler wasn't returning a true value -- filling up the
queue with ping requests. It now returns a true value.
---
 lib/ping.php                 | 77 ++++++++++++++++++++++++++----------
 scripts/pingqueuehandler.php |  4 +-
 2 files changed, 58 insertions(+), 23 deletions(-)

diff --git a/lib/ping.php b/lib/ping.php
index 32c0b9806a..2cbec2f212 100644
--- a/lib/ping.php
+++ b/lib/ping.php
@@ -1,7 +1,7 @@
 <?php
 /*
  * Laconica - a distributed open-source microblogging tool
- * Copyright (C) 2008, Controlez-Vous, Inc.
+ * Copyright (C) 2009, Control Yourself, Inc.
  *
  * This program is free software: you can redistribute it and/or modify
  * it under the terms of the GNU Affero General Public License as published by
@@ -20,49 +20,84 @@
 if (!defined('LACONICA')) { exit(1); }
 
 function ping_broadcast_notice($notice) {
+
 	if (!$notice->is_local) {
-		return;
+		return true;
 	}
-	
+
 	# Array of servers, URL => type
 	$notify = common_config('ping', 'notify');
 	$profile = $notice->getProfile();
 	$tags = ping_notice_tags($notice);
-	
+
 	foreach ($notify as $notify_url => $type) {
 		switch ($type) {
 		 case 'xmlrpc':
 		 case 'extended':
 			$req = xmlrpc_encode_request('weblogUpdates.ping',
 										 array($profile->nickname, # site name
-											   common_local_url('showstream', 
+											   common_local_url('showstream',
 																array('nickname' => $profile->nickname)),
 											   common_local_url('shownotice',
 																array('notice' => $notice->id)),
-											   common_local_url('userrss', 
+											   common_local_url('userrss',
 																array('nickname' => $profile->nickname)),
 											   $tags));
-			
-			# We re-use this tool's fetcher, since it's pretty good
-	
-			$fetcher = Auth_Yadis_Yadis::getHTTPFetcher();
 
-			if (!$fetcher) {
-				common_log(LOG_WARNING, 'Failed to initialize Yadis fetcher.', __FILE__);
-				return false;
-			}
-	
-			$result = $fetcher->post($notify_url,
-									 $req);
-											   
+            $context = stream_context_create(array('http' => array('method' => "POST",
+                                                                   'header' =>
+                                                                   "Content-Type: text/xml\r\n".
+                                                                   "User-Agent: Laconica/".LACONICA_VERSION."\r\n",
+                                                                   'content' => $request)));
+            $file = file_get_contents($notify_url, false, $context);
+            $response = xmlrpc_decode($file);
+            if (xmlrpc_is_fault($response)) {
+                common_log(LOG_WARNING,
+                           "XML-RPC error for ping ($notify_url, $notice->id) ".
+                           "$response[faultString] ($response[faultCode])");
+            } else {
+                common_log(LOG_INFO,
+                           "Ping success for $notify_url $notice->id");
+            }
+            break;
+
 		 case 'get':
-		 case 'post':			
+		 case 'post':
+            $args = array('name' => $profile->nickname,
+                          'url' => common_local_url('showstream',
+                                                    array('nickname' => $profile->nickname)),
+                          'changesURL' => common_local_url('userrss',
+                                                           array('nickname' => $profile->nickname)));
+
+            $fetcher = Auth_Yadis_Yadis::getHTTPFetcher();
+
+            if ($type === 'get') {
+                $result = $fetcher->get($notify_url . '?' . http_build_query($args),
+                                        array('User-Agent: Laconica/'.LACONICA_VERSION));
+            } else {
+                $result = $fetcher->post($notify_url,
+                                         http_build_query($args),
+                                         array('User-Agent: Laconica/'.LACONICA_VERSION));
+            }
+            if ($result->status != '200') {
+                common_log(LOG_WARNING,
+                           "Ping error for '$notify_url' ($notice->id): ".
+                           "$result->body");
+            } else {
+                common_log(LOG_INFO,
+                           "Ping success for '$notify_url' ($notice->id): ".
+                           "'$result->body'");
+            }
+            break;
+
 		 default:
 			common_log(LOG_WARNING, 'Unknown notify type for ' . $notify_url . ': ' . $type);
-										   }
+        }
 	}
+
+    return true;
 }
-		
+
 function ping_notice_tags($notice) {
 	$tag = new Notice_tag();
 	$tag->notice_id = $notice->id;
diff --git a/scripts/pingqueuehandler.php b/scripts/pingqueuehandler.php
index 55a266e4a4..ada6ecdba2 100644
--- a/scripts/pingqueuehandler.php
+++ b/scripts/pingqueuehandler.php
@@ -34,7 +34,7 @@ require_once(INSTALLDIR . '/lib/queuehandler.php');
 set_error_handler('common_error_handler');
 
 class PingQueueHandler extends QueueHandler {
-	
+
 	function transport() {
 		return 'ping';
 	}
@@ -47,7 +47,7 @@ class PingQueueHandler extends QueueHandler {
 	function handle_notice($notice) {
 		return ping_broadcast_notice($notice);
 	}
-	
+
 	function finish() {
 	}
 }

From d1b2a9d7087ecc171f941755b4c3a420cd202842 Mon Sep 17 00:00:00 2001
From: Evan Prodromou <evan@controlyourself.ca>
Date: Thu, 19 Mar 2009 11:01:58 -0400
Subject: [PATCH 07/38] Somewhat better behaviour with mixed caps in search

Deal somewhat better with mixed caps in people and notice search.
---
 actions/groupsearch.php     | 11 +++--------
 actions/noticesearch.php    |  2 +-
 actions/noticesearchrss.php |  3 ---
 actions/peoplesearch.php    |  6 +++---
 lib/search_engines.php      | 34 +++++++++++++++++++++++++---------
 5 files changed, 32 insertions(+), 24 deletions(-)

diff --git a/actions/groupsearch.php b/actions/groupsearch.php
index 9b0026db94..109a53ce11 100644
--- a/actions/groupsearch.php
+++ b/actions/groupsearch.php
@@ -1,9 +1,4 @@
 <?php
-
-
-//        define('GROUPS_PER_PAGE', 20);
-
-
 /**
  * Group search action class.
  *
@@ -90,15 +85,15 @@ class GroupSearchResults extends GroupList
 {
     var $terms = null;
     var $pattern = null;
-    
+
     function __construct($user_group, $terms, $action)
     {
         parent::__construct($user_group, $terms, $action);
-        $this->terms = array_map('preg_quote', 
+        $this->terms = array_map('preg_quote',
                                  array_map('htmlspecialchars', $terms));
         $this->pattern = '/('.implode('|',$terms).')/i';
     }
-    
+
     function highlight($text)
     {
         return preg_replace($this->pattern, '<strong>\\1</strong>', htmlspecialchars($text));
diff --git a/actions/noticesearch.php b/actions/noticesearch.php
index 83e59dd9ae..eb4a072def 100644
--- a/actions/noticesearch.php
+++ b/actions/noticesearch.php
@@ -103,7 +103,7 @@ class NoticesearchAction extends SearchAction
     function showResults($q, $page)
     {
         $notice        = new Notice();
-        $q             = strtolower($q);
+
         $search_engine = $notice->getSearchEngine('identica_notices');
         $search_engine->set_sort_mode('chron');
         // Ask for an extra to see if there's more.
diff --git a/actions/noticesearchrss.php b/actions/noticesearchrss.php
index 0f98ed04bb..ba5276d06e 100644
--- a/actions/noticesearchrss.php
+++ b/actions/noticesearchrss.php
@@ -62,9 +62,6 @@ class NoticesearchrssAction extends Rss10Action
 
         $notice = new Notice();
 
-        # lcase it for comparison
-        $q = strtolower($q);
-
         $search_engine = $notice->getSearchEngine('identica_notices');
         $search_engine->set_sort_mode('chron');
 
diff --git a/actions/peoplesearch.php b/actions/peoplesearch.php
index 14177fcf0d..9e515ade1a 100644
--- a/actions/peoplesearch.php
+++ b/actions/peoplesearch.php
@@ -63,13 +63,13 @@ class PeoplesearchAction extends SearchAction
 
         $profile = new Profile();
 
-        # lcase it for comparison
-        $q = strtolower($q);
+        // lcase it for comparison
+        // $q = strtolower($q);
 
         $search_engine = $profile->getSearchEngine('identica_people');
 
         $search_engine->set_sort_mode('chron');
-        # Ask for an extra to see if there's more.
+        // Ask for an extra to see if there's more.
         $search_engine->limit((($page-1)*PROFILES_PER_PAGE), PROFILES_PER_PAGE + 1);
         if (false === $search_engine->query($q)) {
             $cnt = 0;
diff --git a/lib/search_engines.php b/lib/search_engines.php
index 559107910c..7b9dbb6182 100644
--- a/lib/search_engines.php
+++ b/lib/search_engines.php
@@ -74,7 +74,7 @@ class SphinxSearch extends SearchEngine
     {
         //FIXME without LARGEST_POSSIBLE, the most recent results aren't returned
         //      this probably has a large impact on performance
-        $LARGEST_POSSIBLE = 1e6; 
+        $LARGEST_POSSIBLE = 1e6;
 
         if ($rss) {
             $this->sphinx->setLimits($offset, $count, $count, $LARGEST_POSSIBLE);
@@ -109,12 +109,25 @@ class MySQLSearch extends SearchEngine
 {
     function query($q)
     {
-        if ('identica_people' === $this->table)
-            return $this->target->whereAdd('MATCH(nickname, fullname, location, bio, homepage) ' .
-                           'against (\''.addslashes($q).'\')');
-        if ('identica_notices' === $this->table)
-            return $this->target->whereAdd('MATCH(content) ' .
-                           'against (\''.addslashes($q).'\')');
+        if ('identica_people' === $this->table) {
+            $this->target->whereAdd('MATCH(nickname, fullname, location, bio, homepage) ' .
+                                    'AGAINST (\''.addslashes($q).'\' IN BOOLEAN MODE)');
+            if (strtolower($q) != $q) {
+                $this->target->whereAdd('MATCH(nickname, fullname, location, bio, homepage) ' .
+                                        'AGAINST (\''.addslashes(strtolower($q)).'\' IN BOOLEAN MODE)', 'OR');
+            }
+            return true;
+        } else if ('identica_notices' === $this->table) {
+             $this->target->whereAdd('MATCH(content) ' .
+                                     'AGAINST (\''.addslashes($q).'\' IN BOOLEAN MODE)');
+            if (strtolower($q) != $q) {
+                $this->target->whereAdd('MATCH(content) ' .
+                                        'AGAINST (\''.addslashes(strtolower($q)).'\' IN BOOLEAN MODE)', 'OR');
+            }
+            return true;
+        } else {
+            throw new ServerException('Unknown table: ' . $this->table);
+        }
     }
 }
 
@@ -122,10 +135,13 @@ class PGSearch extends SearchEngine
 {
     function query($q)
     {
-        if ('identica_people' === $this->table)
+        if ('identica_people' === $this->table) {
             return $this->target->whereAdd('textsearch @@ plainto_tsquery(\''.addslashes($q).'\')');
-        if ('identica_notices' === $this->table)
+        } else if ('identica_notices' === $this->table) {
             return $this->target->whereAdd('to_tsvector(\'english\', content) @@ plainto_tsquery(\''.addslashes($q).'\')');
+        } else {
+            throw new ServerException('Unknown table: ' . $this->table);
+        }
     }
 }
 

From 3d8a8aa03c7672966006aa0b7be5da699decbcb3 Mon Sep 17 00:00:00 2001
From: Evan Prodromou <evan@controlyourself.ca>
Date: Thu, 19 Mar 2009 11:36:24 -0400
Subject: [PATCH 08/38] redirect to original URL or URI for remote notices

---
 actions/shownotice.php | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/actions/shownotice.php b/actions/shownotice.php
index d5f35cd84b..ccae49bb3e 100644
--- a/actions/shownotice.php
+++ b/actions/shownotice.php
@@ -177,10 +177,17 @@ class ShownoticeAction extends Action
     {
         parent::handle($args);
 
-        $this->showPage();
+        if ($this->notice->is_local == 0) {
+            if (!empty($this->notice->url)) {
+                common_redirect($this->notice->url, 301);
+            } else if (!empty($this->notice->uri) && preg_match('/^https?:/', $this->notice->uri)) {
+                common_redirect($this->notice->uri, 301);
+            }
+        } else {
+            $this->showPage();
+        }
     }
 
-
     /**
      * Don't show local navigation
      *
@@ -191,7 +198,6 @@ class ShownoticeAction extends Action
     {
     }
 
-
     /**
      * Fill the content area of the page
      *
@@ -208,8 +214,6 @@ class ShownoticeAction extends Action
         $this->elementEnd('ul');
     }
 
-
-
     /**
      * Don't show page notice
      *
@@ -220,7 +224,6 @@ class ShownoticeAction extends Action
     {
     }
 
-
     /**
      * Don't show aside
      *
@@ -230,7 +233,6 @@ class ShownoticeAction extends Action
     function showAside() {
     }
 
-
     /**
      * Extra <head> content
      *

From 8f64c247fd64e1cce12489c212e55dae16e28c39 Mon Sep 17 00:00:00 2001
From: Evan Prodromou <evan@controlyourself.ca>
Date: Thu, 19 Mar 2009 11:36:24 -0400
Subject: [PATCH 09/38] redirect to original URL or URI for remote notices

---
 actions/shownotice.php | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/actions/shownotice.php b/actions/shownotice.php
index d5f35cd84b..ccae49bb3e 100644
--- a/actions/shownotice.php
+++ b/actions/shownotice.php
@@ -177,10 +177,17 @@ class ShownoticeAction extends Action
     {
         parent::handle($args);
 
-        $this->showPage();
+        if ($this->notice->is_local == 0) {
+            if (!empty($this->notice->url)) {
+                common_redirect($this->notice->url, 301);
+            } else if (!empty($this->notice->uri) && preg_match('/^https?:/', $this->notice->uri)) {
+                common_redirect($this->notice->uri, 301);
+            }
+        } else {
+            $this->showPage();
+        }
     }
 
-
     /**
      * Don't show local navigation
      *
@@ -191,7 +198,6 @@ class ShownoticeAction extends Action
     {
     }
 
-
     /**
      * Fill the content area of the page
      *
@@ -208,8 +214,6 @@ class ShownoticeAction extends Action
         $this->elementEnd('ul');
     }
 
-
-
     /**
      * Don't show page notice
      *
@@ -220,7 +224,6 @@ class ShownoticeAction extends Action
     {
     }
 
-
     /**
      * Don't show aside
      *
@@ -230,7 +233,6 @@ class ShownoticeAction extends Action
     function showAside() {
     }
 
-
     /**
      * Extra <head> content
      *

From 0e1186dfd0e96a64688c107f28a93b1ef172f56a Mon Sep 17 00:00:00 2001
From: CiaranG <ciaran@ciarang.com>
Date: Thu, 19 Mar 2009 18:08:49 +0000
Subject: [PATCH 10/38] Get rid of 'Join now...' message if site is closed or
 invite only. See ticket #1335

---
 actions/public.php | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/actions/public.php b/actions/public.php
index a20ae40321..9b22e0a2ce 100644
--- a/actions/public.php
+++ b/actions/public.php
@@ -207,9 +207,14 @@ class PublicAction extends Action
 
     function showAnonymousMessage()
     {
-		$m = _('This is %%site.name%%, a [micro-blogging](http://en.wikipedia.org/wiki/Micro-blogging) service ' .
-               'based on the Free Software [Laconica](http://laconi.ca/) tool. ' .
-               '[Join now](%%action.register%%) to share notices about yourself with friends, family, and colleagues! ([Read more](%%doc.help%%))');
+        if (! (common_config('site','closed') || common_config('site','inviteonly'))) {
+	    $m = _('This is %%site.name%%, a [micro-blogging](http://en.wikipedia.org/wiki/Micro-blogging) service ' .
+                  'based on the Free Software [Laconica](http://laconi.ca/) tool. ' .
+                  '[Join now](%%action.register%%) to share notices about yourself with friends, family, and colleagues! ([Read more](%%doc.help%%))');
+        } else {
+            $m = _('This is %%site.name%%, a [micro-blogging](http://en.wikipedia.org/wiki/Micro-blogging) service ' .
+                   'based on the Free Software [Laconica](http://laconi.ca/) tool.');
+        }
         $this->elementStart('div', array('id' => 'anon_notice'));
         $this->raw(common_markup_to_html($m));
         $this->elementEnd('div');

From 94271293ceb1098d559f83e80aa4578cddd8976a Mon Sep 17 00:00:00 2001
From: CiaranG <ciaran@ciarang.com>
Date: Thu, 19 Mar 2009 21:07:31 +0000
Subject: [PATCH 11/38] Remove 'Register' from login group nav when site is
 closed or inviteonly. See ticket #1335

---
 lib/logingroupnav.php | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/lib/logingroupnav.php b/lib/logingroupnav.php
index fd909581f4..f23985f3ab 100644
--- a/lib/logingroupnav.php
+++ b/lib/logingroupnav.php
@@ -70,16 +70,16 @@ class LoginGroupNav extends Widget
     function show()
     {
         // action => array('prompt', 'title')
-        $menu =
-          array('login' =>
-                array(_('Login'),
-                      _('Login with a username and password')),
-                'register' =>
-                array(_('Register'),
-                      _('Sign up for a new account')),
-                'openidlogin' =>
-                array(_('OpenID'),
-                      _('Login or register with OpenID')));
+        $menu = array();
+
+        $menu['login'] = array(_('Login'),
+                         _('Login with a username and password'));
+        if (!(common_config('site','closed') || common_config('site','inviteonly'))) {
+            $menu['register'] = array(_('Register'),
+                                _('Sign up for a new account'));
+        }
+        $menu['openidlogin'] = array(_('OpenID'),
+                               _('Login or register with OpenID'));
 
         $action_name = $this->action->trimmed('action');
         $this->action->elementStart('ul', array('class' => 'nav'));

From b4c273113cc5d16dfa1ea3236dd8c78d1169cbf3 Mon Sep 17 00:00:00 2001
From: CiaranG <ciaran@ciarang.com>
Date: Thu, 19 Mar 2009 21:55:03 +0000
Subject: [PATCH 12/38] A couple more 'Join Now' messages that need disabling
 when the site is closed or invite only

---
 actions/showgroup.php  | 15 +++++++++++----
 actions/showstream.php | 14 ++++++++++----
 2 files changed, 21 insertions(+), 8 deletions(-)

diff --git a/actions/showgroup.php b/actions/showgroup.php
index b6022840bf..58cc7a97cd 100644
--- a/actions/showgroup.php
+++ b/actions/showgroup.php
@@ -390,11 +390,18 @@ class ShowgroupAction extends Action
 
     function showAnonymousMessage()
     {
-		$m = sprintf(_('**%s** is a user group on %%%%site.name%%%%, a [micro-blogging](http://en.wikipedia.org/wiki/Micro-blogging) service ' .
-                       'based on the Free Software [Laconica](http://laconi.ca/) tool. Its members share ' .
-                       'short messages about their life and interests. '.
-                       '[Join now](%%%%action.register%%%%) to become part of this group and many more! ([Read more](%%%%doc.help%%%%))'),
+        if (!(common_config('site','closed') || common_config('site','inviteonly'))) {
+            $m = sprintf(_('**%s** is a user group on %%%%site.name%%%%, a [micro-blogging](http://en.wikipedia.org/wiki/Micro-blogging) service ' .
+                'based on the Free Software [Laconica](http://laconi.ca/) tool. Its members share ' .
+                'short messages about their life and interests. '.
+                '[Join now](%%%%action.register%%%%) to become part of this group and many more! ([Read more](%%%%doc.help%%%%))'),
                      $this->group->nickname);
+        } else {
+            $m = sprintf(_('**%s** is a user group on %%%%site.name%%%%, a [micro-blogging](http://en.wikipedia.org/wiki/Micro-blogging) service ' .
+                'based on the Free Software [Laconica](http://laconi.ca/) tool. Its members share ' .
+                'short messages about their life and interests. '),
+                     $this->group->nickname);
+        }
         $this->elementStart('div', array('id' => 'anon_notice'));
         $this->raw(common_markup_to_html($m));
         $this->elementEnd('div');
diff --git a/actions/showstream.php b/actions/showstream.php
index 65482167e1..b83f45d53b 100644
--- a/actions/showstream.php
+++ b/actions/showstream.php
@@ -539,10 +539,16 @@ class ShowstreamAction extends Action
 
     function showAnonymousMessage()
     {
-		$m = sprintf(_('**%s** has an account on %%%%site.name%%%%, a [micro-blogging](http://en.wikipedia.org/wiki/Micro-blogging) service ' .
-                       'based on the Free Software [Laconica](http://laconi.ca/) tool. ' .
-                       '[Join now](%%%%action.register%%%%) to follow **%s**\'s notices and many more! ([Read more](%%%%doc.help%%%%))'),
-                     $this->user->nickname, $this->user->nickname);
+        if (!(common_config('site','closed') || common_config('site','inviteonly'))) {
+            $m = sprintf(_('**%s** has an account on %%%%site.name%%%%, a [micro-blogging](http://en.wikipedia.org/wiki/Micro-blogging) service ' .
+                 'based on the Free Software [Laconica](http://laconi.ca/) tool. ' .
+                 '[Join now](%%%%action.register%%%%) to follow **%s**\'s notices and many more! ([Read more](%%%%doc.help%%%%))'),
+                 $this->user->nickname, $this->user->nickname);
+        } else {
+            $m = sprintf(_('**%s** has an account on %%%%site.name%%%%, a [micro-blogging](http://en.wikipedia.org/wiki/Micro-blogging) service ' .
+                 'based on the Free Software [Laconica](http://laconi.ca/) tool. '),
+                 $this->user->nickname, $this->user->nickname);
+	}
         $this->elementStart('div', array('id' => 'anon_notice'));
         $this->raw(common_markup_to_html($m));
         $this->elementEnd('div');

From a9a71297f4c915c11e573adafffeccf3ff65a31c Mon Sep 17 00:00:00 2001
From: CiaranG <ciaran@ciarang.com>
Date: Fri, 20 Mar 2009 22:02:35 +0000
Subject: [PATCH 13/38] Use correct page information for notice search. See
 ticket #1333

---
 actions/noticesearch.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/actions/noticesearch.php b/actions/noticesearch.php
index eb4a072def..4aec416218 100644
--- a/actions/noticesearch.php
+++ b/actions/noticesearch.php
@@ -122,8 +122,8 @@ class NoticesearchAction extends SearchAction
 
         $cnt = $nl->show();
 
-        $this->pagination($this->page > 1, $cnt > NOTICES_PER_PAGE,
-                          $this->page, 'noticesearch', array('q' => $q));
+        $this->pagination($page > 1, $cnt > NOTICES_PER_PAGE,
+                          $page, 'noticesearch', array('q' => $q));
     }
     function isReadOnly()
     {

From 8ba43f18cdfad31415bc9e26b2d4be9e9b4465c0 Mon Sep 17 00:00:00 2001
From: CiaranG <ciaran@ciarang.com>
Date: Sat, 21 Mar 2009 14:16:54 +0000
Subject: [PATCH 14/38] Changes to router setup to make notice search RSS feed
 work

---
 lib/router.php | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/lib/router.php b/lib/router.php
index e39dc217a3..83b3ffe607 100644
--- a/lib/router.php
+++ b/lib/router.php
@@ -136,10 +136,14 @@ class Router
 
         foreach (array('group', 'people', 'notice') as $s) {
             $m->connect('search/'.$s, array('action' => $s.'search'));
-            $m->connect('search/'.$s.'?q=:q', array('action' => $s.'search'), array('q' => '.+'));
+            $m->connect('search/'.$s.'?q=:q', array('action' => $s.'search'),array('q' => '.+'));
         }
 
+        // The second of these is needed to make the link work correctly
+	// when inserted into the page. The first is needed to match the
+	// route on the way in. Seems to be another Net_URL_Mapper bug to me.
         $m->connect('search/notice/rss', array('action' => 'noticesearchrss'));
+        $m->connect('search/notice/rss?q=:q', array('action' => 'noticesearchrss'),array('q' => '.+'));
 
         // notice
 
@@ -421,6 +425,8 @@ class Router
 
     function build($action, $args=null, $params=null, $fragment=null)
     {
+        if($params!=null)
+	    common_log(LOG_DEBUG,"build: ".$action." ".print_r($args,true)." ".print_r($params,true));
         $action_arg = array('action' => $action);
 
         if ($args) {
@@ -429,6 +435,8 @@ class Router
             $args = $action_arg;
         }
 
+        if($params!=null)
+	    common_log(LOG_DEBUG,"generate args:".print_r($args,true));
         return $this->m->generate($args, $params, $fragment);
     }
 }

From c4072ef7c930b82b74f8e90f6554974b761c686c Mon Sep 17 00:00:00 2001
From: CiaranG <ciaran@ciarang.com>
Date: Sat, 21 Mar 2009 14:18:38 +0000
Subject: [PATCH 15/38] RSS 1.0 actions were reading the stream from the
 database twice. Inefficient, but more importantly made notice search RSS fail
 with a DB error due to double search on a DB_DataObject instance

---
 lib/rssaction.php | 18 ++++++++----------
 1 file changed, 8 insertions(+), 10 deletions(-)

diff --git a/lib/rssaction.php b/lib/rssaction.php
index 66c2d9e8cd..ddba862dcf 100644
--- a/lib/rssaction.php
+++ b/lib/rssaction.php
@@ -94,11 +94,11 @@ class Rss10Action extends Action
 
     function handle($args)
     {
-        // Get the list of notices
-        $this->notices = $this->getNotices();
         // Parent handling, including cache check
         parent::handle($args);
-        $this->showRss($this->limit);
+        // Get the list of notices
+        $this->notices = $this->getNotices($this->limit);
+        $this->showRss();
     }
 
     /**
@@ -132,15 +132,13 @@ class Rss10Action extends Action
         return null;
     }
 
-    function showRss($limit=0)
+    function showRss()
     {
-        $notices = $this->getNotices($limit);
-
         $this->initRss();
-        $this->showChannel($notices);
+        $this->showChannel();
         $this->showImage();
 
-        foreach ($notices as $n) {
+        foreach ($this->notices as $n) {
             $this->showItem($n);
         }
 
@@ -148,7 +146,7 @@ class Rss10Action extends Action
         $this->endRss();
     }
 
-    function showChannel($notices)
+    function showChannel()
     {
 
         $channel = $this->getChannel();
@@ -167,7 +165,7 @@ class Rss10Action extends Action
         $this->elementStart('items');
         $this->elementStart('rdf:Seq');
 
-        foreach ($notices as $notice) {
+        foreach ($this->notices as $notice) {
             $this->element('sioct:MicroblogPost', array('rdf:resource' => $notice->uri));
         }
 

From d64be5108d69ff4068d4383ab121a3ba7388ada3 Mon Sep 17 00:00:00 2001
From: CiaranG <ciaran@ciarang.com>
Date: Sat, 21 Mar 2009 14:24:19 +0000
Subject: [PATCH 16/38] Fix to Net_URL_Mapper to make search pagination work.
 See Ticket #1333

---
 extlib/Net/URL/Mapper/Path.php | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/extlib/Net/URL/Mapper/Path.php b/extlib/Net/URL/Mapper/Path.php
index b541002c7a..eb1c34a3fa 100644
--- a/extlib/Net/URL/Mapper/Path.php
+++ b/extlib/Net/URL/Mapper/Path.php
@@ -241,7 +241,12 @@ class Net_URL_Mapper_Path
         }
         $path = '/'.trim(Net_URL::resolvePath($path), '/');
         if (!empty($qstring)) {
-            $path .= '?'.http_build_query($qstring);
+            if (!strpos($path, '?')) {
+                $path .= '?';
+            } else {
+                $path .= '&';
+            }
+	    $path .= http_build_query($qstring);
         }
         if (!empty($anchor)) {
             $path .= '#'.ltrim($anchor, '#');
@@ -427,4 +432,4 @@ class Net_URL_Mapper_Path
 
 }
 
-?>
\ No newline at end of file
+?>

From 92da8a59cba6c14e2023c72adbe46ca8bf1d2235 Mon Sep 17 00:00:00 2001
From: Evan Prodromou <evan@controlyourself.ca>
Date: Sun, 22 Mar 2009 10:51:00 -0400
Subject: [PATCH 17/38] add Mobidentica

---
 db/notice_source.sql | 1 +
 1 file changed, 1 insertion(+)

diff --git a/db/notice_source.sql b/db/notice_source.sql
index 5e2d413c00..76cff1ff86 100644
--- a/db/notice_source.sql
+++ b/db/notice_source.sql
@@ -19,6 +19,7 @@ VALUES
     ('identichat','identichat','http://identichat.prosody.im/', now()),
     ('identitwitch','IdentiTwitch','http://richfish.org/identitwitch/', now()),
     ('mbpidgin','mbpidgin','http://code.google.com/p/microblog-purple/', now()),
+    ('Mobidentica', 'Mobidentica', 'http://www.substanceofcode.com/software/mobidentica/', now()),
     ('moconica','Moconica','http://moconica.com/', now()),
     ('pocketwit','PockeTwit','http://code.google.com/p/pocketwit/', now()),
     ('posty','Posty','http://spreadingfunkyness.com/posty/', now()),

From e947d9fdd1245d5b785df8c709d620e7d0940991 Mon Sep 17 00:00:00 2001
From: Evan Prodromou <evan@controlyourself.ca>
Date: Sun, 22 Mar 2009 15:23:40 -0400
Subject: [PATCH 18/38] variable name error

---
 lib/ping.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/ping.php b/lib/ping.php
index 2cbec2f212..d7472b920a 100644
--- a/lib/ping.php
+++ b/lib/ping.php
@@ -48,7 +48,7 @@ function ping_broadcast_notice($notice) {
                                                                    'header' =>
                                                                    "Content-Type: text/xml\r\n".
                                                                    "User-Agent: Laconica/".LACONICA_VERSION."\r\n",
-                                                                   'content' => $request)));
+                                                                   'content' => $req)));
             $file = file_get_contents($notify_url, false, $context);
             $response = xmlrpc_decode($file);
             if (xmlrpc_is_fault($response)) {

From 2e3f228b4bdb7bfc59a1fd0ce52fbebde7071566 Mon Sep 17 00:00:00 2001
From: Evan Prodromou <evan@controlyourself.ca>
Date: Sun, 22 Mar 2009 15:23:40 -0400
Subject: [PATCH 19/38] variable name error

---
 lib/ping.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/ping.php b/lib/ping.php
index 2cbec2f212..d7472b920a 100644
--- a/lib/ping.php
+++ b/lib/ping.php
@@ -48,7 +48,7 @@ function ping_broadcast_notice($notice) {
                                                                    'header' =>
                                                                    "Content-Type: text/xml\r\n".
                                                                    "User-Agent: Laconica/".LACONICA_VERSION."\r\n",
-                                                                   'content' => $request)));
+                                                                   'content' => $req)));
             $file = file_get_contents($notify_url, false, $context);
             $response = xmlrpc_decode($file);
             if (xmlrpc_is_fault($response)) {

From 149fa14bd42e7ba1fe00ae69df189db02f8779df Mon Sep 17 00:00:00 2001
From: Evan Prodromou <evan@controlyourself.ca>
Date: Sun, 22 Mar 2009 15:34:09 -0400
Subject: [PATCH 20/38] not correctly checking results of XML-RPC request

---
 lib/ping.php | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/lib/ping.php b/lib/ping.php
index d7472b920a..3de541e9aa 100644
--- a/lib/ping.php
+++ b/lib/ping.php
@@ -50,7 +50,15 @@ function ping_broadcast_notice($notice) {
                                                                    "User-Agent: Laconica/".LACONICA_VERSION."\r\n",
                                                                    'content' => $req)));
             $file = file_get_contents($notify_url, false, $context);
+
+            if ($file === false || mb_strlen($file) == 0) {
+                common_log(LOG_WARNING,
+                           "XML-RPC empty results for ping ($notify_url, $notice->id) ");
+                continue;
+            }
+
             $response = xmlrpc_decode($file);
+
             if (xmlrpc_is_fault($response)) {
                 common_log(LOG_WARNING,
                            "XML-RPC error for ping ($notify_url, $notice->id) ".

From fadae96a74abd710316d336109bf8eca4d9394ac Mon Sep 17 00:00:00 2001
From: Sarven Capadisli <csarven@controlyourself.ca>
Date: Sun, 22 Mar 2009 20:21:32 +0000
Subject: [PATCH 21/38] Password recover and change form markup updated.

---
 actions/recoverpassword.php | 22 ++++++++++++++++++++--
 theme/base/css/display.css  |  4 +++-
 2 files changed, 23 insertions(+), 3 deletions(-)

diff --git a/actions/recoverpassword.php b/actions/recoverpassword.php
index eeb6b2516c..620fe7eb8e 100644
--- a/actions/recoverpassword.php
+++ b/actions/recoverpassword.php
@@ -181,13 +181,21 @@ class RecoverpasswordAction extends Action
     function showRecoverForm()
     {
         $this->elementStart('form', array('method' => 'post',
-                                           'id' => 'recoverpassword',
+                                           'id' => 'form_password_recover',
+                                           'class' => 'form_settings',
                                            'action' => common_local_url('recoverpassword')));
+        $this->elementStart('fieldset');
+        $this->element('legend', null, _('Password recover'));
+        $this->elementStart('ul', 'form_data');
+        $this->elementStart('li');
         $this->input('nicknameoremail', _('Nickname or email'),
                      $this->trimmed('nicknameoremail'),
                      _('Your nickname on this server, ' .
                         'or your registered email address.'));
+        $this->elementEnd('li');
+        $this->elementEnd('ul');
         $this->submit('recover', _('Recover'));
+        $this->elementEnd('fieldset');
         $this->elementEnd('form');
     }
 
@@ -213,14 +221,24 @@ class RecoverpasswordAction extends Action
     function showResetForm()
     {
         $this->elementStart('form', array('method' => 'post',
-                                           'id' => 'recoverpassword',
+                                           'id' => 'form_password_change',
+                                           'class' => 'form_settings',
                                            'action' => common_local_url('recoverpassword')));
+        $this->elementStart('fieldset');
+        $this->element('legend', null, _('Password change'));
         $this->hidden('token', common_session_token());
+        $this->elementStart('ul', 'form_data');
+        $this->elementStart('li');
         $this->password('newpassword', _('New password'),
                         _('6 or more characters, and don\'t forget it!'));
+        $this->elementEnd('li');
+        $this->elementStart('li');
         $this->password('confirm', _('Confirm'),
                         _('Same as password above'));
+        $this->elementEnd('li');
+        $this->elementEnd('ul');
         $this->submit('reset', _('Reset'));
+        $this->elementEnd('fieldset');
         $this->elementEnd('form');
     }
 
diff --git a/theme/base/css/display.css b/theme/base/css/display.css
index c741ed4cba..a10ec0223c 100644
--- a/theme/base/css/display.css
+++ b/theme/base/css/display.css
@@ -150,7 +150,9 @@ font-weight:bold;
 #form_openid_login legend,
 #form_search legend,
 #form_invite legend,
-#form_notice_delete legend {
+#form_notice_delete legend,
+#form_password_recover legend,
+#form_password_change legend {
 display:none;
 }
 

From 3ef4f251acbe8ebdfd9d7f1ea43b7344b7332b73 Mon Sep 17 00:00:00 2001
From: Evan Prodromou <evan@controlyourself.ca>
Date: Sun, 22 Mar 2009 16:58:38 -0400
Subject: [PATCH 22/38] One function for producing Atom entry for a Notice

Took the various places that we create an atom entry for a notice, and
jammed them together into one function of the notice class, and then
used that function. Also, added Atom threading extension and
categories for hashtags.
---
 classes/Notice.php | 94 ++++++++++++++++++++++++++++++++++++++++++++++
 lib/jabber.php     | 55 ++++++++-------------------
 lib/twitterapi.php | 30 ++++-----------
 3 files changed, 117 insertions(+), 62 deletions(-)

diff --git a/classes/Notice.php b/classes/Notice.php
index 3087e39a78..44a6aeb986 100644
--- a/classes/Notice.php
+++ b/classes/Notice.php
@@ -799,4 +799,98 @@ class Notice extends Memcached_DataObject
             }
         }
     }
+
+    function asAtomEntry($namespace=false, $source=false)
+    {
+        $profile = $this->getProfile();
+
+        $xs = new XMLStringer(true);
+
+        if ($namespace) {
+            $attrs = array('xmlns' => 'http://www.w3.org/2005/Atom',
+                           'xmlns:thr' => 'http://purl.org/syndication/thread/1.0');
+        } else {
+            $attrs = array();
+        }
+
+        $xs->elementStart('entry', $attrs);
+
+        if ($source) {
+            $xs->elementStart('source');
+            $xs->element('title', null, $profile->nickname . " - " . common_config('site', 'name'));
+            $xs->element('link', array('href' => $profile->profileurl));
+            $user = User::staticGet('id', $profile->id);
+            if (!empty($user)) {
+                $atom_feed = common_local_url('api',
+                                              array('apiaction' => 'statuses',
+                                                    'method' => 'user_timeline',
+                                                    'argument' => $profile->nickname.'.atom'));
+                $xs->element('link', array('rel' => 'self',
+                                           'type' => 'application/atom+xml',
+                                           'href' => $profile->profileurl));
+                $xs->element('link', array('rel' => 'license',
+                                           'href' => common_config('license', 'url')));
+            }
+
+            $xs->element('icon', null, $profile->avatarUrl(AVATAR_PROFILE_SIZE));
+        }
+
+        $xs->elementStart('author');
+        $xs->element('name', null, $profile->nickname);
+        $xs->element('uri', null, $profile->profileurl);
+        $xs->elementEnd('author');
+
+        if ($source) {
+            $xs->elementEnd('source');
+        }
+
+        $xs->element('title', null, $this->content);
+        $xs->element('summary', null, $this->content);
+
+        $xs->element('link', array('rel' => 'alternate',
+                                   'href' => $this->bestUrl()));
+
+        $xs->element('id', null, $this->uri);
+
+        $xs->element('published', null, common_date_w3dtf($this->created));
+        $xs->element('updated', null, common_date_w3dtf($this->modified));
+
+        if ($this->reply_to) {
+            $reply_notice = Notice::staticGet('id', $this->reply_to);
+            if (!empty($reply_notice)) {
+                $xs->element('link', array('rel' => 'related',
+                                           'href' => $reply_notice->bestUrl()));
+                $xs->element('thr:in-reply-to',
+                             array('ref' => $reply_notice->uri,
+                                   'href' => $reply_notice->bestUrl()));
+            }
+        }
+
+        $xs->element('content', array('type' => 'html'), $this->rendered);
+
+        $tag = new Notice_tag();
+        $tag->notice_id = $this->id;
+        if ($tag->find()) {
+            while ($tag->fetch()) {
+                $xs->element('category', array('term' => $tag->tag));
+            }
+        }
+        $tag->free();
+
+        $xs->elementEnd('entry');
+
+        return $xs->getString();
+    }
+
+    function bestUrl()
+    {
+        if (!empty($this->url)) {
+            return $this->url;
+        } else if (!empty($this->uri) && preg_match('/^https?:/', $this->uri)) {
+            return $this->uri;
+        } else {
+            return common_local_url('shownotice',
+                                    array('notice' => $this->id));
+        }
+    }
 }
diff --git a/lib/jabber.php b/lib/jabber.php
index 3cd3b0d37e..9108d1c478 100644
--- a/lib/jabber.php
+++ b/lib/jabber.php
@@ -163,50 +163,25 @@ function jabber_send_notice($to, $notice)
 
 function jabber_format_entry($profile, $notice)
 {
-    // FIXME: notice url might be remote
+    $entry = $notice->asAtomEntry(true, true);
 
-    $noticeurl = common_local_url('shownotice',
-                                  array('notice' => $notice->id));
-
-    $msg = jabber_format_notice($profile, $notice);
-
-    $self_url = common_local_url('userrss', array('nickname' => $profile->nickname));
-
-    $entry  = "\n<entry xmlns='http://www.w3.org/2005/Atom'>\n";
-    $entry .= "<source>\n";
-    $entry .= "<title>" . $profile->nickname . " - " . common_config('site', 'name') . "</title>\n";
-    $entry .= "<link href='" . htmlspecialchars($profile->profileurl) . "'/>\n";
-    $entry .= "<link rel='self' type='application/rss+xml' href='" . $self_url . "'/>\n";
-    $entry .= "<author><name>" . $profile->nickname . "</name></author>\n";
-    $entry .= "<icon>" . $profile->avatarUrl(AVATAR_PROFILE_SIZE) . "</icon>\n";
-    $entry .= "</source>\n";
-    $entry .= "<title>" . htmlspecialchars($msg) . "</title>\n";
-    $entry .= "<summary>" . htmlspecialchars($msg) . "</summary>\n";
-    $entry .= "<link rel='alternate' href='" . $noticeurl . "' />\n";
-    $entry .= "<id>". $notice->uri . "</id>\n";
-    $entry .= "<published>".common_date_w3dtf($notice->created)."</published>\n";
-    $entry .= "<updated>".common_date_w3dtf($notice->modified)."</updated>\n";
-    if ($notice->reply_to) {
-        $replyurl = common_local_url('shownotice',
-                                     array('notice' => $notice->reply_to));
-        $entry .= "<link rel='related' href='" . $replyurl . "'/>\n";
+    $xs = new XMLStringer();
+    $xs->elementStart('html', array('xmlns' => 'http://jabber.org/protocol/xhtml-im'));
+    $xs->elementStart('body', array('xmlns' => 'http://www.w3.org/1999/xhtml'));
+    $xs->element('a', array('href' => $profile->profileurl),
+                 $profile->nickname);
+    $xs->text(": ");
+    if (!empty($notice->rendered)) {
+        $xs->raw($notice->rendered);
+    } else {
+        $xs->raw(common_render_content($notice->content, $notice));
     }
-    $entry .= "</entry>\n";
+    $xs->elementEnd('body');
+    $xs->elementEnd('html');
 
-    $html  = "\n<html xmlns='http://jabber.org/protocol/xhtml-im'>\n";
-    $html .= "<body xmlns='http://www.w3.org/1999/xhtml'>\n";
-    $html .= "<a href='".htmlspecialchars($profile->profileurl)."'>".$profile->nickname."</a>: ";
-    $html .= ($notice->rendered) ? $notice->rendered : common_render_content($notice->content, $notice);
-    $html .= "\n</body>\n";
-    $html .= "\n</html>\n";
+    $html = $xs->asString();
 
-    $address  = "<addresses xmlns='http://jabber.org/protocol/address'>\n";
-    $address .= "<address type='replyto' jid='" . jabber_daemon_address() . "' />\n";
-    $address .= "</addresses>\n";
-
-    // FIXME: include a pubsub event, too.
-
-    return $html . $entry . $address;
+    return $html . ' ' . $entry;
 }
 
 /**
diff --git a/lib/twitterapi.php b/lib/twitterapi.php
index e7239acd5e..b8357c6889 100644
--- a/lib/twitterapi.php
+++ b/lib/twitterapi.php
@@ -238,21 +238,6 @@ class TwitterapiAction extends Action
         $this->elementEnd('item');
     }
 
-    function show_twitter_atom_entry($entry)
-    {
-        $this->elementStart('entry');
-        $this->element('title', null, $entry['title']);
-        $this->element('content', array('type' => 'html'), $entry['content']);
-        $this->element('id', null, $entry['id']);
-        $this->element('published', null, $entry['published']);
-        $this->element('updated', null, $entry['updated']);
-        $this->element('link', array('href' => $entry['link'], 'rel' => 'alternate', 'type' => 'text/html'), null);
-        $this->elementStart('author');
-        $this->element('name', null, $entry['author']);
-        $this->elementEnd('author');
-        $this->elementEnd('entry');
-    }
-
     function show_json_objects($objects)
     {
         print(json_encode($objects));
@@ -383,7 +368,7 @@ class TwitterapiAction extends Action
         }
 
         if (!is_null($selfuri)) {
-            $this->element('link', array('href' => $selfuri, 
+            $this->element('link', array('href' => $selfuri,
                 'rel' => 'self', 'type' => 'application/atom+xml'), null);
         }
 
@@ -392,13 +377,11 @@ class TwitterapiAction extends Action
 
         if (is_array($notice)) {
             foreach ($notice as $n) {
-                $entry = $this->twitter_rss_entry_array($n);
-                $this->show_twitter_atom_entry($entry);
+                $this->raw($n->asAtomEntry());
             }
         } else {
             while ($notice->fetch()) {
-                $entry = $this->twitter_rss_entry_array($notice);
-                $this->show_twitter_atom_entry($entry);
+                $this->raw($notice->asAtomEntry());
             }
         }
 
@@ -578,13 +561,16 @@ class TwitterapiAction extends Action
     function init_twitter_atom()
     {
         $this->startXML();
-        $this->elementStart('feed', array('xmlns' => 'http://www.w3.org/2005/Atom', 'xml:lang' => 'en-US'));
+        // FIXME: don't hardcode the language here!
+        $this->elementStart('feed', array('xmlns' => 'http://www.w3.org/2005/Atom',
+                                          'xml:lang' => 'en-US',
+                                          'xmlns:thr' => 'http://purl.org/syndication/thread/1.0'));
     }
 
     function end_twitter_atom()
     {
-        $this->endXML();
         $this->elementEnd('feed');
+        $this->endXML();
     }
 
     function show_profile($profile, $content_type='xml', $notice=null)

From 14afe2d26874ed30a0ccef5e0acda2c5171afcde Mon Sep 17 00:00:00 2001
From: Evan Prodromou <evan@controlyourself.ca>
Date: Mon, 23 Mar 2009 15:44:17 -0400
Subject: [PATCH 23/38] show subscribe button and block form again

---
 lib/profilelist.php | 20 ++++++++++++--------
 1 file changed, 12 insertions(+), 8 deletions(-)

diff --git a/lib/profilelist.php b/lib/profilelist.php
index bd9b51958c..a4cc235552 100644
--- a/lib/profilelist.php
+++ b/lib/profilelist.php
@@ -109,7 +109,7 @@ class ProfileList extends Widget
         $this->out->elementEnd('span');
         $this->out->elementEnd('a');
 
-        if ($this->profile->fullname !== '') {
+        if (!empty($this->profile->fullname)) {
             $this->out->elementStart('dl', 'entity_fn');
             $this->out->element('dt', null, 'Full name');
             $this->out->elementStart('dd');
@@ -119,7 +119,7 @@ class ProfileList extends Widget
             $this->out->elementEnd('dd');
             $this->out->elementEnd('dl');
         }
-        if ($this->profile->location !== '') {
+        if (!empty($this->profile->location)) {
             $this->out->elementStart('dl', 'entity_location');
             $this->out->element('dt', null, _('Location'));
             $this->out->elementStart('dd', 'label');
@@ -127,7 +127,7 @@ class ProfileList extends Widget
             $this->out->elementEnd('dd');
             $this->out->elementEnd('dl');
         }
-        if ($this->profile->homepage !== '') {
+        if (!empty($this->profile->homepage)) {
             $this->out->elementStart('dl', 'entity_url');
             $this->out->element('dt', null, _('URL'));
             $this->out->elementStart('dd');
@@ -138,7 +138,7 @@ class ProfileList extends Widget
             $this->out->elementEnd('dd');
             $this->out->elementEnd('dl');
         }
-        if ($this->profile->bio !== '') {
+        if (!empty($this->profile->bio)) {
             $this->out->elementStart('dl', 'entity_note');
             $this->out->element('dt', null, _('Note'));
             $this->out->elementStart('dd', 'note');
@@ -194,11 +194,12 @@ class ProfileList extends Widget
 
         $this->out->elementStart('ul');
 
-        if (!$is_own) {
-            # XXX: special-case for user looking at own
-            # subscriptions page
+        // Is this a logged-in user, looking at someone else's
+        // profile?
+
+        if (!empty($user) && $this->profile->id != $user->id) {
             $this->out->elementStart('li', 'entity_subscribe');
-            if (!is_null($user) && $user->isSubscribed($this->profile)) {
+            if ($user->isSubscribed($this->profile)) {
                 $usf = new UnsubscribeForm($this->out, $this->profile);
                 $usf->show();
             } else {
@@ -207,6 +208,9 @@ class ProfileList extends Widget
             }
             $this->out->elementEnd('li');
             $this->out->elementStart('li', 'entity_block');
+            if ($user->id == $this->owner->id) {
+                $this->showBlockForm();
+            }
             $this->out->elementEnd('li');
         }
 

From a1e37b2bd26e817a6fb1e3781c787de66d530cb6 Mon Sep 17 00:00:00 2001
From: Evan Prodromou <evan@controlyourself.ca>
Date: Mon, 23 Mar 2009 15:44:17 -0400
Subject: [PATCH 24/38] show subscribe button and block form again

---
 lib/profilelist.php | 20 ++++++++++++--------
 1 file changed, 12 insertions(+), 8 deletions(-)

diff --git a/lib/profilelist.php b/lib/profilelist.php
index bd9b51958c..a4cc235552 100644
--- a/lib/profilelist.php
+++ b/lib/profilelist.php
@@ -109,7 +109,7 @@ class ProfileList extends Widget
         $this->out->elementEnd('span');
         $this->out->elementEnd('a');
 
-        if ($this->profile->fullname !== '') {
+        if (!empty($this->profile->fullname)) {
             $this->out->elementStart('dl', 'entity_fn');
             $this->out->element('dt', null, 'Full name');
             $this->out->elementStart('dd');
@@ -119,7 +119,7 @@ class ProfileList extends Widget
             $this->out->elementEnd('dd');
             $this->out->elementEnd('dl');
         }
-        if ($this->profile->location !== '') {
+        if (!empty($this->profile->location)) {
             $this->out->elementStart('dl', 'entity_location');
             $this->out->element('dt', null, _('Location'));
             $this->out->elementStart('dd', 'label');
@@ -127,7 +127,7 @@ class ProfileList extends Widget
             $this->out->elementEnd('dd');
             $this->out->elementEnd('dl');
         }
-        if ($this->profile->homepage !== '') {
+        if (!empty($this->profile->homepage)) {
             $this->out->elementStart('dl', 'entity_url');
             $this->out->element('dt', null, _('URL'));
             $this->out->elementStart('dd');
@@ -138,7 +138,7 @@ class ProfileList extends Widget
             $this->out->elementEnd('dd');
             $this->out->elementEnd('dl');
         }
-        if ($this->profile->bio !== '') {
+        if (!empty($this->profile->bio)) {
             $this->out->elementStart('dl', 'entity_note');
             $this->out->element('dt', null, _('Note'));
             $this->out->elementStart('dd', 'note');
@@ -194,11 +194,12 @@ class ProfileList extends Widget
 
         $this->out->elementStart('ul');
 
-        if (!$is_own) {
-            # XXX: special-case for user looking at own
-            # subscriptions page
+        // Is this a logged-in user, looking at someone else's
+        // profile?
+
+        if (!empty($user) && $this->profile->id != $user->id) {
             $this->out->elementStart('li', 'entity_subscribe');
-            if (!is_null($user) && $user->isSubscribed($this->profile)) {
+            if ($user->isSubscribed($this->profile)) {
                 $usf = new UnsubscribeForm($this->out, $this->profile);
                 $usf->show();
             } else {
@@ -207,6 +208,9 @@ class ProfileList extends Widget
             }
             $this->out->elementEnd('li');
             $this->out->elementStart('li', 'entity_block');
+            if ($user->id == $this->owner->id) {
+                $this->showBlockForm();
+            }
             $this->out->elementEnd('li');
         }
 

From 24ce3928e3599389bf80931f4149f3485e505360 Mon Sep 17 00:00:00 2001
From: Evan Prodromou <evan@controlyourself.ca>
Date: Mon, 23 Mar 2009 16:37:13 -0400
Subject: [PATCH 25/38] fix sql error in notice source script

---
 db/notice_source.sql | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/db/notice_source.sql b/db/notice_source.sql
index 76cff1ff86..d28a09383f 100644
--- a/db/notice_source.sql
+++ b/db/notice_source.sql
@@ -45,4 +45,4 @@ VALUES
     ('twitux','Twitux','http://live.gnome.org/DanielMorales/Twitux', now()),
     ('twitvim','TwitVim','http://vim.sourceforge.net/scripts/script.php?script_id=2204', now()),
     ('urfastr','urfastr','http://urfastr.net/', now()),
-    ('adium', 'Adium', 'http://www.adiumx.com/', now()));
+    ('adium', 'Adium', 'http://www.adiumx.com/', now());

From fc6b7e28d46dea9526fbda0c56747dd2d4d960e9 Mon Sep 17 00:00:00 2001
From: CiaranG <ciaran@ciarang.com>
Date: Mon, 23 Mar 2009 22:45:03 +0000
Subject: [PATCH 26/38] Fixed jabber code broken in
 3ef4f251acbe8ebdfd9d7f1ea43b7344b7332b73

---
 lib/jabber.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/jabber.php b/lib/jabber.php
index 9108d1c478..7d584ad016 100644
--- a/lib/jabber.php
+++ b/lib/jabber.php
@@ -179,7 +179,7 @@ function jabber_format_entry($profile, $notice)
     $xs->elementEnd('body');
     $xs->elementEnd('html');
 
-    $html = $xs->asString();
+    $html = $xs->getString();
 
     return $html . ' ' . $entry;
 }

From 88269b288a2b62543cf867d92b6e7cc41d44b922 Mon Sep 17 00:00:00 2001
From: CiaranG <ciaran@ciarang.com>
Date: Tue, 24 Mar 2009 08:05:02 +0000
Subject: [PATCH 27/38] Fix to Korean language selection - see ticket #1351

---
 lib/language.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/language.php b/lib/language.php
index 6791df699d..cd6498d30b 100644
--- a/lib/language.php
+++ b/lib/language.php
@@ -115,7 +115,7 @@ function get_all_languages() {
 		'he'      => array('q' => 0.5, 'lang' => 'he_IL', 'name' => 'Hebrew', 'direction' => 'rtl'),
 		'it'      => array('q' => 1, 'lang' => 'it_IT', 'name' => 'Italian', 'direction' => 'ltr'),
 		'jp'      => array('q' => 0.5, 'lang' => 'ja_JP', 'name' => 'Japanese', 'direction' => 'ltr'),
-		'ko'      => array('q' => 0.9, 'lang' => 'ko',    'name' => 'Korean', 'direction' => 'ltr'),
+		'ko'      => array('q' => 0.9, 'lang' => 'ko_KR',    'name' => 'Korean', 'direction' => 'ltr'),
 		'mk'      => array('q' => 0.5, 'lang' => 'mk_MK', 'name' => 'Macedonian', 'direction' => 'ltr'),
 		'nb'      => array('q' => 0.1, 'lang' => 'nb_NO', 'name' => 'Norwegian (Bokmål)', 'direction' => 'ltr'),
 		'no'      => array('q' => 0.1, 'lang' => 'nb_NO', 'name' => 'Norwegian (Bokmål)', 'direction' => 'ltr'),

From a148569705b252c334925160a7972c3da140e374 Mon Sep 17 00:00:00 2001
From: Evan Prodromou <evan@controlyourself.ca>
Date: Tue, 24 Mar 2009 10:29:30 -0400
Subject: [PATCH 28/38] include text of notice in favourites notification

---
 lib/mail.php | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/lib/mail.php b/lib/mail.php
index dde7571ebe..27a1d99dcb 100644
--- a/lib/mail.php
+++ b/lib/mail.php
@@ -554,17 +554,19 @@ function mail_notify_fave($other, $user, $notice)
 
     $body = sprintf(_("%1\$s just added your notice from %2\$s".
                       " as one of their favorites.\n\n" .
-                      "In case you forgot, you can see the text".
-                      " of your notice here:\n\n" .
+                      "The URL of your notice is:\n\n" .
                       "%3\$s\n\n" .
-                      "You can see the list of %1\$s's favorites here:\n\n" .
+                      "The text of your notice is:\n\n" .
                       "%4\$s\n\n" .
+                      "You can see the list of %1\$s's favorites here:\n\n" .
+                      "%5\$s\n\n" .
                       "Faithfully yours,\n" .
-                      "%5\$s\n"),
+                      "%6\$s\n"),
                     $bestname,
                     common_exact_date($notice->created),
                     common_local_url('shownotice',
                                      array('notice' => $notice->id)),
+                    $notice->content,
                     common_local_url('showfavorites',
                                      array('nickname' => $user->nickname)),
                     common_config('site', 'name'));

From 2c8f67f6a9b4e93161e7cae0c38162cb8991e0ef Mon Sep 17 00:00:00 2001
From: CiaranG <ciaran@ciarang.com>
Date: Wed, 25 Mar 2009 15:39:58 +0000
Subject: [PATCH 29/38] A different search pagination fix (see ticket #1333)
 that doesn't require fixing the upstream code, thus undoing the change made
 in d64be5108d69ff4068d4383ab121a3ba7388ada3

---
 extlib/Net/URL/Mapper/Path.php |  9 ++-------
 lib/router.php                 | 12 +++++++++++-
 2 files changed, 13 insertions(+), 8 deletions(-)

diff --git a/extlib/Net/URL/Mapper/Path.php b/extlib/Net/URL/Mapper/Path.php
index eb1c34a3fa..b541002c7a 100644
--- a/extlib/Net/URL/Mapper/Path.php
+++ b/extlib/Net/URL/Mapper/Path.php
@@ -241,12 +241,7 @@ class Net_URL_Mapper_Path
         }
         $path = '/'.trim(Net_URL::resolvePath($path), '/');
         if (!empty($qstring)) {
-            if (!strpos($path, '?')) {
-                $path .= '?';
-            } else {
-                $path .= '&';
-            }
-	    $path .= http_build_query($qstring);
+            $path .= '?'.http_build_query($qstring);
         }
         if (!empty($anchor)) {
             $path .= '#'.ltrim($anchor, '#');
@@ -432,4 +427,4 @@ class Net_URL_Mapper_Path
 
 }
 
-?>
+?>
\ No newline at end of file
diff --git a/lib/router.php b/lib/router.php
index 83b3ffe607..d1217ca3ce 100644
--- a/lib/router.php
+++ b/lib/router.php
@@ -437,6 +437,16 @@ class Router
 
         if($params!=null)
 	    common_log(LOG_DEBUG,"generate args:".print_r($args,true));
-        return $this->m->generate($args, $params, $fragment);
+        $url=$this->m->generate($args, $params, $fragment);
+
+        // Due to a bug in the Net_URL_Mapper code, the returned URL may
+        // contain a malformed query of the form ?p1=v1?p2=v2?p3=v3. We
+        // repair that here rather than modifying the upstream code...
+        $qpos = strpos($url,'?');
+        if ($qpos !== false) {
+            $url = substr($url, 0, $qpos+1) .
+	              str_replace('?', '&', substr($url, $qpos+1));
+        }
+        return $url;
     }
 }

From d92926f892d72b631ba7ec3447eb73caf9ff03bd Mon Sep 17 00:00:00 2001
From: CiaranG <ciaran@ciarang.com>
Date: Sat, 21 Mar 2009 14:24:19 +0000
Subject: [PATCH 30/38] Fix to Net_URL_Mapper to make search pagination work.
 See Ticket #1333

---
 extlib/Net/URL/Mapper/Path.php | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/extlib/Net/URL/Mapper/Path.php b/extlib/Net/URL/Mapper/Path.php
index b541002c7a..eb1c34a3fa 100644
--- a/extlib/Net/URL/Mapper/Path.php
+++ b/extlib/Net/URL/Mapper/Path.php
@@ -241,7 +241,12 @@ class Net_URL_Mapper_Path
         }
         $path = '/'.trim(Net_URL::resolvePath($path), '/');
         if (!empty($qstring)) {
-            $path .= '?'.http_build_query($qstring);
+            if (!strpos($path, '?')) {
+                $path .= '?';
+            } else {
+                $path .= '&';
+            }
+	    $path .= http_build_query($qstring);
         }
         if (!empty($anchor)) {
             $path .= '#'.ltrim($anchor, '#');
@@ -427,4 +432,4 @@ class Net_URL_Mapper_Path
 
 }
 
-?>
\ No newline at end of file
+?>

From 55e8a6ca1b0af8e05a7ee22735585ef5ebd66fc6 Mon Sep 17 00:00:00 2001
From: CiaranG <ciaran@ciarang.com>
Date: Wed, 25 Mar 2009 15:39:58 +0000
Subject: [PATCH 31/38] A different search pagination fix (see ticket #1333)
 that doesn't require fixing the upstream code, thus undoing the change made
 in d64be5108d69ff4068d4383ab121a3ba7388ada3

Merged.
---
 extlib/Net/URL/Mapper/Path.php |  9 ++-------
 lib/router.php                 | 12 +++++++++++-
 2 files changed, 13 insertions(+), 8 deletions(-)

diff --git a/extlib/Net/URL/Mapper/Path.php b/extlib/Net/URL/Mapper/Path.php
index eb1c34a3fa..b541002c7a 100644
--- a/extlib/Net/URL/Mapper/Path.php
+++ b/extlib/Net/URL/Mapper/Path.php
@@ -241,12 +241,7 @@ class Net_URL_Mapper_Path
         }
         $path = '/'.trim(Net_URL::resolvePath($path), '/');
         if (!empty($qstring)) {
-            if (!strpos($path, '?')) {
-                $path .= '?';
-            } else {
-                $path .= '&';
-            }
-	    $path .= http_build_query($qstring);
+            $path .= '?'.http_build_query($qstring);
         }
         if (!empty($anchor)) {
             $path .= '#'.ltrim($anchor, '#');
@@ -432,4 +427,4 @@ class Net_URL_Mapper_Path
 
 }
 
-?>
+?>
\ No newline at end of file
diff --git a/lib/router.php b/lib/router.php
index e39dc217a3..135e07a0f0 100644
--- a/lib/router.php
+++ b/lib/router.php
@@ -429,6 +429,16 @@ class Router
             $args = $action_arg;
         }
 
-        return $this->m->generate($args, $params, $fragment);
+        $url = $this->m->generate($args, $params, $fragment);
+
+        // Due to a bug in the Net_URL_Mapper code, the returned URL may
+        // contain a malformed query of the form ?p1=v1?p2=v2?p3=v3. We
+        // repair that here rather than modifying the upstream code...
+        $qpos = strpos($url,'?');
+        if ($qpos !== false) {
+            $url = substr($url, 0, $qpos+1) .
+	              str_replace('?', '&', substr($url, $qpos+1));
+        }
+        return $url;
     }
 }

From 1116526f0855af47b353722907c57e1b4285cddc Mon Sep 17 00:00:00 2001
From: Evan Prodromou <evan@controlyourself.ca>
Date: Wed, 25 Mar 2009 12:32:46 -0400
Subject: [PATCH 32/38] fixed pagination variable problem

---
 actions/noticesearch.php | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/actions/noticesearch.php b/actions/noticesearch.php
index eb4a072def..9058cf53c3 100644
--- a/actions/noticesearch.php
+++ b/actions/noticesearch.php
@@ -122,9 +122,10 @@ class NoticesearchAction extends SearchAction
 
         $cnt = $nl->show();
 
-        $this->pagination($this->page > 1, $cnt > NOTICES_PER_PAGE,
-                          $this->page, 'noticesearch', array('q' => $q));
+        $this->pagination($page > 1, $cnt > NOTICES_PER_PAGE,
+                          $page, 'noticesearch', array('q' => $q));
     }
+
     function isReadOnly()
     {
         return true;

From a13bfa5848705d23353783f195b67c088a72a8cb Mon Sep 17 00:00:00 2001
From: Sarven Capadisli <csarven@controlyourself.ca>
Date: Wed, 25 Mar 2009 18:16:20 +0000
Subject: [PATCH 33/38] Ticket http://laconi.ca/trac/ticket/1274

Minimised form_notice markup by removing unordered lists. There is a minor CSS
rule reassignment done by changing the selectors. There is no visual
change in the final result.
---
 lib/messageform.php        | 10 --------
 lib/noticeform.php         |  9 -------
 theme/base/css/display.css | 51 +++++++-------------------------------
 3 files changed, 9 insertions(+), 61 deletions(-)

diff --git a/lib/messageform.php b/lib/messageform.php
index f415083057..b8878ec1f9 100644
--- a/lib/messageform.php
+++ b/lib/messageform.php
@@ -132,20 +132,14 @@ class MessageForm extends Form
         $mutual_users->free();
         unset($mutual_users);
 
-        $this->out->elementStart('ul', 'form_data');
-        $this->out->elementStart('li', array('id' => 'notice_to'));
         $this->out->dropdown('to', _('To'), $mutual, null, false,
                              ($this->to) ? $this->to->id : null);
-        $this->out->elementEnd('li');
 
-        $this->out->elementStart('li', array('id' => 'notice_text'));
         $this->out->element('textarea', array('id' => 'notice_data-text',
                                               'cols' => 35,
                                               'rows' => 4,
                                               'name' => 'content'),
                             ($this->content) ? $this->content : '');
-        $this->out->elementEnd('li');
-        $this->out->elementEnd('ul');
     }
 
     /**
@@ -156,14 +150,10 @@ class MessageForm extends Form
 
     function formActions()
     {
-        $this->out->elementStart('ul', 'form_actions');
-        $this->out->elementStart('li', array('id' => 'notice_submit'));
         $this->out->element('input', array('id' => 'notice_action-submit',
                                            'class' => 'submit',
                                            'name' => 'message_send',
                                            'type' => 'submit',
                                            'value' => _('Send')));
-        $this->out->elementEnd('li');
-        $this->out->elementEnd('ul');
     }
 }
diff --git a/lib/noticeform.php b/lib/noticeform.php
index 0c991c9695..606b5d028e 100644
--- a/lib/noticeform.php
+++ b/lib/noticeform.php
@@ -134,9 +134,6 @@ class NoticeForm extends Form
 
     function formData()
     {
-
-        $this->out->elementStart('ul', 'form_data');
-        $this->out->elementStart('li', array('id' => 'notice_text'));
         $this->out->element('label', array('for' => 'notice_data-text'),
                             sprintf(_('What\'s up, %s?'), $this->user->nickname));
         // XXX: vary by defined max size
@@ -145,8 +142,6 @@ class NoticeForm extends Form
                                               'rows' => 4,
                                               'name' => 'status_textarea'),
                             ($this->content) ? $this->content : '');
-        $this->out->elementEnd('li');
-        $this->out->elementEnd('ul');
 
         $this->out->elementStart('dl', 'form_note');
         $this->out->element('dt', null, _('Available characters'));
@@ -168,14 +163,10 @@ class NoticeForm extends Form
 
     function formActions()
     {
-        $this->out->elementStart('ul', 'form_actions');
-        $this->out->elementStart('li', array('id' => 'notice_submit'));
         $this->out->element('input', array('id' => 'notice_action-submit',
                                            'class' => 'submit',
                                            'name' => 'status_submit',
                                            'type' => 'submit',
                                            'value' => _('Send')));
-        $this->out->elementEnd('li');
-        $this->out->elementEnd('ul');
     }
 }
diff --git a/theme/base/css/display.css b/theme/base/css/display.css
index a10ec0223c..90cd00d553 100644
--- a/theme/base/css/display.css
+++ b/theme/base/css/display.css
@@ -421,6 +421,7 @@ padding:0;
 display:none;
 }
 #form_notice textarea {
+float:left;
 border-radius:7px;
 -moz-border-radius:7px;
 -webkit-border-radius:7px;
@@ -431,30 +432,19 @@ padding:7px 7px 16px 7px;
 }
 #form_notice label {
 display:block;
+float:left;
 font-size:1.3em;
 margin-bottom:7px;
 }
-#form_notice .form_data li {
-float:left;
-}
-
-#form_notice #notice_attach_file label,
 #form_notice #notice_submit label {
 display:none;
 }
-
-#form_notice #notice_attachment {
-margin-top:25px;
-margin-left:4px;
-}
-
 #form_notice .form_note {
 position:absolute;
 top:99px;
 right:98px;
 z-index:9;
 }
-
 #form_notice .form_note dt {
 font-weight:bold;
 display:none;
@@ -464,42 +454,19 @@ font-weight:bold;
 line-height:1.15;
 padding:1px 2px;
 }
-
-#form_notice #notice_data-attach_view {
-position:absolute;
-top:25px;
-right:30px;
-margin-left:4px;
-padding:0;
-width:16px;
-height:16px;
-border:0;
-text-indent:-9999px;
-}
-#form_notice .form_actions {
+#form_notice #notice_action-submit {
+width:60px;
+padding:8px;
 position:absolute;
 bottom:0;
 right:0;
 }
-#form_notice .form_actions input.submit {
-width:60px;
-padding:8px;
-}
-
-#form_notice li {
-margin-bottom:0;
-}
-
-#form_notice #notice_to {
-margin-bottom:7px;
-}
-
-#notice_to label {
-float:left;
-margin-right:18px;
+#form_notice label[for=to] {
 margin-top:11px;
 }
-#notice_to select {
+#form_notice select[id=to] {
+margin-bottom:7px;
+margin-left:18px;
 float:left;
 }
 /*end FORM NOTICE*/

From a7d8f7197e87fd7cbed8b58e07b3904929adf0c5 Mon Sep 17 00:00:00 2001
From: Sarven Capadisli <csarven@controlyourself.ca>
Date: Wed, 25 Mar 2009 22:48:51 +0000
Subject: [PATCH 34/38] Alignment of notice-options in IE6

---
 theme/base/css/ie6.css | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/theme/base/css/ie6.css b/theme/base/css/ie6.css
index 10b31cbcb5..fa6ec92d2f 100644
--- a/theme/base/css/ie6.css
+++ b/theme/base/css/ie6.css
@@ -9,3 +9,6 @@ margin-left:0;
 .entity_profile .entity_depiction {
 margin-bottom:123px;
 }
+.notice div.entry-content {
+width:63%;
+}

From 90e5f01f8af656a3475dc99592a4b13dc1851350 Mon Sep 17 00:00:00 2001
From: Sarven Capadisli <csarven@controlyourself.ca>
Date: Wed, 25 Mar 2009 22:53:21 +0000
Subject: [PATCH 35/38] Processing indicator (aka spinner thingy) for
 form_notice submits

---
 js/util.js                                  |   2 ++
 theme/base/images/icons/icon_processing.gif | Bin 0 -> 673 bytes
 theme/identica/css/display.css              |   6 +++++-
 3 files changed, 7 insertions(+), 1 deletion(-)
 create mode 100644 theme/base/images/icons/icon_processing.gif

diff --git a/js/util.js b/js/util.js
index 3ad0386122..81139744ff 100644
--- a/js/util.js
+++ b/js/util.js
@@ -161,6 +161,7 @@ $(document).ready(function(){
 																				$("#form_notice").addClass("warning");
 																				return false;
 																		   }
+																		   $("#form_notice").addClass("processing");
 																		   $("#notice_action-submit").attr("disabled", "disabled");
 																		   $("#notice_action-submit").addClass("disabled");
 																		   return true;
@@ -179,6 +180,7 @@ $(document).ready(function(){
 													NoticeHover();
 													NoticeReply();
 												}
+												$("#form_notice").removeClass("processing");
 												$("#notice_action-submit").removeAttr("disabled");
 												$("#notice_action-submit").removeClass("disabled");
 											 }
diff --git a/theme/base/images/icons/icon_processing.gif b/theme/base/images/icons/icon_processing.gif
new file mode 100644
index 0000000000000000000000000000000000000000..d0bce1542342e912da81a2c260562df172f30d73
GIT binary patch
literal 673
zcmZ?wbhEHb6krfw_{6~Q|Nnmm28Kh24mmkF0U1e2Nli^nlO|14{Lk&@8WQa67~pE8
zXTZz|lvDgC<y@4SSdyBeP@Y+mp^%uBSdo*Tn4*`NmzK|<_>+Z`3#dv5h=E26FfcG1
zbL_hF&)}42ws10s6^G;;cE1^EoUR)U5A70}d2pLv!jVIT7j&Z~EblI3x0K*v_sV|m
z0kj3v921Z^em#l`(k(o@H$3ZdDRc@9NidXDNbqrumReCGv$gd8+e8WW28HVqkJ_9i
zH>s*<31KtHjANIPvi2#*6BEu%3Dak5O_t&NBI)<h(<yPr>H?V$TxT}#l{vOTn<?_G
z_#ejR!~8}oQ>5naXTfF^&~Hhq+NX@#Ccc>y7T?;vjI&jdhsDsPJyAw*m0Qz>i}K7#
zL9w50<qa%!r20=RDYEpz>Ng{fT}A5JUe8lRK1h7_Y2;BWJDd=c6f&i?Wv5(5q?6|P
zQw{>maxZP<537OA37Uk}7@%_$4o$EWe_Zl>&#id|lE-BpDC#+Fn|msJ%_2h{Hg1vP
z#N8WAzfWasG}yq|xqE)DrWaOofX=z|?*pgc%{ig5vl!pqDlC|q&~Z0$&Rvsft&VO-
z4MZj+%-+Vx%W}v;V76hyp=;+R;x+~t^Q%*xuFTQAF2})fSfTHDAs>sO!OBw`)&)o$
c0!CNZt))x~rAZP^^P&YOFfdqy5)K#u0POD40{{R3

literal 0
HcmV?d00001

diff --git a/theme/identica/css/display.css b/theme/identica/css/display.css
index 576a2e14be..69be116233 100644
--- a/theme/identica/css/display.css
+++ b/theme/identica/css/display.css
@@ -94,7 +94,11 @@ color:#333;
 #form_notice.warning #notice_text-count {
 color:#000;
 }
-
+#form_notice.processing #notice_action-submit {
+background:#fff url(../../base/images/icons/icon_processing.gif) no-repeat 47% 47%;
+cursor:wait;
+text-indent:-9999px;
+}
 
 #nav_register a {
 text-decoration:none;

From 4eb59da0389862cc9f5a737553379fa2f679c1fb Mon Sep 17 00:00:00 2001
From: Sarven Capadisli <csarven@controlyourself.ca>
Date: Wed, 25 Mar 2009 22:59:29 +0000
Subject: [PATCH 36/38] Processing indicator CSS for the default theme

---
 theme/default/css/display.css | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/theme/default/css/display.css b/theme/default/css/display.css
index 85b5aa13e5..bb0b84a67a 100644
--- a/theme/default/css/display.css
+++ b/theme/default/css/display.css
@@ -94,6 +94,11 @@ color:#333;
 #form_notice.warning #notice_text-count {
 color:#000;
 }
+#form_notice.processing #notice_action-submit {
+background:#fff url(../../base/images/icons/icon_processing.gif) no-repeat 47% 47%;
+cursor:wait;
+text-indent:-9999px;
+}
 
 
 #nav_register a {

From e810077c0e958b6c6a28a66dc9fe2ade21600dd3 Mon Sep 17 00:00:00 2001
From: Sarven Capadisli <csarven@controlyourself.ca>
Date: Wed, 25 Mar 2009 23:18:55 +0000
Subject: [PATCH 37/38] Processing indicator image for the default theme

---
 theme/default/images/icons/icon_processing.gif | Bin 0 -> 673 bytes
 1 file changed, 0 insertions(+), 0 deletions(-)
 create mode 100644 theme/default/images/icons/icon_processing.gif

diff --git a/theme/default/images/icons/icon_processing.gif b/theme/default/images/icons/icon_processing.gif
new file mode 100644
index 0000000000000000000000000000000000000000..d0bce1542342e912da81a2c260562df172f30d73
GIT binary patch
literal 673
zcmZ?wbhEHb6krfw_{6~Q|Nnmm28Kh24mmkF0U1e2Nli^nlO|14{Lk&@8WQa67~pE8
zXTZz|lvDgC<y@4SSdyBeP@Y+mp^%uBSdo*Tn4*`NmzK|<_>+Z`3#dv5h=E26FfcG1
zbL_hF&)}42ws10s6^G;;cE1^EoUR)U5A70}d2pLv!jVIT7j&Z~EblI3x0K*v_sV|m
z0kj3v921Z^em#l`(k(o@H$3ZdDRc@9NidXDNbqrumReCGv$gd8+e8WW28HVqkJ_9i
zH>s*<31KtHjANIPvi2#*6BEu%3Dak5O_t&NBI)<h(<yPr>H?V$TxT}#l{vOTn<?_G
z_#ejR!~8}oQ>5naXTfF^&~Hhq+NX@#Ccc>y7T?;vjI&jdhsDsPJyAw*m0Qz>i}K7#
zL9w50<qa%!r20=RDYEpz>Ng{fT}A5JUe8lRK1h7_Y2;BWJDd=c6f&i?Wv5(5q?6|P
zQw{>maxZP<537OA37Uk}7@%_$4o$EWe_Zl>&#id|lE-BpDC#+Fn|msJ%_2h{Hg1vP
z#N8WAzfWasG}yq|xqE)DrWaOofX=z|?*pgc%{ig5vl!pqDlC|q&~Z0$&Rvsft&VO-
z4MZj+%-+Vx%W}v;V76hyp=;+R;x+~t^Q%*xuFTQAF2})fSfTHDAs>sO!OBw`)&)o$
c0!CNZt))x~rAZP^^P&YOFfdqy5)K#u0POD40{{R3

literal 0
HcmV?d00001


From 959d9eda2304df317719ff9768cb555210c98ad0 Mon Sep 17 00:00:00 2001
From: Sarven Capadisli <csarven@controlyourself.ca>
Date: Wed, 25 Mar 2009 23:40:33 +0000
Subject: [PATCH 38/38] Unused file.

---
 theme/default/images/icons/icon_processing.gif | Bin 673 -> 0 bytes
 1 file changed, 0 insertions(+), 0 deletions(-)
 delete mode 100644 theme/default/images/icons/icon_processing.gif

diff --git a/theme/default/images/icons/icon_processing.gif b/theme/default/images/icons/icon_processing.gif
deleted file mode 100644
index d0bce1542342e912da81a2c260562df172f30d73..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 673
zcmZ?wbhEHb6krfw_{6~Q|Nnmm28Kh24mmkF0U1e2Nli^nlO|14{Lk&@8WQa67~pE8
zXTZz|lvDgC<y@4SSdyBeP@Y+mp^%uBSdo*Tn4*`NmzK|<_>+Z`3#dv5h=E26FfcG1
zbL_hF&)}42ws10s6^G;;cE1^EoUR)U5A70}d2pLv!jVIT7j&Z~EblI3x0K*v_sV|m
z0kj3v921Z^em#l`(k(o@H$3ZdDRc@9NidXDNbqrumReCGv$gd8+e8WW28HVqkJ_9i
zH>s*<31KtHjANIPvi2#*6BEu%3Dak5O_t&NBI)<h(<yPr>H?V$TxT}#l{vOTn<?_G
z_#ejR!~8}oQ>5naXTfF^&~Hhq+NX@#Ccc>y7T?;vjI&jdhsDsPJyAw*m0Qz>i}K7#
zL9w50<qa%!r20=RDYEpz>Ng{fT}A5JUe8lRK1h7_Y2;BWJDd=c6f&i?Wv5(5q?6|P
zQw{>maxZP<537OA37Uk}7@%_$4o$EWe_Zl>&#id|lE-BpDC#+Fn|msJ%_2h{Hg1vP
z#N8WAzfWasG}yq|xqE)DrWaOofX=z|?*pgc%{ig5vl!pqDlC|q&~Z0$&Rvsft&VO-
z4MZj+%-+Vx%W}v;V76hyp=;+R;x+~t^Q%*xuFTQAF2})fSfTHDAs>sO!OBw`)&)o$
c0!CNZt))x~rAZP^^P&YOFfdqy5)K#u0POD40{{R3