eliseuamaro/gnu-social
1
0
Fork 0
forked from GNUsocial/gnu-social
Code Issues Pull Requests Releases Wiki Activity

Ticket 2135: trim overlong repeats with ellipsis rather than failing.

Browse Source 
In web interface and retweet/repeat API we show the original untrimmed text, but some back-compat API messages will still show the trimmed 'RT' version.
This matches Twitter's behavior on overlong retweets, though we're outputting the RT version in more API results than they do.
This commit is contained in:
Brion Vibber 2010-01-05 15:04:08 -08:00
parent 7491274c0e
commit eb22d2d240
1 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
classes/Notice.php
View File

@ -1366,12 +1366,21 @@ class Notice extends Memcached_DataObject
{ {
$author = Profile::staticGet('id', $this->profile_id); $author = Profile::staticGet('id', $this->profile_id);
// FIXME: truncate on long repeats...?
$content = sprintf(_('RT @%1$s %2$s'), $content = sprintf(_('RT @%1$s %2$s'),
$author->nickname, $author->nickname,
$this->content); $this->content);
$maxlen = common_config('site', 'textlimit');
if (mb_strlen($content) > $maxlen) {
// Web interface and current Twitter API clients will
// pull the original notice's text, but some older
// clients and RSS/Atom feeds will see this trimmed text.
//
// Unfortunately this is likely to lose tags or URLs
// at the end of long notices.
$content = mb_substr($content, 0, $maxlen - 4) . ' ...';
}
return self::saveNew($repeater_id, $content, $source, return self::saveNew($repeater_id, $content, $source,
array('repeat_of' => $this->id)); array('repeat_of' => $this->id));
} }