Mikael Nordfeldth
3bc2454e91
Avoid excessive remote requests on oEmbed lookups
...
I noticed that each time a notice was accessed it'd do a remote lookup
with HEAD (and continue despite 404 etc.) and then another attempt to
download the resource. If this wasn't successful new attempts would be
made for each loading of the resource, which is extremely resource
intensive.
Whenever we can say "it's been n seconds since the last attempt" we
could probably enable this again - or just manually reload remote
thumbnails (as part of the StoreRemoteMedia plugin etc.)
2017-07-10 14:41:03 +02:00
Mikael Nordfeldth
3395f6081c
Endless loop nesting on ensureHub failure now fixed
...
Essentially I was missing a negation on a test if we were in rediscovery mode.
2017-06-22 14:37:32 +02:00
Mikael Nordfeldth
fa44e0c06e
set a 'rediscovered' parameter to avoid nesting into an ensureHub loop forever
2017-06-22 00:30:38 +02:00
Mikael Nordfeldth
e8eb9f9614
Less raw database dumps in debug please
2017-05-02 09:18:43 +02:00
Mikael Nordfeldth
e9ab06b59e
Fix issues with non-subscribed Ostatus_profiles
2017-05-02 09:14:30 +02:00
Mikael Nordfeldth
06b25f384a
File_redirection->getFile could never get the file anyway if $redir->file_id was empty...
2017-05-02 09:07:00 +02:00
Mikael Nordfeldth
5af5bb2a32
Show WebSub state on remote user profiles
2017-05-01 21:18:04 +02:00
Mikael Nordfeldth
caa5fb75b3
Introduce neat function getFeedSub() on Ostatus_profile
2017-05-01 21:17:22 +02:00
Mikael Nordfeldth
f4d6710a0f
Change mentions of PuSH to WebSub
...
WebSub is probably finalised before we make a release anyway. Here is
the official spec: https://www.w3.org/TR/websub/
Mostly just comments that have been changed. Some references to PuSH <0.4
are left because they actually refer to PuSH 0.3 and that's not WebSub...
The only actual code change that might affect anything is FeedSub->isPuSH()
but the only official plugin using that call was FeedPoller anyway...
2017-05-01 11:04:27 +02:00
Mikael Nordfeldth
b3da5bdaa3
Debugging log fix.
2017-05-01 10:36:55 +02:00
Mikael Nordfeldth
f6d4d00e02
I think this will stop my daemons from endlessly looping
...
I got this which ate all my memory:
queuedaemon.php:10733] HTTPClient: HTTP HEAD https://drive.google.com/file/d/*masked*/view?usp=sharing - 200 OK
queuedaemon.php:10733] Checking for remote URL metadata for https://drive.google.com/file/d/*masked*/view?usp=sharing
queuedaemon.php:10733] HTTPClient: HTTP GET https://drive.google.com/file/d/*masked*/view?usp=sharing - 200 OK
queuedaemon.php:10733] Trying to discover an oEmbed endpoint using link headers.
queuedaemon.php:10733] Could not find an oEmbed endpoint using link headers, trying OpenGraph from HTML.
queuedaemon.php:10733] HTTPClient: HTTP HEAD https://drive.google.com/file/d/*masked*/view?usp=sharing&usp=embed_facebook - 200 OK
queuedaemon.php:10733] Checking for remote URL metadata for https://drive.google.com/file/d/*masked*/view?usp=sharing&usp=embed_facebook
queuedaemon.php:10733] HTTPClient: HTTP GET https://drive.google.com/file/d/*masked*/view?usp=sharing&usp=embed_facebook - 200 OK
queuedaemon.php:10733] Trying to discover an oEmbed endpoint using link headers.
queuedaemon.php:10733] Could not find an oEmbed endpoint using link headers, trying OpenGraph from HTML.
queuedaemon.php:10733] HTTPClient: HTTP HEAD https://drive.google.com/file/d/*masked*/view?usp=sharing&usp=embed_facebook&usp=embed_facebook - 200 OK
queuedaemon.php:10733] Checking for remote URL metadata for https://drive.google.com/file/d/*masked*/view?usp=sharing&usp=embed_facebook&usp=embed_facebook
queuedaemon.php:10733] HTTPClient: HTTP GET https://drive.google.com/file/d/*masked*/view?usp=sharing&usp=embed_facebook&usp=embed_facebook - 200 OK
queuedaemon.php:10733] Trying to discover an oEmbed endpoint using link headers.
queuedaemon.php:10733] Could not find an oEmbed endpoint using link headers, trying OpenGraph from HTML.
...ad nauseam.
2017-05-01 10:27:21 +02:00
Mikael Nordfeldth
37c97ac8fc
Message to end-user on why FeedSub failed.
2017-05-01 07:40:16 +02:00
Mikael Nordfeldth
16880de8f6
ensureHub on 422 status code (Superfeedr error on non-existing topic)
2017-04-30 10:29:16 +02:00
Mikael Nordfeldth
b20b9727cf
More debugging info for FeedSub PuSH self-healing
2017-04-30 09:46:15 +02:00
Mikael Nordfeldth
e21043e81c
syntax fix (throw _new_ *Exception)
2017-04-30 09:33:06 +02:00
Mikael Nordfeldth
1ecf709918
Make sure we don't receiveFeed() in the case of that exception
2017-04-30 09:31:16 +02:00
Mikael Nordfeldth
5288a6f9e2
Update huburi for FeedSub if PuSH signature is invalid
...
This because some remote server might have used third party PuSH hubs
but switch and we don't know about it.
Possible risks here are of course MITM that could force us to rediscover
PuSH hubs from a feed they control, but that currently feels ... meh.
2017-04-30 09:20:08 +02:00
Mikael Nordfeldth
853b016a42
Separate ensureHub into function in FeedSub
2017-04-27 09:24:12 +02:00
Mikael Nordfeldth
598b51eb7a
Escaping a URI in common_debug call
2017-04-27 09:23:45 +02:00
Mikael Nordfeldth
ea6d8b8bde
LRDD blacklisted URL test
2017-04-26 23:21:13 +02:00
Mikael Nordfeldth
bb76af4f65
Test URLs against blacklist also on PuSH subscriptions.
2017-04-26 22:41:59 +02:00
Mikael Nordfeldth
df7ff4ef1a
Moving form to its own file as we do nowadays
2017-04-25 21:13:29 +02:00
Mikael Nordfeldth
c71600c144
Modernise some function calls etc, to newer GNU social standards
2017-04-25 21:03:43 +02:00
Mikael Nordfeldth
5f24fc0986
Blacklist plugin enabled by default (bug fixes will come)
2017-04-25 20:43:31 +02:00
Mikael Nordfeldth
a53284fe4f
Use getByID nistead of getKV for Feedsub in PushInQueueHandler
2017-04-25 20:42:10 +02:00
Mikael Nordfeldth
956cfaf844
Try https first on URL mention lookup
2017-04-22 12:29:53 +02:00
Mikael Nordfeldth
95f991cff3
Somewhat simpler regex. Thanks acct:takeshitakenji@gs.kawa-kun.com
2017-04-22 12:12:27 +02:00
Mikael Nordfeldth
69e944e21a
Fix URL mention regular expression FOR REALZ
2017-04-22 11:45:24 +02:00
Mikael Nordfeldth
51e5cc2ac8
Fix URL mention regular expression in OStatusPlugin
2017-04-22 11:15:55 +02:00
Mikael Nordfeldth
2fc4b174c1
Domain name regular expression into lib/framework.php
2017-04-22 11:07:38 +02:00
Mikael Nordfeldth
bd6c93a811
Split up OStatusPlugin preg functions so they can be reused
2017-04-22 11:02:41 +02:00
Mikael Nordfeldth
54971842f2
A bit more instructive debugging
2017-04-22 10:55:24 +02:00
Mikael Nordfeldth
0fd83f0028
New domain regexp for WebFinger matching.
2017-04-22 10:51:03 +02:00
Mikael Nordfeldth
e98bceec10
Import backlog on new subscription.
...
Danger is when importing a new feed that may be maliciously crafted
to contain a zillion entries.
2017-04-21 09:31:27 +02:00
Mikael Nordfeldth
f51cb6fca9
Split OStatusPlugin FeedSub receive into two parts
...
FeedSub::receive now only handles the PuSH verification
FeedSub::receiveFeed is protected and only parses+imports feed XML
2017-04-21 08:13:39 +02:00
Mikael Nordfeldth
e87115d462
Less frightening interface on remote subscription
...
Instead of an error message in a red box about being unable to find the
profile, you get the title "Remote subscription" and no error message.
2017-04-19 11:41:34 +02:00
Mikael Nordfeldth
548e59fc99
Empty resource would throw exception
...
The "+ Remote" link on your profile page broke because of exception.
2017-04-19 11:37:43 +02:00
Mikael Nordfeldth
35b0a9e3ae
Handle normalized acct: URIs in ostatussub
...
Mastodon sent the proper acct: URI and not just 'user@domain' when
using the remote subscribe functionality.
2017-04-16 11:01:16 +02:00
mmn
24910f2363
Merge branch 'fix-twitterbridge' into 'nightly'
...
Fix TwitterBridge imported notices not displaying in timeline
See merge request !130
2017-04-06 10:20:41 +00:00
Mikael Nordfeldth
bc1f8b5db6
Merge branch 'master' of git.gnu.io:gnu/gnu-social into nightly
...
strk's OpenID fix
2017-04-06 11:15:37 +02:00
mmn
6679ecb9d7
Merge branch 'fix-openid-removal' into 'master'
...
Fix OpenID URI removal
See merge request !138
2017-04-06 09:12:35 +00:00
Sandro Santilli
1ef206467f
Fix OpenID URI removal
...
See #252
2017-03-18 13:33:07 +01:00
Sandro Santilli
85a407e7b0
Normalize OpenID URI before checking it for validity
...
Fixes #251
2017-03-18 10:56:01 +01:00
Mikael Nordfeldth
9fead39f36
Merge branch 'master' of git.gnu.io:gnu/gnu-social
2017-03-18 01:36:35 +01:00
Mikael Nordfeldth
948744538c
StoreRemoteMedia now checks remote filesize before downloading
2017-03-18 01:35:45 +01:00
Chimo
dc7c64592b
Add var type to newListItem() parameter
...
Fixes some "Declaration of $child::method should be compatible with
$parent::method" warnings.
2017-03-16 22:57:16 -04:00
Mikael Nordfeldth
8b8e2825e3
Merge branch 'master' of git.gnu.io:gnu/gnu-social into mmn_fixes
2017-01-15 21:25:06 +01:00
Bjoern Schiessle
f198d5d110
improve status length calculation, each link is exactly 23 characters long at Twitter
2016-12-14 15:54:02 +01:00
Mikael Nordfeldth
6bfc97c95d
Less spammy logs
2016-10-22 23:24:13 +02:00
Mikael Nordfeldth
6ebc5f0bff
some debugging calls and make sure $hints['feedurl'] gets set with $feeduri in case that variable is used.
2016-10-22 23:08:44 +02:00