Mikael Nordfeldth
305c9f33a7
Registration coding cleanup
...
Mainly there was an Undefined variable: code in apiaccountregister.php
2015-01-18 13:06:12 +01:00
Mikael Nordfeldth
98afab74e2
Bad variable reference (needed $this->)
2015-01-18 12:56:17 +01:00
Mikael Nordfeldth
1d339bb118
Better test to see if uploaded media exists
2015-01-13 13:22:23 +01:00
Mikael Nordfeldth
bc51c6b64f
Those variables were set for a reason
...
The ->_subscription variable etc. were set because they were used later.
2015-01-13 12:56:56 +01:00
Mikael Nordfeldth
65c540478e
newnotice action always returns the notice's URL
...
Maybe could return conversation URL, but this will do for now.
Courtesy of the Javascript haters.
2015-01-12 12:13:34 +01:00
Mikael Nordfeldth
c7df5594d0
Simplified by adding an abstract AtompubAction
2015-01-12 03:15:41 +01:00
Mikael Nordfeldth
930b09677c
Actually use the PrimaryNoticeList in actions
2015-01-08 20:29:09 +01:00
Mikael Nordfeldth
370341ce31
Don't show notice form navs on newnotice action
2015-01-08 17:33:09 +01:00
Mikael Nordfeldth
48680942fd
Avoid undefined variables.
2014-12-06 19:56:21 +01:00
Mikael Nordfeldth
e006b73505
Revert "Report a 404 not found if no posts found for User timeline"
...
This reverts commit 5295e8d4de
.
Just reply with an empty timeline...
2014-12-04 19:45:27 +01:00
Hannes Mannerheim
b81857656f
delete groups from groups directory, for admins
2014-12-02 15:31:27 +01:00
Mikael Nordfeldth
5295e8d4de
Report a 404 not found if no posts found for User timeline
2014-11-22 12:29:13 +01:00
Mikael Nordfeldth
d1b10ee92b
Don't define a variable in a function call
2014-11-22 12:26:51 +01:00
Mikael Nordfeldth
046d070ad4
MessageCommand moved to DirectMessage plugin
2014-11-07 16:23:34 +01:00
Mikael Nordfeldth
68143ff916
DirectMessage moved into a plugin, not done yet
...
We still have to move some API calls into the new plugin.
2014-11-07 15:53:35 +01:00
Mikael Nordfeldth
7ea067a0dc
Notice_source checks in better code style
2014-11-05 19:44:22 +01:00
Roland Haeder
db704b5d10
Fixed type-hints + added assert + method getGroup().
...
Signed-off-by: Roland Haeder <roland@mxchange.org>
2014-10-25 14:26:18 +02:00
Hannes Mannerheim
54e27bc30c
shows which user we are confirming to delete
2014-10-20 16:25:42 +02:00
Mikael Nordfeldth
56b07d84c5
AtomPub missing georss namespace merge from chimo
2014-08-24 13:08:41 +02:00
chimo
e3e076a935
Adds missing georss xmlns in subscriptions AtomPub
...
Fixes 'unbound prefix: georss' validation issue.
2014-08-13 00:45:34 -04:00
Mikael Nordfeldth
9a192473d5
declared "next_id" used to set the max_id for next link
2014-08-08 11:35:38 +02:00
Mikael Nordfeldth
2766c2aeec
User timeline ActivityStreams output now has paging data
2014-08-07 22:40:55 +02:00
Mikael Nordfeldth
55db74291c
Using empty on a function return value (thanks mrvdb)
...
Source: https://gist.github.com/mrvdb/0b49dd3c580bcfbe1358
2014-07-15 18:15:36 +02:00
Mikael Nordfeldth
eb955fe629
"Notice posted" message in Ajax title for NewnoticeAction
2014-07-14 17:11:54 +02:00
Mikael Nordfeldth
ae62b91940
Unifying HTML stripping functions to common_strip_html
2014-07-14 13:52:23 +02:00
Mikael Nordfeldth
0a20abf1d8
Email notify-on-fave moved to Profile_prefs (run upgrade.php)
2014-07-13 19:46:40 +02:00
Mikael Nordfeldth
933bf0b026
Start and End EmailSaveForm events now take a scoped profile
2014-07-13 15:42:15 +02:00
Mikael Nordfeldth
c8873de08b
Start and End EmailFormData events include current profile
2014-07-13 15:33:44 +02:00
Mikael Nordfeldth
9ce06f3e82
Adapt NewnoticeAction to latest Form- and ManagedAction
2014-07-06 13:10:22 +02:00
Mikael Nordfeldth
182605cb6a
TagAction extends ManagedAction
2014-07-04 19:32:57 +02:00
Mikael Nordfeldth
4b40d6bb2a
TagprofileAction fiddled with, now doesn't require OStatus override
...
But it still doesn't quite work properly, so a lot of work is necessary for this.
2014-07-03 14:02:21 +02:00
Mikael Nordfeldth
2e77cbfa86
FormAction updates, also fixing NoticeForm CSS
2014-07-03 14:01:12 +02:00
Mikael Nordfeldth
138d26d488
Favorite "aside"-sections moved, also small fixes left from before
...
Action now has 'isAction' which compares the loaded Action with names
of classes in an array (added without the 'Action') to its own type.
2014-06-28 16:09:46 +02:00
Mikael Nordfeldth
7e597ea7cc
More Favorite pluginification (favecount, cache, menus(favecount, cache, menus))
2014-06-28 14:03:30 +02:00
Mikael Nordfeldth
7642f008fb
Bad error message in atompubmembershipfeed
2014-06-28 12:58:24 +02:00
Mikael Nordfeldth
fcdd061b4f
pluginified most of hasFave, getFaves and related calls
...
The code is now more event-driven when it comes to rendering notices
and their related HTML elements, since we can't have direct calls from
core to a plugin.
lib/activitymover.php has a function to move a Favorite activity which
will not happen now. The move must be pluginified and performed as an
event which plugins can catch on to.
2014-06-27 14:09:02 +02:00
Mikael Nordfeldth
db7cc7fa75
Favorite functionality put into plugin (not done yet)
...
Now we have to fix any code in the core which directly uses the Fave class
or any other favorite stuff, since it is pluginised and thus might not be
available on some installations.
2014-06-24 15:58:53 +02:00
Mikael Nordfeldth
53fb39a1d0
Nicknames in subscriptions list
2014-06-24 01:56:55 +02:00
Mikael Nordfeldth
414a95a784
Initial move towards microformats2
...
No validation has been attempted yet. Lots of changes left. This
is visibly not (very) different from the previous CSS layout. But
some simplifications have been made.
Might cause issues with local changes to themes and CSS. Also maybe
javascript which depends on certain legacy microformats elements.
The move to microformats2 is motivated by the announcement that all
microformats should be migrated to version 2, as of 2014-06-20 at:
http://microformats.org/2014/06/20/microformats-org-turns-9-upgrade-to-microformats2
2014-06-22 17:11:04 +02:00
Mikael Nordfeldth
e4f1c77d6b
showAvatar functions deduplicated into Widget class
2014-06-21 23:25:50 +02:00
Mikael Nordfeldth
79824a3625
Could not update avatar due to Bad Thumbnail parameters
2014-06-17 12:48:10 +02:00
Mikael Nordfeldth
5a3d74d9a8
UseFileAsThumbnailException (helps support GIFs)
2014-06-17 12:15:11 +02:00
Mikael Nordfeldth
d596513e39
Stronger typing for NoticeListItem and so
2014-06-02 00:20:27 +02:00
Mikael Nordfeldth
eb7f964598
Modernising subscribers/subscriptions to use $this->scoped/target
...
They extend GalleryAction from ProfileAction, where $this->target is set.
2014-05-28 17:00:34 +02:00
Mikael Nordfeldth
49fa34e234
Make Profile::fromUri use UnknownUriException
2014-05-26 15:05:14 +02:00
Mikael Nordfeldth
d7c40e77b2
Show more links work with AJAX-retrieved HTML
...
Attachment_ajaxAction has been removed since AttachmentAction handles
AJAX calls splendidly.
2014-05-19 00:56:21 +02:00
Mikael Nordfeldth
b0cc9292b1
Notice->repeat() function takes Profile as argument now
2014-05-18 21:03:10 +02:00
Mikael Nordfeldth
0ddc2fc417
RepeatAction extends FormAction (and ManagedAction)
2014-05-18 20:50:15 +02:00
Mikael Nordfeldth
b48e3a22bf
AttachmentAction extends to ManagedAction
...
Also moved AttachmentListItem and its extended class Attachment are moved
into separate files (autoloaded from lib/).
2014-05-18 12:59:33 +02:00
Mikael Nordfeldth
e086ef3a84
ProfileAction derivatives somewhat migrated to ManagedAction
2014-05-12 22:41:05 +02:00
Mikael Nordfeldth
cd3cff451f
ConversationTree is now a plugin (not oldschool setting)
...
Conversation trees works pretty bad with the current layout, javascript
etc. So it's best if we separate it and work on it as a side-project. The
oldschool settings are currently being deprecated (or broken out like this).
I'll wait with removing User preferences for oldschool conversation tree,
since that might be reusable data. But I guess it will go in the near future.
2014-05-12 11:51:11 +02:00
Mikael Nordfeldth
1a81188355
Use an Event to present notices conversations
2014-05-12 11:03:21 +02:00
Mikael Nordfeldth
f9481467f8
ConversationAction extends from ManagedAction
...
Also added some of the nifty autoconfiguration, such as $this->scoped,
to ConversationAction for increased code consistency.
2014-05-11 21:11:09 +02:00
Mikael Nordfeldth
be14634c5f
ConversationRepliesAction removed, Conversation is enough
2014-05-11 21:05:25 +02:00
Mikael Nordfeldth
ce23c68d1c
FileAction removed (we have AttachmentAction).
...
It seems it was only used to get a _single_ file attachment from
the posted notice, with no possibility to get multiple attachments.
If one fetches metadata about attachments for the notice, we have
enough data there to fulfill anyone's fetching dreams.
2014-05-10 12:29:34 +02:00
Mikael Nordfeldth
c075b9f730
Removed 'bookmarklet' since we have Bookmark plugin
2014-05-10 02:50:56 +02:00
Mikael Nordfeldth
1776c90cb9
Moved oEmbed stuff out to a plugin (Oembed).
2014-05-06 23:32:13 +02:00
Mikael Nordfeldth
820a21e16d
parent::handlePost() in CancelsubscriptionAction
2014-05-06 13:26:30 +02:00
Mikael Nordfeldth
10cbf8c45e
Shorter, cleaner, smarter CancelsubscriptionAction
2014-05-06 00:21:54 +02:00
Mikael Nordfeldth
7028c16d1c
Cleaning up FavorAction
2014-05-05 22:49:34 +02:00
Mikael Nordfeldth
4774a25040
Link notice posted time to local representation
...
Notice class got a 'getLocalUrl' function.
2014-05-01 14:28:53 +02:00
Mikael Nordfeldth
b77a09fdee
Notice URIs are not necessarily URLs.
...
Let's use getUrl() for URL retrieval. May throw exceptions, but
only if it's a Notice that cannot be linked like that anyway.
2014-04-30 20:44:23 +02:00
Mikael Nordfeldth
34b570352f
Fix Direct Message functionality.
2014-04-29 20:37:58 +02:00
Mikael Nordfeldth
5fd6053220
Code cleanup and enabling User object's etc. getUri()
2014-04-28 14:08:42 +02:00
Mikael Nordfeldth
37ce1f4766
Better fallback on UnsupportedMediaException
2014-04-28 12:12:06 +02:00
Mikael Nordfeldth
c862b3f355
Redirect from Attachment_thumbnailAction
...
Noone should trust an <img/> tag delivered like that anyway.
2014-04-21 21:19:45 +02:00
Mikael Nordfeldth
d59eb5e184
Dynamically generate thumbnails (see full text)
...
The File object now stores width and height of files that can
supply this kind of information. Formats which we can not read
natively in PHP do not currently benefit from this. However an
event hook will be introduced later.
The CreateFileImageThumbnail event is renamed to:
CreateFileImageThumbnailSource to clarify that the hooks should not
generate their own thumbnails but only the source image. Also it now
accepts File objects, not MediaFile objects.
The thumbnail generation is documented in the source code. For
developers, call 'getThumbnail' on a File object and hope for the best.
Default thumbnail sizes have increased to be more appealing.
2014-04-21 20:46:11 +02:00
Mikael Nordfeldth
7f3611c51c
use intval() instead of floor() for int return type
2014-04-21 19:32:08 +02:00
Mikael Nordfeldth
b3bf036975
Preparing File for dynamic thumbnail generation.
2014-04-21 12:33:26 +02:00
Mikael Nordfeldth
7ca6597c7f
Missing semi colon in showNotice class.
2014-04-19 22:20:45 +02:00
Mikael Nordfeldth
132be99506
Improve ShownoticeAction remote redirect code
2014-04-19 22:13:48 +02:00
Mikael Nordfeldth
454a9bc1c4
Use getUrl() instead of ->url in OembedAction
2014-04-19 22:05:44 +02:00
Mikael Nordfeldth
418b3c3c53
Some files got updated coding style
...
Actions have $this->scoped as the current profile which we can gladly
replace all the $cur=common_current_user() with.
And we want the prepare/handle functions to be protected. Plus only
the prepare function uses $args (which _must_ be an array).
2014-04-15 10:49:20 +02:00
Mikael Nordfeldth
c00491cd7a
Cosmetic changes to common_redirect, clientError, serverError
...
Since these functions exit (or throw exception) after running, there
is no need to have a 'return' statement or similar afterwards.
2014-03-10 00:25:57 +01:00
Mikael Nordfeldth
acbe94936f
common_redirect and clientError exits, so refactor
...
One Event would never be called, and other stuff were redundant clauses.
2014-03-10 00:24:32 +01:00
Mikael Nordfeldth
5c34369460
Don't use PEAR MIME lib when we have PECL fileinfo
2014-03-08 01:20:08 +01:00
Mikael Nordfeldth
0bc7d9c6c6
We sent a User object instead of Profile to InboxNoticeStream (thanks postblue)
2014-03-07 01:27:14 +01:00
Mikael Nordfeldth
4b2a66ed29
New mechanism for "all" feed (InboxNoticeStream)
...
Also cleaned up and made typing stricter for the stream, so only
profiles can be submitted. This reasonably also means we can create
"inbox" or "all" streams for foreign profiles as well using the same
stream handler (but of course only for messages we already know about).
To avoid looking up posts for a long time in a large notice database,
the lookback period for the inbox is no longer than the profile creation
date. (this matches the behaviour of Inbox)
Inbox class can probably be removed now.
2014-03-06 04:18:54 +01:00
Mikael Nordfeldth
4baaf7274c
Spiffing up all.php and making it more profile:y
2014-03-05 01:17:34 +01:00
Mikael Nordfeldth
fc047bd6e6
Minor code cleanup with group related actions (thanks brw12)
...
Originated from brw12 who noticed an incorrect variable name used in
an error message in actions/apigroupjoin.php:109
2014-03-01 12:01:17 +01:00
Mikael Nordfeldth
63102950b2
Compare to profile id of group, for backward compatibility
2014-02-23 21:28:52 +01:00
Mikael Nordfeldth
5487c596fc
Remove callback sneakery by StatusNet
2014-02-23 14:57:12 +01:00
Mikael Nordfeldth
915d329b5a
updating prepare and handle
2014-01-01 20:30:30 +01:00
Mikael Nordfeldth
4ab56f34dd
Previous edit made translation notes incompatible
2014-01-01 20:09:11 +01:00
Mikael Nordfeldth
df43684196
apparently not only regex 'https?' urls are sent
2014-01-01 19:47:49 +01:00
Mikael Nordfeldth
3552bf4d94
No pagination when no groups shown... :)
2013-11-04 16:57:30 +01:00
Mikael Nordfeldth
f110fc5c9a
Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION
2013-11-01 13:51:41 +01:00
Mikael Nordfeldth
810495708d
Version name strings updated, StatusNet only retained for copyright
2013-10-30 16:37:13 +01:00
Mikael Nordfeldth
8dafce34c3
LoginAction somewhat converted to FormAction
2013-10-30 12:23:10 +01:00
Mikael Nordfeldth
9b6633698c
Group discovery from text functions polished
...
Also removed the entirely unused saveGroups function.
Now avoiding multiGet and using listFind in Profile->getGroups()
so we don't have to deal with ArrayWrapper.
2013-10-29 13:40:14 +01:00
Mikael Nordfeldth
f8b49e69d0
Protected function prepare with array $args defaulting to array()
2013-10-29 10:26:46 +01:00
Mikael Nordfeldth
23a6b4595f
Reworked the ActivityContext->attention structure
...
Removing Evan's obscure attentionType solution and directly using the attention array
2013-10-28 22:21:14 +01:00
Mikael Nordfeldth
fcba540a14
Removed legacy OMB. Use OStatus for remote profiles.
2013-10-28 16:22:09 +01:00
Mikael Nordfeldth
362b6ad2fc
ForceGroup and some qvitter API stuff still used staticGet
2013-10-25 13:20:53 +02:00
Mikael Nordfeldth
a38ed0057a
Moved jbfavre's Twitter card support to Twitter plugin
...
It was causing problems with an undefined TWITTER_SERVICE constant.
2013-10-22 20:35:03 +02:00
Mikael Nordfeldth
a6c52c5ca7
Prepare the RepeatAction for modernisation (more OOP)
2013-10-21 23:27:09 +02:00
Mikael Nordfeldth
145fbf1130
Move nick updating of User entry to Profile->update()
...
Also, timezone and language in User table weren't indexes. So no need
to do them separately.
2013-10-17 16:38:42 +02:00
Mikael Nordfeldth
274b70784f
When updating a User_group nickname, correlate Local_group and Profile
...
...no need to make a separate call to Local_group's setNickname all the time,
or a bunch of redundant code for the Profile table.
Next up is User->update()...
2013-10-17 13:49:20 +02:00
Mikael Nordfeldth
6ed66d9c76
Local_group and User are now assumed to be in same namespace
2013-10-17 01:27:01 +02:00
Mikael Nordfeldth
db7ef52d13
Better use of Nickname validation functions
...
Nickname verifications on registration and updates for profiles (not yet
groups) have been improved.
Minor bugs in RegisterAction were also fixed, where multiple forms would
be outputed because the function did not return after showForm(). This
will be solved more permanently with throwing exceptions in the future.
2013-10-16 15:38:54 +02:00