Commit Graph

5220 Commits

Author SHA1 Message Date
brion
84227dd4e1 Use spinner icon while performing AJAX submissions of favorite/unfavorite button so there's some visual feedback that something's happening. 2009-08-16 20:01:56 -04:00
Craig Andrews
136a69a387 Merge commit 'jeff-themovie/0.8.x-openid-enabled' into 0.8.x 2009-08-16 19:50:37 -04:00
brion
46c77b83b1 Fix bug bug 1563 "opensearch content type incorrectly set"
http://laconi.ca/trac/ticket/1563

OpenSearch description info is now sent with correct Content-Type: application/opensearchdescription+xml instead of text/html.
2009-08-16 19:46:44 -04:00
Evan Prodromou
b936a5166d Revert "Revert "Return a 404 when a page is request that has no notices""
This reverts commit 1b204fde39.
2009-08-16 10:37:15 -04:00
Evan Prodromou
e0815de960 Revert "Revert "Return a 404 when a page is request that has no notices""
This reverts commit 6c597eabec.
2009-08-16 10:37:04 -04:00
Evan Prodromou
6c597eabec Revert "Return a 404 when a page is request that has no notices"
An empty list still exists; we should not return a 404 for empty lists.

This reverts commit 355effe631.
2009-08-14 13:05:57 -07:00
Evan Prodromou
1b204fde39 Revert "Return a 404 when a page is request that has no notices"
An empty list still exists; we shouldn't return a 404.

This reverts commit c29892c875.
2009-08-14 13:05:29 -07:00
Jeffery To
75a0a3e18b Fixed OpenID appearing in primary nav when OpenID is enabled but not OpenID-only 2009-08-15 00:17:00 +08:00
Evan Prodromou
2cf50ea432 whitespace in error.php 2009-08-14 08:04:03 -07:00
Jeffery To
7dc3a90d12 Added a configuration option to disable OpenID.
If $config['openid']['enabled'] is set to false, OpenID is removed from
the navigation and direct accesses to OpenID login pages redirect to the
login page.

If OpenID is enabled, $config['site']['openidonly'] is ignored, i.e.
OpenID is required to go OpenID-only.
2009-08-13 22:18:06 +08:00
Evan Prodromou
a0f6b4f078 ServerErrorAction always logs 2009-08-12 11:16:57 -07:00
Evan Prodromou
347f74d650 ServerErrorAction always logs 2009-08-12 11:16:31 -07:00
Evan Prodromou
7d33478e86 Merge branch '0.8.x' of git@gitorious.org:laconica/mainline into 0.8.x 2009-08-12 10:50:46 -07:00
Craig Andrews
853b6d38b3 Define the member variable N
N is defined in the DB_DataObject class, which this class kind of extends. So to keep a consistent interface for consumers, we need to have N defined here.
2009-08-12 11:53:46 -04:00
Brett Taylor
3243612e76 Prevents redirect URLs that have canonical URLs longer than 255 chars from being written to the database as their canonical. Redirecting URLs will instead be saved to the database as given.
The reason for this is that table 'file' column 'url' is a VARCHAR(255) in MySQL and it silently truncates URLs longer than 255 characters, breaking the url.

The proper fix for this is to improve this column, making its type TEXT, but there are no database changes for 0.8.x, so this is the next best thing for data integrity. A migration script for 0.9.x could be written to audit the database checking for redirects and updating these urls to their proper canonical url.
2009-08-12 16:17:02 +12:00
Craig Andrews
2260cf20f5 Corrected the Infinite Scroll CSS Selectors
Thanks dcostalis for making me aware of the issue!
2009-08-11 23:05:46 -04:00
Craig Andrews
c29892c875 Return a 404 when a page is request that has no notices 2009-08-11 22:48:35 -04:00
Craig Andrews
355effe631 Return a 404 when a page is request that has no notices 2009-08-11 22:09:02 -04:00
Craig Andrews
7eda7295e4 oEmbed provider does not use the twitter api library classes any more 2009-08-11 21:15:42 -04:00
Craig Andrews
4f751563c7 Make notice attachment lightbox work after an infinite scroll happens 2009-08-11 16:36:34 -04:00
Evan Prodromou
01dccefccc reformat newnotice.php 2009-08-11 11:18:24 -04:00
Craig Andrews
091152b6a5 Merge commit 'jeff-themovie/0.8.x-private-returnto' into 0.8.x 2009-08-11 10:42:04 -04:00
Craig Andrews
76d2a71fb0 Merge commit 'jeff-themovie/0.8.x-jcrop-0.9.8' into 0.8.x 2009-08-11 10:41:17 -04:00
Craig Andrews
b93df1ccbc Merge commit 'jeff-themovie/0.8.x-private-search' into 0.8.x 2009-08-11 10:39:44 -04:00
Evan Prodromou
2d29800b6f Merge branch 'master' into 0.8.x
Conflicts:
	lib/mail.php
	lib/rssaction.php
	lib/twitterapi.php
2009-08-11 10:23:11 -04:00
Jeffery To
e432df76d5 Set returnto when redirected to login of a private install 2009-08-11 21:55:24 +08:00
Jeffery To
fedadd5c5b Added opensearch to the list of public actions.
IE7+ will ask for this (opensearch/people and opensearch/notice) on every page access, and as the content is not sensitive, returning it is better than a 307 redirect.
2009-08-11 21:00:51 +08:00
Jeffery To
4d37e919ec Don't show Search in the primary nav if the user isn't logged in and the site is private 2009-08-11 20:47:41 +08:00
Jeffery To
a459313e10 Updated Jcrop to 0.9.8 (avatar cropping wasn't working in IE7 with 0.9.5) 2009-08-11 20:29:45 +08:00
Brett Taylor
73cde378c9 Merge commit 'mainline/0.8.x' into 0.8.x-notices-in-htmloutputter 2009-08-11 15:57:53 +12:00
Brett Taylor
d6bcc635bb two variables $public and $system were generating notices in lib/htmloutputter.php, removed because these two parameters are null by default. 2009-08-11 15:53:37 +12:00
Brett Taylor
04c6272915 fix for trac bug #1805:
bug on line 381 referred to non existant variable, and caused a php notice and potentially would create a misconfigured config.php database type setting.
2009-08-11 15:30:03 +12:00
Brenda Wallace
f2cd83dd51 Revert "changed file.url column type from varcahr(255) to varchar(2047)"
This reverts commit c1b19929f6.
2009-08-11 14:41:48 +12:00
Evan Prodromou
aa9fcb9184 Revert "common_config returns false if the config value is not set. Design::toWebColor checks with is_null. Hence the common_config value should be adjusted."
This reverts commit 5ba46186b7.
2009-08-10 16:42:21 -04:00
Evan Prodromou
3cdefe9983 Revert "Typo, session_name is a function."
This reverts commit d0793c0f44.
2009-08-10 16:42:10 -04:00
Evan Prodromou
36eaf42bbb Revert "UnsubscribeAction: Add LACONICA gate, fix PHPCS errors, fix error handling typo."
This reverts commit e1270b26f5.
2009-08-10 16:42:04 -04:00
Adrian Lang
bbf10e5bdf common_config returns false if the config value is not set. Design::toWebColor checks with is_null. Hence the common_config value should be adjusted. 2009-08-10 16:35:09 -04:00
Adrian Lang
77037b3cc3 UnsubscribeAction: Add LACONICA gate, fix PHPCS errors, fix error handling typo. 2009-08-10 16:34:56 -04:00
Evan Prodromou
6aee059033 Merge branch 'master' of git@gitorious.org:laconica/mainline 2009-08-10 16:33:36 -04:00
Christopher Vollick
65c37d66c8 $args Was Out Of Scope in CheckMirror.
It looks like when the code was factored out no one noticed this variable doesn't exist here.
2009-08-10 16:33:07 -04:00
Craig Andrews
7dc2717231 Merge commit 'dcostalis/econversation' into 0.8.x 2009-08-10 13:20:56 -04:00
brion
a1a97930f3 Workaround for bug 1317 '"What's up" textarea on iPhone missing proper submit button'
http://laconi.ca/trac/ticket/1317

Mobile Safari shows a 'return' button for making newlines in a <textarea> where it would show a submit button for plain <input> text fields...
However there's a keydown event handler which is supposed to detect hitting enter and submit the form for us. This didn't work on Mobile Safari because it was checking of 13 ("\r") but the iPhone sends us char 10 ("\n") here. Changed to accept both, so we now submit on hitting 'return' on iPhone.

Note: I also added a blur() to move focus out of the textarea, which closes the on-screen keyboard. It will also take focus out of the textarea on other platforms, but this is probably the right thing -- the same thing happens when you push the "send" button after all.

Also note: unfortunately the layout right now looks pretty awful generally while editing on the iPhone; you can't see the send button or character counter while typing at the default zoom, and it doesn't zoom out after you submit so you can't really see where your message is going. This should be dealt with in general by fixing up the mobile skin variant...
2009-08-10 11:58:55 -04:00
Craig Andrews
e9ed20a69d Merge commit 'jeff-themovie/0.8.x-openidonly' into 0.8.x 2009-08-10 11:53:35 -04:00
Adrian Lang
d0793c0f44 Typo, session_name is a function. 2009-08-10 15:24:27 +02:00
Adrian Lang
5ba46186b7 common_config returns false if the config value is not set. Design::toWebColor checks with is_null. Hence the common_config value should be adjusted. 2009-08-10 15:01:00 +02:00
Adrian Lang
e1270b26f5 UnsubscribeAction: Add LACONICA gate, fix PHPCS errors, fix error handling typo. 2009-08-10 14:51:41 +02:00
Zach Copley
17dcf1c317 Merge branch 'twitter-oauth' into 0.8.x
Conflicts:

	scripts/getvaliddaemons.php
2009-08-10 07:49:51 +00:00
Zach Copley
06c5f490ea Add Twitter OAuth key and secret example 2009-08-10 07:21:35 +00:00
Zach Copley
681bcbf71e Add synctwitterfriends to daemon startup and stop scripts 2009-08-10 07:18:09 +00:00
Zach Copley
dae74e8ff4 Take token field out of foreign_link
This undoes patch a49272d448
2009-08-10 07:13:00 +00:00