GNUsocial/gnu-social
4
0
Fork 1
Code Issues Releases Wiki Activity

remove favoritedrss

Browse Source 
I've removed the favoritedrss action, and removed the links from the
favorited page.

Most-favorited is not a good candidate for an RSS format. RSS works
well for series that work sequentially -- new things always come in at
the top.

This just isn't the case with "most favorited". The favorited notices
list on Identi.ca is sorted by how many times a message is favorited.

What happens if a notice used to be on that list, then falls off
because other messages get more faves, then gets back on because it
gets faved again? Or if a notice moves "up" on the list?

darcs-hash:20081207165900-84dde-23afe73c9c61cfb259ec5dc0cac5030643b31f2c.gz
This commit is contained in:
Evan Prodromou 2008-12-07 11:59:00 -05:00
parent b5956e5b76
commit 6e856cf7ee
2 changed files with 1 additions and 92 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
actions/favorited.php
View File

@ -44,18 +44,10 @@ class FavoritedAction extends StreamAction {
common_raw($output);
common_element_end('div');
$this->public_views_menu();
$this->show_feeds_list(array(0=>array('href'=>common_local_url('favoritedrss'),
'type' => 'rss',
'version' => 'RSS 1.0',
'item' => 'favoritedrss')));
}
function show_header() {
common_element('link', array('rel' => 'alternate',
'href' => common_local_url('favoritedrss'),
'type' => 'application/rss+xml',
'title' => _('Favorited Stream Feed')));
return;
}
function get_instructions() {

83
actions/favoritedrss.php
View File

@ -1,83 +0,0 @@
<?php
/*
* Laconica - a distributed open-source microblogging tool
* Copyright (C) 2008, Controlez-Vous, Inc.
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
if (!defined('LACONICA')) { exit(1); }
require_once(INSTALLDIR.'/lib/rssaction.php');
// Formatting of RSS handled by Rss10Action
class FavoritedrssAction extends Rss10Action {
function init() {
return true;
}
function get_notices($limit=0) {
$qry =
'SELECT notice_id, sum(exp(-(now() - modified)/864000)) as weight ' .
'FROM fave GROUP BY notice_id ' .
'ORDER BY weight DESC';
$offset = 0;
$total = ($limit == 0) ? 48 : $limit;
if (common_config('db','type') == 'pgsql') {
$qry .= ' LIMIT ' . $total . ' OFFSET ' . $offset;
} else {
$qry .= ' LIMIT ' . $offset . ', ' . $limit;
}
$fave = new Fave;
$fave->query($qry);
$notice_list = array();
while ($fave->fetch()) {
array_push($notice_list, $fave->notice_id);
}
$notice = new Notice();
$notice->query(sprintf('SELECT * FROM notice WHERE id in (%s)',
implode($notice_list, ',')));
$notices = array();
while ($notice->fetch()) {
$notices[] = clone($notice);
}
return $notices;
}
function get_channel() {
global $config;
$c = array('url' => common_local_url('favoritedrss'),
'title' => sprintf(_('%s Most Favorited Stream'), $config['site']['name']),
'link' => common_local_url('favorited'),
'description' => sprintf(_('Most favorited updates for %s'), $config['site']['name']));
return $c;
}
function get_image() {
return NULL;
}
}