GNUsocial
/
gnu-social
4
0
Fork 1
Code Issues Releases Wiki Activity

[TheFreeNetwork][fix_duplicates.php] Small improvements on queries performed

This commit is contained in:
Diogo Cordeiro 2020-08-04 12:38:51 +01:00 committed by Diogo Peralta Cordeiro
parent 1667d727b4
commit f81b578a37
1 changed files with 22 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

44
modules/TheFreeNetwork/scripts/fix_duplicates.php
View File

@ -40,13 +40,12 @@ require_once INSTALLDIR . '/scripts/commandline.inc';
/** /**
* Remote profiles are inspected from the most to the least * Remote profiles are inspected from the most to the least
* relevant according to the protocols they belong. * preferred according to the protocols they belong and age.
* Invariants: * Invariants:
* - `seen_local` array: The most recent profile inside of a certain protocol * - `seen_local` array: The most recent profile inside of a certain protocol are kept
* - global `seen` array: The most relevant profile (if there were duplicates, the first protocol of the list is the one to have its profile maintained) * - global `seen` array: The most relevant profile (if there were duplicates, the first protocol of the list is the one to have its profile maintained) are kept
* We do so while maintaining a global 'seen' array makes it * These two variables make it easy to satisfy a policy of maintaining
* easy to satisfy a policy of maintaining only the duplicated * only the profiles that are either the most relevant or the newest
* profiles that are either the most relevant or the newest
* ones intra-protocol wise. * ones intra-protocol wise.
*/ */
@ -62,41 +61,42 @@ function run(): void
function fix_duplicates(string $profile_class, array &$seen): void function fix_duplicates(string $profile_class, array &$seen): void
{ {
$db = new $profile_class(); $protocol_profile = new $profile_class();
$db->selectAdd('profile_id'); $protocol_profile->selectAdd();
$db->selectAdd('uri'); $protocol_profile->selectAdd('profile_id');
$db->whereAdd('profile_id IS NOT NULL'); // ignore groups $protocol_profile->selectAdd('uri');
$protocol_profile->whereAdd('profile_id IS NOT NULL'); // ignore groups
if (!$db->find()) { if (!$protocol_profile->find()) {
// This protocol wasn't used apparently
return; return;
} }
$seen_local = []; $seen_local = [];
while ($db->fetch()) { while ($protocol_profile->fetch()) {
$id = $db->profile_id; $id = $protocol_profile->profile_id;
$uri = $db->uri; $uri = $protocol_profile->uri;
// Have we seen this profile before? // Have we seen this profile before?
if (array_key_exists($uri, $seen)) { if (array_key_exists($uri, $seen)) {
// Was it on a previous protocol? Keep the highest preference protocol's one // Was it on a previous protocol? Keep the highest preference protocol's one
if ($seen[$uri] !== $id) { if ($seen[$uri] !== $id) {
printfv("Deleting Profile with id = {$id}\n"); printfnq("Deleting Profile with id = {$id}\n");
$profile = Profile::getKV('id', $id); $profile = Profile::getByID($id);
$profile->delete(); $profile->delete();
} else { } else {
printfv("Deleting {$profile_class} with id = {$id}\n"); printfnq("Deleting {$profile_class} with id = {$id}\n");
$profile = $profile_class::getKV('profile_id', $id); $protocol_profile->delete();
$profile->delete();
} }
} elseif (array_key_exists($uri, $seen_local)) { } elseif (array_key_exists($uri, $seen_local)) {
// Was it in this protocol? Delete the older record. // Was it in this protocol? Delete the older record.
if ($seen_local[$uri] !== $id) { if ($seen_local[$uri] !== $id) {
printfv("Deleting Profile with id = {$seen_local[$uri]}\n"); printfnq("Deleting Profile with id = {$seen_local[$uri]}\n");
$profile = Profile::getKV('id', $seen_local[$uri]); $profile = Profile::getByID($seen_local[$uri]);
$profile->delete(); $profile->delete();
} else { } else {
printfv("Deleting {$profile_class} with id = {$seen_local[$uri]}\n"); printfnq("Deleting {$profile_class} with id = {$seen_local[$uri]}\n");
$profile = $profile_class::getKV('profile_id', $seen_local[$uri]); $profile = $profile_class::getKV('profile_id', $seen_local[$uri]);
$profile->delete(); $profile->delete();
} }