With the milestone Port Media system from v2 we had ported the existing attachment system. The fact is that this system wasn't good enough.
It's always important to start with the original code as that allows us to review past decisions and understand all the corner cases previously considered.
Sadly, what motivated us to re-design the attachment system were the non-considered corner cases. In particular:
title
from attachment, as it's part of the relation between attachment and note.actor
from attachment, many actors may publish the same attachment.is_local
from attachment, as it's part of the relation between attachment and note.remote_url
from attachment, different urls can return the same attachment.Key commits:
The structural changes and how it compares to v2 is detailed in our wiki.
Some relevant observations:
Link
is now part of GNU social Data Representation terms. It represents
any remote URL being shared in a note.