diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

minor #39760 [HttpClient] Fix transient test with HttpClient jitter (jderusse)

Browse Source 
This PR was merged into the 5.2 branch.

Discussion
----------

[HttpClient] Fix transient test with HttpClient jitter

| Q             | A
| ------------- | ---
| Branch?       | 5.2
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | f-
| License       | MIT
| Doc PR        | -

Fix transient test, when asserting jitter generates random delay

Commits
-------

70fe66005a Fix transient test with HttpClient jitter
This commit is contained in:
Nicolas Grekas 2021-01-12 12:36:23 +01:00
commit 15e7eeefd0
1 changed files with 8 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/Symfony/Component/HttpClient/Tests/Retry/GenericRetryStrategyTest.php
View File

@ -93,19 +93,16 @@ class GenericRetryStrategyTest extends TestCase
public function testJitter()
{
$strategy = new GenericRetryStrategy([], 1000, 1, 0, 1);
$belowHalf = 0;
$aboveHalf = 0;
for ($i = 0; $i < 20; ++$i) {
$min = 2000;
$max = 0;
for ($i = 0; $i < 50; ++$i) {
$delay = $strategy->getDelay($this->getContext(0, 'GET', 'http://example.com/', 200), null, null);
if ($delay < 500) {
++$belowHalf;
} elseif ($delay > 1500) {
++$aboveHalf;
}
$min = min($min, $delay);
$max = max($max, $delay);
}
$this->assertGreaterThanOrEqual(1, $belowHalf);
$this->assertGreaterThanOrEqual(1, $aboveHalf);
$this->assertGreaterThanOrEqual(1000, $max - $min);
$this->assertGreaterThanOrEqual(1000, $max);
$this->assertLessThanOrEqual(1000, $min);
}
private function getContext($retryCount, $method, $url, $statusCode): AsyncContext