merged branch Burgov/enhance_form_error_message (PR #4557)
Commits -------b5cf337
[Form] Enhanced the form error message Discussion ---------- [Form] Enhanced the form error message Bug fix: no Feature addition: yes Backwards compatibility break: no Symfony2 tests pass: yes The error message on type mismatch is a bit obscure: The form's view data is expected to be an instance of class Samson\Bundle\TRSBundle\Entity\Labour, but has the type object. You can avoid this error by setting the "data_class" option to null or by adding a view transformer that transforms object to Samson\Bundle\TRSBundle\Entity\Labour. This commit changes it to: The form's view data is expected to be an instance of class Samson\Bundle\TRSBundle\Entity\Labour, but is an instance of class Closure. You can avoid this error by setting the "data_class" option to null or by adding a view transformer that transforms an instance of Closure to an instance of class Samson\Bundle\TRSBundle\Entity\Labour. --------------------------------------------------------------------------- by travisbot at 2012-06-12T14:04:08Z This pull request [fails](http://travis-ci.org/symfony/symfony/builds/1601478) (merged 70a15df6 into77839690
). --------------------------------------------------------------------------- by travisbot at 2012-06-12T14:06:31Z This pull request [fails](http://travis-ci.org/symfony/symfony/builds/1601507) (merged 12ec4dbd into77839690
). --------------------------------------------------------------------------- by travisbot at 2012-06-12T14:13:09Z This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1601517) (mergedb5cf337c
into77839690
). --------------------------------------------------------------------------- by bschussek at 2012-06-12T18:21:31Z 👍 Thanks!
This commit is contained in:
commit
37550d23c6
@ -348,25 +348,27 @@ class Form implements \IteratorAggregate, FormInterface
|
||||
if (!empty($viewData)) {
|
||||
$dataClass = $this->config->getDataClass();
|
||||
|
||||
$actualType = is_object($viewData) ? 'an instance of class ' . get_class($viewData) : ' a(n) ' . gettype($viewData);
|
||||
|
||||
if (null === $dataClass && is_object($viewData) && !$viewData instanceof \ArrayAccess) {
|
||||
$expectedType = 'scalar, array or an instance of \ArrayAccess';
|
||||
|
||||
throw new FormException(
|
||||
'The form\'s view data is expected to be of type ' . $expectedType . ', ' .
|
||||
'but is an instance of class ' . get_class($viewData) . '. You ' .
|
||||
'but is ' . $actualType . '. You ' .
|
||||
'can avoid this error by setting the "data_class" option to ' .
|
||||
'"' . get_class($viewData) . '" or by adding a view transformer ' .
|
||||
'that transforms ' . get_class($viewData) . ' to ' . $expectedType . '.'
|
||||
'that transforms ' . $actualType . ' to ' . $expectedType . '.'
|
||||
);
|
||||
}
|
||||
|
||||
if (null !== $dataClass && !$viewData instanceof $dataClass) {
|
||||
throw new FormException(
|
||||
'The form\'s view data is expected to be an instance of class ' .
|
||||
$dataClass . ', but has the type ' . gettype($viewData) . '. You ' .
|
||||
'can avoid this error by setting the "data_class" option to ' .
|
||||
'null or by adding a view transformer that transforms ' .
|
||||
gettype($viewData) . ' to ' . $dataClass . '.'
|
||||
$dataClass . ', but is '. $actualType . '. You can avoid this error ' .
|
||||
'by setting the "data_class" option to null or by adding a view ' .
|
||||
'transformer that transforms ' . $actualType . ' to an instance of ' .
|
||||
$dataClass . '.'
|
||||
);
|
||||
}
|
||||
}
|
||||
|
Reference in New Issue
Block a user