diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

bug #36297 [Form] action allows only strings (maxhelias)

Browse Source 
This PR was submitted for the 5.0 branch but it was merged into the 5.1-dev branch instead.

Discussion
----------

[Form] action allows only strings

| Q             | A
| ------------- | ---
| Branch?       | 5.0
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | ...
| License       | MIT
| Doc PR        | ...

On updating an old project that had actions to null it's caused me a type-hint error. With that, we can quickly identify where the problem is

Commits
-------

e861500ce8 [Form] action allows only strings
This commit is contained in:
Fabien Potencier 2020-04-04 09:23:05 +02:00
commit 5aeecc2dab
2 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/Symfony/Component/Form/Extension/Core/Type/FormType.php
View File

@ -203,6 +203,7 @@ class FormType extends BaseType
]);
$resolver->setAllowedTypes('label_attr', 'array');
$resolver->setAllowedTypes('action', 'string');
$resolver->setAllowedTypes('upload_max_size_message', ['callable']);
$resolver->setAllowedTypes('help', ['string', 'null']);
$resolver->setAllowedTypes('help_attr', 'array');

6
src/Symfony/Component/Form/Tests/Extension/Core/Type/FormTypeTest.php
View File

@ -341,6 +341,12 @@ class FormTypeTest extends BaseTypeTest
$this->factory->create(static::TESTED_TYPE, null, ['attr' => '']);
}
public function testActionCannotBeNull()
{
$this->expectException('Symfony\Component\OptionsResolver\Exception\InvalidOptionsException');
$this->factory->create(static::TESTED_TYPE, null, ['action' => null]);
}
public function testNameCanBeEmptyString()
{
$form = $this->factory->createNamed('', static::TESTED_TYPE);