bug #14683 Fixed the indentation in the compiled template for the DumpNode (stof)
This PR was merged into the 2.6 branch.
Discussion
----------
Fixed the indentation in the compiled template for the DumpNode
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
The Twig codebase is very careful at making compiled templates readable by formatting them properly. This fixes a case where Symfony does not respect this careful formatting (yes, I went debugging things into my compiled template today)
Commits
-------
9106ddb
Fixed the indentation in the compiled template for the DumpNode
This commit is contained in:
commit
a810fd13b9
@ -79,6 +79,6 @@ class DumpNode extends \Twig_Node
|
||||
|
||||
$compiler
|
||||
->outdent()
|
||||
->raw("}\n");
|
||||
->write("}\n");
|
||||
}
|
||||
}
|
||||
|
@ -39,6 +39,30 @@ EOTXT;
|
||||
$this->assertSame($expected, $compiler->compile($node)->getSource());
|
||||
}
|
||||
|
||||
public function testIndented()
|
||||
{
|
||||
$node = new DumpNode('bar', null, 7);
|
||||
|
||||
$env = new \Twig_Environment();
|
||||
$compiler = new \Twig_Compiler($env);
|
||||
|
||||
$expected = <<<'EOTXT'
|
||||
if ($this->env->isDebug()) {
|
||||
$barvars = array();
|
||||
foreach ($context as $barkey => $barval) {
|
||||
if (!$barval instanceof \Twig_Template) {
|
||||
$barvars[$barkey] = $barval;
|
||||
}
|
||||
}
|
||||
// line 7
|
||||
\Symfony\Component\VarDumper\VarDumper::dump($barvars);
|
||||
}
|
||||
|
||||
EOTXT;
|
||||
|
||||
$this->assertSame($expected, $compiler->compile($node, 1)->getSource());
|
||||
}
|
||||
|
||||
public function testOneVar()
|
||||
{
|
||||
$vars = new \Twig_Node(array(
|
||||
|
Reference in New Issue
Block a user