bug #25926 [Form] Fixed Button::setParent() when already submitted (HeahDude)
This PR was merged into the 2.7 branch.
Discussion
----------
[Form] Fixed Button::setParent() when already submitted
| Q | A
| ------------- | ---
| Branch? | 2.7
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | ~
| License | MIT
| Doc PR | ~
The `Button` does not respect the [FormInterface](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Form/FormInterface.php#L28), by extension the `SubmitButton` neither.
Commits
-------
9f0c7bf549
Fixed Button::setParent() when already submitted
This commit is contained in:
commit
ba8fb60bbd
@ -106,6 +106,10 @@ class Button implements \IteratorAggregate, FormInterface
|
||||
*/
|
||||
public function setParent(FormInterface $parent = null)
|
||||
{
|
||||
if ($this->submitted) {
|
||||
throw new AlreadySubmittedException('You cannot set the parent of a submitted button');
|
||||
}
|
||||
|
||||
$this->parent = $parent;
|
||||
}
|
||||
|
||||
|
@ -30,6 +30,20 @@ class ButtonTest extends TestCase
|
||||
$this->factory = $this->getMockBuilder('Symfony\Component\Form\FormFactoryInterface')->getMock();
|
||||
}
|
||||
|
||||
/**
|
||||
* @expectedException \Symfony\Component\Form\Exception\AlreadySubmittedException
|
||||
*/
|
||||
public function testSetParentOnSubmittedButton()
|
||||
{
|
||||
$button = $this->getButtonBuilder('button')
|
||||
->getForm()
|
||||
;
|
||||
|
||||
$button->submit('');
|
||||
|
||||
$button->setParent($this->getFormBuilder('form')->getForm());
|
||||
}
|
||||
|
||||
/**
|
||||
* @dataProvider getDisabledStates
|
||||
*/
|
||||
@ -37,11 +51,13 @@ class ButtonTest extends TestCase
|
||||
{
|
||||
$form = $this->getFormBuilder('form')
|
||||
->setDisabled($parentDisabled)
|
||||
->getForm();
|
||||
->getForm()
|
||||
;
|
||||
|
||||
$button = $this->getButtonBuilder('button')
|
||||
->setDisabled($buttonDisabled)
|
||||
->getForm();
|
||||
->getForm()
|
||||
;
|
||||
|
||||
$button->setParent($form);
|
||||
|
||||
|
Reference in New Issue
Block a user