bug #29386 undeprecate the single-colon notation for controllers (fbourigault)
This PR was merged into the 4.1 branch.
Discussion
----------
undeprecate the single-colon notation for controllers
| Q | A
| ------------- | ---
| Branch? | 4.1
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | N/A
| License | MIT
| Doc PR | N/A
This is the same as https://github.com/symfony/symfony/pull/29218 but for `Symfony\Bundle\FrameworkBundle\Routing\DelegatingLoader`.
Commits
-------
09371ad6f1
undeprecate the single-colon notation for controllers
This commit is contained in:
commit
eef2a948b8
@ -95,7 +95,7 @@ class DelegatingLoader extends BaseDelegatingLoader
|
|||||||
|
|
||||||
if (1 === substr_count($controller, ':')) {
|
if (1 === substr_count($controller, ':')) {
|
||||||
$nonDeprecatedNotation = str_replace(':', '::', $controller);
|
$nonDeprecatedNotation = str_replace(':', '::', $controller);
|
||||||
@trigger_error(sprintf('Referencing controllers with a single colon is deprecated since Symfony 4.1, use "%s" instead.', $nonDeprecatedNotation), E_USER_DEPRECATED);
|
// TODO deprecate this in 5.1
|
||||||
}
|
}
|
||||||
|
|
||||||
$route->setDefault('_controller', $controller);
|
$route->setDefault('_controller', $controller);
|
||||||
|
@ -25,7 +25,6 @@ class DelegatingLoaderTest extends TestCase
|
|||||||
/**
|
/**
|
||||||
* @group legacy
|
* @group legacy
|
||||||
* @expectedDeprecation Referencing controllers with foo:bar:baz is deprecated since Symfony 4.1, use "some_parsed::controller" instead.
|
* @expectedDeprecation Referencing controllers with foo:bar:baz is deprecated since Symfony 4.1, use "some_parsed::controller" instead.
|
||||||
* @expectedDeprecation Referencing controllers with a single colon is deprecated since Symfony 4.1, use "foo::baz" instead.
|
|
||||||
*/
|
*/
|
||||||
public function testLoad()
|
public function testLoad()
|
||||||
{
|
{
|
||||||
|
Reference in New Issue
Block a user