This PR was merged into the 4.4 branch.
Discussion
----------
[Console] mark as skip test testTraversableMultiselectAutocomplete for Windows
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? |no
| Deprecations? | no
| Tickets | Fix #...
| License | MIT
| Doc PR |
I think that in tests we need to adhere to one style, if we skip tests with "stty", then this one needs to be skipped or unchecked from all the others.
```cmd
C:\symfony>C:\php\7.1.3\php.exe C:\symfony\phpunit --color=never --bootstrap C:\symfony\vendor\autoload.php --configuration C:\symfony\phpunit.xml.dist src/Symfony/Component/Console/Tests/Helper/QuestionHelperTest.php
#!/usr/bin/env php
PHPUnit 7.5.20 by Sebastian Bergmann and contributors.
Testing Symfony\Component\Console\Tests\Helper\QuestionHelperTest
....SSSSSSSSSSSS..................................SSF 53 / 53 (100%)
Time: 912 ms, Memory: 8.00 MB
There was 1 failure:
1) Symfony\Component\Console\Tests\Helper\QuestionHelperTest::testTraversableMultiselectAutocomplete
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
Array (
- 0 => 'FooBundle'
+ 0 => 'AcmeDemoBundle'
+ 1 => 'AsseticBundle'
)
C:\symfony\src\Symfony\Component\Console\Tests\Helper\QuestionHelperTest.php:864
FAILURES!
Tests: 53, Assertions: 72, Failures: 1, Skipped: 14.
`
Commits
-------
6272c4b007 skip test
This PR was merged into the 4.4 branch.
Discussion
----------
[Validator] Added missing translations for Croatian (hr)
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | Fix#41816
| License | MIT
| Doc PR | -
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.
Additionally (see https://symfony.com/releases):
- Always add tests and ensure they pass.
- Never break backward compatibility (see https://symfony.com/bc).
- Bug fixes must be submitted against the lowest maintained branch where they apply
(lowest branches are regularly merged to upper ones so they get the fixes too.)
- Features and deprecations must be submitted against branch 5.x.
- Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry
-->
Commits
-------
e218a31565 Add missing validators translation
This PR was merged into the 4.4 branch.
Discussion
----------
Improve usage of twig ternary
| Q | A
| ------------- | ---
| Branch? | 5.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | none
| License | MIT
| Doc PR | none
Remove useless `else` condition when using twig ternary:
> `{{ foo ? 'yes' }}` is the same as `{{ foo ? 'yes' : '' }}`
See: https://twig.symfony.com/doc/3.x/templates.html#other-operators
Commits
-------
4be962d323 Improve usage of twig ternary
This PR was merged into the 4.4 branch.
Discussion
----------
[4.4] Add missing ``@return`` annotations
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
These annotations are needed to notify that the return is going to change because a parent class/interface is already advertising that (eg using PHP 8.1's tentative return types).
We should add the `#[ReturnTypeWillChange]` attribute on many of those methods, but `DebugClassLoader` is not ready to do it yet.
Commits
-------
3c578b1794 [4.4] Add missing ``@return`` annotations
This PR was merged into the 4.4 branch.
Discussion
----------
[Lock] Handle lock with long key
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
When lock key is very long, the generated file exceeded the maximum length supported by the system, leading to an exception
`fopen(/tmp/sf.username_xxxxxxxx[...].d3rUs2a.lock): Failed to open stream: File name too long`
Commits
-------
f82682424e Handle lock with long key
This PR was merged into the 5.2 branch.
Discussion
----------
[Lock] recommend createIndex over ensureIndex
| Q | A
| ------------- | ---
| Branch? | 5.2
| Bug fix? | no - kinda (phpdoc only fix)
| New feature? | no
| Deprecations? | no
| Tickets | Fix#42227
| License | MIT
| Doc PR | https://github.com/symfony/symfony-docs/pull/15547
Updated PHPDoc to recommend using `createIndex` instead of `ensureIndex`. `ensureIndex` was deprecated in `mongodb 3.0.0` and removed in `mongodb 5.0.0`
Commits
-------
4f8d8ee85d#42227 update phpdoc to recommend createIndex over ensureIndex
This PR was merged into the 4.4 branch.
Discussion
----------
[HttpFoundation] update phpdoc to recommend createIndex over ensureIndex
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no - kinda (phpdoc only fix)
| New feature? | no
| Deprecations? | no
| Tickets | Fix#42229
| License | MIT
| Doc PR | https://github.com/symfony/symfony-docs/pull/15548
Updated PHPDoc to recommend using `createIndex` instead of `ensureIndex`. `ensureIndex` was deprecated in `mongodb 3.0.0` and removed in `mongodb 5.0.0`
Commits
-------
05d8ca1046#42229 update phpdoc to recommend createIndex over ensureIndex
This PR was merged into the 4.4 branch.
Discussion
----------
[Debug][ErrorHandler] Do not use the php80 polyfill
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
Commits
-------
dd6bb2c367 [ErrorHandler][Debug] Do not use the php80 polyfill
This PR was merged into the 4.4 branch.
Discussion
----------
Leverage str_contains/str_starts_with
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | N/A
| License | MIT
| Doc PR | N/A
I'd like to use `str_contains()` and `str_starts_with()` whenever possible. On PHP 8, this is a native function and for all earlier versions, we can maintain the most efficient way to perform those operations in the polyfill package. And apart from that, I find the new functions more intuitive than the `strpos()` expressions I'm replacing here.
All code changes in this PR were automated, see FriendsOfPHP/PHP-CS-Fixer#5754
Of course, this is more than just a CS change. If you don't feel comfortable merging this change into 4.4, I can easily redo the PR for 5.4.
Commits
-------
e585b26730 Leverage str_contains/str_starts_with
This PR was merged into the 4.4 branch.
Discussion
----------
Leverage str_ends_with
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets |
| License | MIT
| Doc PR |
added the php80 polyfill to requirements when necessary. some components already had the requirement anyway.
Related to #41576
Commits
-------
9d807298be Leverage str_ends_with
This PR was squashed before being merged into the 4.4 branch.
Discussion
----------
Fixes missing translations for Dutch (nl)
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets | Fix#41818 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License | MIT
| Doc PR | symfony/symfony-docs#... <!-- required for new features -->
Fixes missing translations for Dutch (nl)
Related to #38710
The Fabbot check is a false-positive
Commits
-------
456bcdaaa0 Fixes missing translations for Dutch (nl)
This PR was merged into the 4.4 branch.
Discussion
----------
[Mailer] Make sure Http TransportException is not leaking
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets |
| License | MIT
| Doc PR |
We dont want the mailer to throw exceptions from the http-client component. This will make sure to catch such exceptions and rethrow the proper HttpTransportException from the Mailer component.
Commits
-------
1681bc1cce [Mailer] Make sure Http TransportException is not leaking
Fabien Potencier
Nyholm
HypeMC
Sébastien ALFAIATE
Nicolas Grekas
Jérémy Derussé
Roman Martinuk
Joe Bennett
Tobias Schultze
Alexander M. Turek
Robin Chalas
Richard van Laak