This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#11182).
Discussion
----------
Small comment update according to PSR-2
See [PSR-2](http://www.php-fig.org/psr/psr-2/) paragraph 5.2
> There MUST be a comment such as `// no break` when fall-through is intentional in a non-empty case body.
Related to #11181
Commits
-------
31b1dff Small comment update according to PSR-2
See [PSR-2](http://www.php-fig.org/psr/psr-2/) paragraph 5.2
> There MUST be a comment such as `// no break` when fall-through is intentional in a non-empty case body.
Related to #11181
This PR was merged into the 2.3 branch.
Discussion
----------
[Console] Fixed notice in DialogHelper
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| License | MIT
When pressing escape in a question, a notice is shown because the sequence is only 2 characters long.
Commits
-------
ff6c65e [Console] Fixed notice in DialogHelper
This PR was merged into the 2.3 branch.
Discussion
----------
[HttpFoundation] Fixed Request::getPort returns incorrect value under IPv6
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Commits
-------
2a0e8e3 [HttpFoundation] Fixed Request::getPort returns incorrect value under IPv6
This PR was merged into the 2.3 branch.
Discussion
----------
[Filesystem] Fix test suite on OSX
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
Reviewing PR's, I realized the filesystem test suite fails on my setup (OSX, PHP 5.5.13 with posix ext). `posix_getgrgid` returns false, so some tests are failing.
This solves this issue.
Be aware that the patched method has been moved in FilesystemTestCase in recent branches
Commits
-------
e26f08e [Filesystem] Fix test suite on OSX
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#11077).
Discussion
----------
[TwigBundle] [Tests] Add framework-bundle
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? |[yes
| Fixed tickets | -
| License | MIT
| Doc PR |
I'm unable to run the test from within TwigBundle
```bash
src/Symfony/Bundle/TwigBundle
composer install
phpunit
```
gives
```
PHP Fatal error: Class 'Symfony\Bundle\FrameworkBundle\Templating\TemplateReference' not found
```
Adding the FrameworkBundle fixes this but is that what is needed?
I believe `require` and `require-dev` should use `dev-master`
- [x] require(-dev) is not up to par with symfony master.
Commits
-------
a12471d Add framework-bundle
This PR was squashed before being merged into the 2.3 branch (closes#10966).
Discussion
----------
PHP Fatal error when getContainer method of ContainerAwareCommand has be...
PHP Fatal error when getContainer method of ContainerAwareCommand has been called within the configure method of a Command (application property is not been set yet at that time)
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Commits
-------
8ea5c4c PHP Fatal error when getContainer method of ContainerAwareCommand has be...
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#10981).
Discussion
----------
[HttpFoundation] Fixed isSecure() check to be compliant with the docs
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? |no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
According to the [php docs](http://www.php.net/manual/en/reserved.variables.server.php) the `HTTPS` field will be non-empty when the query was issued via HTTPS.
It isn't restricted to only "on" and 1.
Exception: "off" is sent by IIS
BC breaks: no, because old behavior was not conform with the docs.
Commits
-------
7bc37bd [HttpFoundation] Fixed isSecure() check to be compliant with the docs
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#11128).
Discussion
----------
Update MimeTypeExtensionGuesser.php
Add ```'text/rtf' => 'rtf'``` type, as it is a valid type specification for rtf documents.
Commits
-------
c986b91 Update MimeTypeExtensionGuesser.php
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#11118).
Discussion
----------
fix test src/Symfony/Component/HttpFoundation/Tests/BinaryFileResponseTest.php
src/Symfony/Component/HttpFoundation/Tests/BinaryFileResponseTest.php
| Q | A
| ------------- | ---
| Bug fix? | [no]
| New feature? | [no]
| BC breaks? | [no]
| Deprecations? | [no]
| Tests pass? | [yes]
| Fixed tickets | []
| License | MIT
| Doc PR | []
When running the tests in the HTTPFoundation package these failed. I felt like fixen these so I can start working with all tests green in the package.
Commits
-------
9247ef5 fix test src/Symfony/Component/HttpFoundation/Tests/BinaryFileResponseTest.php
This PR was merged into the 2.3 branch.
Discussion
----------
Fixed the Travis build on PHP 5.3.3
Updating PHPUnit requires OpenSSL which is not available on 5.3.3 on Travis.
Commits
-------
84561d2 Fixed the Travis build on PHP 5.3.3
This PR was merged into the 2.3 branch.
Discussion
----------
Simplified the way to update PHPUnit to the latest version
Commits
-------
ba37394 Simplified the way to update PHPUnit to the latest version
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#11106).
Discussion
----------
Minor doc fix in FormTypeInterface
Commits
-------
bf21d1a Minor doc fix.
This PR was merged into the 2.3 branch.
Discussion
----------
[HttpFoundation] Fix basic authentication in url with PHP-FPM
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | dispute
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
`getUser()` and `getPassword()` from `Request` are broken when using PHP-FPM because of the lack of `$_SERVER['PHP_AUTH_USER']` and `$_SERVER['PHP_AUTH_PW']`. This PR fixes the issue.
However, now an empty password will return an empty string (which is the expected behavior of `ServerBag`) instead of `NULL`. The test is updated accordingly, but should we consider this as a breakage?
This issue was spotted by using basic auth via the Illuminate component of Laravel and is present from v2.1.0 to master.
Commits
-------
7a75adf [HttpFoundation] Basic auth in url is broken when using PHP CGI/FPM
This PR was merged into the 2.3 branch.
Discussion
----------
[2.3][Process] Minor README update
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| License | MIT
Commits
-------
c7d6bbb [Process] Minor README update
Request#getUser() and Request#getPassword() introduced in
aecfd0a891 do not handle the lack of
PHP_AUTH_USER and PHP_AUTH_PW in $this->server when using PHP-FPM. Use
$this->headers instead.
Furthermore, the test of empty password now expects an empty string
instead of NULL according to a450d002f2.
This PR was merged into the 2.3 branch.
Discussion
----------
Fixed a html error "Element ul is not closed" in logger.html.twig
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Commits
-------
e3bf86f Fixed a html error "Element ul is not closed" in logger.html.twig
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#11066).
Discussion
----------
#10808 crawler test
Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |#10808
| License | MIT
Adds test for #10808
Commits
-------
876d6ca issue #10808 crawler test
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#10808).
Discussion
----------
[DomCrawler] Empty select with attribute name="foo[]" bug fix
If you have a select with attribute name="foo[]", and you submit your form, http_build_query returns empty string as a result. In this case you get a form extra field validation error, because your field "foo" converts to
'' => bool(false)
Commits
-------
15f081d Empty select with attribute name="foo[]" bug fix
If you have a select with attribute name="foo[]", and you submit your form, http_build_query returns empty string as a result. In this case you get a form extra field validation error, because your field "foo" converts to
'' => bool(false)
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#11065).
Discussion
----------
Fixed contextually wrong translation
This PR was submitted on the symfony/Validator read-only repository and moved automatically to the main Symfony repository (closessymfony/Validator#9).
"This value should not be blank." was translated as "Bu değer boşluk olamaz." However, the word "boşluk" means "space" in Turkish, therefore reverse translation implies "This value should not be space." and obviously this is wrong. The corrected translation should be "Bu değer boş bırakılmamalıdır."
Commits
-------
96518b4 Fixed contextually wrong translation
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#11016).
Discussion
----------
[Bridge][Twig] Replace deprecated features
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
This PR replaces the deprecated classes `Twig_Function_Node` and `Twig_Function_Method` by the`Twig_SimpleFunction`.
Commits
-------
14a4e4d [Bridge][Twig] Replace deprecated features
This PR was merged into the 2.3 branch.
Discussion
----------
[HttpFoundation] smaller fixes for PdoSessionHandler
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #10652
| License | MIT
For both the PdoSessionHandler and DbalSessionHandler
- https://github.com/symfony/symfony/pull/10652#issuecomment-42370425: Transactional DELETE + INSERT does not work as expected
- https://github.com/symfony/symfony/pull/10652#issuecomment-44359784: sqlsrv 2005 does not support the MERGE SQL, and if used it requires an HOLDLOCK
- missing time update for sqlsrv and oracle
Commits
-------
a0e1d4d [Doctrine Bridge] fix DBAL session handler according to PdoSessionHandler
00d707f [HttpFoundation] use different approach for duplicate keys in postgres, fix merge for sqlsrv and oracle
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#10974).
Discussion
----------
[HttpFoundation] Added PHPDoc for Cache-Control directives methods
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Commits
-------
58b0aef Added phpdoc for Cache-Control directives methods
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#11041).
Discussion
----------
Remove undefined variable $e
This PR was submitted on the symfony/DependencyInjection read-only repository and moved automatically to the main Symfony repository (closessymfony/DependencyInjection#6).
Commits
-------
637c6e1 Remove undefined variable $e
This PR was merged into the 2.3 branch.
Discussion
----------
[Validator] Fix a parameter name in a test
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | none
| License | MIT
| Doc PR | not required
Commits
-------
069e925 Fix a parameter name in a test