Commits
-------
9e3e589 Alter upgrade notes with changes to _form_is_choice_selected twig function
Discussion
----------
Undocumented BC break - choice field type template
The upgrade notes for the choice field template are out of date. They currently state:
```
The `choices` variable now contains `ChoiceView` objects with two getters,
getValue() and getLabel(), to access the choice data.
```
However these methods do not exist. I assume this is the result of a rollback to maintain BC?
In addition to this, the `_form_is_choice_selected` twig function has been removed and replaced with a filter called `selectedchoice`. This is an undocumented BC break. I have attached an update to the notes to reflect these changes.
---------------------------------------------------------------------------
by fabpot at 2012-08-15T17:20:35Z
ping @bschussek
---------------------------------------------------------------------------
by bschussek at 2012-08-16T17:36:22Z
Looks good apart from my comment. Thanks for fixing this!
Commits
-------
3ad3876 [Form] Fixed support for preferred choices in "entity" type
Discussion
----------
[Form] Fixed support for preferred choices in "entity" type
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: #5205
Todo: -
Commits
-------
493aa12 Added support to redis, wincache and zend data cache.
Discussion
----------
Added support to redis, wincache and zend data cache.
These three drivers were missing support on DoctrineBundle.
DoctrineBundle PR https://github.com/doctrine/DoctrineBundle/pull/99 must be merged first
---------------------------------------------------------------------------
by stof at 2012-08-09T20:35:21Z
This looks good to me
Commits
-------
ac0fb48 0x02 -> \MongoBinData::BYTE_ARRAY
70a64bd MongoBinData constructor now require "type" parameter
Discussion
----------
MongoBinData constructor now requires "type" parameter
From mongo driver version 1.2.11 E_DEPRECATED is emitted when the 2nd argument (type) is not used for MongoBinData constructor. At the moment the default value is 0x02 ("byte array").
See: http://php.net/manual/en/mongobindata.construct.php
From mongo driver version 1.2.11 E_DEPRECATED is emitted when the 2nd argument (type) is not used for MongoBinData constructor. At the moment the default value is 0x02 ("byte array").
See: http://php.net/manual/en/mongobindata.construct.php
Commits
-------
57694aa Removed MySQL-exclusive usage of unsigned integer from table creation
Discussion
----------
[Security] Removed MySQL-exclusive usage of unsigned integer from table creation
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: #5108
This patch removes the setting of unsigned integer fields which are MySQL-only.
---------------------------------------------------------------------------
by fabpot at 2012-08-13T12:25:23Z
@beberlei Does it look good?
---------------------------------------------------------------------------
by travisbot at 2012-08-13T12:30:27Z
This pull request [passes](http://travis-ci.org/symfony/symfony/builds/2107738) (merged 57694aaa into 31536c36).
---------------------------------------------------------------------------
by lsmith77 at 2012-08-13T20:04:20Z
indeed afaik unsigned isnt part of the sql standard. in other RDBMS you need to use a constraint if you want to prevent negative values and of course there is no way to then also get the additional values per bit that you get with MySQL, but so it goes. that being said .. i dont know how Doctrine schema handles unsigned for other RDBMS .. ie if it just emulates them by trying to double the size with a constraint.
---------------------------------------------------------------------------
by beberlei at 2012-08-13T20:10:44Z
Looks good.
Doctrine ignores the 'unsigned' => true for all others vendors.
Commits
-------
b7caf37 Adding more specific debug bar reset CSS.
Discussion
----------
Fixes#5250 - Adding more specific debug bar reset CSS.
This prevents frameworks like Foundation from getting past the reset.
Fixes#5250
---------------------------------------------------------------------------
by travisbot at 2012-08-13T19:10:38Z
This pull request [passes](http://travis-ci.org/symfony/symfony/builds/2111135) (merged b7caf374 into 7bc6d6d1).
Commits
-------
f248e0c Update src/Symfony/Component/Validator/Resources/translations/validators.it.xlf
Discussion
----------
Update src/Symfony/Component/Validator/Resources/translations/validators...
fixed typo in Italian translation
see https://github.com/symfony/FrameworkBundle/pull/3
---------------------------------------------------------------------------
by travisbot at 2012-08-13T11:26:32Z
This pull request [passes](http://travis-ci.org/symfony/symfony/builds/2107229) (merged f248e0c3 into 31536c36).
Commits
-------
1a4a4ee [DependencyInjection] Fixed a frozen constructor of a container with no parameters
2a124bc [DependencyInjection] Added a test for a frozen constructor of a container with no parameters
Discussion
----------
[DependencyInjection] Fix PHP Dumper for a constructor of a frozen container with no parameters
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets:
Todo: -
License of the code: MIT
---------------------------------------------------------------------------
by travisbot at 2012-08-06T16:51:20Z
This pull request [passes](http://travis-ci.org/symfony/symfony/builds/2049206) (merged 1a4a4ee9 into 3d32a0bc).
Commits
-------
039264d [Console] Fixed tests about message exception when command is not available
a4d2d31 [Console] Added tests for message exception when command is not available
Discussion
----------
[Console] Fixed message exception when command is not avaible
Bug fix: yes
Feature addition: yes
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: -
License of the code: MIT
Fixed singular / plural
`Did you mean this?` VS `Did you mean one of these`
---------------------------------------------------------------------------
by travisbot at 2012-08-07T14:40:55Z
This pull request [fails](http://travis-ci.org/symfony/symfony/builds/2057647) (merged 039264d2 into b91a4a83).
---------------------------------------------------------------------------
by lyrixx at 2012-08-07T15:11:47Z
@travisbot You failed, not me !
Commits
-------
5ad75c7 updated method name in a comment
Discussion
----------
updated method name in a comment
---------------------------------------------------------------------------
by travisbot at 2012-08-07T14:35:39Z
This pull request [passes](http://travis-ci.org/symfony/symfony/builds/2057604) (merged 5ad75c71 into b91a4a83).
Commits
-------
c51fc10 avoid fatal error on invalid session
Discussion
----------
[Security] avoid fatal error on invalid session
If the session has something instead of a token there will be a fatal error when `$this->refreshUser($token)` is called because the argument on that method is strictly typed.
```
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: ~
Todo: ~
License of the code: MIT
Documentation PR: ~
```
---------------------------------------------------------------------------
by travisbot at 2012-08-07T18:35:47Z
This pull request [passes](http://travis-ci.org/symfony/symfony/builds/2059743) (merged c51fc105 into 3d32a0bc).
Commits
-------
fa93324 [HttpFoundation] Fixed test under Windows environment
Discussion
----------
[HttpFoundation] Fixed test under Windows environment
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: #5226
Todo: -
License of the code: MIT
Documentation PR: -
---------------------------------------------------------------------------
by travisbot at 2012-08-10T09:54:20Z
This pull request [passes](http://travis-ci.org/symfony/symfony/builds/2084750) (merged fa933247 into dd9afddf).
Commits
-------
22be499 [HttpFoundation][Session] Cleaned up constructor invokation
Discussion
----------
[HttpFoundation][Session] Cleaned up constructor invokation
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: ~
Todo: ~
License of the code: MIT
Documentation PR: ~
This simply cleans up a mismatch between the class instantiation and the actual class constructor. Evidently something left over from the various iterations.
---------------------------------------------------------------------------
by travisbot at 2012-08-07T19:16:14Z
This pull request [passes](http://travis-ci.org/symfony/symfony/builds/2060028) (merged 22be4993 into 7dbadbf2).
---------------------------------------------------------------------------
by drak at 2012-08-09T08:25:43Z
ping @fabpot
Commits
-------
0677ed7 [Validator] Updated Romanian translations
Discussion
----------
[Validator] Updated Romanian translations
Just a small update for the validator translation.
---------------------------------------------------------------------------
by travisbot at 2012-08-08T21:47:01Z
This pull request [passes](http://travis-ci.org/symfony/symfony/builds/2070722) (merged 0677ed77 into 7dbadbf2).
Commits
-------
33105e0 [Locale] added more information to the README.md regarding the need to build the ICU data when the intl extension ICU data version mismatch the one shipped with Symfony
3191c70 [Validator] fixed tests, ICU 4.4 (Travis version) does not have the "my" locale
d7b6bb3 [Locale] updated README.md
6456361 [Locale] added note about ICU data building: use the same PHP intl/ICU version as the desired version to build
025f972 [Locale] renamed function
8da99ca [Locale] updated CHANGELOG.md
d909360 [Locale] don't create a "current" directory anymore, uses only the ICU version as the name of the data directory
3f2b4bf [Locale] changed build data script name
61e3539 [Form][Locale] updated minimum ICU version to 4.0
0d442c7 [Locale] as of ICU 4.8+, slash ("/") and dash ("-") are interchangeable, you can use any of them in a date/time pattern
90d6dc3 [Locale] fixed tests
86da1b3 [Locale] added ICU update-data script to be run before the test suite
5fd4eb1 [Locale] updated ICU data paths
64ccee7 [Locale] updated ICU data
0d0a8d4 [Locale] updated script to generate separated data directories for different ICU releases
Discussion
----------
[2.1][Locale] ICU data update
Bug fix: no
Feature addition: yes
Backwards compatibility break: no
Symfony2 tests pass: no
Fixes the following tickets:
Todo: -
License of the code: MIT
[](http://travis-ci.org/eriksencosta/symfony)
The tests are passing in Travis only because it uses ICU 4.4. The tests fails in ICU 4.8 and 49.1. The data files now are up-to-date with ICU 49.1.2. The fails are consistent between 32 and 64 bit for the PHP 5.3.3, 5.3.14 and 5.4.4 (each one compiled with ICU 4.2 to 49).
Basically tests that relies on Locale will have some idiosyncrasies:
- Some tests will assert a different value for different ICU versions, mostly for currency/date formatting
- Some tests will skip if not the latest ICU release, code that format/parse something that is directly based on ICU behavior will always implement the behavior from the latest release
- Some tests will make different assertions for different PHP versions (we already have them, just to note)
The Composer script handler was a very quick implementation, I accept suggestions about it. It basically invokes the `update-data.php` script. I will also rename this script later since it now behave a little bit different from the original script.
@fabpot, @stof: should I add mine Composer `post-install-cmd` script in both the project root and component `composer.json` file?
I'm planning to configure a CI server with a setup similar with mine Symfony development environment to run jobs with the different PHP/ICU releases for the Locale component. But most importantly is to document how I did it since it took a lot of time to have an enviroment that supports all this "ICU hell development". Also, there are some pitfalls regarding testing and to generating the resource bundles for the different ICU versions.
Almost there! I'll try to update later tomorrow (monday).
---------------------------------------------------------------------------
by fabpot at 2012-07-30T08:14:29Z
I would not have added the script in the `composer.json` file but in the `.travis.yml` file directly instead. We don't want this script to be run whenever someone run composer on the repository.
---------------------------------------------------------------------------
by eriksencosta at 2012-07-31T03:07:58Z
Ok, moved the script call to the `.travis.yml` file.
---------------------------------------------------------------------------
by eriksencosta at 2012-07-31T12:38:23Z
@stof The last commit was just to backup WIP changes and to ask something to @igorw, it is mine "stage" :)
---------------------------------------------------------------------------
by travisbot at 2012-08-06T03:05:16Z
This pull request [fails](http://travis-ci.org/symfony/symfony/builds/2044244) (merged c6a1dcd1 into 20d2e5a1).
---------------------------------------------------------------------------
by travisbot at 2012-08-06T03:16:12Z
This pull request [fails](http://travis-ci.org/symfony/symfony/builds/2044311) (merged 76868419 into 20d2e5a1).
---------------------------------------------------------------------------
by travisbot at 2012-08-06T03:52:20Z
This pull request [fails](http://travis-ci.org/symfony/symfony/builds/2044425) (merged 7e768eb2 into 20d2e5a1).
---------------------------------------------------------------------------
by travisbot at 2012-08-06T04:04:30Z
This pull request [fails](http://travis-ci.org/symfony/symfony/builds/2044461) (merged edaca423 into 20d2e5a1).
---------------------------------------------------------------------------
by eriksencosta at 2012-08-06T04:33:55Z
Ready for primetime. The failed test is not related with mine changes.
---------------------------------------------------------------------------
by travisbot at 2012-08-07T02:32:19Z
This pull request [passes](http://travis-ci.org/symfony/symfony/builds/2053806) (merged 386d20c8 into 842b599c).
---------------------------------------------------------------------------
by fabpot at 2012-08-07T13:51:59Z
After merging this PR, I have more failing tests on my machine:
PHP 5.3.8 - ICU 4.4.1
Is it expected? Is yes, how do we need to run the tests locally?
---------------------------------------------------------------------------
by eriksencosta at 2012-08-07T14:56:23Z
@fabpot Yep, it is expected. You'll need to build the ICU data for this version and export the `USE_INTL_ICU_DATA_VERSION` before running the tests:
php src/Symfony/Component/Locale/Resources/data/build-data.php
export USE_INTL_ICU_DATA_VERSION=1
phpunit src/Symfony/Component/Locale/Tests
The errors happens because the implementation is in sync with the behavior of ICU 49.1.2 and the shipped data is from data version too. Maybe I should add the steps above in the components `README.md` since it is more straightforward.
---------------------------------------------------------------------------
by fabpot at 2012-08-07T14:58:44Z
@eriksencosta Yes, that would be good to add some more information in the README file.
---------------------------------------------------------------------------
by eriksencosta at 2012-08-07T15:21:04Z
@fabpot Done!
---------------------------------------------------------------------------
by eriksencosta at 2012-08-07T15:21:29Z
And rebased.
