This PR was merged into the 2.8 branch.
Discussion
----------
[PropertyInfo] Fix some namespaces in tests
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
Commits
-------
0660891 [PropertyInfo] Fix some namespaces in tests
This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes#16698).
Discussion
----------
[PropertyAccessor] A little refactor
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| License | MIT
- Remove obsolete code
- Remove excessive actions
- Fix phpdoc & comments
Commits
-------
457b3f0 [PropertyAccessor] A little refactor - Remove obsolete code - Remove excessive actions - Fix phpdoc & comments
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#16839).
Discussion
----------
[PropertyAccess] minor: constants as internal and removed unused var
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
Commits
-------
6c9bb86 [PropertyAccess] minor: constants as internal and removed unused var
This PR was squashed before being merged into the 2.8 branch (closes#16911).
Discussion
----------
[PropertyInfo] Update List Information from ReflectionExtractor
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #16889
| License | MIT
| Doc PR | symfony/symfony-docs#5974
Unless a property with the same casing exists, lowercase the first letter of a property name extracted from a method. From what I understand, we don't actually need to support `snake_case` at all in the PropertyInfo component.
I cannot think of any use-case where PropertyAccess would be used to get/set a property value *before* using PropertyInfo to find out information about the property and the values it supports.
Since PropertyInfo supports the discovery of property names, which can then be used as identifiers in PropertyAccess, there should be no need to support a naming strategy to map property identifiers from one naming convention to another.
---
Running `$reflectionExtractor->getProperties($class)` with the following classes:
```php
class X
{
public $a;
public $b;
public function getA() {}
}
// Result: array('a', 'b');
```
```php
class Y
{
public $A;
public $b;
public function setA() {}
}
// Result: array('A', 'b');
```
```php
class Y
{
public $username;
protected $emailAddress;
public $password;
public function getEmailAddress() {}
public function isActive() {}
}
// Result: array('username', 'emailAddress', 'password', 'active');
```
Commits
-------
b2da76c [PropertyInfo] Update List Information from ReflectionExtractor
This PR was submitted for the 3.0 branch but it was merged into the 2.7 branch instead (closes#17011).
Discussion
----------
[CONSOLE] Remove unnecessary test
Question interface 'quarantees' that $validator is null or callable
Commits
-------
5dc9bd9 Remove unnecessary test
This PR was merged into the 2.8 branch.
Discussion
----------
[FrameworkBundle] ContainerDebugCommand: pass the right object to the descriptors
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | c5067dacb3 (commitcomment-14884960)
| License | MIT
| Doc PR |
Commits
-------
8cf0022 pass the right object to the descriptors
This PR was merged into the 3.0 branch.
Discussion
----------
[FrameworkBundle][HttpKernel] Remove remaining $triggerDeprecation flag
| Q | A
| ------------- | ---
| Fixed tickets | n/a
| License | MIT
Introduced in #14665, this flag controlled the deprecation notice triggering when using the `ContainerAwareHttpKernel`, in order to avoid triggering it when using this class in the Symfony framework. This class no longer exists now, neither the flag.
Commits
-------
ac15454 [FrameworkBundle][HttpKernel] Remove remaining $triggerDeprecation flag
* Fixes edge case on windows where PHP does not generate a PHP Warning but instead returns a wrong result https://bugs.php.net/bug.php?id=71103
* Improved error reporting on `unlink` used in `remove()`
This PR was merged into the 2.7 branch.
Discussion
----------
[2.7][Console] Table: fix some PhpDoc
| Q | A
| ------------- | ---
| Fixed tickets | n/a
| License | MIT
Commits
-------
1eaef57 [2.7][Console] Table: fix some PhpDoc
This PR was merged into the 2.8 branch.
Discussion
----------
[Form] Improve deprecation notice to mention the affected service id
| Q | A
| ------------- | ---
| Bug fix? |no
| New feature? |no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
This fix changes the deprecation notice to mention the affected service id. Without this update it is quite annoying to find the service with the deprecated definition.
Commits
-------
0b9ea95 Improve form deprecation notices to mention the affected service ids
This PR was merged into the 3.0 branch.
Discussion
----------
[HttpKernel] HttpCache: remove an ESI instance checking
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | no
| License | MIT
| Doc PR | no
This checking was added by this commit 32d964ba39, but now it's not needed
Commits
-------
7528134 Removed ESI instance check
This PR was merged into the 2.8 branch.
Discussion
----------
[Security][Guard] checkCredentials() should have a @return annotation
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | none
| License | MIT
| Doc PR | none
According to its documentation, an implementation of the `GuardAuthenticatorInterface::checkCredentials()` method should return `true` on success. I've added a `@return` annotation to the PHPDoc block to reflect the fact that this method should actually return something.
Commits
-------
4fd24a0 Added @return to checkCredentials()
This PR was merged into the 2.8 branch.
Discussion
----------
[PhpUnitBridge] Replace "weak-verbose" by "deprecations upper bound" mode
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #16789, #14475
| License | MIT
| Doc PR | -
This is a "new feature" that replaces a "new feature" not yet released but merged into 2.8.1. See #16789.
It is way more flexible to be able to specify the upper bound of remaining deprecation notices that you allow in your test suite. This allows lowering this number while deprecations are removed, step after step.
ping @WouterJ @Tobion @craue @fabpot @stof
Commits
-------
58cd3ee [PhpUnitBridge] Replace "weak-verbose" by "deprecations upper bound" mode
This PR was merged into the 2.3 branch.
Discussion
----------
Clean useless deprecation silencing
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
We added these when we triggered unsilenced notices. But we silence them now.
Commits
-------
9953550 Clean useless deprecation silencing
This PR was merged into the 3.0 branch.
Discussion
----------
return ajax collector to collectors.php
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | no
| Fixed tickets | #16880
| License | MIT
| Doc PR |
in symfony 3.0 there is no ajax collector declared. Because of that debug toolbar do not display ajax calls
Commits
-------
8a2c757 return ajax collector to collectors.php