Commit Graph

36333 Commits

Author SHA1 Message Date
Nicolas Grekas
2f6125f4cc minor #28034 [Validator] Add missing Ukrainian translations (azhurb)
This PR was merged into the 2.8 branch.

Discussion
----------

[Validator] Add missing Ukrainian translations

| Q             | A
| ------------- | ---
| Branch?       | 2.8 <!-- see below -->
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| License       | MIT

Add missing Ukrainian translations.

<!--
Write a short README entry for your feature/bugfix here (replace this comment block.)
This will help people understand your PR and can be used as a start of the Doc PR.
Additionally:
 - Bug fixes must be submitted against the lowest branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->

Commits
-------

b7d55ede15 Add missing Ukrainian translations
2018-07-26 11:27:25 +02:00
Nicolas Grekas
7b80bc2c78 Merge branch '2.8' into 3.4
* 2.8:
  Alpha-ordering for "use" statements
2018-07-26 11:06:28 +02:00
Nicolas Grekas
528eef336b Alpha-ordering for "use" statements 2018-07-26 11:03:18 +02:00
Nicolas Grekas
f5939a8336 Merge branch '2.8' into 3.4
* 2.8:
  Fix Clidumper tests
  Enable the fixer enforcing fully-qualified calls for compiler-optimized functions
  Apply fixers
  Disable the native_constant_invocation fixer until it can be scoped
  Update the list of excluded files for the CS fixer
2018-07-26 10:45:46 +02:00
Nicolas Grekas
82d13dae31 minor #27852 Fix coding standards (stof)
This PR was squashed before being merged into the 2.8 branch (closes #27852).

Discussion
----------

Fix coding standards

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

This PR is mostly about running the PHP-CS-Fixer (v2.12.1) in the whole codebase.

- I updated the exclude rule to avoid some false positives for the `error_suppression` fixer (we have more files triggering unsilenced deprecations on purpose than when building the initial whitelist, mostly).
- I ran the fixer with this updated config. Most changes were related to fully-qualifying some constants, with the new fixer implemented in https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/3127, for which @nicolas-grekas and I suggested a config to include in the Symfony ruleset. Based on the output, I suggested a feature request in https://github.com/FriendsOfPHP/PHP-CS-Fixer/issues/3872 as we might want to avoid the `\` in non-namespaced files to improve readability. We might want to remove the second commit of this PR if we decide to wait for the feature to be implemented (update: implementation is contributed in https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/3876)
- I added the `native_function_invocation` fixer explicitly, to automatically fully-qualify calls to compiler-optimized functions. This feature was implemented in PHP-CS-Fixer based on our feature request (as currently, we do such thing only manually in some hot path, because it could not be automated). I opened https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/3873 to include it in the ruleset automatically.

TODOs:
- [x] agree on the updated rules
- [x] update fabbot to use the new version of PHP-CS-Fixer
- [ ] make separate PRs for newer branches with their own updates (exclude rules, and CS fixes), once this PR gets merged.

Commits
-------

538c69dc26 Fix Clidumper tests
04654cfeb3 Enable the fixer enforcing fully-qualified calls for compiler-optimized functions
f00b3279ea Apply fixers
720ed4d379 Disable the native_constant_invocation fixer until it can be scoped
8892b98627 Update the list of excluded files for the CS fixer
2018-07-26 10:30:16 +02:00
Nicolas Grekas
3349ec66a7 Merge branch '2.8' into 3.4
* 2.8:
  bumped Symfony version to 2.8.44
2018-07-26 10:16:47 +02:00
Jérémy Derussé
ce49036790
Allow multidimensional collection in property info 2018-07-25 12:57:02 +02:00
Nicolas Grekas
1b9baa48bd bug #28052 [HttpKernel] Fix merging bindings for controllers' locators (nicolas-grekas)
This PR was merged into the 3.4 branch.

Discussion
----------

[HttpKernel] Fix merging bindings for controllers' locators

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #28041
| License       | MIT
| Doc PR        | -

Commits
-------

94b620ebc2 [HttpKernel] Fix merging bindings for controllers' locators
2018-07-25 10:23:09 +02:00
Jérémy Derussé
6331687f65
Allow multidimensional collection in property info 2018-07-24 17:28:18 +02:00
Christophe Coevoet
538c69dc26 Fix Clidumper tests 2018-07-24 14:25:56 +02:00
Christophe Coevoet
04654cfeb3 Enable the fixer enforcing fully-qualified calls for compiler-optimized functions 2018-07-24 12:05:38 +02:00
Christophe Coevoet
f00b3279ea Apply fixers 2018-07-24 09:48:17 +02:00
Christophe Coevoet
720ed4d379 Disable the native_constant_invocation fixer until it can be scoped
We don't want to run it on non-namespaced code to reduce visual clutter.
2018-07-24 09:45:01 +02:00
Christophe Coevoet
8892b98627 Update the list of excluded files for the CS fixer 2018-07-24 09:39:57 +02:00
Nicolas Grekas
94b620ebc2 [HttpKernel] Fix merging bindings for controllers' locators 2018-07-24 09:03:36 +02:00
Roland Franssen
d3d7766874 [HttpFoundation] Fix Cookie::isCleared 2018-07-23 20:57:35 +02:00
Fabien Potencier
0ff03c9b3d bumped Symfony version to 3.4.14 2018-07-23 19:11:49 +02:00
Fabien Potencier
c406c5a4f1
Merge pull request #28039 from fabpot/release-3.4.13
released v3.4.13
2018-07-23 18:37:45 +02:00
Fabien Potencier
7446a290ad updated VERSION for 3.4.13 2018-07-23 18:37:31 +02:00
Fabien Potencier
30b834bdaf updated CHANGELOG for 3.4.13 2018-07-23 18:37:26 +02:00
Fabien Potencier
a57549d0a1 bumped Symfony version to 2.8.44 2018-07-23 16:56:24 +02:00
Nicolas Grekas
707e52afd7 minor #28037 [Form] fix truncating form views in data collector (nicolas-grekas)
This PR was merged into the 3.4 branch.

Discussion
----------

[Form] fix truncating form views in data collector

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no (fixing a non released patch)
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Fixes #27923.

Commits
-------

5fa1f12f3c [Form] fix truncating form views in data collector
2018-07-23 16:49:37 +02:00
Nicolas Grekas
ad316675f5 minor #28036 [TwigBridge][Form] fix tests by moving AbstractBootstrap* cases to the bridge (nicolas-grekas)
This PR was merged into the 3.4 branch.

Discussion
----------

[TwigBridge][Form] fix tests by moving AbstractBootstrap* cases to the bridge

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #27897
| License       | MIT
| Doc PR        | -

Commits
-------

8869b296b8 [TwigBridge][Form] fix tests by moving AbstractBootstrap* cases to the bridge
2018-07-23 15:28:27 +02:00
Nicolas Grekas
5fa1f12f3c [Form] fix truncating form views in data collector 2018-07-23 14:58:27 +02:00
Nicolas Grekas
8869b296b8 [TwigBridge][Form] fix tests by moving AbstractBootstrap* cases to the bridge 2018-07-23 14:38:31 +02:00
Nicolas Grekas
d61bedabd5 Merge branch '2.8' into 3.4
* 2.8:
  updated VERSION for 2.8.43
  update CONTRIBUTORS for 2.8.43
  updated CHANGELOG for 2.8.43
  backported translations
  Fixed templateExists on parse error of the template name
2018-07-23 13:36:14 +02:00
Oleksii Zhurbytskyi
b7d55ede15
Add missing Ukrainian translations 2018-07-23 13:56:58 +03:00
Fabien Potencier
e7f50768f1
Merge pull request #28031 from fabpot/release-2.8.43
released v2.8.43
2018-07-23 11:03:03 +02:00
Fabien Potencier
78ef2a0740 updated VERSION for 2.8.43 2018-07-23 11:02:45 +02:00
Fabien Potencier
d74b11f877 update CONTRIBUTORS for 2.8.43 2018-07-23 11:02:44 +02:00
Fabien Potencier
6f97c89340 updated CHANGELOG for 2.8.43 2018-07-23 11:02:31 +02:00
Fabien Potencier
b2ec4aaf76 bug #28005 [HttpKernel] Fixed templateExists on parse error of the template name (yceruto)
This PR was merged into the 2.8 branch.

Discussion
----------

[HttpKernel] Fixed templateExists on parse error of the template name

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #28001
| License       | MIT
| Doc PR        | -

9bfa971bc5/src/Symfony/Bundle/FrameworkBundle/Templating/TemplateNameParser.php (L49-L51)

Commits
-------

53347c42fd Fixed templateExists on parse error of the template name
2018-07-23 10:31:26 +02:00
Fabien Potencier
48644a8fc8 backported translations 2018-07-23 10:22:17 +02:00
Fabien Potencier
a97a6175ba Merge branch '2.8' into 3.4
* 2.8:
  fixed UUID error message id in translation files
  Add several missing translations of the UUID validation message.
  Serbo-Croatian has Serbian plural rule
  [Validator] Add missing UUID validator message translation (hu)
  [Validator] Add missing UUID validator message translation (en)
  add missing translation for uuid validator
  Fix PHPDoc return type
  [MonologBridge] Improve FirePHPHandler
  Fix SVGs not scaling in IE9, IE10, and IE11
2018-07-23 10:18:36 +02:00
Fabien Potencier
53cbd0dabf minor #28030 Fix UUID error message id in translation files (fabpot)
This PR was merged into the 2.8 branch.

Discussion
----------

Fix UUID error message id in translation files

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Id 82 is already taken for the generic error message.

<!--
Write a short README entry for your feature/bugfix here (replace this comment block.)
This will help people understand your PR and can be used as a start of the Doc PR.
Additionally:
 - Bug fixes must be submitted against the lowest branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->

Commits
-------

5d76ed7a3a fixed UUID error message id in translation files
2018-07-23 10:16:33 +02:00
Fabien Potencier
5d76ed7a3a fixed UUID error message id in translation files 2018-07-23 10:13:01 +02:00
David Prévot
31353147a3 Use an empty string as default for assertEquals
Make sure it isn’t interpreted as a type NULL, making the test fail with
PHPUnit 7.2.
2018-07-22 11:14:14 +08:00
Yonel Ceruto
53347c42fd Fixed templateExists on parse error of the template name 2018-07-19 14:17:34 -04:00
Fabien Potencier
9bfa971bc5 minor #27999 [Validator] Add several missing translations of the UUID validation message. (apfelbox)
This PR was merged into the 2.8 branch.

Discussion
----------

[Validator] Add several missing translations of the UUID validation message.

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | (Comments in #27992)   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | —

All the remaining translations from #27992

Commits
-------

ee780f3c66 Add several missing translations of the UUID validation message.
2018-07-19 14:13:50 +02:00
Jannik Zschiesche
ee780f3c66 Add several missing translations of the UUID validation message. 2018-07-19 14:11:20 +02:00
Fabien Potencier
286996c9d9 bug #27997 Serbo-Croatian has Serbian plural rule (kylekatarnls)
This PR was submitted for the master branch but it was merged into the 2.8 branch instead (closes #27997).

Discussion
----------

Serbo-Croatian has Serbian plural rule

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Enable correct plural on Serbo-Croatian translations. Could be safely merged in versions branches.

Commits
-------

4ff0f951be Serbo-Croatian has Serbian plural rule
2018-07-19 14:06:36 +02:00
Kyle
4ff0f951be Serbo-Croatian has Serbian plural rule 2018-07-19 14:06:28 +02:00
Fabien Potencier
08a49bc530 minor #27992 add missing translation for uuid validator (garak)
This PR was merged into the 2.8 branch.

Discussion
----------

add missing translation for uuid validator

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | related to #27984
| License       | MIT
| Doc PR        | -

Commits
-------

7cf840c83c add missing translation for uuid validator
2018-07-19 13:20:54 +02:00
Fabien Potencier
903d04cc02 minor #27994 [Validator] Add missing UUID validator message translation (hu) (1ed)
This PR was merged into the 2.8 branch.

Discussion
----------

[Validator] Add missing UUID validator message translation (hu)

| Q             | A
| ------------- | ---
| Branch?       |2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

<!--
Write a short README entry for your feature/bugfix here (replace this comment block.)
This will help people understand your PR and can be used as a start of the Doc PR.
Additionally:
 - Bug fixes must be submitted against the lowest branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->

Commits
-------

0b2134415c [Validator] Add missing UUID validator message translation (hu)
2018-07-19 13:19:27 +02:00
Fabien Potencier
22e152905f minor #27993 [Validator] Add missing UUID validator message translation (en) (1ed)
This PR was merged into the 2.8 branch.

Discussion
----------

[Validator] Add missing UUID validator message translation (en)

| Q             | A
| ------------- | ---
| Branch?       |2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

<!--
Write a short README entry for your feature/bugfix here (replace this comment block.)
This will help people understand your PR and can be used as a start of the Doc PR.
Additionally:
 - Bug fixes must be submitted against the lowest branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->

Commits
-------

2a950b668f [Validator] Add missing UUID validator message translation (en)
2018-07-19 13:18:27 +02:00
Gábor Egyed
0b2134415c [Validator] Add missing UUID validator message translation (hu) 2018-07-19 12:22:12 +02:00
Gábor Egyed
2a950b668f [Validator] Add missing UUID validator message translation (en) 2018-07-19 12:05:15 +02:00
Massimiliano Arione
7cf840c83c
add missing translation for uuid validator 2018-07-19 10:51:22 +02:00
Fabien Potencier
18edda3716 bug #26193 Fix false-positive deprecation notices for TranslationLoader and WriteCheckSessionHandler (iquito)
This PR was squashed before being merged into the 3.4 branch (closes #26193).

Discussion
----------

Fix false-positive deprecation notices for TranslationLoader and WriteCheckSessionHandler

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #25518
| License       | MIT

Symfony 3.4 emits deprecation warnings for  `TranslationLoader` and `WriteCheckSessionHandler` as soon as these classes are loaded, yet at the same time these classes are part of the default services defined in Symfony 3.4, so if these classes are loaded during container compilation a deprecation warning is emitted, even if these classes are never actually used.

An example would be the following within a compiler pass:

    foreach ($containerBuilder->getDefinitions() as $definition) {
      if (is_subclass_of($definition->getClass(), SomeClass::class)) {
        $definition->addMethodCall('setSomething', [new Reference('someservice')]);
      }
    }

This will load both `TranslationLoader` and `WriteCheckSessionHandler` in order to check their definition.  No instance of the classes are ever used and the classes are not loaded after compilation ever, yet the deprecation notices are shown on every single page. More details are provided in issue #25518 .

By moving the deprecation notices to the class constructors false-positives are avoided while actual usage of the classes should still generate the deprecation warnings.

Commits
-------

1a427b181d Fix false-positive deprecation notices for TranslationLoader and WriteCheckSessionHandler
2018-07-19 09:08:28 +02:00
Andreas
1a427b181d Fix false-positive deprecation notices for TranslationLoader and WriteCheckSessionHandler 2018-07-19 09:08:14 +02:00