This PR was merged into the 4.4 branch.
Discussion
----------
[WebLink] fix types on Link::withAttribute()
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | Fix#40126
| License | MIT
| Doc PR | -
Related to 10e52348a2
Commits
-------
29903e2c35 [WebLink] fix types on Link::withAttribute()
This PR was merged into the 4.4 branch.
Discussion
----------
[HttpFoundation] allow savePath of NativeFileSessionHandler to be null
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Fix#41669
| License | MIT
By introducing the great Symfony\Component\HttpFoundation\Session\Storage\Handler\SessionHandlerFactory it is possible to configure session handler via DSN. But if I want to use the NativeFileSessionHandler to use configured session.save_path of php.ini, it doesn't work as expected because the $savePath constructor param is an empty string (and not NULL) by using "file://" as DSN.
Commits
-------
f8a082daeb [HttpFoundation] allow savePath of NativeFileSessionHandler to be null
This PR was submitted for the 5.4 branch but it was merged into the 5.2 branch instead.
Discussion
----------
[Notifier] Do not use static::class for final messages
| Q | A
| ------------- | ---
| Branch? | 5.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | https://github.com/symfony/symfony/pull/39402#discussion_r638619033
| License | MIT
| Doc PR | N/A
Micro optimization
Commits
-------
69f6409731 Do not use static::class for final messages
This PR was merged into the 5.2 branch.
Discussion
----------
[Messenger] prevent reflection usages when classes do not exist
| Q | A
| ------------- | ---
| Branch? | 5.2
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Fix#41748
| License | MIT
| Doc PR |
Commits
-------
017b4b341c prevent reflection usages when classes do not exist
This PR was merged into the 5.2 branch.
Discussion
----------
[Messenger] Remove TLS related options when not using TLS
| Q | A
| ------------- | ---
| Branch? | 5.2
| Bug fix? | not really
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
Remove TLS related options when not using TLS to connect to a broker.
The goal is to be able to use the same configuration for both `amqp://` & `amqps://` DSN.
Currently, when using a configuration containing a `cacert` key with a non-TLS DSN will throw a `AMQPConnectionException` (Socket error: could not connect to host.)
Configuration example:
```yaml
framework:
messenger:
transports:
async:
dsn: '%env(MESSENGER_TRANSPORT_DSN)%'
options:
cacert: '%kernel.project_dir%/amqp_cacert.pem'
```
Commits
-------
37e602dd28 Remove TLS related options when not using TLS
This PR was merged into the 5.2 branch.
Discussion
----------
[FrameworkBundle] fix Could not find service "test.service_container"
| Q | A
| ------------- | ---
| Branch? | 5.2, needs to be ported to 5.3
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Fix#41715
| License | MIT
Partial backport of https://github.com/symfony/symfony/pull/41530
Related to https://github.com/symfony/symfony/issues/41715 and https://github.com/symfony/symfony/pull/41530
When launching phpunit, got an error:
`LogicException: Could not find service "test.service_container". Try updating the "framework.test" config to "true".`
```
There was 1 error:
1) App\Symfony\Bundle\Tests\Integration\IntegrationTest::testServiceWiringWithConfiguration
LogicException: Could not find service "test.service_container". Try updating the "framework.test" config to "true".
/Projects/app/vendor/symfony/framework-bundle/Test/KernelTestCase.php:109
/Projects/app/tests/integration/IntegrationTest.php:23
Caused by
Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException: You have requested a non-existent service "test.service_container". Did you mean this: "service_container"?
/Projects/app/vendor/symfony/dependency-injection/Container.php:280
/Projects/app/vendor/symfony/dependency-injection/Container.php:228
/Projects/app/vendor/symfony/framework-bundle/Test/KernelTestCase.php:107
/Projects/app/tests/integration/IntegrationTest.php:23
```
/cc `@xabbuh` `@nicolas`-grekas
Commits
-------
0748b5247e bug #41715: [FrameworkBundle] Partial backport of PR#41530
This PR was merged into the 4.4 branch.
Discussion
----------
[Validator] Fix some typos in Greek language
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| License | MIT
Fix some typos in Greek language
Commits
-------
8df2ea12d3 Fix some typos in Greek language
This PR was submitted for the 5.4 branch but it was squashed and merged into the 4.4 branch instead.
Discussion
----------
[Process] Fix incorrect parameter type
In the affected line of code, fclose() should ONLY be passed a parameter of type resource, but fopen() can return a value of type bool (if the fopen() fails). This results in a fatal error under PHP 8: Fatal error: Uncaught TypeError: fclose(): Argument #1 ($stream) must be of type resource, bool given.
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets |
| License | MIT
| Doc PR |
Commits
-------
d1579a2922 [Process] Fix incorrect parameter type
This PR was merged into the 5.2 branch.
Discussion
----------
[Validator] Fix tests by making constraint options dumps order consistent
| Q | A
| ------------- | ---
| Branch? | 5.2
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Part of #41552
| License | MIT
| Doc PR | N/A
Commits
-------
181d5480c6 [Validator] Fix tests by making constraint options dumps order consistent
This PR was merged into the 4.4 branch.
Discussion
----------
[Config] Backport type declarations
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | N/A
| License | MIT
| Doc PR | N/A
This PR backports type declarations from #41575 where it's safe to do so.
Commits
-------
46e18aff9b [Config] Backport type declarations
This PR was merged into the 4.4 branch.
Discussion
----------
[VarExporter] Fix test on PHP 8.1
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Part of #41552
| License | MIT
| Doc PR | N/A
On PHP 8.1, when dumping the properties of an object (either through serialization, `var_dump` or an array cast), those properties might appear in a different order than on PHP 8.0 and earlier.
Because of that, the test I'm fixing here fails. Since the order of the properties is not really important, I'm sorting the dumped array by key in order to get a stable order.
Commits
-------
56359cb999 [VarExporter] Fix test on PHP 8.1
This PR was merged into the 4.4 branch.
Discussion
----------
[Mime] Fix CSV file mime type guess test for PHP 8.1
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets | Part of #41552 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License | MIT
| Doc PR | N/A
I had the same result as `@derrabus` on my computer: `application/csv`. The CI returns `text/csv`. These two seem possible, although `text/csv` is described in [RFC 7111](https://datatracker.ietf.org/doc/html/rfc7111#page-3).
(Oops little typo in title, thanks Alexander for the fix 🙏 )
Commits
-------
117cb8f085 [DependencyInjection] Fix CSV file mime type guess test for PHP 8.1
This PR was merged into the 4.4 branch.
Discussion
----------
[HttpClient] Revert bindto workaround for unaffected PHP versions
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Fix#41622
| License | MIT
| Doc PR | N/A
This PR reverts the changes of #38086 for PHP versions that don't need that workaround.
Commits
-------
e9afce3334 [HttpClient] Revert bindto workaround