Commit Graph

42312 Commits

Author SHA1 Message Date
Nicolas Grekas
2a631ecb83 minor #31709 [EventDispatcher] Remove deprecation layer (derrabus)
This PR was merged into the 5.0-dev branch.

Discussion
----------

[EventDispatcher] Remove deprecation layer

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | N/A
| License       | MIT
| Doc PR        | N/A

This PR removes all deprecations from the event dispatcher component.

Commits
-------

678e066aa8 [EventDispatcher] Remove deprecation layer.
2019-05-31 09:52:39 +02:00
Nicolas Grekas
89f423fc35 bug #31744 [Validator] Fix TimezoneValidator default option (ro0NL)
This PR was squashed before being merged into the 4.3 branch (closes #31744).

Discussion
----------

[Validator] Fix TimezoneValidator default option

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against branch 4.4.
 - Legacy code removals go to the master branch.
-->

Commits
-------

ee71cdbae4 [Validator] Fix TimezoneValidator default option
2019-05-31 09:43:12 +02:00
Roland Franssen
ee71cdbae4 [Validator] Fix TimezoneValidator default option 2019-05-31 09:42:02 +02:00
Nicolas Grekas
d38c19a3b4 bug #31749 [DoctrineBridge][Validator] do not enable validator auto mapping by default (xabbuh)
This PR was merged into the 4.3 branch.

Discussion
----------

[DoctrineBridge][Validator] do not enable validator auto mapping by default

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | part of #31715, #31752
| License       | MIT
| Doc PR        |

Commits
-------

a3555fc49c do not enable validator auto mapping by default
2019-05-31 09:34:40 +02:00
Nicolas Grekas
da01afacfc bug #31757 [DomCrawler] Fix type error with null Form::$currentUri (chalasr)
This PR was merged into the 4.2 branch.

Discussion
----------

[DomCrawler] Fix type error with null Form::$currentUri

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #31644
| License       | MIT
| Doc PR        | n/a

Commits
-------

e48d5d07e3 [DomCrawler] Fix type error with null Form::$currentUri
2019-05-31 09:33:33 +02:00
Robin Chalas
91817e4de0 [Messenger] Inject RoutableMessageBus instead of bus locator 2019-05-31 02:51:53 +02:00
Robin Chalas
e48d5d07e3 [DomCrawler] Fix type error with null Form::$currentUri 2019-05-31 01:40:59 +02:00
Robin Chalas
0b6a9f9058 minor #31755 [Contracts] Fixed typos (samnela)
This PR was merged into the 4.3 branch.

Discussion
----------

[Contracts] Fixed typos

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Commits
-------

0bb8ba4ea4 [Contracts] Fixed typos
2019-05-31 01:00:21 +02:00
SAMUEL NELA
0bb8ba4ea4
[Contracts] Fixed typos 2019-05-31 00:41:44 +02:00
Robin Chalas
5a404b25ea minor #31725 [Security] remove simple_preauth and simple_form authenticators (xabbuh)
This PR was merged into the 5.0-dev branch.

Discussion
----------

[Security] remove simple_preauth and simple_form authenticators

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

35de7e2545 remove simple_preauth and simple_form authenticators
2019-05-31 00:11:20 +02:00
Robin Chalas
8fc75e30a6 minor #31753 [Security][Http] Forbid security-core 5.x (chalasr)
This PR was merged into the 4.4 branch.

Discussion
----------

[Security][Http] Forbid security-core 5.x

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Required for #31725

Commits
-------

7481db6570 [Security][Http] Forbid security-core 5.x
2019-05-30 23:52:10 +02:00
Robin Chalas
7481db6570 [Security][Http] Forbid security-core 5.x 2019-05-30 23:24:03 +02:00
Christian Flothmann
a3555fc49c do not enable validator auto mapping by default 2019-05-30 21:25:18 +02:00
Christian Flothmann
35de7e2545 remove simple_preauth and simple_form authenticators 2019-05-30 20:39:35 +02:00
Alexander M. Turek
678e066aa8 [EventDispatcher] Remove deprecation layer. 2019-05-30 18:59:28 +02:00
Nicolas Grekas
9c76aae7dd minor #31742 [HttpClient] remove unused argument (nicolas-grekas)
This PR was merged into the 4.3 branch.

Discussion
----------

[HttpClient] remove unused argument

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

da85b48c32 [HttpClient] remove unused argument
2019-05-30 18:42:29 +02:00
Nicolas Grekas
da85b48c32 [HttpClient] remove unused argument 2019-05-30 18:27:37 +02:00
Nicolas Grekas
dc82bba1e1 Merge branch '4.4'
* 4.4:
  Use willReturn() instead of will(returnValue()).
2019-05-30 18:12:02 +02:00
Nicolas Grekas
c62032a730 Merge branch '4.3' into 4.4
* 4.3:
  Use willReturn() instead of will(returnValue()).
2019-05-30 18:10:19 +02:00
Nicolas Grekas
0da213711c Merge branch '4.2' into 4.3
* 4.2:
  Use willReturn() instead of will(returnValue()).
2019-05-30 18:10:05 +02:00
Nicolas Grekas
06c655251c Merge branch '3.4' into 4.2
* 3.4:
  Use willReturn() instead of will(returnValue()).
2019-05-30 18:06:08 +02:00
Nicolas Grekas
3cd3522735 minor #31738 Use willReturn() instead of will(returnValue()) (derrabus)
This PR was merged into the 3.4 branch.

Discussion
----------

Use willReturn() instead of will(returnValue())

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | N/A
| License       | MIT
| Doc PR        | N/A

In a recent PR, fabbot complained about the usage of will(returnValue()) in test cases that I haven't changed. In this PR, I've applied the PHP CS Fixer's `php_unit_mock_short_will_return` fixer on the whole codebase.

Commits
-------

4fb67df612 Use willReturn() instead of will(returnValue()).
2019-05-30 17:49:51 +02:00
Alexander M. Turek
4fb67df612 Use willReturn() instead of will(returnValue()). 2019-05-30 17:47:52 +02:00
Nicolas Grekas
6b7493871b minor #31667 [TwigBundle] Removed capability to load Twig template from legacy directories (yceruto)
This PR was merged into the 5.0-dev branch.

Discussion
----------

[TwigBundle] Removed capability to load Twig template from legacy directories

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Ref https://github.com/symfony/symfony/pull/28891

Commits
-------

4b6752bf3e Removed capability to load Twig template from legacy directories
2019-05-30 16:52:50 +02:00
Yonel Ceruto
4b6752bf3e Removed capability to load Twig template from legacy directories 2019-05-30 10:22:13 -04:00
Nicolas Grekas
0dd0679362 Merge branch '4.4'
* 4.4:
  Disable php_unit_mock_short_will_return rule of php-cs
  [github] define 4.4 as the feature branch
2019-05-30 16:20:10 +02:00
Nicolas Grekas
e7279c292a Merge branch '4.3' into 4.4
* 4.3:
  Disable php_unit_mock_short_will_return rule of php-cs
  [github] define 4.4 as the feature branch
2019-05-30 16:15:06 +02:00
Nicolas Grekas
c319c5c3e8 Merge branch '4.2' into 4.3
* 4.2:
  Disable php_unit_mock_short_will_return rule of php-cs
  [github] define 4.4 as the feature branch
2019-05-30 16:14:53 +02:00
Nicolas Grekas
6892c30930 Merge branch '3.4' into 4.2
* 3.4:
  Disable php_unit_mock_short_will_return rule of php-cs
  [github] define 4.4 as the feature branch
2019-05-30 16:14:40 +02:00
Nicolas Grekas
7ae54b43ea minor #31737 Disable php_unit_mock_short_will_return rule of php-cs (nicolas-grekas)
This PR was merged into the 3.4 branch.

Discussion
----------

Disable php_unit_mock_short_will_return rule of php-cs

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

bf782ecb38 Disable php_unit_mock_short_will_return rule of php-cs
2019-05-30 16:14:23 +02:00
Nicolas Grekas
31c3c59131 minor #31583 [github] define 4.4 as the feature branch (nicolas-grekas)
This PR was merged into the 3.4 branch.

Discussion
----------

[github] define 4.4 as the feature branch

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

And let's use master for preparing 5.0.

Commits
-------

30b560c4df [github] define 4.4 as the feature branch
2019-05-30 16:13:52 +02:00
Nicolas Grekas
bf782ecb38 Disable php_unit_mock_short_will_return rule of php-cs 2019-05-30 16:12:14 +02:00
Nicolas Grekas
5720b94db0 minor #31689 [Console] Remove deprecated code (chalasr)
This PR was merged into the 5.0-dev branch.

Discussion
----------

[Console] Remove deprecated code

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Commits
-------

317b80facc [Console] Remove deprecated features
2019-05-30 15:59:49 +02:00
Nicolas Grekas
3fadcc6a96 Merge branch '4.4'
* 4.4:
  [HttpKernel] Make DebugHandlersListener internal
  HttpKernel 4.4 is incompatible with Console 5 because of the EventDispatcher changes.
  Add missed use class for Symfony\Bundle\FrameworkBundle\Test\WebTestCase::$client
  bump Twig bridge dependency
  [HttpClient] Minor fix in an error message
  Fix parameter documentation for Inflector::pluralize() method
  Use a more appropriate group when deprecating mode
  Marked several components as incompatible with EventDispatcher 5.
  bumped Symfony version to 4.3.1
  updated VERSION for 4.3.0
  updated CHANGELOG for 4.3.0
  [FrameworkBundle] fix test fixture using deprecated controller and add missing deprecation
  exchanged $rootDir and $fileLinkFormatter arguments in DebugCommand
  [FrameworkBundle] Add a validation on the messenger section
2019-05-30 15:57:29 +02:00
Nicolas Grekas
47fd08eb5c Merge branch '4.3' into 4.4
* 4.3:
  Add missed use class for Symfony\Bundle\FrameworkBundle\Test\WebTestCase::$client
  [HttpClient] Minor fix in an error message
  Fix parameter documentation for Inflector::pluralize() method
  Use a more appropriate group when deprecating mode
  bumped Symfony version to 4.3.1
  updated VERSION for 4.3.0
  updated CHANGELOG for 4.3.0
  [FrameworkBundle] fix test fixture using deprecated controller and add missing deprecation
  [FrameworkBundle] Add a validation on the messenger section
2019-05-30 15:50:22 +02:00
Nicolas Grekas
fb865a670c minor #31699 [Serializer] Unified normalizers/encoders config through default context solely (ogizanagi)
This PR was squashed before being merged into the 5.0-dev branch (closes #31699).

Discussion
----------

[Serializer] Unified normalizers/encoders config through default context solely

| Q             | A
| ------------- | ---
| Branch?       | master <!-- see below -->
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #28709   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A

As planned in #28709.
Split into two commits to ease review.

Commits
-------

914577eaa9 [Serializer] Unified normalizers/encoders config through default context solely
2019-05-30 15:48:28 +02:00
Maxime Steinhausser
914577eaa9 [Serializer] Unified normalizers/encoders config through default context solely 2019-05-30 15:48:21 +02:00
Robin Chalas
317b80facc [Console] Remove deprecated features 2019-05-30 15:36:38 +02:00
Nicolas Grekas
1203290688 feature #31732 [HttpKernel] Make DebugHandlersListener internal (chalasr)
This PR was merged into the 4.4 branch.

Discussion
----------

[HttpKernel] Make DebugHandlersListener internal

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Required to remove the legacy `Event` argument type declaration from its `configure()` method in 5.0.
Unlocks #31689

Commits
-------

1a8db293c6 [HttpKernel] Make DebugHandlersListener internal
2019-05-30 15:26:48 +02:00
Robin Chalas
1a8db293c6 [HttpKernel] Make DebugHandlersListener internal 2019-05-30 15:23:23 +02:00
Nicolas Grekas
174a0a7576 minor #31731 [DI] remove support for non-string default env() parameters (ro0NL)
This PR was merged into the 5.0-dev branch.

Discussion
----------

[DI] remove support for non-string default env() parameters

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

See #27808

Commits
-------

614f5da2a6 [DI] remove support for non-string default env() parameters
2019-05-30 15:19:32 +02:00
Nicolas Grekas
2ff0273206 minor #31734 [HttpKernel] Don't install HttpKernel 4.4 with Console 5 (derrabus)
This PR was merged into the 4.4 branch.

Discussion
----------

[HttpKernel] Don't install HttpKernel 4.4 with Console 5

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | N/A
| License       | MIT
| Doc PR        | N/A

Another attempt to get the build of #31709 green. Because the base class of `ConsoleEvent` was changed, the Console component 5.0 in going to be incompatible with `DebugHandlersListener` in HttpKernel 4.4.

Commits
-------

44f326dc4c HttpKernel 4.4 is incompatible with Console 5 because of the EventDispatcher changes.
2019-05-30 15:13:04 +02:00
Alexander M. Turek
44f326dc4c HttpKernel 4.4 is incompatible with Console 5 because of the EventDispatcher changes. 2019-05-30 14:30:19 +02:00
Roland Franssen
614f5da2a6 [DI] remove support for non-string default env() parameters 2019-05-30 13:48:35 +02:00
Nicolas Grekas
3392186e7f minor #31719 Add missed use class for Symfony\Bundle\FrameworkBundle\Test\WebTestCase::$client (andrew-demb)
This PR was squashed before being merged into the 4.3 branch (closes #31719).

Discussion
----------

Add missed use class for Symfony\Bundle\FrameworkBundle\Test\WebTestCase::$client

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

In `Symfony\Bundle\FrameworkBundle\Test\WebTestCase::$client` property exists phpdoc about property class, but no `use` declaration added.

As `Symfony\Bundle\FrameworkBundle\Client` deprecated, and actually this will be `Symfony\Bundle\FrameworkBundle\KernelBrowser` instance, we can put `KernelBrowser` instead `Client` (not sure about BC)
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->

Commits
-------

6982025e3a Add missed use class for Symfony\Bundle\FrameworkBundle\Test\WebTestCase::$client
2019-05-30 13:26:49 +02:00
Andrii Dembitskyi
6982025e3a Add missed use class for Symfony\Bundle\FrameworkBundle\Test\WebTestCase::$client 2019-05-30 13:26:44 +02:00
Nicolas Grekas
bfa43d3038 minor #31724 [Security] remove the has_role() security expression function (xabbuh)
This PR was merged into the 5.0-dev branch.

Discussion
----------

[Security] remove the has_role() security expression function

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

c99dfdf119 remove the has_role() security expression function
2019-05-30 13:25:38 +02:00
Nicolas Grekas
299b6264cb minor #31728 [TwigBundle] bump Twig bridge dependency (xabbuh)
This PR was merged into the 4.4 branch.

Discussion
----------

[TwigBundle] bump Twig bridge dependency

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #31688
| License       | MIT
| Doc PR        |

We need a version of the `DebugCommand` class that is compatible with
its service definition in the Twig bundle.

Commits
-------

9df66b831a bump Twig bridge dependency
2019-05-30 13:23:15 +02:00
Christian Flothmann
9df66b831a bump Twig bridge dependency
We need a version of the `DebugCommand` class that is compatible with
its service definition in the Twig bundle.
2019-05-30 12:28:51 +02:00
Nicolas Grekas
d690792dc7 minor #31726 [HttpClient] Minor fix in an error message (javiereguiluz)
This PR was merged into the 4.3 branch.

Discussion
----------

[HttpClient] Minor fix in an error message

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Fixes this:

![image](https://user-images.githubusercontent.com/73419/58624608-e9de9e00-82d0-11e9-9558-3f52388f1531.png)

Commits
-------

2da9e3f717 [HttpClient] Minor fix in an error message
2019-05-30 12:01:41 +02:00