Commits
-------
cf736cc [DomCrawler] Add test for ChoiceFormField without value
bca551e [DomCrawler] ChoiceFormField should take the content when value is unavailable
Discussion
----------
[DomCrawler] ChoiceFormField should take the content when value is unavai
[DomCrawler] ChoiceFormField should take the content when value is unavailable
---------------------------------------------------------------------------
by fabpot at 2011/09/20 09:15:21 -0700
Can you some unit tests?
Commits
-------
ab8e760 Fixed the creation of the subrequests
Discussion
----------
Fixed the creation of the subrequests
The subrequest must be created using an absolute path to keep the
informations about the host and the base path.
Closes#2168
Commits
-------
95dc7e1 Fixed fourth argument of Filesystem->mirror()
Discussion
----------
Fixed fourth argument of Filesystem->mirror()
See #2027 and #2033 for discussion.
@fabpot said that we don't want to use symlink at all on Windows so if this is confirmed, we should also change ``Filesystem->symlink()`` implementation.
---------------------------------------------------------------------------
by alexandresalome at 2011/09/16 08:29:40 -0700
Tested on Windows, OK for me
Commits
-------
8e2cbe6 fixes usage of mb_*
Discussion
----------
Fixes usage of mb_strlen
---------------------------------------------------------------------------
by Seldaek at 2011/09/16 05:33:45 -0700
This will fail if the mbstring ext isn't enabled, you should still test for the mb_ function first.
Commits
-------
aa8e029 Swedish translation fix.
Discussion
----------
Swedish translation fix.
"valda" translates to "chosen". Changed to correct term "angivna".
Commits
-------
43b55ef [Locale] Fix#2179 StubIntlDateFormatter support yy format
Discussion
----------
[Locale] Fix#2179 StubIntlDateFormatter support yy format
Fix#2179 Year limit is 2031 like IntlDateFormatter
Commits
-------
777f876 [HttpFoundation] Added test that exposes error in session saving
Discussion
----------
[HttpFoundation] Added test that exposes error in session saving
Noticed this commit in the recent release:
https://github.com/symfony/symfony/commit/34a1b53
And noticed that the save in __destruct won't be fired if a manual save has been called. The testSavedOnDestructAfterManualSave test I've added fails on 2.0.1 but it passes with 2.0.0. An example:
$session->set('foo', 'value');
$session->__destruct(); // eventually called during shutdown, triggers a save
// During next request, $session->get('foo') returns 'value'
$session->set('foo', 'value');
$session->save();
$session->set('foo', 'newvalue');
$session->__destruct(); // eventually called during shutdown, however WON'T trigger save
// During next request, $session->get('foo') returns 'value'
In my eyes the save on destruction should still happen whether a save has been called manually or not - it's more predictable. But i can see arguments for the opposite as well.
If consensus is that this is a bug, I'm happy to provide a fix but wanted to get feedback on the 2 options:
* Save optimisation can be reverted
* Can make the save optimisation more intelligent so a write to storage is only done if something has changed. The best way to do this would be to close down the api and mark the session as invalid when an attribute is set for example, however all properties are currently protected and would need to be private, so it might break some people's extensions of session
---------------------------------------------------------------------------
by stof at 2011/09/04 02:13:52 -0700
@fabpot what about it ?
Commits
-------
ff99d80 Changed the behavior of Session::regenerate to destroy the session when it invalidates it.
Discussion
----------
Changed the behavior of Session::regenerate to destroy the old session when invalidates it.
When invalidating a session, I've yet to find a reason for the storage not to destroy the old session.
If the intent of the method is to invalidate the session, there's no reason at all to keep the old session around in storage, since it's supposed to be invalid.
(New PR with changed base from #2176)
Commits
-------
b15d80e Added missing translation for Swedish
Discussion
----------
Added missing translation for Swedish
A missing Swedish translation for "One or more of the given values is invalid" was added.
(New PR with changed base from #2177)
Commits
-------
cd40ed4 Added missing method to HTTP Digest entry point
Discussion
----------
Added missing method to HTTP Digest entry point
Re-submitting to 2.0 branch as it is a bugfix, thanks!
