Fabien Potencier
1374abd6e8
minor #34399 [HttpKernel] dont check cache freshness more than once per process (nicolas-grekas)
...
This PR was merged into the 4.4 branch.
Discussion
----------
[HttpKernel] dont check cache freshness more than once per process
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
While running some functional tests in a loop, I noticed that half the time is spent computing cache freshness. This makes no sense - this mechanism is supposed to run once per process.
Here is the Blackfire comparison:
https://blackfire.io/profiles/compare/a4f2eb44-ae85-440b-ae87-edf43c2b2ef7/graph
![image](https://user-images.githubusercontent.com/243674/68955196-c5667780-07c5-11ea-9a19-f8e765664a8e.png )
Commits
-------
7f9556ce19
[HttpKernel] dont check cache freshness more than once per process
2019-11-15 18:39:48 +01:00
Nicolas Grekas
7f9556ce19
[HttpKernel] dont check cache freshness more than once per process
2019-11-15 16:26:40 +01:00
Fabien Potencier
ca9a3a41a3
bug #34389 [WebProfilerBundle] add FrameworkBundle requirement (xabbuh)
...
This PR was merged into the 4.4 branch.
Discussion
----------
[WebProfilerBundle] add FrameworkBundle requirement
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Fix #34379
| License | MIT
| Doc PR |
Commits
-------
1752dd9432
add FrameworkBundle requirement
2019-11-15 12:26:07 +01:00
Nicolas Grekas
b8f8ac947e
bug #34358 [Security] always check the token on non-lazy firewalls (nicolas-grekas, lyrixx)
...
This PR was merged into the 4.4 branch.
Discussion
----------
[Security] always check the token on non-lazy firewalls
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Fix #34357
| License | MIT
| Doc PR |
Commits
-------
2c2632a04c
[SecurityBundle] add tests with empty authenticator
797450d6b8
[Security] always check the token on non-lazy firewalls
2019-11-15 12:06:35 +01:00
Nicolas Grekas
6fd10771d9
bug #34390 [FrameworkBundle] fix wiring of httplug client (nicolas-grekas)
...
This PR was merged into the 4.4 branch.
Discussion
----------
[FrameworkBundle] fix wiring of httplug client
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Closes https://github.com/symfony/recipes/issues/676
| License | MIT
| Doc PR | -
Commits
-------
d969d49292
[FrameworkBundle] fix wiring of httplug client
2019-11-15 12:03:34 +01:00
Nicolas Grekas
d969d49292
[FrameworkBundle] fix wiring of httplug client
2019-11-15 11:02:26 +01:00
Christian Flothmann
1752dd9432
add FrameworkBundle requirement
2019-11-15 10:12:35 +01:00
Grégoire Pineau
2c2632a04c
[SecurityBundle] add tests with empty authenticator
2019-11-14 23:51:34 +01:00
Nicolas Grekas
797450d6b8
[Security] always check the token on non-lazy firewalls
2019-11-14 23:50:50 +01:00
Fabien Potencier
81588eb835
minor #34380 [Mailer] Add UPGRADE entry about the null transport DSN (ogizanagi)
...
This PR was merged into the 4.4 branch.
Discussion
----------
[Mailer] Add UPGRADE entry about the null transport DSN
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets | N/A
| License | MIT
| Doc PR | already up-to-date
Commits
-------
abcf63aaa8
[Mailer] Add UPGRADE entry about the null transport DSN
2019-11-14 15:48:11 +01:00
Maxime Steinhausser
abcf63aaa8
[Mailer] Add UPGRADE entry about the null transport DSN
2019-11-14 15:24:33 +01:00
Nicolas Grekas
2a2d2bc0c0
minor #34367 [Form] Allow symfony/service-contracts v2 (derrabus)
...
This PR was merged into the 4.4 branch.
Discussion
----------
[Form] Allow symfony/service-contracts v2
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | N/A
| License | MIT
| Doc PR | N/A
In Symfony 4.4 applications, the Form component currently prevents the installation of `symfony/service-contracts` 2.0.0. That should not be the case.
Commits
-------
4755e160be
[Form] Allow symfony/service-contracts v2.
2019-11-14 09:55:14 +01:00
Fabien Potencier
2a91f28ed4
bug #34369 [FrameworkBundle] Disallow WebProfilerBundle < 4.4 (derrabus)
...
This PR was merged into the 4.4 branch.
Discussion
----------
[FrameworkBundle] Disallow WebProfilerBundle < 4.4
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Fix #34364
| License | MIT
| Doc PR | N/A
Commits
-------
3d2b589af9
[FrameworkBundle] Disallow WebProfilerBundle < 4.4.
2019-11-14 05:22:53 +01:00
Fabien Potencier
afdb89fe3c
bug #34370 [DI] fix detecting singly implemented interfaces (nicolas-grekas)
...
This PR was merged into the 4.4 branch.
Discussion
----------
[DI] fix detecting singly implemented interfaces
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Fix #34361
| License | MIT
| Doc PR | -
Commits
-------
eccb937d97
[DI] fix detecting singly implemented interfaces
2019-11-14 05:11:06 +01:00
Nicolas Grekas
eccb937d97
[DI] fix detecting singly implemented interfaces
2019-11-13 22:56:53 +01:00
Alexander M. Turek
3d2b589af9
[FrameworkBundle] Disallow WebProfilerBundle < 4.4.
2019-11-13 22:26:07 +01:00
Alexander M. Turek
4755e160be
[Form] Allow symfony/service-contracts v2.
2019-11-13 22:07:47 +01:00
Fabien Potencier
29a2f17124
bumped Symfony version to 4.4.0
2019-11-13 10:18:19 +01:00
Fabien Potencier
97ee03e4dd
Merge pull request #34353 from fabpot/release-4.4.0-BETA2
...
released v4.4.0-BETA2
2019-11-13 10:13:50 +01:00
Fabien Potencier
8c47650d53
updated VERSION for 4.4.0-BETA2
2019-11-13 10:13:36 +01:00
Fabien Potencier
e8325ed818
updated CHANGELOG for 4.4.0-BETA2
2019-11-13 10:13:29 +01:00
Nicolas Grekas
ae3552685d
Merge branch '4.3' into 4.4
...
* 4.3:
[Console] Constant STDOUT might be undefined.
Allow returning null from NormalizerInterface::normalize
[Security\Core] throw AccessDeniedException when switch user fails
[Mime] fix guessing mime-types of files with leading dash
[HttpFoundation] fix guessing mime-types of files with leading dash
[VarExporter] fix exporting some strings
[Cache] forbid serializing AbstractAdapter and TagAwareAdapter instances
Use constant time comparison in UriSigner
2019-11-13 08:39:40 +01:00
Nicolas Grekas
983b5d1d5f
Merge branch '3.4' into 4.3
...
* 3.4:
[Console] Constant STDOUT might be undefined.
Allow returning null from NormalizerInterface::normalize
2019-11-13 08:29:07 +01:00
Nicolas Grekas
32bde39f63
bug #34344 [Console] Constant STDOUT might be undefined (nicolas-grekas)
...
This PR was merged into the 3.4 branch.
Discussion
----------
[Console] Constant STDOUT might be undefined
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Fix #34341
| License | MIT
| Doc PR | N/A
Commits
-------
bb8c82c0b5
[Console] Constant STDOUT might be undefined.
2019-11-13 08:27:07 +01:00
Nicolas Grekas
53dc781814
minor #34340 Allow returning null from NormalizerInterface::normalize (teohhanhui)
...
This PR was merged into the 3.4 branch.
Discussion
----------
Allow returning null from NormalizerInterface::normalize
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | yes?
| New feature? | no
| Deprecations? | no
| Tickets | N/A
| License | MIT
| Doc PR | N/A
Looking at the code, it seems that a normalizer might be called with a `null` value for `$data`, and thus it's only sensible that it be allowed to return `null` too:
7064ff35f2/src/Symfony/Component/Serializer/Serializer.php (L141-L148)
Updating the phpdoc to match.
Commits
-------
1c8edc55ad
Allow returning null from NormalizerInterface::normalize
2019-11-13 08:26:33 +01:00
Nicolas Grekas
43b753d318
minor #34343 [FrameworkBundle] Add missing conflict with symfony/serializer <4.4 (yceruto)
...
This PR was merged into the 4.4 branch.
Discussion
----------
[FrameworkBundle] Add missing conflict with symfony/serializer <4.4
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Fix #34342
| License | MIT
| Doc PR | -
Commits
-------
5db0981fd9
Add missing conflict with symfony/serializer <4.4
2019-11-13 08:24:55 +01:00
Nicolas Grekas
bb8c82c0b5
[Console] Constant STDOUT might be undefined.
2019-11-13 08:12:39 +01:00
Yonel Ceruto
5db0981fd9
Add missing conflict with symfony/serializer <4.4
2019-11-12 14:08:04 -05:00
Teoh Han Hui
1c8edc55ad
Allow returning null from NormalizerInterface::normalize
2019-11-12 18:51:12 +01:00
Fabien Potencier
839c6b4256
bumped Symfony version to 4.4.0
2019-11-12 18:50:34 +01:00
Fabien Potencier
28bcb9a68c
Merge pull request #34338 from fabpot/release-4.4.0-BETA1
...
Release v4.4.0-BETA1
2019-11-12 18:45:07 +01:00
Fabien Potencier
88927e1640
updated VERSION for 4.4.0-BETA1
2019-11-12 18:37:44 +01:00
Fabien Potencier
090aad009b
updated CHANGELOG for 4.4.0-BETA1
2019-11-12 18:37:14 +01:00
Nicolas Grekas
193306cfb1
bug #34336 Fix some \Throwable support remaining issues (fancyweb)
...
This PR was merged into the 4.4 branch.
Discussion
----------
Fix some \Throwable support remaining issues
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | -
| Deprecations? | -
| Tickets | -
| License | MIT
| Doc PR | -
Replaces https://github.com/symfony/symfony/pull/34335 and restore https://github.com/symfony/symfony/pull/34309/files#diff-234309116eb79dcc9603b3a49669e499L73 .
Commits
-------
47bd32e16f
Fix some \Throwable support remaining issues
2019-11-12 18:18:55 +01:00
Thomas Calvet
47bd32e16f
Fix some \Throwable support remaining issues
2019-11-12 18:18:47 +01:00
Nicolas Grekas
7cee181e08
feature #34333 Revert "feature #34329 [ExpressionLanguage] add XOR operator (ottaviano)" (nicolas-grekas)
...
This PR was merged into the 4.4 branch.
Discussion
----------
Revert "feature #34329 [ExpressionLanguage] add XOR operator (ottaviano)"
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | yes
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
This reverts commit d1d4bc8bad
, reversing
changes made to f63976fcbb
.
Commits
-------
adb716dd2c
Revert "feature #34329 [ExpressionLanguage] add XOR operator (ottaviano)"
2019-11-12 15:57:18 +01:00
Nicolas Grekas
686e9b7d72
feature #34332 Allow \Throwable $previous everywhere (fancyweb)
...
This PR was merged into the 4.4 branch.
Discussion
----------
Allow \Throwable $previous everywhere
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
Commits
-------
59e044dfb1
Allow \Throwable $previous everywhere
2019-11-12 15:56:48 +01:00
Nicolas Grekas
adb716dd2c
Revert "feature #34329 [ExpressionLanguage] add XOR operator (ottaviano)"
...
This reverts commit d1d4bc8bad
, reversing
changes made to f63976fcbb
.
2019-11-12 15:53:53 +01:00
Thomas Calvet
59e044dfb1
Allow \Throwable $previous everywhere
2019-11-12 15:51:11 +01:00
Nicolas Grekas
d1d4bc8bad
feature #34329 [ExpressionLanguage] add XOR operator (ottaviano)
...
This PR was merged into the 4.4 branch.
Discussion
----------
[ExpressionLanguage] add XOR operator
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | yes
| Deprecations? | no
| Tickets | ~
| License | MIT
| Doc PR | ~
👋
little PR for adding the best logical operator: `XOR`
Commits
-------
46fe91781d
[ExpressionLanguage] add XOR operator
2019-11-12 15:00:30 +01:00
Dimitri Gritsajuk
46fe91781d
[ExpressionLanguage] add XOR operator
2019-11-12 15:00:18 +01:00
Nicolas Grekas
f63976fcbb
bug #34331 [TwigBundle] Restore the preview mechanism (yceruto)
...
This PR was merged into the 4.4 branch.
Discussion
----------
[TwigBundle] Restore the preview mechanism
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
follow up https://github.com/symfony/symfony/pull/34312
Commits
-------
d3f1121885
[TwigBundle] Restore the preview mechanism
2019-11-12 14:55:43 +01:00
Yonel Ceruto
d3f1121885
[TwigBundle] Restore the preview mechanism
2019-11-12 08:42:17 -05:00
Nicolas Grekas
3ae3094a18
security #cve-2019-18886 [Security\Core] throw AccessDeniedException when switch user fails (nicolas-grekas)
...
This PR was merged into the 4.3 branch.
2019-11-12 14:13:43 +01:00
Nicolas Grekas
bcfc282d42
[Security\Core] throw AccessDeniedException when switch user fails
2019-11-12 14:12:56 +01:00
Nicolas Grekas
0b2c3a43bc
security #cve-2019-18888 [Mime] fix guessing mime-types of files with leading dash (nicolas-grekas)
...
This PR was merged into the 4.3 branch.
2019-11-12 14:10:56 +01:00
Nicolas Grekas
77ddabf2e7
[Mime] fix guessing mime-types of files with leading dash
2019-11-12 14:10:02 +01:00
Nicolas Grekas
227e73d164
security #cve-2019-11325 [VarExporter] fix exporting some strings (nicolas-grekas)
...
This PR was merged into the 4.3 branch.
2019-11-12 14:08:52 +01:00
Nicolas Grekas
2baf53aa7a
Merge branch '3.4' into 4.3
...
* 3.4:
[HttpFoundation] fix guessing mime-types of files with leading dash
[Cache] forbid serializing AbstractAdapter and TagAwareAdapter instances
Use constant time comparison in UriSigner
2019-11-12 14:07:20 +01:00
Nicolas Grekas
4cc37df2fb
security #cve-2019-18889 [Cache] forbid serializing AbstractAdapter and TagAwareAdapter instances (nicolas-grekas)
...
This PR was merged into the 3.4 branch.
2019-11-12 13:50:33 +01:00