This PR was merged into the 2.1 branch.
Discussion
----------
[DomCrawler] Fix Crawler::children() to not trigger a notice for childless node
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #8048
| License | MIT
| Doc PR | n/a
Commits
-------
91b8490 Fix Crawler::children() to not trigger a notice for childless node
This PR was merged into the 2.1 branch.
Discussion
----------
[Validator] Fixed XML syntax in translation.
| Q | A
| ------------- | ---
| Fixed tickets |
| License | MIT
Commits
-------
0a4837d Fixed XML syntax.
This PR was merged into the 2.1 branch.
Discussion
----------
Fixed parsing of leading blank lines in folded scalars.
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #7989
| License | MIT
| Doc PR | n/a
Fixed the issue raised in #7989. The cause was in the way the parser determined the indentation level of block scalars. When the indentation is not manually specified, the parser now determines the indentation from the first *non-empty* line as per section [8.1.1.1.](http://www.yaml.org/spec/1.2/spec.html#id2793979) of the spec.
Commits
-------
a5441b2 Fixed parsing of leading blank lines in folded scalars. Closes#7989.
This PR was submitted for the master branch but it was merged into the 2.1 branch instead (closes#7987).
Discussion
----------
[Config] FIxed Loader::import()
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? |no
| Tests pass? | yes
| Fixed tickets | fixes#7965, replaces #7983
| License | MIT
| Doc PR | -
Commits
-------
984e56a [Config] Added a test case for Loader::import().
2f69860 [Config] Fixed Loader import
This PR was squashed before being merged into the 2.1 branch (closes#7969).
Discussion
----------
[Console] Added dedicated testcase for HelperSet class
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | NA
| License | MIT
| Doc PR | NA
Previously the HelperSet class was only tested by way of the Application testcase. This patch adds a dedicated testcase and increases test coverage of the class to 100%.
Commits
-------
37af771 [Console] Added dedicated testcase for HelperSet class
This PR was merged into the 2.1 branch.
Discussion
----------
[Filesystem] Fix regression introduced in 10dea94
This is one of ideas to fix the regression from 10dea948, @kachkaev what do you think?
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| Tests pass? | yes
| Fixed tickets | #7920
| License | MIT
Commits
-------
e4913f8 [Filesystem] Fix regression introduced in 10dea948
This PR was merged into the 2.1 branch.
Discussion
----------
added a missing check for the provider key
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
Commits
-------
5b7e1e6 added a missing check for the provider key
This PR was merged into the 2.1 branch.
Discussion
----------
[Form] Fixed: String validation groups are never interpreted as callbacks
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #7371
| License | MIT
| Doc PR | -
Commits
-------
7b2ebbf [Form] Fixed: String validation groups are never interpreted as callbacks
This PR was squashed before being merged into the 2.1 branch (closes#7906).
Discussion
----------
if the repository method returns an array ensure that it's internal poin...
...ter is resetted
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #6651
| License | MIT
| Doc PR |
Commits
-------
0610750 if the repository method returns an array ensure that it's internal poin...
This PR was submitted for the master branch but it was merged into the 2.1 branch instead (closes#7909).
Discussion
----------
[DependencyInjection] Fix method use + example in doc block
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| License | MIT
Fixes using a wrong method in ``findTaggedServiceIds`` and adds an example for the usage and showing the returned data structure as ``@return array`` is not very helpful, the datastructure being a bit unintuitive.
Commits
-------
ad2c955 [DependencyInjection] Fix wrong method in findTaggedServiceIds(), add example to docblock.
This PR was submitted for the master branch but it was merged into the 2.1 branch instead (closes#7857).
Discussion
----------
[HttpCache] remove validation related headers when needed
| Q | A
| ------------- | ---
| Bug fix? | [yes]
| New feature? | [no]
| BC breaks? | [yes]
| Deprecations? | [no]
| Tests pass? | [yes]
| Fixed tickets | [#6977]
| License | MIT
Fixes#6977 by removing validation related headers when there is at least one embedded response.
I've added an embedded response counter because the current check was wrong I think, it was checking count($this->ttls) which isn't updated for validateable responses.
And for the BC break, looking at the interface PHPDoc description, it supposes add() method should only be applied on esi responses and update() takes the master one at the end, what do you think?
Commits
-------
bb80139 [HttpCache] remove validation related headers when needed
This PR was submitted for the master branch but it was merged into the 2.1 branch instead (closes#7886).
Discussion
----------
[HttpKernel][Profile] Fixes#7883
Commits
-------
0172fc1 [HttpKernel][Profile] use while loop for iterating
This PR was merged into the 2.1 branch.
Discussion
----------
[Filesystem] copy() is not working when open_basedir is set
More details: https://bugs.php.net/bug.php?id=64634
Commits
-------
10dea94 [Filesystem] copy() is not working when open_basedir is set
This PR was submitted for the master branch but it was merged into the 2.1 branch instead (closes#7871).
Discussion
----------
Fix getPort() returning 80 instead of 443 when X-FORWARDED-PROTO is set to https
[HttpFoundation] fixed something
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #7870
| License | MIT
| Doc PR |
Ensure that the getPort() method returns port 443 as default when
X-FORWARDED-PROTO is set to https. Currently it would return port 80
if X-FORWARDED-PROTO was set to https and X-FORWARDED-PORT was not
set by the trusted proxy.
Commits
-------
8554af3 Fix getPort() returning 80 instead of 443 when X-FORWARDED-PROTO is set to https
This PR was merged into the 2.1 branch.
Discussion
----------
[BrowserKit] fixed BC break done recently
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
This PR tries to avoid a BC break that was introduced recently in the management of cookies (see #7738).
see fabpot/Silex#684
Commits
-------
25b8b84 [BrowserKit] fixed BC break done recently
This PR was merged into the 2.1 branch.
Discussion
----------
[Process] Fix#5594 : `termsig` must be used instead of `stopsig` in exceptions when a process is signaled
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #5594
| License | MIT
When a process is signaled, an exception is thrown saying `The process has been signaled with signal "0".`. This is wrong because "0" is not a signal.
This is actually a bug in `Process` because we retrieve the `stopsig` property of the process status whereas we should retrieve the `termsig`.
`stopsig` should be retrieved in case the process has been stopped, and `termsig` when it has been signaled, see [PHP documentation](http://www.php.net/manual/en/function.proc-get-status.php).
Commits
-------
8757ad4 [Process] Fix#5594 : `termsig` must be used instead of `stopsig` in exceptions when a process is signaled
This PR was submitted for the master branch but it was merged into the 2.1 branch instead (closes#7837).
Discussion
----------
Rename misprint property (from warmer to finder)
Commits
-------
a1f5bd5 Rename misprint property (from warmer to finder)
This PR was merged into the 2.1 branch.
Discussion
----------
Add This field is missing RU translation
This PR was submitted on the symfony/Validator read-only repository and moved automatically to the main Symfony repository (closessymfony/Validator#4).
<source>This field is missing.</source>
Have no translation. Not exists in EN version too. Just forgot?
Symfony\Component\Validator\Constraints\Collection()
public $missingFieldsMessage = 'This field is missing.';
Commits
-------
97c4291 Add This field is missing RU translation
<source>This field is missing.</source>
Have no translation. Not exists in EN version too. Just forgotten?
Symfony\Component\Validator\Constraints\Collection()
public $missingFieldsMessage = 'This field is missing.';
