Commit Graph

6286 Commits

Author SHA1 Message Date
Abdellatif Ait boudad
1999e89e7c [TranslationUpdateCommand] fixed undefined resultMessage var. 2015-12-10 19:14:16 +00:00
Nicolas Grekas
829c011b49 Merge branch '2.7' into 2.8
* 2.7:
  [Process] Enhance compatiblity with --enable-sigchild
  fix short array syntax for php 5.3
  [Serializer] Fixed  on array of objects in .
  [Process] Always call proc_close
  [Validator] Updated Luxembourgish translations for 2.8
  disable server commands without Process component
  list all server command names in suggestion
  Suggested Process dependency
  disable server:run cmd without Process component
  Suggested Process dependency
  [FrameworkBundle] prevent cache:clear creating too long paths
  [FrameworkBundle] [Translation] Fixed translations not written when no translations directory in update command

Conflicts:
	.travis.yml
	src/Symfony/Bundle/FrameworkBundle/Command/TranslationUpdateCommand.php
	src/Symfony/Bundle/FrameworkBundle/composer.json
2015-12-10 18:11:25 +01:00
Nicolas Grekas
f253d624a0 Merge branch '2.3' into 2.7
* 2.3:
  [Process] Enhance compatiblity with --enable-sigchild
  [Process] Always call proc_close
  [Validator] Updated Luxembourgish translations for 2.8
  [FrameworkBundle] prevent cache:clear creating too long paths

Conflicts:
	src/Symfony/Component/Process/Tests/ProcessTest.php
	src/Symfony/Component/Process/Tests/SigchildDisabledProcessTest.php
	src/Symfony/Component/Process/Tests/SigchildEnabledProcessTest.php
	src/Symfony/Component/Process/Tests/SimpleProcessTest.php
	src/Symfony/Component/Validator/Resources/translations/validators.lb.xlf
2015-12-10 17:58:22 +01:00
Tobias Schultze
4cde2d1e33 bug #16829 [FrameworkBundle] prevent cache:clear creating too long paths (Tobion)
This PR was merged into the 2.3 branch.

Discussion
----------

[FrameworkBundle] prevent cache:clear creating too long paths

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #15547 #16783
| License       | MIT
| Doc PR        | -

Commits
-------

6e279c5 [FrameworkBundle] prevent cache:clear creating too long paths
2015-12-10 01:42:36 +01:00
Almog Baku
d2b9a1db88 [FrameworkBundle] [Bug] Fixes new InputStyle bug #16920 2015-12-09 14:54:22 +01:00
Fabien Potencier
420da14156 bug #16757 [FrameworkBundle] [Translation] Fixed translations not written when no translations directory in update command (jeremyFreeAgent)
This PR was merged into the 2.7 branch.

Discussion
----------

[FrameworkBundle] [Translation] Fixed translations not written when no translations directory in update command

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Currently when you run the TranslationUpdateCommand and want to write the translation in the domain file without a `translations` directory the output is `[OK] Success` but the file is not created.

This PR fix the creation of the directory.

Commits
-------

8c45107 [FrameworkBundle] [Translation] Fixed translations not written when no translations directory in update command
2015-12-08 19:14:24 +01:00
Javier Eguiluz
c5067dacb3 Improved the code of the commands that use the new SymfonyStyle class 2015-12-07 22:56:39 +01:00
Fabien Potencier
b8fbe69bb8 bug #16871 [FrameworkBundle] Disable built-in server commands when Process component is missing (gnugat, xabbuh)
This PR was merged into the 2.7 branch.

Discussion
----------

[FrameworkBundle] Disable built-in server commands when Process component is missing

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

This also backports the improvement for the `suggest` section from #16650 to the `2.7` branch and improves it by also mentioning the other built-in server commands.

Commits
-------

972c4ca disable server commands without Process component
dd82b64 list all server command names in suggestion
d18fb9b Suggested Process dependency
2015-12-07 22:55:06 +01:00
Fabien Potencier
52915ede0f Merge branch '2.3' into 2.7
* 2.3:
  disable server:run cmd without Process component
  Suggested Process dependency
2015-12-07 22:53:02 +01:00
Christian Flothmann
972c4caae8 disable server commands without Process component 2015-12-06 23:34:46 +01:00
Christian Flothmann
dd82b6459d list all server command names in suggestion 2015-12-06 23:34:45 +01:00
Loïc Faugeron
d18fb9bbbe Suggested Process dependency
The `server:run` command requires the Process component.
2015-12-06 23:33:58 +01:00
Christian Flothmann
99d174176a disable server:run cmd without Process component 2015-12-06 23:31:12 +01:00
Loïc Faugeron
604174c963 Suggested Process dependency
The `server:run` command requires the Process component.
2015-12-06 23:31:09 +01:00
Christophe Coevoet
dbb0ba8f11 Merge branch '2.7' into 2.8
* 2.7:
  [Process] Fix stopping a process on Windows
  Added a test case for the Logger class.
  CS: general fixes
2015-12-05 18:37:59 +01:00
Christophe Coevoet
237b13c56c Merge branch '2.3' into 2.7
* 2.3:
  [Process] Fix stopping a process on Windows
  Added a test case for the Logger class.
  CS: general fixes
2015-12-05 18:37:09 +01:00
Christophe Coevoet
b6e13f8861 minor #16650 Suggested Process dependency (gnugat)
This PR was merged into the 2.8 branch.

Discussion
----------

Suggested Process dependency

The `server:run` command requires the Process component.

Commits
-------

7c1231a Suggested Process dependency
2015-12-05 16:18:14 +01:00
Tobias Schultze
6e279c5f8a [FrameworkBundle] prevent cache:clear creating too long paths 2015-12-05 03:07:20 +01:00
Dariusz Ruminski
d3f671e8f6 CS: general fixes 2015-12-01 23:08:33 +01:00
Jérémy Romey
8c45107856 [FrameworkBundle] [Translation] Fixed translations not written when no translations directory in update command 2015-11-30 14:03:45 +01:00
Nicolas Grekas
ef61e5481f Forward compatibility with AbstractLayout* 2.8 tests 2015-11-29 18:06:34 +01:00
WouterJ
b272ab569f Make sure security.role_hierarchy.roles always exists 2015-11-29 09:13:21 +01:00
WouterJ
96afff6a05 [SecurityBundle] Fix disabling of RoleHierarchyVoter when passing empty hierarchy 2015-11-28 16:45:57 +01:00
Jakub Zalas
04508658b5 [Security][SecurityBundle] Use csrf_token_id instead of deprecated intention 2015-11-28 16:40:40 +01:00
Christian Flothmann
444b6eff0a test legacy CSRF configuration options 2015-11-28 09:35:12 +01:00
Nicolas Grekas
62eba7c426 [Form+SecurityBundle] Trigger deprecation for csrf_provider+intention options 2015-11-27 13:22:26 +01:00
Fabien Potencier
5de9c354dd Merge branch '2.7' into 2.8
* 2.7:
  Fixed the wrong source name and the ja translation
  [Debug] fix readme: DebugClassLoader moved to debug itself
  [SecurityBundle] disable the init:acl command if ACL is not used
  [DI] remove useless condition around unset
  [Form] Disabled view data validation if "data_class" is set to null
  [HttpFoundation] Workaround HHVM rewriting HTTP response line
2015-11-27 06:45:55 +01:00
Fabien Potencier
d65b92469e Merge branch '2.3' into 2.7
* 2.3:
  Fixed the wrong source name and the ja translation
  [SecurityBundle] disable the init:acl command if ACL is not used
  [DI] remove useless condition around unset
2015-11-27 06:41:56 +01:00
Tobias Schultze
55f84a3369 [SecurityBundle] disable the init:acl command if ACL is not used 2015-11-26 20:19:29 +01:00
Fabien Potencier
14f70aeafd bug #16621 [Console] Fix bug with $output overloading (WouterJ)
This PR was squashed before being merged into the 2.8 branch (closes #16621).

Discussion
----------

[Console] Fix bug with $output overloading

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | https://github.com/symfony/symfony-standard/issues/887, #16622
| License       | MIT
| Doc PR        | -

This is exactly why variable overloading isn't a great idea :)

Commits
-------

5764a00 [Console] Fix bug with  overloading
2015-11-26 17:44:52 +01:00
Wouter J
5764a00a76 [Console] Fix bug with overloading 2015-11-26 17:44:51 +01:00
Javier Eguiluz
09f489530b Fixes the stack traces of the deprecation logs 2015-11-25 09:53:09 +01:00
Fabien Potencier
074a4bf89e minor #16647 Minor design tweaks for the Logs and Doctrine profiler panels (javiereguiluz)
This PR was merged into the 2.8 branch.

Discussion
----------

Minor design tweaks for the Logs and Doctrine profiler panels

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

### Logger panel BEFORE

![stacktrace_before](https://cloud.githubusercontent.com/assets/73419/11362363/65924218-9293-11e5-8b89-c405e6bcee9a.png)

### Logger panel AFTER

![stacktrace_after](https://cloud.githubusercontent.com/assets/73419/11362365/68cd37da-9293-11e5-8ef9-607d60a1b4cf.png)

### Doctrine panel BEFORE

![doctrine_before](https://cloud.githubusercontent.com/assets/73419/11362370/6ce78f14-9293-11e5-8bd8-d486447c1134.png)

### Doctrine panel AFTER

![doctrine_after](https://cloud.githubusercontent.com/assets/73419/11362372/71a3eade-9293-11e5-9949-a7f0463fb12a.png)

Commits
-------

fdfa176 Minor design tweaks for the Logs and Doctrine profiler panels
2015-11-25 05:22:23 +01:00
Fabien Potencier
09e896c306 feature #16031 [Translation][Form] Do not translate form labels and placeholders when 'translation_domain' is false (Restless-ET)
This PR was squashed before being merged into the 2.8 branch (closes #16031).

Discussion
----------

[Translation][Form] Do not translate form labels and placeholders when 'translation_domain' is false

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Seems like this behaviour was already partially added (as stated [here](https://github.com/symfony/symfony/pull/16016#issuecomment-144464875)) to solve the problem of expanded choice widgets.

Commits
-------

0e0b904 [Translation][Form] Do not translate form labels and placeholders when 'translation_domain' is false
2015-11-25 05:07:02 +01:00
Restless-ET
0e0b904ff2 [Translation][Form] Do not translate form labels and placeholders when 'translation_domain' is false 2015-11-25 05:06:57 +01:00
Loïc Faugeron
7c1231a2e0 Suggested Process dependency
The `server:run` command requires the Process component.
2015-11-24 11:52:35 +00:00
Javier Eguiluz
fdfa1767b9 Minor design tweaks for the Logs and Doctrine profiler panels 2015-11-24 10:07:02 +01:00
Fabien Potencier
922b9468b1 bug #16609 [HttpKernel] Don't reset on shutdown but in FrameworkBundle/Test/KernelTestCase (nicolas-grekas)
This PR was merged into the 2.8 branch.

Discussion
----------

[HttpKernel] Don't reset on shutdown but in FrameworkBundle/Test/KernelTestCase

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #15185
| License       | MIT
| Doc PR        | -

While trying to migrate Blackfire to 2.8-beta, I found this BC-break: by resetting the container on kernel shut-down, functional tests are broken when they need to use the container after a call to `$this->client->request()`. Broken because e.g . the session or the profiler state is lost between consecutive requests in the same test, and because a call to $container->get('kernel') throws a synthetic-related exception.

This PR fixes the BC-break by reverting to the <=2.7 behavior (not resetting the container on kernel shut-down), and moving resetting to the KernelTestCase.

Commits
-------

baad4da [HttpKernel] Don't reset on shutdown but in FrameworkBundle/Test/KernelTestCase
2015-11-23 10:32:50 +01:00
Jelle Kapitein
ca9f446f03 [WebProfilerBundle] Added a top left border radius to the minified to… 2015-11-23 10:30:25 +01:00
Nicolas Grekas
baad4da9b7 [HttpKernel] Don't reset on shutdown but in FrameworkBundle/Test/KernelTestCase 2015-11-20 13:20:48 +01:00
Richard
0459912523 [WebProfilerBundle] Fix minitoolbar height 2015-11-19 10:07:51 +01:00
Nicolas Grekas
ecdd681898 Merge branch '2.7' into 2.8
* 2.7:
  Fix undefined array $server
  Fix bug in windows detection
  [ProxyManager] Tmp fix composer reqs issue in ZF
  Add missing exclusions from phpunit.xml.dist
  [Serializer] ObjectNormalizer: don't serialize static methods and props
  Fix the server variables in the router_*.php files
  [Validator] Allow an empty path with a non empty fragment or a query
  The following change adds support for Armenian pluralization.
  [2.3][Process] fix Proccess run with pts enabled

Conflicts:
	composer.json
	src/Symfony/Bridge/ProxyManager/composer.json
	src/Symfony/Component/Security/phpunit.xml.dist
2015-11-18 14:45:00 +01:00
Nicolas Grekas
a8d21b5ca9 Merge branch '2.3' into 2.7
* 2.3:
  Fix undefined array $server
  [ProxyManager] Tmp fix composer reqs issue in ZF
  Add missing exclusions from phpunit.xml.dist
  Fix the server variables in the router_*.php files
  [Validator] Allow an empty path with a non empty fragment or a query
  The following change adds support for Armenian pluralization.
  [2.3][Process] fix Proccess run with pts enabled

Conflicts:
	composer.json
	src/Symfony/Bridge/ProxyManager/composer.json
	src/Symfony/Bundle/DebugBundle/phpunit.xml.dist
	src/Symfony/Component/Security/phpunit.xml.dist
2015-11-18 14:41:01 +01:00
Jérôme Vasseur
d04984ad05 Fix PropertyInfo extractor namespace in framework bundle 2015-11-18 09:40:44 +01:00
Nicolas Grekas
d4880c4785 Add missing exclusions from phpunit.xml.dist 2015-11-18 09:19:46 +01:00
Tobias Schultze
17608389f1 minor #16568 [Form] Enhance some FormRegistry deprecation messages (nicolas-grekas)
This PR was merged into the 2.8 branch.

Discussion
----------

[Form] Enhance some FormRegistry deprecation messages

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

02d2148 [Form] Enhance some FormRegistry deprecation messages
2015-11-17 12:52:32 +01:00
Nicolas Grekas
02d2148f37 [Form] Enhance some FormRegistry deprecation messages 2015-11-17 11:33:11 +01:00
Douglas Greenshields
9b0850511f [WebProfilerBundle] correct typo in show stack trace link 2015-11-17 00:47:20 +00:00
Fabien Potencier
c0f7463c3e bug #16352 Fix the server variables in the router_*.php files (leofeyer)
This PR was squashed before being merged into the 2.3 branch (closes #16352).

Discussion
----------

Fix the server variables in the router_*.php files

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | none
| License       | MIT

The built-in web server automatically rewrites everything to the `app_dev.php` script, but it does not adjust the server variables accordingly.

Here is the output of `print_r($_SERVER)` on Apache with mod_rewrite enabled (relevant lines only):

```
Array
(
    [REQUEST_URI] => /text-elements.html
    [SCRIPT_NAME] => /app_dev.php
    [PHP_SELF] => /app_dev.php
)
```

And here is the output of the exact same script on the built-in server:

```
Array
(
    [REQUEST_URI] => /text-elements.html
    [SCRIPT_NAME] => /text-elements.html
    [PHP_SELF] => /text-elements.html
)
```

And here is the return value of Symfony's `Request::getScriptName()` method:

```php
// Apache: http://localhost/text-elements.html
echo $this->container->get('request_stack')->getCurrentRequest()->getScriptName(); // /app_dev.php

// Built-in web server: http://127.0.0.1:8000/text-elements.html
echo $this->container->get('request_stack')->getCurrentRequest()->getScriptName(); // /text-elements.html
```

This PR fixes the two server variables in the `router_dev.php` script.

Commits
-------

4923411 Fix the server variables in the router_*.php files
2015-11-13 09:09:50 +01:00
Leo Feyer
4923411062 Fix the server variables in the router_*.php files 2015-11-13 09:09:48 +01:00