This PR was merged into the 4.4 branch.
Discussion
----------
do not mock event classes
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets |
| License | MIT
| Doc PR |
Commits
-------
8da1969afc do not mock event classes
This PR was merged into the 4.4 branch.
Discussion
----------
[GHA] Clarify some bits in the deps=high script
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | Fix -
| License | MIT
| Doc PR |
I had some difficulty understanding how flipped tests worked. Luckily, `@nicolas`-grekas was available to answer some questions. However, I'm sure that I've forgotten the logic in about a week time, so I think it's worth clarifying the code a bit (but feel free to close if it's just me).
Commits
-------
ff08dcaca6 [GHA] Clarify some bits in the deps=high script
This PR was squashed before being merged into the 4.4 branch.
Discussion
----------
[ErrorHandle] Remove a link from the exception page
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
This link is causing lots of confusion to some people, who think that we provide free support for open source Symfony projects. That's why we've decided to remove this link. Thanks!
Commits
-------
387254ff5a [ErrorHandle] Remove a link from the exception page
This PR was merged into the 4.4 branch.
Discussion
----------
[Validator] Added Ukrainian translations
| Q | A
| ------------- | ---
| Branch? | 4.4 <!-- see below -->
| Bug fix? | no
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets | Fix#41838 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License | MIT
| Doc PR | <!-- required for new features -->
Added some missing Ukrainian translations.
Commits
-------
b3c28ca02c [Validator] Added Ukrainian translations
This PR was merged into the 4.4 branch.
Discussion
----------
[DomCrawler] Backport type fixes
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | N/A
| License | MIT
| Doc PR | N/A
Discovered while working on #41981.
Commits
-------
6996988fe5 [DomCrawler] Backport type fixes
This PR was merged into the 4.4 branch.
Discussion
----------
[Cache] backport type fixes
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
Backported from #42015
Commits
-------
a6a00915c3 [Cache] backport type fixes
This PR was submitted for the 5.4 branch but it was merged into the 4.4 branch instead.
Discussion
----------
[Translation] Missing translations from traits
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Fix#40528 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License | MIT
| Doc PR | symfony/symfony-docs#... <!-- required for new features -->
If you use ->trans() in traits, your translations will be cleaned with translation:update --clean command
Affected all Symfony versions
Please write some tests for me, I took me long time to debug and repair this :(
Commits
-------
0d8737ff16 Missing translations from traits
This PR was merged into the 4.4 branch.
Discussion
----------
Fix SkippedTestSuite
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
Throwing a TestSkipped in a `setUpBeforeClass` si handled by PHP unit as a standard exception, leading to a generic exception `Test skipped because of an error in hook method` (see https://github.com/symfony/symfony/pull/41380/checks?check_run_id=2645369759#step:14:165)
However phpunit is able to catch `SkippedTestSuiteError` in such situation.(https://github.com/sebastianbergmann/phpunit/blob/master/src/Framework/TestSuite.php#L438-L448)
This PR replaces `self::markTestSkipped` by `throw new SkippedTestSuiteError` (we don't have static method helper for this exception) in our `setUpBeforeClass` methods.
Commits
-------
6f2aa6d245 Fix SkippedTestSuite
This PR was merged into the 4.4 branch.
Discussion
----------
[Console] Revert "bug #41952 fix handling positional arguments"
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
Reverts #41952 as it breaks tests on 5.3 due to an implicit string cast:
We added the `string` typehint to the `$name` argument in 5.x, removing it now to allow for `string|int` would be a BC break which I don't think is worth it.
Commits
-------
6ac2776c47 [Console] Fix type annotation on InputInterface::hasArgument()
9928be05fe Revert "minor #41949 [Console] fix type annotations on InputInterface (nicolas-grekas)"
8fc58aaa45 Revert "bug #41952 [Console] fix handling positional arguments (nicolas-grekas)"
This PR was submitted for the 5.4 branch but it was squashed and merged into the 4.4 branch instead.
Discussion
----------
[EventDispatcher] Correct the called event listener method case
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | none
| Tickets | none
| License | MIT
| Doc PR | none
when define an event listener, if you don't specify a method, then the word case of the actual method maybe wrong, for example :
```yaml
services:
my_kernel_envent_listeners:
class: App\EventListener\KernelListener
tags:
- { name: kernel.event_listener, event: kernel.controller_arguments }
```
no `method` key at this tag, then actual method called is `onKernelControllerarguments`, actually it should be `onKernelControllerArguments`, the case of word 'arguments' should be upper.
ps: only event name that has dash(`_`) will be affected.
Commits
-------
29b4b76416 [EventDispatcher] Correct the called event listener method case
This PR was merged into the 4.4 branch.
Discussion
----------
[Validator] Add missing translations for Japanese.
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | Fix#41823
| License | MIT
| Doc PR | N/A
This PR adds missing Japanese translations.
Commits
-------
603ea6af14 Add missing translations for Japanese.
This PR was merged into the 4.4 branch.
Discussion
----------
Add Bulgarian translation for the validator
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | Fix#38710
| License | MIT
| Doc PR | N/A
Commits
-------
a812cea58a Add Bulgarian translation for the validator
This PR was merged into the 4.4 branch.
Discussion
----------
[Console] fix type annotations on InputInterface
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
`hasArgument` already accepts `string|int`.
Makes sense?
Commits
-------
ab76477012 [Console] fix type annotations on InputInterface
This PR was merged into the 4.4 branch.
Discussion
----------
[PhpUnitBridge] Avoid triggering the autoloader in Deprecation::isLegacy()
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | N/A
| License | MIT
| Doc PR | N/A
The low-deps tests are currently failing because Deprecation::isLegacy() keeps triggering the autoloader and might even do so while `DebugClassLoader` considers a failed autoload attempt as an error.
Commits
-------
b95dfede5f Avoid triggering the autoloader in Deprecation::isLegacy()
This PR was merged into the 4.4 branch.
Discussion
----------
[4.4] Backport type fixes
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
And other changes made while preparing 6.0.
Commits
-------
e1afcb6de1 Backport type fixes
Nicolas Grekas
Christian Flothmann
Fabien Potencier
Javier Eguiluz
Andrii Bodnar
Alexander M. Turek
Wouter de Jong
Yup
Exploit.cz
Jérémy Derussé
jaggle
Ippei Sumida
Robin Chalas
Adrian Nguyen
Ivo Valchev
