Commit Graph

19681 Commits

Author SHA1 Message Date
Bernhard Schussek
7e89345a0d [Form] Added getBlockPrefix() to ResolvedFormTypeInterface 2015-11-29 22:12:04 +01:00
Christian Flothmann
21270585a6 [Yaml] look for colon in parsed inline string
Looking for a colon in an unquoted mapping value can lead to falsely
reported parse errors (e.g. when a comment after the mapping value
contains a colon).
2015-11-29 19:08:13 +01:00
Nicolas Grekas
ef61e5481f Forward compatibility with AbstractLayout* 2.8 tests 2015-11-29 18:06:34 +01:00
Nicolas Grekas
ab2044f6d8 Merge branch '2.8'
* 2.8:
  [Bridge/Doctrine+Ldap] Fix tests
  Marked the Ldap component as internal and removed Ldap constants polyfill

Conflicts:
	src/Symfony/Bridge/Doctrine/Tests/Form/Type/EntityTypeTest.php
2015-11-29 17:26:49 +01:00
Nicolas Grekas
4819a702d7 [Bridge/Doctrine+Ldap] Fix tests 2015-11-29 17:07:42 +01:00
Martin Hujer
613804d0cf [Yaml] minor CS cleaning 2015-11-29 11:53:50 +01:00
Fabien Potencier
afe1668b41 feature #16735 [WIP] [Ldap] Marked the Ldap component as internal (csarrazi)
This PR was merged into the 2.8 branch.

Discussion
----------

[WIP] [Ldap] Marked the Ldap component as internal

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | no
| Fixed tickets | no
| License       | MIT
| Doc PR        | not yet

As mentioned earlier, the LDAP component suffers from a few problems, addressed in PR #15994
However, as raised by @Tobion, the component does not yet have tests (they can be added at a later time, though), and is not considered stable yet.

Commits
-------

3f89b2c Marked the Ldap component as internal and removed Ldap constants polyfill
2015-11-29 11:47:37 +01:00
Nicolas Grekas
9952ef9ec7 Merge branch '2.8'
* 2.8:
  [Bridge/Twig] Fix lowest form dep
  [Bridge/Doctrine] Fix legacy tests
  Make sure security.role_hierarchy.roles always exists
  [Form] Fix tests and reference usage
  [SecurityBundle] Fix disabling of RoleHierarchyVoter when passing empty hierarchy

Conflicts:
	src/Symfony/Bridge/Doctrine/Tests/Form/ChoiceList/AbstractEntityChoiceListCompositeIdTest.php
	src/Symfony/Bridge/Doctrine/Tests/Form/ChoiceList/AbstractEntityChoiceListSingleAssociationToIntIdTest.php
	src/Symfony/Bridge/Doctrine/Tests/Form/ChoiceList/AbstractEntityChoiceListSingleIntIdTest.php
	src/Symfony/Bridge/Doctrine/Tests/Form/ChoiceList/AbstractEntityChoiceListSingleStringIdTest.php
	src/Symfony/Bridge/Doctrine/Tests/Form/ChoiceList/AbstractEntityChoiceListTest.php
	src/Symfony/Bridge/Doctrine/Tests/Form/ChoiceList/LoadedEntityChoiceListCompositeIdTest.php
	src/Symfony/Bridge/Doctrine/Tests/Form/ChoiceList/LoadedEntityChoiceListSingleAssociationToIntIdTest.php
	src/Symfony/Bridge/Doctrine/Tests/Form/ChoiceList/LoadedEntityChoiceListSingleIntIdTest.php
	src/Symfony/Bridge/Doctrine/Tests/Form/ChoiceList/LoadedEntityChoiceListSingleStringIdTest.php
	src/Symfony/Bridge/Doctrine/Tests/Form/ChoiceList/UnloadedEntityChoiceListCompositeIdTest.php
	src/Symfony/Bridge/Doctrine/Tests/Form/ChoiceList/UnloadedEntityChoiceListCompositeIdWithQueryBuilderTest.php
	src/Symfony/Bridge/Doctrine/Tests/Form/ChoiceList/UnloadedEntityChoiceListSingleAssociationToIntIdTest.php
	src/Symfony/Bridge/Doctrine/Tests/Form/ChoiceList/UnloadedEntityChoiceListSingleAssociationToIntIdWithQueryBuilderTest.php
	src/Symfony/Bridge/Doctrine/Tests/Form/ChoiceList/UnloadedEntityChoiceListSingleIntIdTest.php
	src/Symfony/Bridge/Doctrine/Tests/Form/ChoiceList/UnloadedEntityChoiceListSingleIntIdWithQueryBuilderTest.php
	src/Symfony/Bridge/Doctrine/Tests/Form/ChoiceList/UnloadedEntityChoiceListSingleStringIdTest.php
	src/Symfony/Bridge/Doctrine/Tests/Form/ChoiceList/UnloadedEntityChoiceListSingleStringIdWithQueryBuilderTest.php
	src/Symfony/Bundle/SecurityBundle/Resources/config/security.xml
	src/Symfony/Component/Form/Extension/Core/Type/ChoiceType.php
2015-11-29 11:01:15 +01:00
Nicolas Grekas
b255dfebc3 minor #16739 [Bridge/Doctrine] Fix legacy tests (nicolas-grekas)
This PR was merged into the 2.8 branch.

Discussion
----------

[Bridge/Doctrine] Fix legacy tests

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | no fatal error anymore
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

7d92372 [Bridge/Doctrine] Fix legacy tests
2015-11-29 10:58:44 +01:00
Nicolas Grekas
0dd72cd5be Merge branch '2.7' into 2.8
* 2.7:
  [Bridge/Twig] Fix lowest form dep
  [Form] Fix tests and reference usage

Conflicts:
	src/Symfony/Bridge/Twig/composer.json
2015-11-29 10:57:23 +01:00
Nicolas Grekas
beb8525fe4 [Bridge/Twig] Fix lowest form dep 2015-11-29 10:55:05 +01:00
Nicolas Grekas
7d9237200f [Bridge/Doctrine] Fix legacy tests 2015-11-29 10:46:30 +01:00
WouterJ
b272ab569f Make sure security.role_hierarchy.roles always exists 2015-11-29 09:13:21 +01:00
Charles Sarrazin
3f89b2c714 Marked the Ldap component as internal and removed Ldap constants polyfill 2015-11-28 23:36:49 +01:00
Tobias Schultze
873a5417a8 [Console] do not encode backslashes in console default description 2015-11-28 23:15:59 +01:00
Nicolas Grekas
a3f48a5879 [Bridge/Twig] Fix legacy test 2015-11-28 19:08:21 +01:00
Nicolas Grekas
2cb74982de minor #16728 [Form] removed unused base test case (xabbuh)
This PR was merged into the 3.0-dev branch.

Discussion
----------

[Form] removed unused base test case

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

fa9fd26 [Form] removed unused base test case
2015-11-28 18:13:40 +01:00
Nicolas Grekas
6001644ffe [Form] Fix tests and reference usage 2015-11-28 17:53:21 +01:00
Christian Flothmann
fa9fd26016 [Form] removed unused base test case 2015-11-28 17:25:40 +01:00
Tobias Schultze
07ac1229d3 feature #16723 [Form] remove deprecated CSRF options (xabbuh)
This PR was merged into the 3.0-dev branch.

Discussion
----------

[Form] remove deprecated CSRF options

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

d641fc5 [Form] remove deprecated CSRF options
2015-11-28 17:15:22 +01:00
Tobias Schultze
445bdadc96 feature #16725 [Form] Removed useless code (webmozart)
This PR was merged into the 3.0-dev branch.

Discussion
----------

[Form] Removed useless code

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

8add405 [Form] Removed useless code
2015-11-28 16:52:51 +01:00
Christian Flothmann
d641fc5d7c [Form] remove deprecated CSRF options 2015-11-28 16:51:48 +01:00
WouterJ
96afff6a05 [SecurityBundle] Fix disabling of RoleHierarchyVoter when passing empty hierarchy 2015-11-28 16:45:57 +01:00
Fabien Potencier
6e6ac49946 Merge branch '2.8'
* 2.8:
  [Security][SecurityBundle] Use csrf_token_id instead of deprecated intention
2015-11-28 16:44:17 +01:00
Fabien Potencier
f2ee5618cf feature #16724 [3.0] Added getBlockPrefix to FormTypeInterface (WouterJ)
This PR was merged into the 3.0-dev branch.

Discussion
----------

[3.0] Added getBlockPrefix to FormTypeInterface

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

d834cd3 Added getBlockPrefix to FormTypeInterface
2015-11-28 16:43:01 +01:00
Fabien Potencier
5486c689cf feature #16722 [Security][SecurityBundle] Use csrf_token_id instead of deprecated intention (jakzal)
This PR was squashed before being merged into the 2.8 branch (closes #16722).

Discussion
----------

[Security][SecurityBundle] Use csrf_token_id instead of deprecated intention

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #16720
| License       | MIT
| Doc PR        | -

Commits
-------

0450865 [Security][SecurityBundle] Use csrf_token_id instead of deprecated intention
2015-11-28 16:40:59 +01:00
Jakub Zalas
04508658b5 [Security][SecurityBundle] Use csrf_token_id instead of deprecated intention 2015-11-28 16:40:40 +01:00
Christian Flothmann
4a2aea0bd7 [Form] remove deprecated getTimezones() method 2015-11-28 16:31:53 +01:00
Fabien Potencier
b5b1d504b4 minor #16707 [Process] Remove PHP_BINARY existence check (ogizanagi)
This PR was merged into the 3.0-dev branch.

Discussion
----------

[Process] Remove PHP_BINARY existence check

| Q             | A
| ------------- | ---
| Fixed tickets | -
| License       | MIT

`PHP_BINARY` constant will always exists as of PHP >= 5.4.

Commits
-------

42a75bc [Process] Remove PHP_BINARY existence check
2015-11-28 14:17:09 +01:00
Nicolas Grekas
c2b54bbf47 Merge branch '2.8'
* 2.8:
  [Bundle\Twig] Fix lowet form dep

Conflicts:
	src/Symfony/Bridge/Twig/composer.json
2015-11-28 13:50:03 +01:00
Nicolas Grekas
f94c6d4126 [Bundle\Twig] Fix lowet form dep 2015-11-28 13:49:09 +01:00
Bernhard Schussek
8add4053c0 [Form] Removed useless code 2015-11-28 13:33:28 +01:00
WouterJ
d834cd3d68 Added getBlockPrefix to FormTypeInterface 2015-11-28 12:15:28 +01:00
Fabien Potencier
7ba5f7acb3 Merge branch '2.8'
* 2.8:
  [HttpKernel] clearstatcache() so the Cache sees when a .lck file has been released
  [WIP] [Form] [TwigBridge] Bootstrap horizontal theme missing tests
  [Serializer] Improve ObjectNormalizer performance
  AssetBundle - fix docs
  [Yaml] more fixes to changelog and upgrade files
  CS: remove impossible default argument value
2015-11-28 12:03:53 +01:00
Fabien Potencier
cd0639d95b Merge branch '2.7' into 2.8
* 2.7:
  [HttpKernel] clearstatcache() so the Cache sees when a .lck file has been released
  [WIP] [Form] [TwigBridge] Bootstrap horizontal theme missing tests
  AssetBundle - fix docs
  CS: remove impossible default argument value
2015-11-28 12:03:39 +01:00
Fabien Potencier
e3f4278d59 Merge branch '2.3' into 2.7
* 2.3:
  [HttpKernel] clearstatcache() so the Cache sees when a .lck file has been released
2015-11-28 12:02:41 +01:00
Fabien Potencier
b2899a6c2e bug #16312 [HttpKernel] clearstatcache() so the Cache sees when a .lck file has been released (mpdude)
This PR was squashed before being merged into the 2.3 branch (closes #16312).

Discussion
----------

[HttpKernel] clearstatcache() so the Cache sees when a .lck file has been released

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #15813
| License       | MIT
| Doc PR        | n/a

I've been trying to debug #15813 and modified the Store in a way to keep unique request IDs in the .lck file. That way, I was hoping to find out which request is blocking and/or if the request is actually still running.

It turned out that `is_file()` would claim that a lock file still exists, but a subsequent attempt to read the information from that file returned "file not found" errors.

So, my assumption is that the `is_file()` result is based on the fstat cache and wrong once a process has seen the lock file.

@jakzal said in https://github.com/symfony/symfony/issues/15813#issuecomment-149013691 that `unlink()`ing the lock file should clear the statcache, but I doubt this is true across PHP processes.

Commits
-------

982710f [HttpKernel] clearstatcache() so the Cache sees when a .lck file has been released
2015-11-28 11:48:57 +01:00
Matthias Pigulla
982710ff18 [HttpKernel] clearstatcache() so the Cache sees when a .lck file has been released 2015-11-28 11:48:55 +01:00
Pieter
a35d3d44d0 [WIP] [Form] [TwigBridge] Bootstrap horizontal theme missing tests 2015-11-28 11:44:04 +01:00
Fabien Potencier
2659c8e3a8 minor #16547 [Serializer] Improve ObjectNormalizer performance (dunglas)
This PR was squashed before being merged into the 2.8 branch (closes #16547).

Discussion
----------

[Serializer] Improve ObjectNormalizer performance

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #16179
| License       | MIT
| Doc PR        | n/a

Cache attributes detection in a similar way than in #16294 for PropertyAccess.

As for the PropertyAccess Component, I'll open another PR (in 2.8 or 3.1) allowing to cache these attributes between requests using Doctrine Cache.

@Tobion, can you try this PR with your benchmark to estimate the gain?

Commits
-------

683f0f7 [Serializer] Improve ObjectNormalizer performance
2015-11-28 11:40:26 +01:00
Kévin Dunglas
683f0f7315 [Serializer] Improve ObjectNormalizer performance 2015-11-28 11:40:16 +01:00
Fabien Potencier
833495278b feature #16715 [Form] Remove choices_as_values option on ChoiceType (nicolas-grekas)
This PR was merged into the 3.0-dev branch.

Discussion
----------

[Form] Remove choices_as_values option on ChoiceType

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

ed0e26a [Form] Remove choices_as_values option on ChoiceType
2015-11-28 11:38:07 +01:00
Fabien Potencier
26c17f6878 feature #16692 [Form] Drop remaing CsrfProviderAdapter/Interface mentions (nicolas-grekas)
This PR was merged into the 3.0-dev branch.

Discussion
----------

[Form] Drop remaing CsrfProviderAdapter/Interface mentions

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

CsrfProviderAdapter+Interface have already been removed from master, we should not use them anymore. Let's see if tests agree.

Commits
-------

5bc34d2 [Form] Drop remaing CsrfProviderAdapter/Interface mentions
2015-11-28 11:35:52 +01:00
Fabien Potencier
2a22d8696b minor #16721 [DoctrineBridge] remove unused abstract test classes (xabbuh)
This PR was merged into the 3.0-dev branch.

Discussion
----------

[DoctrineBridge] remove unused abstract test classes

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #15696
| License       | MIT
| Doc PR        |

Tests depending on these classes have already been removed in #15696.

Commits
-------

0108cd4 remove unused abstract test classes
2015-11-28 11:33:50 +01:00
Fabien Potencier
c4501c511b feature #16719 [Security] remove deprecated HTTP digest auth key (xabbuh)
This PR was merged into the 3.0-dev branch.

Discussion
----------

[Security] remove deprecated HTTP digest auth key

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

812396d [Security] remove deprecated HTTP digest auth key
2015-11-28 11:31:12 +01:00
Michal Piotrowski
62b3cb2805 AssetBundle - fix docs 2015-11-28 11:26:33 +01:00
Fabien Potencier
0cb308f634 minor #16697 CS: remove impossible default argument value (keradus)
This PR was merged into the 2.7 branch.

Discussion
----------

CS: remove impossible default argument value

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | ?
| Fixed tickets | N/A
| License       | MIT
| Doc PR        | N/A

Commits
-------

acef3a3 CS: remove impossible default argument value
2015-11-28 11:22:51 +01:00
Fabien Potencier
06279791c5 minor #16662 [Yaml] more fixes to changelog and upgrade files (Christian Flothmann)
This PR was merged into the 2.8 branch.

Discussion
----------

[Yaml] more fixes to changelog and upgrade files

| Q             | A
| ------------- | ---
| Fixed tickets | #16433, #16654
| License       | MIT

Commits
-------

273ed25 [Yaml] more fixes to changelog and upgrade files
2015-11-28 11:18:42 +01:00
Christian Flothmann
0108cd4c90 remove unused abstract test classes 2015-11-28 11:07:17 +01:00
Christian Flothmann
812396d6c6 [Security] remove deprecated HTTP digest auth key 2015-11-28 10:30:56 +01:00
Nicolas Grekas
ed0e26a620 [Form] Remove choices_as_values option on ChoiceType 2015-11-28 10:26:50 +01:00
Nicolas Grekas
5bc34d2d51 [Form] Drop remaing CsrfProviderAdapter/Interface mentions 2015-11-28 10:23:07 +01:00
Nicolas Grekas
380ce606aa Merge branch '2.8'
* 2.8:
  test legacy CSRF configuration options
2015-11-28 10:22:01 +01:00
Nicolas Grekas
953ed3c28c minor #16718 [SecurityBundle] test legacy CSRF configuration options (xabbuh)
This PR was merged into the 2.8 branch.

Discussion
----------

[SecurityBundle] test legacy CSRF configuration options

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #16704
| License       | MIT
| Doc PR        |

Commits
-------

444b6ef test legacy CSRF configuration options
2015-11-28 10:21:20 +01:00
Nicolas Grekas
ba3afdb189 Merge branch '2.8'
* 2.8:
  [ci] Force update of ./phpunit deps
  [PhpUnitBridge] fix typo
  [Bridge\PhpUnit] Display the stack trace of a deprecation on-demand
  [Form] Fixed: Duplicate choice labels are remembered when using "choices_as_values" = false
  [Process] Don't catch RuntimeException when it complicates tests debugging
  [appveyor] Workaround transient segfault when APCu is enabled

Conflicts:
	appveyor.yml
	src/Symfony/Component/Form/Extension/Core/Type/ChoiceType.php
2015-11-28 10:12:47 +01:00
Nicolas Grekas
d94c322272 Merge branch '2.7' into 2.8
* 2.7:
  [ci] Force update of ./phpunit deps
  [Form] Fixed: Duplicate choice labels are remembered when using "choices_as_values" = false
  [Process] Don't catch RuntimeException when it complicates tests debugging
  [appveyor] Workaround transient segfault when APCu is enabled
2015-11-28 10:05:52 +01:00
Nicolas Grekas
60b02fcc97 Merge branch '2.3' into 2.7
* 2.3:
  [ci] Force update of ./phpunit deps
  [Process] Don't catch RuntimeException when it complicates tests debugging
  [appveyor] Workaround transient segfault when APCu is enabled
2015-11-28 10:05:32 +01:00
Christian Flothmann
444b6eff0a test legacy CSRF configuration options 2015-11-28 09:35:12 +01:00
Christian Flothmann
1cec08b844 [PhpUnitBridge] fix typo 2015-11-27 23:51:43 +01:00
Nicolas Grekas
d628d925c1 bug #16685 [Form] Fixed: Duplicate choice labels are remembered when using "choices_as_values" = false (webmozart)
This PR was merged into the 2.7 branch.

Discussion
----------

[Form] Fixed: Duplicate choice labels are remembered when using "choices_as_values" = false

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #15606
| License       | MIT
| Doc PR        | -

Commits
-------

1179f07 [Form] Fixed: Duplicate choice labels are remembered when using "choices_as_values" = false
2015-11-27 23:37:53 +01:00
Nicolas Grekas
342786aa8f feature #16709 [Bridge\PhpUnit] Display the stack trace of a deprecation on-demand (nicolas-grekas)
This PR was merged into the 2.8 branch.

Discussion
----------

[Bridge\PhpUnit] Display the stack trace of a deprecation on-demand

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

This PR has been essential into making #16708, and I think everyone working on a 3.0 migration will need this.

Example:

```
$ SYMFONY_DEPRECATIONS_HELPER=/FormExtensionBootstrap3LayoutTest/ ./phpunit src/Symfony/Bridge/Twig/
PHPUnit 4.8.18 by Sebastian Bergmann and contributors.

Testing src/Symfony/Bridge/Twig/
................................................
Remaining deprecation triggered by Symfony\Bridge\Twig\Tests\Extension\FormExtensionBootstrap3LayoutTest::testSingleChoiceGrouped:
The value "false" for the "choices_as_values" option is deprecated since version 2.8 and will not be supported anymore in 3.0. Set this option to "true" and flip the contents of the "choices" option instead.
Stack trace:
#0 src/Symfony/Component/Form/Extension/Core/Type/ChoiceType.php(286): trigger_error()
#1 src/Symfony/Component/OptionsResolver/OptionsResolver.php(962): Symfony\Component\Form\Extension\Core\Type\ChoiceType->Symfony\Component\Form\Extension\Core\Type\{closure}()
#2 src/Symfony/Component/Form/Extension/Core/Type/ChoiceType.php(277): Symfony\Component\OptionsResolver\OptionsResolver->offsetGet()
#3 src/Symfony/Component/OptionsResolver/OptionsResolver.php(962): Symfony\Component\Form\Extension\Core\Type\ChoiceType->Symfony\Component\Form\Extension\Core\Type\{closure}()
#4 src/Symfony/Component/OptionsResolver/OptionsResolver.php(791): Symfony\Component\OptionsResolver\OptionsResolver->offsetGet()
#5 src/Symfony/Component/Form/ResolvedFormType.php(156): Symfony\Component\OptionsResolver\OptionsResolver->resolve()
#6 src/Symfony/Component/Form/FormFactory.php(119): Symfony\Component\Form\ResolvedFormType->createBuilder()
#7 src/Symfony/Component/Form/FormFactory.php(48): Symfony\Component\Form\FormFactory->createNamedBuilder()
#8 src/Symfony/Component/Form/Tests/AbstractBootstrap3LayoutTest.php(540): Symfony\Component\Form\FormFactory->createNamed()
#9 [internal function]: Symfony\Component\Form\Tests\AbstractBootstrap3LayoutTest->testSingleChoiceGrouped()
#10 {main}
KO src/Symfony/Bridge/Twig/
```

Commits
-------

5a88fb6 [Bridge\PhpUnit] Display the stack trace of a deprecation on-demand
2015-11-27 23:34:17 +01:00
Christian Flothmann
273ed25573 [Yaml] more fixes to changelog and upgrade files 2015-11-27 22:31:42 +01:00
Nicolas Grekas
5a88fb619f [Bridge\PhpUnit] Display the stack trace of a deprecation on-demand 2015-11-27 17:34:29 +01:00
Nicolas Grekas
743e670f4a Merge branch '2.8'
* 2.8:
  [Form+SecurityBundle] Trigger deprecation for csrf_provider+intention options
2015-11-27 15:37:36 +01:00
Nicolas Grekas
fad3d38e95 bug #16704 [Form+SecurityBundle] Trigger deprecation for csrf_provider+intention options (nicolas-grekas)
This PR was merged into the 2.8 branch.

Discussion
----------

[Form+SecurityBundle] Trigger deprecation for csrf_provider+intention options

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

ping @stof

Commits
-------

62eba7c [Form+SecurityBundle] Trigger deprecation for csrf_provider+intention options
2015-11-27 15:37:15 +01:00
Nicolas Grekas
4603e6417e feature #16629 [HttpFoundation] Remove deprecated class method parameter (belka-ew)
This PR was merged into the 3.0-dev branch.

Discussion
----------

[HttpFoundation] Remove deprecated class method parameter

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

$deep argument in Symfony\Component\HttpFoundation\BagParameter::get was deprecated  in 2.8 and removed in master, but it is still used in the code of the class (and in the filter() method)

Commits
-------

4ffe14c [HttpFoundation] Remove deprecated class method parameter
2015-11-27 15:30:17 +01:00
Bernhard Schussek
1179f0727b [Form] Fixed: Duplicate choice labels are remembered when using "choices_as_values" = false 2015-11-27 15:25:47 +01:00
Nicolas Grekas
aa4bc475ed Merge branch '2.8'
* 2.8:
  [Form] Fix missing choices_as_values=true in tests
  [HttpFoundation] Deprecate $deep parameter on ParameterBag

Conflicts:
	src/Symfony/Component/HttpFoundation/ParameterBag.php
	src/Symfony/Component/HttpFoundation/Request.php
2015-11-27 15:23:49 +01:00
Nicolas Grekas
de08816caa Merge branch '2.7' into 2.8
* 2.7:
  [Form] Fix missing choices_as_values=true in tests

Conflicts:
	src/Symfony/Component/Form/Tests/AbstractBootstrap3LayoutTest.php
	src/Symfony/Component/Form/Tests/AbstractDivLayoutTest.php
	src/Symfony/Component/Form/Tests/AbstractLayoutTest.php
2015-11-27 15:19:27 +01:00
Nicolas Grekas
2a16e87aec [Form] Fix missing choices_as_values=true in tests 2015-11-27 14:50:51 +01:00
ogizanagi
42a75bc224 [Process] Remove PHP_BINARY existence check 2015-11-27 13:38:29 +01:00
Nicolas Grekas
62eba7c426 [Form+SecurityBundle] Trigger deprecation for csrf_provider+intention options 2015-11-27 13:22:26 +01:00
Nicolas Grekas
9610602ab5 feature #16706 [HttpFoundation] Deprecate $deep parameter on ParameterBag (nicolas-grekas)
This PR was merged into the 2.8 branch.

Discussion
----------

[HttpFoundation] Deprecate $deep parameter on ParameterBag

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

f4f082e [HttpFoundation] Deprecate $deep parameter on ParameterBag
2015-11-27 12:57:36 +01:00
Nicolas Grekas
f4f082ee6d [HttpFoundation] Deprecate $deep parameter on ParameterBag 2015-11-27 12:03:19 +01:00
Fabien Potencier
9b9fa3d262 Merge branch '2.8'
* 2.8:
  [Form] Deprecated setting "choices_as_values" to "false"
  [Form] Deprecated setting "choices_as_values" to "false"
  [Form] Deprecated ArrayKeyChoiceList
  [Form] Deprecated TimezoneType::getTimezones()
2015-11-27 11:23:00 +01:00
Fabien Potencier
78ff9dc515 Merge branch '2.7' into 2.8
* 2.7:
  [Form] Deprecated setting "choices_as_values" to "false"
2015-11-27 11:16:11 +01:00
Bernhard Schussek
3ab8189080 [Form] Deprecated setting "choices_as_values" to "false" 2015-11-27 10:37:24 +01:00
Fabien Potencier
b29691067d feature #16690 [Form] Deprecated ArrayKeyChoiceList (webmozart)
This PR was merged into the 2.8 branch.

Discussion
----------

[Form] Deprecated ArrayKeyChoiceList

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

5386752 [Form] Deprecated ArrayKeyChoiceList
2015-11-27 10:03:43 +01:00
Fabien Potencier
6dacdc4ebd feature #16687 [Form] Deprecated TimezoneType::getTimezones() (webmozart)
This PR was merged into the 2.8 branch.

Discussion
----------

[Form] Deprecated TimezoneType::getTimezones()

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

This method is useless as of https://github.com/symfony/symfony/pull/16681. It needs to be deprecated before we can remove it since it is public.

Commits
-------

41df3fc [Form] Deprecated TimezoneType::getTimezones()
2015-11-27 10:01:47 +01:00
Bernhard Schussek
5d7678e432 [Form] Deprecated setting "choices_as_values" to "false" 2015-11-27 10:00:10 +01:00
Nicolas Grekas
8588a4f63b [Process] Don't catch RuntimeException when it complicates tests debugging 2015-11-27 09:37:23 +01:00
Fabien Potencier
0468f745d8 Merge branch '2.8'
* 2.8:
  Fixed the wrong source name and the ja translation
  [Debug] fix readme: DebugClassLoader moved to debug itself
  [SecurityBundle] disable the init:acl command if ACL is not used
  [DI] remove useless condition around unset
  [Console] Fix bug with  overloading
  [Form] Fixed wrong usages of the "text" type
  [Form] Disabled view data validation if "data_class" is set to null
  [HttpFoundation] Workaround HHVM rewriting HTTP response line
2015-11-27 06:46:53 +01:00
Fabien Potencier
5de9c354dd Merge branch '2.7' into 2.8
* 2.7:
  Fixed the wrong source name and the ja translation
  [Debug] fix readme: DebugClassLoader moved to debug itself
  [SecurityBundle] disable the init:acl command if ACL is not used
  [DI] remove useless condition around unset
  [Form] Disabled view data validation if "data_class" is set to null
  [HttpFoundation] Workaround HHVM rewriting HTTP response line
2015-11-27 06:45:55 +01:00
Fabien Potencier
d65b92469e Merge branch '2.3' into 2.7
* 2.3:
  Fixed the wrong source name and the ja translation
  [SecurityBundle] disable the init:acl command if ACL is not used
  [DI] remove useless condition around unset
2015-11-27 06:41:56 +01:00
hainey
90f3b941d3 Fixed the wrong source name and the ja translation 2015-11-27 06:41:08 +01:00
Dariusz Ruminski
acef3a3b34 CS: remove impossible default argument value 2015-11-26 23:11:33 +01:00
Fabien Potencier
98f827beab minor #16664 [Debug] fix readme: DebugClassLoader moved to debug itself (Tobion)
This PR was merged into the 2.7 branch.

Discussion
----------

[Debug] fix readme: DebugClassLoader moved to debug itself

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | https://github.com/symfony/symfony/pull/16663#discussion_r45866385
| License       | MIT
| Doc PR        | -

Commits
-------

123a300 [Debug] fix readme: DebugClassLoader moved to debug itself
2015-11-26 21:07:32 +01:00
Tobias Schultze
123a300ad7 [Debug] fix readme: DebugClassLoader moved to debug itself 2015-11-26 21:02:12 +01:00
Tobias Schultze
55f84a3369 [SecurityBundle] disable the init:acl command if ACL is not used 2015-11-26 20:19:29 +01:00
Tobias Schultze
fc66283c7b [SecurityBundle] make ACL an optional dependency 2015-11-26 19:59:37 +01:00
Fabien Potencier
c9fbff03bc minor #16686 [DI] use try-finally for container (Tobion)
This PR was merged into the 3.0-dev branch.

Discussion
----------

[DI] use try-finally for container

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Continuation of #15949

Commits
-------

1ab7316 [DI] use try-finally for container
2015-11-26 19:05:46 +01:00
Fabien Potencier
402d474a96 bug #16677 [Form] Fixed wrong usages of the "text" type (webmozart)
This PR was merged into the 2.8 branch.

Discussion
----------

[Form] Fixed wrong usages of the "text" type

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

9149622 [Form] Fixed wrong usages of the "text" type
2015-11-26 18:59:59 +01:00
Tobias Schultze
478375d664 [DI] remove useless condition around unset 2015-11-26 18:53:25 +01:00
Bernhard Schussek
5386752bf9 [Form] Deprecated ArrayKeyChoiceList 2015-11-26 18:38:25 +01:00
Fabien Potencier
99c05b3fc4 bug #16679 [Form] Disabled view data validation if "data_class" is set to null (webmozart)
This PR was merged into the 2.7 branch.

Discussion
----------

[Form] Disabled view data validation if "data_class" is set to null

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #14877
| License       | MIT
| Doc PR        | -

After this PR, Form::setData() does not validate the view data anymore when "data_class" is set to `null`. This way it is possible to create fields with dynamic view data types (see #14877).

Commits
-------

f495410 [Form] Disabled view data validation if "data_class" is set to null
2015-11-26 18:18:04 +01:00
Bernhard Schussek
41df3fce32 [Form] Deprecated TimezoneType::getTimezones() 2015-11-26 18:08:26 +01:00
Fabien Potencier
14f70aeafd bug #16621 [Console] Fix bug with $output overloading (WouterJ)
This PR was squashed before being merged into the 2.8 branch (closes #16621).

Discussion
----------

[Console] Fix bug with $output overloading

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | https://github.com/symfony/symfony-standard/issues/887, #16622
| License       | MIT
| Doc PR        | -

This is exactly why variable overloading isn't a great idea :)

Commits
-------

5764a00 [Console] Fix bug with  overloading
2015-11-26 17:44:52 +01:00
Wouter J
5764a00a76 [Console] Fix bug with overloading 2015-11-26 17:44:51 +01:00
Fabien Potencier
8988409dc6 minor #16663 [Debug] remove unused use statement (Tobion)
This PR was merged into the 3.0-dev branch.

Discussion
----------

[Debug] remove unused use statement

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

ref #15418

Commits
-------

a862e5e [Debug] remove unused use statement
2015-11-26 17:42:16 +01:00
Bernhard Schussek
91496229ab [Form] Fixed wrong usages of the "text" type 2015-11-26 17:29:22 +01:00
Tobias Schultze
1ab73166a7 [DI] use try-finally for container 2015-11-26 17:15:31 +01:00
Nicolas Grekas
327a52d02f Merge branch '2.8'
* 2.8:
  [Security] Deprecate "AbstractVoter" in favor of "Voter"
  [Security] Revert changes made between 2.7 and 2.8-beta

Conflicts:
	UPGRADE-2.8.md
	src/Symfony/Component/Security/Core/Authorization/Voter/AbstractVoter.php
	src/Symfony/Component/Security/Core/Tests/Authorization/Voter/AbstractVoterTest.php
2015-11-26 15:51:35 +01:00
Nicolas Grekas
a58df11244 feature #16601 [Security] Deprecate "AbstractVoter" in favor of "Voter" (nicolas-grekas, lyrixx)
This PR was merged into the 2.8 branch.

Discussion
----------

[Security] Deprecate "AbstractVoter" in favor of "Voter"

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | #16556, #16558, #16554
| License       | MIT
| Doc PR        | -

Commits
-------

fd8b87c [Security] Deprecate "AbstractVoter" in favor of "Voter"
d3c6d93 [Security] Revert changes made between 2.7 and 2.8-beta
2015-11-26 15:48:43 +01:00
Nicolas Grekas
0a40b543e4 Merge branch '2.3' into 2.7
* 2.3:
  [HttpFoundation] Workaround HHVM rewriting HTTP response line

Conflicts:
	src/Symfony/Component/HttpFoundation/Response.php
2015-11-26 10:20:19 +01:00
Bernhard Schussek
f495410d25 [Form] Disabled view data validation if "data_class" is set to null 2015-11-26 10:11:54 +01:00
Nicolas Grekas
5183c881d0 Merge branch '2.8'
* 2.8:
  Always enable clock-mock for HttpFoundation
  [ClassLoader] Fix parsing namespace when token_get_all() is missing
  Bug #16343 [Router] Too many Routes ?
  Fixes the stack traces of the deprecation logs
  fix unused variable warning
  [Translation][Form] Do not translate form labels and placeholders when 'translation_domain' is false
  add composer exclude-from-classmap for new 2.8 components
  [Yaml] sync changelog and upgrade files
  [Debug] Ensure class declarations are loaded only once
  Minor design tweaks for the Logs and Doctrine profiler panels

Conflicts:
	UPGRADE-2.8.md
2015-11-26 08:02:09 +01:00
Nicolas Grekas
da43309f07 Merge branch '2.7' into 2.8
* 2.7:
  Always enable clock-mock for HttpFoundation
  [ClassLoader] Fix parsing namespace when token_get_all() is missing
  Bug #16343 [Router] Too many Routes ?
  [Debug] Ensure class declarations are loaded only once
2015-11-26 08:00:59 +01:00
Nicolas Grekas
d1a50a2b61 Merge branch '2.3' into 2.7
* 2.3:
  Always enable clock-mock for HttpFoundation
  [ClassLoader] Fix parsing namespace when token_get_all() is missing
  Bug #16343 [Router] Too many Routes ?
2015-11-26 08:00:48 +01:00
Nicolas Grekas
5013f9895f [HttpFoundation] Workaround HHVM rewriting HTTP response line 2015-11-26 07:58:58 +01:00
Nicolas Grekas
4a17c9e6af [ClassLoader] Fix parsing namespace when token_get_all() is missing 2015-11-25 18:16:22 +01:00
Fabien Potencier
cd0ffc9a41 bug #16615 fix type assignement (rande)
This PR was squashed before being merged into the 3.0-dev branch (closes #16615).

Discussion
----------

fix type assignement

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

This PR make sure the original key is used when the type is resolved. Also the code now respect the PHPDoc.

Commits
-------

cc26454 fix type assignement
2015-11-25 16:48:43 +01:00
Thomas Rabaix
cc2645404a fix type assignement 2015-11-25 16:48:40 +01:00
Tobias Schultze
a862e5ef8f [Debug] remove unused use statement 2015-11-25 14:49:01 +01:00
Jelte Steijaert
0113ac3ce2 Bug #16343 [Router] Too many Routes ? 2015-11-25 13:20:52 +01:00
Javier Eguiluz
09f489530b Fixes the stack traces of the deprecation logs 2015-11-25 09:53:09 +01:00
Fabien Potencier
074a4bf89e minor #16647 Minor design tweaks for the Logs and Doctrine profiler panels (javiereguiluz)
This PR was merged into the 2.8 branch.

Discussion
----------

Minor design tweaks for the Logs and Doctrine profiler panels

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

### Logger panel BEFORE

![stacktrace_before](https://cloud.githubusercontent.com/assets/73419/11362363/65924218-9293-11e5-8b89-c405e6bcee9a.png)

### Logger panel AFTER

![stacktrace_after](https://cloud.githubusercontent.com/assets/73419/11362365/68cd37da-9293-11e5-8ef9-607d60a1b4cf.png)

### Doctrine panel BEFORE

![doctrine_before](https://cloud.githubusercontent.com/assets/73419/11362370/6ce78f14-9293-11e5-8bd8-d486447c1134.png)

### Doctrine panel AFTER

![doctrine_after](https://cloud.githubusercontent.com/assets/73419/11362372/71a3eade-9293-11e5-9949-a7f0463fb12a.png)

Commits
-------

fdfa176 Minor design tweaks for the Logs and Doctrine profiler panels
2015-11-25 05:22:23 +01:00
Fabien Potencier
3ed092ed80 bug #16498 fix unused variable warning (eventhorizonpl)
This PR was squashed before being merged into the 2.8 branch (closes #16498).

Discussion
----------

fix unused variable warning

Hi,

This PR fixes a bug in ClockMock class.

Best regards,
Michal

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

Commits
-------

cf28474 fix unused variable warning
2015-11-25 05:20:03 +01:00
Michal Piotrowski
cf284742ff fix unused variable warning 2015-11-25 05:19:33 +01:00
Fabien Potencier
8b58291f20 minor #16654 [Yaml] sync changelog and upgrade files (xabbuh)
This PR was merged into the 2.8 branch.

Discussion
----------

[Yaml] sync changelog and upgrade files

| Q             | A
| ------------- | ---
| Fixed tickets | #16433
| License       | MIT

Commits
-------

062d707 [Yaml] sync changelog and upgrade files
2015-11-25 05:12:04 +01:00
Fabien Potencier
9042dc543c minor #16655 add composer exclude-from-classmap for new 2.8 components (Tobion)
This PR was merged into the 2.8 branch.

Discussion
----------

add composer exclude-from-classmap for new 2.8 components

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

#16397 for new components in 2.8 that was missing

Commits
-------

2edebbf add composer exclude-from-classmap for new 2.8 components
2015-11-25 05:08:23 +01:00
Fabien Potencier
09e896c306 feature #16031 [Translation][Form] Do not translate form labels and placeholders when 'translation_domain' is false (Restless-ET)
This PR was squashed before being merged into the 2.8 branch (closes #16031).

Discussion
----------

[Translation][Form] Do not translate form labels and placeholders when 'translation_domain' is false

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Seems like this behaviour was already partially added (as stated [here](https://github.com/symfony/symfony/pull/16016#issuecomment-144464875)) to solve the problem of expanded choice widgets.

Commits
-------

0e0b904 [Translation][Form] Do not translate form labels and placeholders when 'translation_domain' is false
2015-11-25 05:07:02 +01:00
Restless-ET
0e0b904ff2 [Translation][Form] Do not translate form labels and placeholders when 'translation_domain' is false 2015-11-25 05:06:57 +01:00
Tobias Schultze
2edebbf2ae add composer exclude-from-classmap for new 2.8 components 2015-11-24 23:11:35 +01:00
Christian Flothmann
062d707820 [Yaml] sync changelog and upgrade files 2015-11-24 22:06:14 +01:00
Grégoire Pineau
fd8b87c498 [Security] Deprecate "AbstractVoter" in favor of "Voter" 2015-11-24 16:56:59 +01:00
Nicolas Grekas
d3c6d93dff [Security] Revert changes made between 2.7 and 2.8-beta 2015-11-24 14:34:07 +01:00
Nicolas Grekas
01c08fccf4 [Debug] Ensure class declarations are loaded only once 2015-11-24 12:55:28 +01:00
Loïc Faugeron
7c1231a2e0 Suggested Process dependency
The `server:run` command requires the Process component.
2015-11-24 11:52:35 +00:00
Javier Eguiluz
fdfa1767b9 Minor design tweaks for the Logs and Doctrine profiler panels 2015-11-24 10:07:02 +01:00
Abdellatif Ait boudad
a21a0166c6 [DI][autowiring] throw exception when many services use the same class. 2015-11-24 08:45:36 +00:00
Ryan Weaver
07d627de0f Tweaking deprecation message to include class name 2015-11-23 21:38:01 +01:00
Fabien Potencier
fc0ee0efd5 bumped Symfony version to 2.7.8 2015-11-23 13:27:27 +01:00
Fabien Potencier
d99f2410b3 updated VERSION for 2.7.7 2015-11-23 12:57:49 +01:00
Fabien Potencier
03eb2e909d bumped Symfony version to 2.3.36 2015-11-23 12:27:40 +01:00
Fabien Potencier
3b790dd0da updated VERSION for 2.3.35 2015-11-23 11:44:06 +01:00
Fabien Potencier
45fe468074 Merge branch '2.8'
* 2.8:
  removed usage of the deprecated StringUtils::equals() method
  Fix: Resolve tempdir symlink, not working on OSX
  fixed tests
  migrate session after remember me authentication
  prevent timing attacks in digest auth listener
  mitigate CSRF timing attack vulnerability
  fix potential timing attack issue
  [WebProfilerBundle] Added a top left border radius to the minified to…
  [Routing] Changing RouteCollectionBuilder::import() behavior to add to the builder
  [HttpKernel] Don't reset on shutdown but in FrameworkBundle/Test/KernelTestCase
  [Process] PhpExecutableFinder: add regression test
2015-11-23 11:41:47 +01:00
Fabien Potencier
2dbb75aef4 removed usage of the deprecated StringUtils::equals() method 2015-11-23 11:39:33 +01:00
Fabien Potencier
8a6da3f021 Merge branch '2.7' into 2.8
* 2.7:
  fixed tests
  migrate session after remember me authentication
  prevent timing attacks in digest auth listener
  mitigate CSRF timing attack vulnerability
  fix potential timing attack issue
2015-11-23 11:34:41 +01:00
Fabien Potencier
5edc71e2fc Merge branch '2.3' into 2.7
* 2.3:
  migrate session after remember me authentication
  prevent timing attacks in digest auth listener
  mitigate CSRF timing attack vulnerability
  fix potential timing attack issue
2015-11-23 11:34:14 +01:00
Fabien Potencier
f95078c409 security #16631 n/a (xabbuh)
This PR was merged into the 2.3 branch.

Discussion
----------

n/a

n/a

Commits
-------

f88e600 migrate session after remember me authentication
2015-11-23 11:22:15 +01:00
toretto460
3aee6b93e2 Fix: Resolve tempdir symlink, not working on OSX 2015-11-23 11:19:46 +01:00
Fabien Potencier
d12cf1904c fixed tests 2015-11-23 11:17:36 +01:00
Christian Flothmann
f88e600833 migrate session after remember me authentication 2015-11-23 11:04:06 +01:00
Christian Flothmann
819aa54fe4 prevent timing attacks in digest auth listener 2015-11-23 11:02:49 +01:00
Christian Flothmann
557ea17eeb mitigate CSRF timing attack vulnerability 2015-11-23 11:02:49 +01:00
Christian Flothmann
f1fd7686c5 fix potential timing attack issue 2015-11-23 11:02:49 +01:00
Fabien Potencier
551d164b4f minor #16606 [Process] PhpExecutableFinder: add regression test (ogizanagi)
This PR was merged into the 2.8 branch.

Discussion
----------

[Process] PhpExecutableFinder: add regression test

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #16599
| License       | MIT
| Doc PR        | -

I guess it won't be a shame to have this simple test after #16599 .

Commits
-------

576f802 [Process] PhpExecutableFinder: add regression test
2015-11-23 10:36:02 +01:00
Fabien Potencier
06959c045d bug #16607 [HttpFoundation] Delete not existing session handler proxy member (belka-ew)
This PR was merged into the 3.0-dev branch.

Discussion
----------

[HttpFoundation] Delete not existing session handler proxy member

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

open() and close() SessionHandlerProxy method suse $this->active
that was removed from the parent AbstractProxy class after 2.8.

Commits
-------

b06b93f [HttpFoundation] Remove not existing class member
2015-11-23 10:33:29 +01:00
Fabien Potencier
922b9468b1 bug #16609 [HttpKernel] Don't reset on shutdown but in FrameworkBundle/Test/KernelTestCase (nicolas-grekas)
This PR was merged into the 2.8 branch.

Discussion
----------

[HttpKernel] Don't reset on shutdown but in FrameworkBundle/Test/KernelTestCase

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #15185
| License       | MIT
| Doc PR        | -

While trying to migrate Blackfire to 2.8-beta, I found this BC-break: by resetting the container on kernel shut-down, functional tests are broken when they need to use the container after a call to `$this->client->request()`. Broken because e.g . the session or the profiler state is lost between consecutive requests in the same test, and because a call to $container->get('kernel') throws a synthetic-related exception.

This PR fixes the BC-break by reverting to the <=2.7 behavior (not resetting the container on kernel shut-down), and moving resetting to the KernelTestCase.

Commits
-------

baad4da [HttpKernel] Don't reset on shutdown but in FrameworkBundle/Test/KernelTestCase
2015-11-23 10:32:50 +01:00
Fabien Potencier
43d82e7845 minor #16628 [WebProfilerBundle] Added a top left border radius to the minified to… (Jelle Kapitein)
This PR was squashed before being merged into the 2.8 branch (closes #16628).

Discussion
----------

[WebProfilerBundle] Added a top left border radius to the minified to…

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | N/A
| License       | MIT
| Doc PR        | N/A

The minified toolbar (to us at least) looked very out of place in all of our projects. Adding a border radius to the top left fixes that.

Chrome 46
![schermafbeelding 2015-11-23 om 09 29 06](https://cloud.githubusercontent.com/assets/6209772/11332470/41240b96-91c6-11e5-9d03-4738ff213295.png)

Firefox 42
![schermafbeelding 2015-11-23 om 09 29 53](https://cloud.githubusercontent.com/assets/6209772/11332476/55fbf574-91c6-11e5-898b-1ba2590a813b.png)

Safari 9
![schermafbeelding 2015-11-23 om 09 30 33](https://cloud.githubusercontent.com/assets/6209772/11332485/6351525a-91c6-11e5-8cbc-14b7efd82ce0.png)

Cannot test on IE/Edge at the moment, will be able to later today.

(The screenshots do not have commit 0459912523)

Commits
-------

ca9f446 [WebProfilerBundle] Added a top left border radius to the minified to…
2015-11-23 10:30:31 +01:00
Jelle Kapitein
ca9f446f03 [WebProfilerBundle] Added a top left border radius to the minified to… 2015-11-23 10:30:25 +01:00
Fabien Potencier
57e0468cc3 bug #16477 [Routing] Changing RouteCollectionBuilder::import() behavior to add to the builder (weaverryan)
This PR was squashed before being merged into the 2.8 branch (closes #16477).

Discussion
----------

[Routing] Changing RouteCollectionBuilder::import() behavior to add to the builder

| Q             | A
| ------------- | ---
| Bug fix?      | behavior change
| New feature?  | behavior change
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Based on conversation starting here: https://github.com/symfony/symfony/pull/15990#issuecomment-154081718.

```php
// Before:
$routes->mount('/admin', $routes->import(__DIR__.'/config/admin.yml');

// After:
$routes->import(__DIR__.'/config/admin.yml', '/admin');
```

This makes `import()` actually add the `RouteCollectionBuilder` into itself. We didn't do this before at Fabien's request, and actually the current implementation (before this PR) is quite "clean". However, I agree with @WouterJ that `import()` really sounds/looks like it will actually *import* those routes *into* this `RouteCollectionBuilder`.

This change is subjective - we just need to pick which way we like better and run full steam with it.

Commits
-------

8feb9ef [Routing] Changing RouteCollectionBuilder::import() behavior to add to the builder
2015-11-23 10:29:40 +01:00
Ryan Weaver
8feb9ef080 [Routing] Changing RouteCollectionBuilder::import() behavior to add to the builder 2015-11-23 10:29:39 +01:00
Eugene Wissner
4ffe14cab4 [HttpFoundation] Remove deprecated class method parameter 2015-11-23 09:57:30 +01:00
Nicolas Grekas
4d2ea16b90 Merge branch '2.8'
* 2.8:
  Add Spanish translation for BIC validator
  Added translation for BIC validator
  Sent out a status text for unknown HTTP headers.
  [DependencyInjection] Unescape parameters for all types of injection
  [Process] Fix trailing space in PHP binary finder
  Remove tmp addition of zend-stdlib
  [WebProfilerBundle] Fix minitoolbar height
  [Form] Fix ResolvedFormType deprecation notices
  [Serializer] add missing unit tests related to Encoder
  add it back

Conflicts:
	src/Symfony/Bridge/ProxyManager/composer.json
	src/Symfony/Component/Form/ResolvedFormType.php
2015-11-20 18:45:52 +01:00
Nicolas Grekas
fe6e9e4543 Merge branch '2.7' into 2.8
* 2.7:
  Sent out a status text for unknown HTTP headers.
  [DependencyInjection] Unescape parameters for all types of injection
2015-11-20 18:41:52 +01:00
Nicolas Grekas
c91638f826 Merge branch '2.3' into 2.7
* 2.3:
  Sent out a status text for unknown HTTP headers.
  [DependencyInjection] Unescape parameters for all types of injection
2015-11-20 18:41:18 +01:00
Fabien Potencier
02c31ad773 minor #16610 Add Spanish translation for BIC validator (ajgarlag)
This PR was merged into the 2.8 branch.

Discussion
----------

Add Spanish translation for BIC validator

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

357dea1 Add Spanish translation for BIC validator
2015-11-20 15:39:26 +01:00
Antonio J. García Lagar
357dea1ea8 Add Spanish translation for BIC validator 2015-11-20 14:32:45 +01:00
Nicolas Grekas
baad4da9b7 [HttpKernel] Don't reset on shutdown but in FrameworkBundle/Test/KernelTestCase 2015-11-20 13:20:48 +01:00
Joshua Thijssen
a591ba3d80 Added translation for BIC validator 2015-11-20 11:06:22 +01:00
ogizanagi
576f802917 [Process] PhpExecutableFinder: add regression test 2015-11-20 08:33:53 +01:00
Fabien Potencier
b6857ba405 minor #16557 [Serializer] add missing unit tests related to Encoder (FlorianLB)
This PR was merged into the 2.8 branch.

Discussion
----------

[Serializer] add missing unit tests related to Encoder

Add some missing unit tests on the Serializer component.

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

7418d29 [Serializer] add missing unit tests related to Encoder
2015-11-20 07:33:45 +01:00
Eugene Wissner
b06b93fd30 [HttpFoundation] Remove not existing class member
open() and close() SessionHandlerProxy method suse $this->active
that was removed from the parent AbstractProxy class after 2.8.
2015-11-20 04:02:44 +01:00
Daniel Wehner
eec6fbc768 Sent out a status text for unknown HTTP headers. 2015-11-19 17:24:57 +01:00
Fabien Potencier
4e1fffe016 bug #16377 [WebProfilerBundle] Fix minitoolbar height (rvanlaak)
This PR was merged into the 2.8 branch.

Discussion
----------

[WebProfilerBundle] Fix minitoolbar height

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

The height of the minimized toolbar icon was a bit off. This change makes sure the icon has the same height as the toolbar itself.

Commits
-------

0459912 [WebProfilerBundle] Fix minitoolbar height
2015-11-19 17:15:38 +01:00
Fabien Potencier
5a17f80858 Merge branch '2.7' into 2.8
* 2.7:
  [Process] Fix trailing space in PHP binary finder
  Remove tmp addition of zend-stdlib
2015-11-19 17:12:55 +01:00
Fabien Potencier
16fb7016c8 Merge branch '2.3' into 2.7
* 2.3:
  [Process] Fix trailing space in PHP binary finder
  Remove tmp addition of zend-stdlib
2015-11-19 17:11:24 +01:00
Tristan Darricau
331a0469c1 [DependencyInjection] Unescape parameters for all types of injection 2015-11-19 15:08:33 +01:00
Nicolas Grekas
1728dcca82 minor #16599 [Process] Fix trailing space in PHP binary finder (nicolas-grekas)
This PR was merged into the 2.3 branch.

Discussion
----------

[Process] Fix trailing space in PHP binary finder

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #16598
| License       | MIT
| Doc PR        | -

Commits
-------

f15e6e0 [Process] Fix trailing space in PHP binary finder
2015-11-19 13:57:32 +01:00
Nicolas Grekas
f15e6e0ba9 [Process] Fix trailing space in PHP binary finder 2015-11-19 13:49:26 +01:00
Nicolas Grekas
6e015e7e0e Remove tmp addition of zend-stdlib 2015-11-19 13:33:53 +01:00
Richard
0459912523 [WebProfilerBundle] Fix minitoolbar height 2015-11-19 10:07:51 +01:00
Tobias Schultze
a22a43636f minor #16592 [Form] Fix ResolvedFormType deprecation notices (nicolas-grekas)
This PR was merged into the 2.8 branch.

Discussion
----------

[Form] Fix ResolvedFormType deprecation notices

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

baafb7a [Form] Fix ResolvedFormType deprecation notices
2015-11-19 00:57:27 +01:00
Nicolas Grekas
baafb7a88b [Form] Fix ResolvedFormType deprecation notices 2015-11-18 19:46:46 +01:00
Fabien Potencier
36bf7069ac bug #16585 Add support for HTTP status code 418 back (dawehner)
This PR was merged into the 2.8 branch.

Discussion
----------

Add support for HTTP status code 418 back

See https://gist.github.com/anonymous/a863d7b493c4b09733ec what this results into

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | 16584
| License       | MIT
| Doc PR        |

Commits
-------

db5fbe0 add it back
2015-11-18 18:36:10 +01:00
Nicolas Grekas
dba51b40fc Merge branch '2.8'
* 2.8:
  [Process] Fix PhpProcess with phpdbg runtime

Conflicts:
	src/Symfony/Bridge/ProxyManager/composer.json
2015-11-18 17:57:58 +01:00
Nicolas Grekas
7748b05747 Merge branch '2.7' into 2.8
* 2.7:
  [Process] Fix PhpProcess with phpdbg runtime

Conflicts:
	composer.json
	src/Symfony/Bridge/ProxyManager/composer.json
2015-11-18 17:56:24 +01:00
Nicolas Grekas
aa82cd338a Merge branch '2.3' into 2.7
* 2.3:
  [Process] Fix PhpProcess with phpdbg runtime

Conflicts:
	composer.json
	src/Symfony/Bridge/ProxyManager/composer.json
2015-11-18 17:27:55 +01:00
Nicolas Grekas
9669238af6 [Process] Fix PhpProcess with phpdbg runtime 2015-11-18 16:41:59 +01:00
Nicolas Grekas
2abbb8a451 Merge branch '2.8'
* 2.8:
  Fix undefined array $server
  Fix call to undefined function json_last_error_message
  Fix bug in windows detection
  [ProxyManager] Tmp fix composer reqs issue in ZF
  Fix PropertyInfo extractor namespace in framework bundle
  Add missing exclusions from phpunit.xml.dist
  [Serializer] ObjectNormalizer: don't serialize static methods and props
  [Form] Enhance some FormRegistry deprecation messages
  [Validator] [sl] BIC (SWIFT-BIC) validation constraint
  [WebProfilerBundle] correct typo in show stack trace link
  bumped Symfony version to 2.8.0
  updated VERSION for 2.8.0-BETA1
  updated CHANGELOG for 2.8.0-BETA1
  Fix the server variables in the router_*.php files
  [Validator] Allow an empty path with a non empty fragment or a query
  The following change adds support for Armenian pluralization.
  [2.3][Process] fix Proccess run with pts enabled

Conflicts:
	src/Symfony/Bridge/ProxyManager/composer.json
	src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Compiler/FormPass.php
	src/Symfony/Component/Form/FormRegistry.php
2015-11-18 14:48:51 +01:00
Nicolas Grekas
ecdd681898 Merge branch '2.7' into 2.8
* 2.7:
  Fix undefined array $server
  Fix bug in windows detection
  [ProxyManager] Tmp fix composer reqs issue in ZF
  Add missing exclusions from phpunit.xml.dist
  [Serializer] ObjectNormalizer: don't serialize static methods and props
  Fix the server variables in the router_*.php files
  [Validator] Allow an empty path with a non empty fragment or a query
  The following change adds support for Armenian pluralization.
  [2.3][Process] fix Proccess run with pts enabled

Conflicts:
	composer.json
	src/Symfony/Bridge/ProxyManager/composer.json
	src/Symfony/Component/Security/phpunit.xml.dist
2015-11-18 14:45:00 +01:00
Nicolas Grekas
a8d21b5ca9 Merge branch '2.3' into 2.7
* 2.3:
  Fix undefined array $server
  [ProxyManager] Tmp fix composer reqs issue in ZF
  Add missing exclusions from phpunit.xml.dist
  Fix the server variables in the router_*.php files
  [Validator] Allow an empty path with a non empty fragment or a query
  The following change adds support for Armenian pluralization.
  [2.3][Process] fix Proccess run with pts enabled

Conflicts:
	composer.json
	src/Symfony/Bridge/ProxyManager/composer.json
	src/Symfony/Bundle/DebugBundle/phpunit.xml.dist
	src/Symfony/Component/Security/phpunit.xml.dist
2015-11-18 14:41:01 +01:00
FlorianLB
7418d29ae9 [Serializer] add missing unit tests related to Encoder 2015-11-18 11:51:45 +01:00
Fabien Potencier
e122d88eb6 minor #16565 [Validator] BIC (SWIFT-BIC) validation constraint sl translation (peterkokot)
This PR was merged into the 2.8 branch.

Discussion
----------

[Validator] BIC (SWIFT-BIC) validation constraint sl translation

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | N/A
| License       | MIT
| Doc PR        | N/A

Commits
-------

39f0989 [Validator] [sl] BIC (SWIFT-BIC) validation constraint
2015-11-18 11:19:47 +01:00
Fabien Potencier
6f72d6346e minor #16580 Add missing exclusions from phpunit.xml.dist (nicolas-grekas)
This PR was merged into the 2.3 branch.

Discussion
----------

Add missing exclusions from phpunit.xml.dist

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

d4880c4 Add missing exclusions from phpunit.xml.dist
2015-11-18 11:16:24 +01:00
Eugene Wissner
75aa6f68f8 Fix undefined array $server 2015-11-18 11:13:04 +01:00
Fabien Potencier
362974b85b bug #16581 Fix call to undefined function json_last_error_message (dawehner)
This PR was squashed before being merged into the 2.8 branch (closes #16581).

Discussion
----------

Fix call to undefined function json_last_error_message

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

15f9cf2 Fix call to undefined function json_last_error_message
2015-11-18 11:05:39 +01:00
Daniel Wehner
15f9cf2740 Fix call to undefined function json_last_error_message 2015-11-18 11:05:38 +01:00
Kevin Bond
c4068d923d Fix bug in windows detection 2015-11-18 10:54:26 +01:00
Daniel Wehner
db5fbe0e23 add it back 2015-11-18 10:45:48 +01:00
Nicolas Grekas
01251455c0 [ProxyManager] Tmp fix composer reqs issue in ZF 2015-11-18 10:04:13 +01:00
Jérôme Vasseur
d04984ad05 Fix PropertyInfo extractor namespace in framework bundle 2015-11-18 09:40:44 +01:00
Nicolas Grekas
d4880c4785 Add missing exclusions from phpunit.xml.dist 2015-11-18 09:19:46 +01:00
Kévin Dunglas
1fab27b58c [Serializer] ObjectNormalizer: don't serialize static methods and props 2015-11-17 20:34:27 +01:00
Tobias Schultze
17608389f1 minor #16568 [Form] Enhance some FormRegistry deprecation messages (nicolas-grekas)
This PR was merged into the 2.8 branch.

Discussion
----------

[Form] Enhance some FormRegistry deprecation messages

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

02d2148 [Form] Enhance some FormRegistry deprecation messages
2015-11-17 12:52:32 +01:00
Nicolas Grekas
02d2148f37 [Form] Enhance some FormRegistry deprecation messages 2015-11-17 11:33:11 +01:00
Peter Kokot
39f09893b9 [Validator] [sl] BIC (SWIFT-BIC) validation constraint 2015-11-17 02:04:18 +01:00
Douglas Greenshields
9b0850511f [WebProfilerBundle] correct typo in show stack trace link 2015-11-17 00:47:20 +00:00
Fabien Potencier
9835236a54 bumped Symfony version to 3.0.0 2015-11-16 15:59:01 +01:00