Commit Graph

42498 Commits

Author SHA1 Message Date
Alexander M. Turek
2bc94721b1 [EventDispatcher] Add type-hints to EventDispatcherInterface. 2019-06-10 23:08:37 +02:00
Nicolas Grekas
e8c2a1b807 minor #31967 [DI] remove deprecated tag !tagged in favor of !tagged_iterator (jschaedl)
This PR was merged into the 5.0-dev branch.

Discussion
----------

[DI] remove deprecated tag !tagged in favor of !tagged_iterator

| Q             | A
| ------------- | ---
| Branch?       | master <!-- see below -->
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | yes     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | related ticket #31289   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#tbd <!-- required for new features -->

This PR removes tag `tagged` which was deprecated in https://github.com/symfony/symfony/pull/31321

Commits
-------

997818406a [DI] removed tagged
2019-06-09 22:26:37 +02:00
Jan Schädlich
997818406a [DI] removed tagged 2019-06-09 21:05:58 +02:00
Nicolas Grekas
e7ce055e13 Merge branch '4.4'
* 4.4:
  [DI] deprecates tag !tagged in favor of !tagged_iterator
  [FrameworkBundle] remove dead code
2019-06-09 18:08:04 +02:00
Nicolas Grekas
7f39f36379 feature #31321 [DI] deprecates tag !tagged in favor of !tagged_iterator (jschaedl)
This PR was squashed before being merged into the 4.4 branch (closes #31321).

Discussion
----------

[DI] deprecates tag !tagged in favor of !tagged_iterator

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | #31289
| License       | MIT
| Doc PR        | tbd.

### Todo

- [x] fix tests

Commits
-------

ab8fb1868f [DI] deprecates tag !tagged in favor of !tagged_iterator
2019-06-09 18:06:29 +02:00
Jan Schädlich
ab8fb1868f [DI] deprecates tag !tagged in favor of !tagged_iterator 2019-06-09 18:06:22 +02:00
Nicolas Grekas
d0913f5a5d minor #31957 Remove deprecated code paths that trigger a runtime notice (nicolas-grekas)
This PR was merged into the 5.0-dev branch.

Discussion
----------

Remove deprecated code paths that trigger a runtime notice

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

39622488bb Remove deprecated code paths that trigger a runtime notice
2019-06-09 16:50:28 +02:00
Nicolas Grekas
39622488bb Remove deprecated code paths that trigger a runtime notice 2019-06-09 16:44:48 +02:00
Nicolas Grekas
0f35e5b360 minor #31672 [HttpKernel] remove all deprecated code from http kernel (Simperfit)
This PR was merged into the 5.0-dev branch.

Discussion
----------

[HttpKernel] remove all deprecated code from http kernel

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | none   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        |to check<!-- required for new features -->

<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->
REmove all deprecated code from HttpKernel, update all listener and all tests

Commits
-------

48351d53e0 [HttpKernel] remove all deprecated code from http kernel
2019-06-08 16:26:35 +02:00
Amrouche Hamza
48351d53e0 [HttpKernel] remove all deprecated code from http kernel 2019-06-08 16:24:48 +02:00
Nicolas Grekas
cdaa4d69e9 [FrameworkBundle] remove dead code 2019-06-08 16:18:47 +02:00
Nicolas Grekas
ceb40c14be minor #31951 [DI] remove deprecated code paths (nicolas-grekas)
This PR was merged into the 5.0-dev branch.

Discussion
----------

[DI] remove deprecated code paths

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

@ro0NL there is still one legacy test in ValidateEnvPlaceholdersPassTest, I'll let you remove it if you don't mind, please :)

Commits
-------

3ff69f09f1 [DI] remove deprecated code paths
2019-06-08 15:32:03 +02:00
Nicolas Grekas
a2f2769748 minor #31678 [Config] Removed env var support with cannotBeEmpty() (ro0NL)
This PR was merged into the 5.0-dev branch.

Discussion
----------

[Config] Removed env var support with cannotBeEmpty()

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

See #28858

Commits
-------

ec27d7486d [Config] Removed env var support with cannotBeEmpty()
2019-06-08 15:29:30 +02:00
Nicolas Grekas
3ff69f09f1 [DI] remove deprecated code paths 2019-06-08 13:09:13 +02:00
Roland Franssen
ec27d7486d [Config] Removed env var support with cannotBeEmpty() 2019-06-08 13:07:59 +02:00
Nicolas Grekas
8e84328d60 Merge branch '4.4'
* 4.4:
  [TwigBundle] fix FC with DI v5
  [FrameworkBundle] fix FC with DI v5
  [Config] decouple tests from DI
2019-06-08 12:50:12 +02:00
Nicolas Grekas
82d5ff075a [TwigBundle] fix FC with DI v5 2019-06-08 12:47:47 +02:00
Nicolas Grekas
ac95704a20 [FrameworkBundle] fix FC with DI v5 2019-06-08 12:35:19 +02:00
Nicolas Grekas
1dce522b9a [Config] decouple tests from DI 2019-06-08 12:17:01 +02:00
Nicolas Grekas
260df48366 minor #31949 Remove various legacy code paths (nicolas-grekas)
This PR was merged into the 5.0-dev branch.

Discussion
----------

Remove various legacy code paths

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

ccbe132d3b Remove various legacy code paths
2019-06-08 10:29:00 +02:00
Nicolas Grekas
ccbe132d3b Remove various legacy code paths 2019-06-08 10:28:16 +02:00
Nicolas Grekas
ba40486dbf [SecurityBundle] fix compat with security-http v4 2019-06-08 08:45:23 +02:00
Nicolas Grekas
242cf9b1c4 Merge branch '4.4'
* 4.4:
  [Serializer] add missing "internal" annotation
  [DI] Fix suspicious test
  [SecurityBundle] add missing contraint for symfony/config dep
2019-06-08 08:40:01 +02:00
Nicolas Grekas
c3c70507f4 minor #31771 [Serializer] Remove last deprecated/obsolete paths (ogizanagi)
This PR was merged into the 5.0-dev branch.

Discussion
----------

[Serializer] Remove last deprecated/obsolete paths

| Q             | A
| ------------- | ---
| Branch?       | master <!-- see below -->
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #28316, #28709, #31030, #27020, #29896, 16f8a13810 (r201060750)   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A <!-- required for new features -->

This should fix the last deprecations & obsolete code paths for the Serializer component.

Commits
-------

c703b355b8 [Serializer] Remove last deprecated/obsolete paths
2019-06-08 08:36:58 +02:00
Nicolas Grekas
e8975e2dfe Merge branch '4.3' into 4.4
* 4.3:
  [Serializer] add missing "internal" annotation
  [DI] Fix suspicious test
  [SecurityBundle] add missing contraint for symfony/config dep
2019-06-08 08:36:25 +02:00
Nicolas Grekas
2b8e44164e [Serializer] add missing "internal" annotation 2019-06-08 08:34:08 +02:00
Nicolas Grekas
b5306d2e81 Merge branch '4.2' into 4.3
* 4.2:
  [DI] Fix suspicious test
  [SecurityBundle] add missing contraint for symfony/config dep
2019-06-08 08:33:08 +02:00
Nicolas Grekas
bc1a0bd0ca minor #31918 [HttpKernel] remove all deprecated event and replace their use (Simperfit, nicolas-grekas)
This PR was merged into the 5.0-dev branch.

Discussion
----------

[HttpKernel] remove all deprecated event and replace their use

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | none   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        |to check<!-- required for new features -->

<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->

Extract the whole event & listener part from  https://github.com/symfony/symfony/pull/31672#issuecomment-499648703 to its own PR to ease the removal of deprecated code from HttpKernel.

Commits
-------

be5f641308 Fix annotations
48073ddcf9 [HttpKernel] remove all deprecated event and replace their use
2019-06-08 08:26:29 +02:00
Nicolas Grekas
be5f641308 Fix annotations 2019-06-08 08:23:28 +02:00
Nicolas Grekas
d81ab9b262 minor #31945 [DI][5.0] Fix suspicious test (ro0NL)
This PR was merged into the 5.0-dev branch.

Discussion
----------

[DI][5.0] Fix suspicious test

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

Cleanup of #31944 for 5.0

Commits
-------

98c25dd340 [DI][5.0] Fix suspicious test
2019-06-08 08:04:09 +02:00
Nicolas Grekas
13e5773132 minor #31944 [DI] Fix suspicious test (ro0NL)
This PR was merged into the 4.2 branch.

Discussion
----------

[DI] Fix suspicious test

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #31942
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

cc @nicolas-grekas

Commits
-------

25b961aadc [DI] Fix suspicious test
2019-06-08 08:03:01 +02:00
Roland Franssen
25b961aadc [DI] Fix suspicious test 2019-06-08 08:01:32 +02:00
Roland Franssen
98c25dd340 [DI][5.0] Fix suspicious test 2019-06-07 22:46:17 +02:00
Nicolas Grekas
e2660e0a0e Merge branch '3.4' into 4.2
* 3.4:
  [SecurityBundle] add missing contraint for symfony/config dep
2019-06-07 22:41:35 +02:00
Amrouche Hamza
48073ddcf9
[HttpKernel] remove all deprecated event and replace their use 2019-06-07 22:41:09 +02:00
Nicolas Grekas
07ca9f4831 [SecurityBundle] add missing contraint for symfony/config dep 2019-06-07 22:39:07 +02:00
Nicolas Grekas
e33ee9d530 Merge branch '4.4'
* 4.4:
  Fixing bug where PropertyInfoLoader tried to add validation to non-existent properties
  [TwigBundle] fix tests
  [travis] increase concurrency
  [FrameworkBundle] fix FC with HttpKernel v5
2019-06-07 20:32:40 +02:00
Nicolas Grekas
02a792a313 minor #31938 [FrameworkBundle] fix FC with HttpKernel v5 (nicolas-grekas)
This PR was merged into the 4.4 branch.

Discussion
----------

[FrameworkBundle] fix FC with HttpKernel v5

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

This class is deprecated and is thus not enough a reason to conflict with http-kernel v5

Should unlock #31918

Commits
-------

6c109c71a9 [FrameworkBundle] fix FC with HttpKernel v5
2019-06-07 20:31:13 +02:00
Nicolas Grekas
3bef037b7b Merge branch '4.3' into 4.4
* 4.3:
  Fixing bug where PropertyInfoLoader tried to add validation to non-existent properties
  [TwigBundle] fix tests
  [travis] increase concurrency
2019-06-07 20:28:30 +02:00
Nicolas Grekas
bc7e7bbb3b minor #31941 [TwigBundle] fix tests (nicolas-grekas)
This PR was merged into the 4.3 branch.

Discussion
----------

[TwigBundle] fix tests

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Should make master back to green.

Commits
-------

5b29918043 [TwigBundle] fix tests
2019-06-07 20:28:14 +02:00
Nicolas Grekas
e7184588e7 bug #31936 PropertyInfoLoader should not try to add validation to non-existent property (weaverryan)
This PR was merged into the 4.3 branch.

Discussion
----------

PropertyInfoLoader should not try to add validation to non-existent property

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #31796 (see https://github.com/symfony/symfony/issues/31796#issuecomment-499924238)
| License       | MIT
| Doc PR        | not needed

With auto-validation, if a class has a setter (e.g. `setFoo()`) but there is no `foo` property, it still tries to add validation to that property, resulting in a:

> Property "foo" does not exist in class "App\Entity\Bar

This fixes that. I believe it's "just this simple", but I don't have any experience with the code in this area yet.

Cheers!

Commits
-------

b702598b0b Fixing bug where PropertyInfoLoader tried to add validation to non-existent properties
2019-06-07 20:25:55 +02:00
Nicolas Grekas
5cec9e77a1 Merge branch '4.2' into 4.3
* 4.2:
  [travis] increase concurrency
2019-06-07 20:25:32 +02:00
Nicolas Grekas
f3f7721dcb Merge branch '3.4' into 4.2
* 3.4:
  [travis] increase concurrency
2019-06-07 20:25:08 +02:00
Ryan Weaver
b702598b0b Fixing bug where PropertyInfoLoader tried to add validation to non-existent properties 2019-06-07 14:22:04 -04:00
Nicolas Grekas
5238826912 minor #31939 [travis] increase concurrency (nicolas-grekas)
This PR was merged into the 3.4 branch.

Discussion
----------

[travis] increase concurrency

just a try to see if this makes the CI faster

Commits
-------

5e1ffb8d7f [travis] increase concurrency
2019-06-07 20:17:32 +02:00
Nicolas Grekas
5b29918043 [TwigBundle] fix tests 2019-06-07 20:15:33 +02:00
Nicolas Grekas
5e1ffb8d7f [travis] increase concurrency 2019-06-07 19:50:04 +02:00
Maxime Steinhausser
c703b355b8 [Serializer] Remove last deprecated/obsolete paths 2019-06-07 18:54:15 +02:00
Nicolas Grekas
6c109c71a9 [FrameworkBundle] fix FC with HttpKernel v5 2019-06-07 18:47:40 +02:00
Nicolas Grekas
e281087fd7 Merge branch '4.4'
* 4.4:
  [Validator] relax low dep
  [Validator] fix conflict rule
  [Serializer] Fix DataUriNormalizer deprecation (MIME type guesser is optional)
  [DependencyInjection] fix the ValidateEnvPlaceHolderPassTest that was using a deprecated path for TreeBuilder
  avoid service id conflicts with Swiftmailer
  [Form] fix usage of legacy TranslatorInterface
  [Serializer] Fix DataUriNormalizer docblock & composer suggest section
  [Validator] v4 conflicts with translation v5
2019-06-07 17:32:26 +02:00