This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes#8479).
Discussion
----------
[HttpFoundation] Fixed NativeSessionStorage:regenerate when does not exists
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #8460
| License | MIT
| Doc PR | -
**warning** I did not try to reproduce this bug, so I am not sure it fixes the issue. I just open a PR with the suggested patch. Tests for http foundation are OK. I am not sur it's the best way to fix this issue as I do not understand why symfony reach this code if $_SESSION is not set.
Commits
-------
f5d59fb [HttpFoundation] Fixed NativeSessionStorage:regenerate when does not exists
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes#8477).
Discussion
----------
Reverts recent change that added type coercion for JSON responses
We shouldn't be coercing primitive in the array provided to setData.
Commits
-------
02e6aef Reverts JSON_NUMERIC_CHECK
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes#8476).
Discussion
----------
Just a typo
Just a typo in the doc
Commits
-------
fdaf59f Just a Typo
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes#8465).
Discussion
----------
[Config] Fixed error messages of min/max validation methods
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
This PR fixes the error messages of the configuration validation methods `min` and `max`. The error message was "Should be greater/less than: <value>" but should be "Should be greater/less than or equal to <value>".
Commits
-------
3395837 Fixing configuration validation error messages.
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes#8462).
Discussion
----------
[HttpKernel] fixed inline fragment renderer
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #8450
| License | MIT
| Doc PR | none
Commits
-------
1554f1f [HttpKernel] fixed inline fragment renderer
This PR was merged into the 2.2 branch.
Discussion
----------
[Console] Show completed percentage, not a rounded value.
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
This pull request has 2 minor changes:
- 199/200 => 99% instead of 100% (there was no test case and I added one, everything else passes) In the past the value was rounded, the progress bar ended up being 100% for 0.5% of the total execution time. That means 18 seconds on a 1 hour process.
- Fixed the comments to match the inner workings of RedrawFrequency.
First Symfony PR and second overall so hope I just did this the right way.
PR #8419 Rebased for 2.2
Commits
-------
91bb757 ProgressHelper shows percentage complete.
40591b9 Comment fixed: RedrawFrequency is measured in steps.
In the past the value was rounded, the progressbar ended up being 100% for 0.5%
of the total execution time. That means 18 seconds on a 1 hour process.
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes#8420).
Discussion
----------
Update JsonResponse.php
Added JSON_NUMERIC_CHECK flag to fix issues when json response is used in JavaScript apps and especially in AngularJS.
Commits
-------
2b1c973 Update JsonResponse.php
This PR was merged into the 2.2 branch.
Discussion
----------
Passed the config when building the Configuration in ConfigurableExtension
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
This passes the config to ``getConfiguration`` instead of passing an empty array in ConfigurableExtension. This makes the class usable for bundle overwriting the ``getConfiguration`` method to use the config instead of using the default logic (which does not need the config).
Commits
-------
a830001 Passed the config when building the Configuration in ConfigurableExtension
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes#8400).
Discussion
----------
Replace romaji period characters with Japanese style zenkaku period char...
...acters
Found 4 of the Japanese translations inconsistently used romaji style periods. Replaced with zenkaku periods.
Commits
-------
1b3b1a7 Replace romaji period characters with Japanese style zenkaku period characters
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes#8363).
Discussion
----------
typo first->second
Commits
-------
2d9a84b typo first->second
This PR was submitted for the 2.3 branch but it was merged into the 2.2 branch instead (closes#8310).
Discussion
----------
[FrameworkBundle] Fixed variable name used in translation cache
This simply fixes the `$catalogueXXX` variable name used in the translation cache files in case the user use locales such as `en-US`, the generated variable's name was `$catalogueEn-Us`, with this fix it will be `$catalogueEnUs`.
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #7824
| License | MIT
| Doc PR | -
Commits
-------
e50399c [FrameworkBundle] Fixed variable name used in translation cache
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes#8337).
Discussion
----------
Fix grammar
Commits
-------
4163f71 Fix grammar
