Commit Graph

52445 Commits

Author SHA1 Message Date
Nicolas Grekas
3741b064df bug #39525 [VarDumper] dont hide any nodes until JS is proven to work (nicolas-grekas)
This PR was merged into the 5.2 branch.

Discussion
----------

[VarDumper] dont hide any nodes until JS is proven to work

| Q             | A
| ------------- | ---
| Branch?       | 5.2
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #39394
| License       | MIT
| Doc PR        | -

Replaces #39523

Commits
-------

42ad1ece92 [VarDumper] dont hide any nodes until JS is proven to work
2020-12-17 09:32:53 +01:00
Nicolas Grekas
42ad1ece92 [VarDumper] dont hide any nodes until JS is proven to work 2020-12-16 18:02:19 +01:00
Alexander M. Turek
904b05a0de Merge branch '5.1' into 5.2
* 5.1:
  [Notifier] Improve tests (5.1)
  [Notifier] Fix wrong package names
  [Notifier] [Free Mobile] Could not use custom host in DSN
2020-12-16 08:59:53 +01:00
Alexander M. Turek
40672e1748 minor #39509 [Notifier] Improve tests (5.1) (OskarStark)
This PR was squashed before being merged into the 5.1 branch.

Discussion
----------

[Notifier] Improve tests (5.1)

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | ---
| License       | MIT
| Doc PR        | ---

Please review commit by commit

Commits
-------

5773a46677 [Notifier] Improve tests (5.1)
2020-12-16 08:45:27 +01:00
Oskar Stark
5773a46677 [Notifier] Improve tests (5.1) 2020-12-16 08:45:20 +01:00
Alexander M. Turek
6112be33d2 bug #39498 [DoctrineBridge] Guess correct form types for DATE_IMMUTABLE and DATETIME_IMMUTABLE (guillaume-sainthillier)
This PR was squashed before being merged into the 5.2 branch.

Discussion
----------

[DoctrineBridge] Guess correct form types for DATE_IMMUTABLE and DATETIME_IMMUTABLE

| Q             | A
| ------------- | ---
| Branch?       | 5.2
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #39468
| License       | MIT
| Doc PR        | -

Rebased PR #39469
Fixes #39468 related to Doctrine Form Type Guesser with DateImmutable type

Commits
-------

238d318e34 [DoctrineBridge] Guess correct form types for DATE_IMMUTABLE and DATETIME_IMMUTABLE
2020-12-16 08:43:23 +01:00
Guillaume Sainthillier
238d318e34 [DoctrineBridge] Guess correct form types for DATE_IMMUTABLE and DATETIME_IMMUTABLE 2020-12-16 08:43:10 +01:00
Fabien Potencier
77960f86a9 bug #39510 [Notifier]  [Free Mobile] Could not use custom host in DSN (OskarStark)
This PR was merged into the 5.1 branch.

Discussion
----------

[Notifier]  [Free Mobile] Could not use custom host in DSN

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | ---
| License       | MIT
| Doc PR        | ---

While working on #39509 I discovered, that you cannot set a custom host through the DSN string itself, only by calling `setHost()` method in the transport, which is only possible by **not** using the factory....

I changed it the way all other bridges work. I don't add a testcase for the port, because non of the others have that test.
I plan to implement it in #39495

As this is a bugfix I created an extra PR.

Cheers

EDIT:

Also the host is not allowed to contain `https://` otherwise calling `__toString()` will result in: `freemobile://https://......`

Commits
-------

63350cc19b [Notifier] [Free Mobile] Could not use custom host in DSN
2020-12-15 18:16:25 +01:00
Fabien Potencier
9613b41efa bug #39515 [Notifier] Fix wrong package name (OskarStark)
This PR was merged into the 5.2 branch.

Discussion
----------

[Notifier] Fix wrong package name

| Q             | A
| ------------- | ---
| Branch?       | 5.2
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | ---
| License       | MIT
| Doc PR        | ---

Same like https://github.com/symfony/symfony/pull/39514 but for `5.2`

Commits
-------

f345ecd966 [Notifier] Fix wrong package name
2020-12-15 14:02:02 +01:00
Fabien Potencier
1a98df5342 bug #39514 [Notifier] Fix wrong package names (OskarStark)
This PR was merged into the 5.1 branch.

Discussion
----------

[Notifier] Fix wrong package names

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | ---
| License       | MIT
| Doc PR        | ---

Commits
-------

344437286a [Notifier] Fix wrong package names
2020-12-15 14:01:00 +01:00
Oskar Stark
f345ecd966 [Notifier] Fix wrong package name 2020-12-15 13:50:14 +01:00
Oskar Stark
344437286a [Notifier] Fix wrong package names 2020-12-15 13:48:34 +01:00
Fabien Potencier
8399f9c6e1 bug #39502 Add missing symfony/deprecation-contracts requirement - 5.2 (jderusse)
This PR was merged into the 5.2 branch.

Discussion
----------

Add missing symfony/deprecation-contracts requirement - 5.2

| Q             | A
| ------------- | ---
| Branch?       | 5.2
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

same PR than #39494 for branch 5.2

Commits
-------

bdf8744c2a Add missing symfony/deprecation-contracts requirement
2020-12-15 13:30:33 +01:00
Jérémy Derussé
bdf8744c2a
Add missing symfony/deprecation-contracts requirement 2020-12-15 12:53:10 +01:00
Jérémy Derussé
862b19982a
Merge branch '5.1' into 5.2
* 5.1:
  Add missing symfony/deprecation-contracts requirement
2020-12-15 12:52:46 +01:00
Alexander M. Turek
defb90b030 bug #39494 Add missing symfony/deprecation-contracts requirement (jderusse)
This PR was merged into the 5.1 branch.

Discussion
----------

Add missing symfony/deprecation-contracts requirement

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

We should require the `symfony/deprecation-contracts` package in components that call `trigger_deprecated`.

Commits
-------

5ae2364c7e Add missing symfony/deprecation-contracts requirement
2020-12-15 12:05:57 +01:00
Oskar Stark
63350cc19b [Notifier] [Free Mobile] Could not use custom host in DSN 2020-12-15 11:50:27 +01:00
Robin Chalas
302b80768a Merge branch '5.1' into 5.2
* 5.1:
  [Uid] Fix tests namespace
2020-12-15 10:12:47 +01:00
Robin Chalas
a7fd98bee8 bug #39360 [FrameworkBundler] Fix cache:clear with buildDir (jderusse)
This PR was merged into the 5.2 branch.

Discussion
----------

[FrameworkBundler] Fix cache:clear with buildDir

| Q             | A
| ------------- | ---
| Branch?       | 5.2
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #39232
| License       | MIT
| Doc PR        |

Since #36515 there are 2 caches dir `cacheDir` and `buildDir`. For BC reason both points to the same folders, but when app don't use the same folder, many thing are broken:
This PR fixes several issues introduces by the above PR:
- some files are persisted in the wrong folder (`App_KernelDevDebugContainerDeprecations.log`, `App_KernelDevDebugContainer.xml`)
- LoggerDataCollector looks into cache_dir, while `Compiler.log` is written in build_dir and `Deprecations.log` were written in cache_dir before this PR
- the logic that mirror cacheDir into buildDir at the end of CacheClearCommand does not make sens when `cache_dir` and `build_dir` are not identical.
- Files generated in cacheDir are trashed at the end of CacheWarming (initial issue)

Commits
-------

ea68966e91 Fix cache:clear with buildDir
2020-12-15 10:04:49 +01:00
Alexander M. Turek
3a3b2498fd minor #39508 [Uid] Fix tests namespace (fancyweb)
This PR was merged into the 5.1 branch.

Discussion
----------

[Uid] Fix tests namespace

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | no
| License       | MIT
| Doc PR        | -

Commits
-------

cd11ef67dc [Uid] Fix tests namespace
2020-12-15 01:19:30 +01:00
Thomas Calvet
cd11ef67dc [Uid] Fix tests namespace 2020-12-15 00:03:24 +01:00
Alexander M. Turek
6caf916083 Merge branch '5.1' into 5.2
* 5.1:
  [Notifier] Rework/streamline bridges (5.1)
  [Mailer] [Amazon] Ensure "ext-simplexml" is loaded if SesApiTransport is used
  Stop using deprecated trait
  [PhpUnitBridge] Lint files with PHP 5.5
2020-12-14 23:27:17 +01:00
Alexander M. Turek
ef461b6f8e minor #39455 [Notifier] Rework/streamline bridges (5.1) (OskarStark)
This PR was squashed before being merged into the 5.1 branch.

Discussion
----------

[Notifier] Rework/streamline bridges (5.1)

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | ---
| License       | MIT
| Doc PR        | ---

This PR

* add missing tests
* pull up scheme check (check scheme first and then for required options)

Commits
-------

856e191687 [Notifier] Rework/streamline bridges (5.1)
2020-12-14 23:20:55 +01:00
Oskar Stark
856e191687 [Notifier] Rework/streamline bridges (5.1) 2020-12-14 23:20:24 +01:00
Jérémy Derussé
2fb9fa3dac
Merge branch '4.4' into 5.1
* 4.4:
  [Mailer] [Amazon] Ensure "ext-simplexml" is loaded if SesApiTransport is used
  Stop using deprecated trait
  [PhpUnitBridge] Lint files with PHP 5.5
2020-12-14 21:31:08 +01:00
Jérémy Derussé
e96b0e7d4d
minor #39463 [Mailer] [Amazon] Ensure "ext-simplexml" is loaded if SesApiTransport is used (OskarStark)
This PR was squashed before being merged into the 4.4 branch.

Discussion
----------

[Mailer] [Amazon] Ensure "ext-simplexml" is loaded if SesApiTransport is used

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | ---
| License       | MIT
| Doc PR        | ---

For reference:
150d8506e4/src/Symfony/Component/Mailer/Bridge/Amazon/Transport/SesApiTransport.php (L66-L69)

Commits
-------

a40d1375f9 [Mailer] [Amazon] Ensure "ext-simplexml" is loaded if SesApiTransport is used
2020-12-14 21:27:32 +01:00
Oskar Stark
a40d1375f9
[Mailer] [Amazon] Ensure "ext-simplexml" is loaded if SesApiTransport is used 2020-12-14 21:27:17 +01:00
Jérémy Derussé
ea68966e91
Fix cache:clear with buildDir 2020-12-14 18:14:39 +01:00
Nicolas Grekas
698dadccb1 minor #39497 [PhpUnitBridge] [phpunit] Stop using deprecated trait (jderusse)
This PR was merged into the 4.4 branch.

Discussion
----------

[PhpUnitBridge] [phpunit] Stop using deprecated trait

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

the `SetUpTearDownTrait` trait has been removed in #39487 this PR remove usage of it in branch 4.4

Commits
-------

55ed00cd3c Stop using deprecated trait
2020-12-14 17:15:46 +01:00
Jérémy Derussé
55ed00cd3c
Stop using deprecated trait 2020-12-14 16:50:10 +01:00
Nicolas Grekas
510623f890 minor #39421 [PhpUnitBridge] Lint files with PHP 5.5 (derrabus)
This PR was squashed before being merged into the 4.4 branch.

Discussion
----------

[PhpUnitBridge] Lint files with PHP 5.5

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | N/A
| License       | MIT
| Doc PR        | N/A

I'd like to make sure that PhpUnitBridge remains compatible with PHP 5.5.

cc @nicolas-grekas @fancyweb

Commits
-------

0bc15ff759 [PhpUnitBridge] Lint files with PHP 5.5
2020-12-14 16:00:54 +01:00
Alexander M. Turek
0bc15ff759 [PhpUnitBridge] Lint files with PHP 5.5 2020-12-14 16:00:48 +01:00
Jérémy Derussé
5ae2364c7e
Add missing symfony/deprecation-contracts requirement 2020-12-14 15:33:09 +01:00
Nicolas Grekas
b81a03d7a1 Merge branch '5.1' into 5.2
* 5.1:
  Fix EncoderInterface::encode() return type
  [Lock] Prevent store exception break combined store
  Remove check for unsupported PHP version
  [Notifier] Rename test method names
2020-12-14 11:56:50 +01:00
Nicolas Grekas
bae2782cdb Merge branch '4.4' into 5.1
* 4.4:
  Fix EncoderInterface::encode() return type
  [Lock] Prevent store exception break combined store
2020-12-14 11:55:48 +01:00
Nicolas Grekas
25f79ab808 minor #39444 [Notifier] [Discord] Fix exception message + test (OskarStark)
This PR was merged into the 5.2 branch.

Discussion
----------

[Notifier] [Discord] Fix exception message + test

| Q             | A
| ------------- | ---
| Branch?       | 5.2
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | ---
| License       | MIT
| Doc PR        | ---

Before this PR the message was wrong, "less than 2000" is not correct, it can have 2000 chars, but not more.

Commits
-------

01623391f6 [Notifier][Discord] Fix exception message + test
2020-12-14 11:49:49 +01:00
Nicolas Grekas
c052542e65 minor #39451 [Serializer] Fix EncoderInterface::encode() return type (jeroennoten)
This PR was merged into the 4.4 branch.

Discussion
----------

[Serializer] Fix EncoderInterface::encode() return type

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | N.A.
| License       | MIT
| Doc PR        | N.A.

I might have missed something (in that case, please let me know), but I believe that `EncoderInterface::encode()` will and should always return a `string`. This makes more sense because `DecoderInterface::decode()` only accepts a string as input.

Commits
-------

ae6f054cc1 Fix EncoderInterface::encode() return type
2020-12-14 11:44:27 +01:00
Jeroen Noten
ae6f054cc1 Fix EncoderInterface::encode() return type 2020-12-14 11:44:14 +01:00
Nicolas Grekas
43ab20e4f2 bug #39476 [Lock] Prevent store exception break combined store (dzubchik)
This PR was squashed before being merged into the 4.4 branch.

Discussion
----------

[Lock] Prevent store exception break combined store

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? |no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | Fix #39470 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT

Handle exception to preserve expected behavior - one or multiple stores could be unreachable in a moment and combined store will handle this according to strategy.

Commits
-------

0daff35bae [Lock] Prevent store exception break combined store
2020-12-14 11:21:44 +01:00
Dmytro Dzubenko
0daff35bae [Lock] Prevent store exception break combined store 2020-12-14 11:21:37 +01:00
Nicolas Grekas
936bab4b3b bug #39478 [FrameworkBundle] Fix missing kernel.build_dir on cache clear (chalasr)
This PR was merged into the 5.2 branch.

Discussion
----------

[FrameworkBundle] Fix missing kernel.build_dir on cache clear

| Q             | A
| ------------- | ---
| Branch?       | 5.2
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #39250
| License       | MIT
| Doc PR        | -

Fixes post-upgrade cache:clear on 5.2.

Commits
-------

42abc059a6 Fix missing kernel.build_dir on cache clear
2020-12-14 11:19:29 +01:00
Nicolas Grekas
aa0d2c8c0d minor #39490 Remove check for unsupported PHP version (pierredup)
This PR was merged into the 5.1 branch.

Discussion
----------

Remove check for unsupported PHP version

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | N/A
| License       | MIT
| Doc PR        | N/A

Remove check for PHP 7.1 since it's not supported anymore

Commits
-------

14c3614ac4 Remove check for unsupported PHP version
2020-12-14 11:17:57 +01:00
Pierre du Plessis
14c3614ac4 Remove check for unsupported PHP version 2020-12-14 12:10:03 +02:00
Nicolas Grekas
b1246ebf9e minor #39489 [Notifier] Rename test method names (OskarStark)
This PR was merged into the 5.1 branch.

Discussion
----------

[Notifier] Rename test method names

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | ---
| License       | MIT
| Doc PR        | ---

To stay consistent

Commits
-------

45b3a3062c [Notifier] Rename test method names
2020-12-14 10:22:39 +01:00
Oskar Stark
45b3a3062c [Notifier] Rename test method names
To stay consistent
2020-12-14 10:19:36 +01:00
Fabien Potencier
e05b8ef230 Merge branch '5.1' into 5.2
* 5.1:
  Fix tests
  Fix applyVersion tests
  [Notifier][Free Mobile] Fix wrong scheme in mapping
2020-12-14 08:03:22 +01:00
Fabien Potencier
9d73e7caf0 Merge branch '4.4' into 5.1
* 4.4:
  Fix tests
2020-12-14 08:03:02 +01:00
Fabien Potencier
0a8a3d77e8 minor #39486 [Asset] Fix tests for 5.1 (jderusse)
This PR was merged into the 5.1 branch.

Discussion
----------

[Asset] Fix tests for 5.1

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Commits
-------

fe40ddb013 Fix applyVersion tests
2020-12-14 08:02:33 +01:00
Fabien Potencier
3ebcc28fab minor #39485 [Asset] Fix tests (jderusse)
This PR was merged into the 4.4 branch.

Discussion
----------

[Asset] Fix tests

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Commits
-------

d651fb539c Fix tests
2020-12-14 08:01:17 +01:00
Jérémy Derussé
d651fb539c
Fix tests 2020-12-13 23:21:11 +01:00