Commit Graph

30229 Commits

Author SHA1 Message Date
Jeremy Benoist
fca16bab53
Use PHPUnit 5.4 instead of 5.3
PHPUnit 5.3 doesn't have the forward compatibility layer for PHPUnit 6 so that `PHPUnit\Framework\TestCase` can be used instead of `PHPUnit_Framework_TestCase`.
This generates an error when upgrading to Symfony 3.2.5 without forcing the `SYMFONY_PHPUNIT_VERSION` const:

```
Class 'PHPUnit\Framework\TestCase' not found in vendor/symfony/symfony/src/Symfony/Bundle/FrameworkBundle/Test/KernelTestCase.php on line 25
```

This was introduced by c9684ad31f in 3.2.5
2017-03-09 13:58:16 +01:00
Nicolas Grekas
64f9f7b193 bug #21927 [FrameworkBundle] Add missing resource tracking for validation mapping (chalasr)
This PR was merged into the 3.3-dev branch.

Discussion
----------

[FrameworkBundle] Add missing resource tracking for validation mapping

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | https://github.com/symfony/symfony/pull/19086#discussion_r104890636
| License       | MIT
| Doc PR        | n/a

https://github.com/symfony/symfony/pull/21927/files?w=1

Commits
-------

0a19cbe Add missing resource tracking for validation mapping
2017-03-09 11:46:22 +01:00
Nicolas Grekas
5b1a96a363 bug #21942 [DI] Fix dumping null ServiceClosureArgument (nicolas-grekas)
This PR was merged into the 3.3-dev branch.

Discussion
----------

[DI] Fix dumping null ServiceClosureArgument

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #21941
| License       | MIT
| Doc PR        | -

Commits
-------

35977fd [DI] Fix dumping null ServiceClosureArgument
2017-03-09 11:23:16 +01:00
Robin Chalas
0a19cbe906 Add missing resource tracking for validation mapping 2017-03-09 11:23:13 +01:00
Nicolas Grekas
24f36b6c44 bug #21936 [PropertyAccess] Use ArrayAdapter in debug mode (chalasr)
This PR was merged into the 3.2 branch.

Discussion
----------

[PropertyAccess] Use ArrayAdapter in debug mode

| Q             | A
| ------------- | ---
| Branch?       | 3.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #21894
| License       | MIT
| Doc PR        | n/a

https://github.com/symfony/symfony/pull/21936/files?w=1

Commits
-------

dca3f36 [PropertyAccess] Use ArrayAdapter in debug mode
2017-03-09 11:20:43 +01:00
Robin Chalas
dca3f365d7 [PropertyAccess] Use ArrayAdapter in debug mode 2017-03-09 10:04:18 +01:00
Nicolas Grekas
35977fdf0a [DI] Fix dumping null ServiceClosureArgument 2017-03-09 09:35:59 +01:00
Fabien Potencier
e2965c2d30 bumped Symfony version to 3.2.6 2017-03-08 18:27:39 -08:00
Fabien Potencier
463b6558ce Merge pull request #21939 from fabpot/release-3.2.5
released v3.2.5
2017-03-08 18:03:55 -08:00
Fabien Potencier
7ee31a7b2d updated VERSION for 3.2.5 2017-03-08 18:01:51 -08:00
Fabien Potencier
f8f10c6724 updated CHANGELOG for 3.2.5 2017-03-08 18:01:40 -08:00
Fabien Potencier
7f6f402fad Merge branch '3.2'
* 3.2:
  [Workflow] Delete dead code
  Rename StackOverflow to Stack Overflow
  [travis] Test with hhvm 3.18
  [Workflow] Fixed marking state on leave and enter events
2017-03-08 17:48:13 -08:00
Fabien Potencier
575b7987bf Merge branch '2.8' into 3.2
* 2.8:
  Rename StackOverflow to Stack Overflow
  [travis] Test with hhvm 3.18
2017-03-08 17:47:54 -08:00
Fabien Potencier
25a2ce062b Merge branch '2.7' into 2.8
* 2.7:
  Rename StackOverflow to Stack Overflow
  [travis] Test with hhvm 3.18
2017-03-08 17:47:20 -08:00
Fabien Potencier
fe995a3bc9 bug #21922 [FrameworkBundle] Fix autoloader in insulated clients (nicolas-grekas)
This PR was merged into the 3.3-dev branch.

Discussion
----------

[FrameworkBundle] Fix autoloader in insulated clients

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Related to the deprecation of the class loader component:
the `Client` already uses this code in `HttpKernel`, but `FrameworkBundle` is missing the same update.
Spotted while debugging the hhvm 3.18 issue (the chain is: `ComposerResource` sees different vendors, thus says the kernel cache is not fresh, thus it is rebuild, thus we hit https://github.com/facebook/hhvm/issues/7722).

Commits
-------

414ac5d976 [FrameworkBundle] Fix autoloader in insulated clients
2017-03-08 11:43:39 -08:00
Fabien Potencier
a0945fc182 bug #21923 [travis] Test with hhvm 3.18 (nicolas-grekas)
This PR was merged into the 2.7 branch.

Discussion
----------

[travis] Test with hhvm 3.18

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #21900
| License       | MIT
| Doc PR        | -

Needs #21922 on master to be green also.
Works around  facebook/hhvm#7722.

Commits
-------

7f1f0cb630 [travis] Test with hhvm 3.18
2017-03-08 11:42:39 -08:00
Grégoire Pineau
633c0393b3 [Workflow] Added the workflow name in log generated by AuditTrailListener 2017-03-08 17:23:28 +01:00
Grégoire Pineau
b786bccb3a [FrameworkBundle][Workflow] Add a way to enable the AuditTrail Logger 2017-03-08 17:21:33 +01:00
Grégoire Pineau
aabed215e0 feature #21925 [Workflow] Added the workflow name to all events dispatched (lyrixx)
This PR was merged into the 3.3-dev branch.

Discussion
----------

[Workflow] Added the workflow name to all events dispatched

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #21818
| License       | MIT
| Doc PR        | -

Commits
-------

b3400c7312 [Workflow] Added the workflow name to all events dispatched
2017-03-08 15:34:54 +01:00
Grégoire Pineau
2fad5affe6 minor #21913 [Workflow] Delete dead code (lyrixx)
This PR was merged into the 3.2 branch.

Discussion
----------

[Workflow] Delete dead code

| Q             | A
| ------------- | ---
| Branch?       | 3.2
| Bug fix?      | "no"
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

---

Me (and all reviewers ;) ) totally miss this class. It has never been used and there are no reason to use it anyway. It's just a relic from the designing of the Component. Sorry.

I really don't think it deserves a deprecation as the component is quite new, and it is really some dead code.

Commits
-------

28e85cc32a [Workflow] Delete dead code
2017-03-08 15:32:26 +01:00
Grégoire Pineau
b3400c7312 [Workflow] Added the workflow name to all events dispatched 2017-03-08 15:21:36 +01:00
Grégoire Pineau
ce0fda64d7 bug #21793 [Workflow] Fixed marking state on leave and enter events (HeahDude)
This PR was merged into the 3.2 branch.

Discussion
----------

[Workflow] Fixed marking state on leave and enter events

| Q             | A
| ------------- | ---
| Branch?       | 3.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | ~
| License       | MIT
| Doc PR        | related to https://github.com/symfony/symfony-docs/pull/7528

It seems weird to me to dispatch an event while the marking is not yet marked by the new places.
The event is still "marked" by old places when leaving occurs, my guess is that the symmetry should be mirrored.

Do you agree? Should I add a test?

Commits
-------

175858a67e [Workflow] Fixed marking state on leave and enter events
2017-03-08 15:16:21 +01:00
Arthur de Moulins
865a6af153 cached files rely on umask 2017-03-08 13:16:26 +01:00
Grégoire Pineau
28e85cc32a [Workflow] Delete dead code 2017-03-08 11:36:52 +01:00
Nicolas Grekas
68f810919c minor #21920 Rename StackOverflow to Stack Overflow (lex111)
This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #21920).

Discussion
----------

Rename StackOverflow to Stack Overflow

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | N/A
| License       | MIT
| Doc PR        | N/A

Renamed StackOverflow to Stack Overflow in README.md.

Commits
-------

e3ac705 Rename StackOverflow to Stack Overflow
2017-03-08 11:34:04 +01:00
Alexey Pyltsyn
e3ac705b69 Rename StackOverflow to Stack Overflow 2017-03-08 11:34:04 +01:00
Nicolas Grekas
7f1f0cb630 [travis] Test with hhvm 3.18 2017-03-08 10:42:29 +01:00
Nicolas Grekas
414ac5d976 [FrameworkBundle] Fix autoloader in insulated clients 2017-03-08 10:00:17 +01:00
Fabien Potencier
d236af6757 fixed typo 2017-03-07 18:50:36 -08:00
Fabien Potencier
5b25e95de0 bug #21910 [DI] Add a check on the getReflectionClass call (Taluu)
This PR was merged into the 3.3-dev branch.

Discussion
----------

[DI] Add a check on the getReflectionClass call

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | ~
| License       | MIT
| Doc PR        | ~

This prevents from doing a getter injection if the definition's idcannot be resolved to an existing class.

Commits
-------

a6590b3659 [DI] Add a check on the getReflectionClass call
2017-03-07 18:50:00 -08:00
Nicolas Grekas
2a239fc00f minor #21914 [travis] Master fixes for HHVM 3.18LTS (nicolas-grekas)
This PR was merged into the 3.3-dev branch.

Discussion
----------

[travis] Master fixes for HHVM 3.18LTS

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #21900
| License       | MIT
| Doc PR        | -

For some reason, the current HHVM 3.15 consistently crashes in its shutdown sequence on master.
Time to move to 3.18?

https://github.com/symfony/symfony/pull/21914/files?w=1

Commits
-------

114d62c [travis] Master fixes for HHVM 3.18LTS
2017-03-07 22:25:18 +01:00
Nicolas Grekas
f61ed2ef62 Merge branch '3.2'
* 3.2:
  [travis] Disable HHVM JIT - makes tests twice as fast
  [hhvm] 3.18-related fix
2017-03-07 22:22:48 +01:00
Nicolas Grekas
2ec78c2294 minor #21918 [hhvm] 3.18-related fix (nicolas-grekas)
This PR was merged into the 3.2 branch.

Discussion
----------

[hhvm] 3.18-related fix

| Q             | A
| ------------- | ---
| Branch?       | 3.2
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

See #21914

Commits
-------

bc6c569 [hhvm] 3.18-related fix
2017-03-07 22:22:04 +01:00
Nicolas Grekas
ba73890f91 Merge branch '2.8' into 3.2
* 2.8:
  [travis] Disable HHVM JIT - makes tests twice as fast
2017-03-07 22:16:05 +01:00
Nicolas Grekas
d59c9c759c Merge branch '2.7' into 2.8
* 2.7:
  [travis] Disable HHVM JIT - makes tests twice as fast
2017-03-07 22:15:34 +01:00
Nicolas Grekas
bdebb713c4 minor #21915 [travis] Disable HHVM JIT - makes tests twice as fast (nicolas-grekas)
This PR was merged into the 2.7 branch.

Discussion
----------

[travis] Disable HHVM JIT - makes tests twice as fast

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

0691639 [travis] Disable HHVM JIT - makes tests twice as fast
2017-03-07 22:14:40 +01:00
Nicolas Grekas
0691639063 [travis] Disable HHVM JIT - makes tests twice as fast 2017-03-07 22:12:28 +01:00
Nicolas Grekas
114d62c847 [travis] Master fixes for HHVM 3.18LTS 2017-03-07 20:35:42 +01:00
Nicolas Grekas
bc6c5692c9 [hhvm] 3.18-related fix 2017-03-07 20:34:05 +01:00
HeahDude
175858a67e [Workflow] Fixed marking state on leave and enter events 2017-03-07 20:23:24 +01:00
Baptiste Clavié
a6590b3659
[DI] Add a check on the getReflectionClass call 2017-03-07 18:13:07 +01:00
Nicolas Grekas
0626cea1cf Merge branch '3.2'
* 3.2:
  [Yaml] dump escape sequences when possible
2017-03-07 17:54:31 +01:00
Nicolas Grekas
d3c55c51d6 bug #21912 [Yaml] dump escape sequences when possible (xabbuh)
This PR was merged into the 3.2 branch.

Discussion
----------

[Yaml] dump escape sequences when possible

| Q             | A
| ------------- | ---
| Branch?       | 3.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Tests for them have been introduced in #21903 (in 2.7 and 2.8 this does not need to be fixed as those versions didn't dump the `!!binary` tag).

Commits
-------

997103d [Yaml] dump escape sequences when possible
2017-03-07 17:54:16 +01:00
Christian Flothmann
997103d931 [Yaml] dump escape sequences when possible 2017-03-07 17:47:02 +01:00
Nicolas Grekas
7bba83d3d7 Merge branch '3.2'
* 3.2:
  [Cache] Fix Redis pipelining/multi-ops
  [Yaml] Fix the tests
  [github] Add a reminder about CHANGELOG.md files
  respect the umask argument in dumpFile()
  dumpFile(), preserve existing file permissions
  [Form] Fixed overridden choices option in extended choice types
  Add validate method to mockec validator in form TypeTestCase
  bumped Symfony version to 2.8.19
  updated VERSION for 2.8.18
  updated CHANGELOG for 2.8.18
  bumped Symfony version to 2.7.26
  updated VERSION for 2.7.25
  update CONTRIBUTORS for 2.7.25
  updated CHANGELOG for 2.7.25
  [HttpKernel] fixed Kernel name when stored in a directory starting with a number
  context listener: hardening user provider handling
  [Console] Do not squash input changes made from console.command event
2017-03-07 17:28:52 +01:00
Nicolas Grekas
3265ed4a66 bug #21908 [Cache] Fix Redis pipelining/multi-ops (nicolas-grekas)
This PR was merged into the 3.2 branch.

Discussion
----------

[Cache] Fix Redis pipelining/multi-ops

| Q             | A
| ------------- | ---
| Branch?       | 3.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #21858
| License       | MIT
| Doc PR        | -

`MSET` doesn't work on clustered connections. Let's use pipelining instead.

Commits
-------

f1648e2 [Cache] Fix Redis pipelining/multi-ops
2017-03-07 17:20:56 +01:00
Nicolas Grekas
17f717c847 Merge branch '2.8' into 3.2
* 2.8:
  [Yaml] Fix the tests
  [github] Add a reminder about CHANGELOG.md files
2017-03-07 17:20:19 +01:00
Nicolas Grekas
6568a76411 Merge branch '2.7' into 2.8
* 2.7:
  [Yaml] Fix the tests
  [github] Add a reminder about CHANGELOG.md files
2017-03-07 17:19:54 +01:00
Nicolas Grekas
f1648e2484 [Cache] Fix Redis pipelining/multi-ops 2017-03-07 16:57:48 +01:00
Jules Lamur
abda966d75 301 status code must drop request method to GET.
[RFC 7231 §6.4.2](https://tools.ietf.org/html/rfc7231#section-6.4.2) states that 301 HTTP Code should forward POST requests to the Location URI.

But, it also states that:

> For historical reasons, a user agent MAY change the request method from POST to GET for the subsequent request.

This is the behavior implemented in almost all user agents.
However the `BrowserKit` did forward the method to the subsequent request.
2017-03-07 14:08:59 +01:00